[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 --- Comment #8 from Fedora Update System --- FEDORA-2020-c5ebbc6add has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-06-26 00:46:21 --- Comment #7 from Fedora Update System --- FEDORA-2020-8a0be5567f has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 --- Comment #6 from Fedora Update System --- FEDORA-2020-8a0be5567f has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-8a0be5567f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8a0be5567f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- FEDORA-2020-c5ebbc6add has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-c5ebbc6add \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-c5ebbc6add See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-8a0be5567f has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8a0be5567f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-opencensus -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 --- Comment #2 from Mohamed El Morabity --- Many thanks for this review ;) (In reply to Fabian Affolter from comment #1) > At the moment there is no binary eggs in the source but I suggest to add the > removal to %prep in case in a future update ther eis one and not to forget > it. And you're right ;). This will be fixed at import, as usual ;). > The removal of some extensions, is OK from my point of view. > opencensus-ext-mysql is the only one that has its dependency present and > perhaps could be enabled. Good catch, I enabled the extension on my side, by fixing the corresponding setup.py, and it seems to work. > - contrib/opencensus-ext-postgresql > Issue: >= 0.8.dev0, current 0.7.7 > Dep: https://src.fedoraproject.org/rpms/python-psycopg2, would require a > patch for the setup.py It works also, as for the mysql extension (by fixing requirement to psycopg2). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 Bug 1839479 depends on bug 1839477, which changed state. Bug 1839477 Summary: Review Request: python-google-api-core - Core Library for Google Client Libraries https://bugzilla.redhat.com/show_bug.cgi?id=1839477 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 Bug 1839479 depends on bug 1839470, which changed state. Bug 1839470 Summary: Review Request: python-googleapis-common-protos - Common protobufs used in Google APIs https://bugzilla.redhat.com/show_bug.cgi?id=1839470 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 Bug 1839479 depends on bug 1839472, which changed state. Bug 1839472 Summary: Review Request: python-grpcio-gcp - gRPC for GCP extensions https://bugzilla.redhat.com/show_bug.cgi?id=1839472 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 Bug 1839479 depends on bug 1839473, which changed state. Bug 1839473 Summary: Review Request: python-opencensus-proto - Language Independent Interface Types For OpenCensus https://bugzilla.redhat.com/show_bug.cgi?id=1839473 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479
Fabian Affolter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Fabian Affolter ---
At the moment there is no binary eggs in the source but I suggest to add the
removal to %prep in case in a future update ther eis one and not to forget it.
Missing link to upstream issue. Would be nice to have one but is not a blocker.
The removal of some extensions, is OK from my point of view.
opencensus-ext-mysql is the only one that has its dependency present and
perhaps could be enabled.
- contrib/opencensus-ext-google-cloud-clientlibs
Issue: >= 0.8.dev0, current 0.7.7
- contrib/opencensus-ext-mysql
Dep: https://src.fedoraproject.org/rpms/python-PyMySQL
- contrib/opencensus-ext-postgresql
Issue: >= 0.8.dev0, current 0.7.7
Dep: https://src.fedoraproject.org/rpms/python-psycopg2, would require a
patch for the setup.py
- contrib/opencensus-ext-stackdriver
Deps not present
Package APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package must not depend on deprecated() packages.
Note: python3-pytest4 is deprecated, you must not depend on it.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/deprecating-packages/
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache License (v2.0)",
"Apache License (v2.0)". 173 files have unknown license. Detailed
output of licensecheck in
/home/fab/Documents/repos/reviews/1839479-python-
opencensus/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python3.9/site-
packages/opencensus/ext
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.9/site-
packages/opencensus, /usr/lib/python3.9/site-packages/opencensus/ext,
/usr/lib/python3.9/site-packages/opencensus/common
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 245760 bytes in 45 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]:
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 Fabian Affolter changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@fabian-affolter.ch Assignee|nob...@fedoraproject.org|m...@fabian-affolter.ch Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 Mohamed El Morabity changed: What|Removed |Added Blocks||1830659 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1830659 [Bug 1830659] FTI: python-azure-sdk: python3-azure-sdk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 Mohamed El Morabity changed: What|Removed |Added Blocks||1834085 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1834085 [Bug 1834085] F32FailsToInstall: python3-azure-sdk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 Mohamed El Morabity changed: What|Removed |Added Blocks||1839480 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1839480 [Bug 1839480] Review Request: python-opentelemetry - The OpenTelemetry Python client -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 Mohamed El Morabity changed: What|Removed |Added Depends On||1839473, 1839470, 1839477, ||1839472 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1839470 [Bug 1839470] Review Request: python-googleapis-common-protos - Common protobufs used in Google APIs https://bugzilla.redhat.com/show_bug.cgi?id=1839472 [Bug 1839472] Review Request: python-grpcio-gcp - gRPC for GCP extensions https://bugzilla.redhat.com/show_bug.cgi?id=1839473 [Bug 1839473] Review Request: python-opencensus-proto - Language Independent Interface Types For OpenCensus https://bugzilla.redhat.com/show_bug.cgi?id=1839477 [Bug 1839477] Review Request: python-google-api-core - Core Library for Google Client Libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
