[Bug 1853081] Review Request: mlxbf-bfscripts - Helper scripts for Mellanox BlueField systems
https://bugzilla.redhat.com/show_bug.cgi?id=1853081 Alaa Hleihel (NVIDIA Mellanox) changed: What|Removed |Added Blocks||1858600 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1853081] Review Request: mlxbf-bfscripts - Helper scripts for Mellanox BlueField systems
https://bugzilla.redhat.com/show_bug.cgi?id=1853081 --- Comment #9 from Alaa Hleihel (NVIDIA Mellanox) --- Thanks! Spencer, I think now you need to request-repo and push the package to it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1853081] Review Request: mlxbf-bfscripts - Helper scripts for Mellanox BlueField systems
https://bugzilla.redhat.com/show_bug.cgi?id=1853081 Robert-André Mauchin changed: What|Removed |Added Flags|fedora-review- |fedora-review+ --- Comment #8 from Robert-André Mauchin --- Refreshed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1853081] Review Request: mlxbf-bfscripts - Helper scripts for Mellanox BlueField systems
https://bugzilla.redhat.com/show_bug.cgi?id=1853081 Robert-André Mauchin changed: What|Removed |Added Flags|fedora-review+ |fedora-review- |needinfo?(zebo...@gmail.com | |) | --- Comment #7 from Robert-André Mauchin --- Sorry I'm more ausy these days. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1853081] Review Request: mlxbf-bfscripts - Helper scripts for Mellanox BlueField systems
https://bugzilla.redhat.com/show_bug.cgi?id=1853081 Alaa Hleihel (NVIDIA Mellanox) changed: What|Removed |Added Flags||needinfo?(zebo...@gmail.com ||) --- Comment #6 from Alaa Hleihel (NVIDIA Mellanox) --- Hi, What is the status of adding this package to Fedora? Thanks, Alaa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1853081] Review Request: mlxbf-bfscripts - Helper scripts for Mellanox BlueField systems
https://bugzilla.redhat.com/show_bug.cgi?id=1853081
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #5 from Robert-André Mauchin ---
- Not needed
%build
exit 0
- This is not needed, it is already the default:
%attr(644, root, root)
Package approved, please fix the aforementioned issues before import.
Maybe needinfo your reviewers in the dependencies, otherwise you won't be able
to install it.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 2-clause "Simplified" License",
"BSD 3-clause "New" or "Revised" License". 28 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/mlxbf-bfscripts/review-mlxbf-
bfscripts/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
systemd_postun in %postun for Systemd service files.
Note: Systemd service file(s) in mlxbf-bfscripts
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[Bug 1853081] Review Request: mlxbf-bfscripts - Helper scripts for Mellanox BlueField systems
https://bugzilla.redhat.com/show_bug.cgi?id=1853081
--- Comment #4 from Spencer Lingard ---
New version for review.
Spec URL:
https://download.copr.fedorainfracloud.org/results/slingard/mlxbf-bfscripts/fedora-rawhide-aarch64/01575325-mlxbf-bfscripts/mlxbf-bfscripts.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/slingard/mlxbf-bfscripts/fedora-rawhide-aarch64/01575325-mlxbf-bfscripts/mlxbf-bfscripts-3.0.0~beta1-3.fc33.src.rpm
Scratch Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=47787034
(In reply to Artur Iwicki from comment #3)
> >Source: mlxbf-bfscripts.tar.gz
> Ideally this should be a downloadable URL. Are you using the "3.0.beta1" git
> tag? Then you could use
> "https://github.com/Mellanox/bfscripts/archive/3.0.beta1/bfscripts-3.0.beta1.
> tar.gz" here.
The spec file and SRPM are generated by rpkg-util. I put a comment here that
shows how to create the source files needed.
> >%{__install} bfbootmgr%{installdir}
> >%{__install} man/bfbootmgr.8 %{man8dir}
> >...
> 1. Macro forms of system executables are discouraged.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
Done.
> 2. Use the "-p" flag to preserve timestamps.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps
Done.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1853081] Review Request: mlxbf-bfscripts - Helper scripts for Mellanox BlueField systems
https://bugzilla.redhat.com/show_bug.cgi?id=1853081
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
--- Comment #3 from Artur Iwicki ---
>Source: mlxbf-bfscripts.tar.gz
Ideally this should be a downloadable URL. Are you using the "3.0.beta1" git
tag? Then you could use
"https://github.com/Mellanox/bfscripts/archive/3.0.beta1/bfscripts-3.0.beta1.tar.gz;
here.
>%{__install} bfbootmgr%{installdir}
>%{__install} man/bfbootmgr.8 %{man8dir}
>...
1. Macro forms of system executables are discouraged.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
2. Use the "-p" flag to preserve timestamps.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1853081] Review Request: mlxbf-bfscripts - Helper scripts for Mellanox BlueField systems
https://bugzilla.redhat.com/show_bug.cgi?id=1853081 --- Comment #2 from Spencer Lingard --- New version for review. Spec URL: https://download.copr.fedorainfracloud.org/results/slingard/mlxbf-bfscripts/fedora-rawhide-aarch64/01571580-mlxbf-bfscripts/mlxbf-bfscripts.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/slingard/mlxbf-bfscripts/fedora-rawhide-aarch64/01571580-mlxbf-bfscripts/mlxbf-bfscripts-3.0.0~beta1-2.fc33.src.rpm Scratch Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=47584583 Fixes shellcheck issues, and issues detected automatically by fedora-review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1853081] Review Request: mlxbf-bfscripts - Helper scripts for Mellanox BlueField systems
https://bugzilla.redhat.com/show_bug.cgi?id=1853081 Alaa Hleihel (Mellanox) changed: What|Removed |Added Blocks||1656141 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1853081] Review Request: mlxbf-bfscripts - Helper scripts for Mellanox BlueField systems
https://bugzilla.redhat.com/show_bug.cgi?id=1853081 Honggang LI changed: What|Removed |Added CC||ho...@redhat.com --- Comment #1 from Honggang LI --- Created attachment 1699586 --> https://bugzilla.redhat.com/attachment.cgi?id=1699586=edit coverity scan report please fix the defects reported by coverity. thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1853081] Review Request: mlxbf-bfscripts - Helper scripts for Mellanox BlueField systems
https://bugzilla.redhat.com/show_bug.cgi?id=1853081 Spencer Lingard changed: What|Removed |Added Depends On||1846139, 1835452 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1835452 [Bug 1835452] Review Request: mlxbf-bootctl - Bootloader control for Mellanox BlueField https://bugzilla.redhat.com/show_bug.cgi?id=1846139 [Bug 1846139] Review Request: mlxbf-aarch64-firmware - Boot firmware (ATF, UEFI...) for Mellanox BlueField -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
