[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

2020-08-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1868991

Fabio Valentini  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||jakarta-el-4.0.0-1.fc33
 Resolution|--- |NEXTRELEASE
Last Closed||2020-08-23 20:10:39



--- Comment #13 from Fabio Valentini  ---
Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1598848
And for fedora 33:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1598850


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

2020-08-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1868991



--- Comment #12 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/jakarta-el


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

2020-08-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1868991



--- Comment #11 from Fabio Valentini  ---
Thanks!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

2020-08-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1868991

Mat Booth  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Mat Booth  ---
APPROVED


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

2020-08-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1868991



--- Comment #9 from Fabio Valentini  ---
Alright, let's not break the pattern.

Though I don't think that having %{name} as the default subdirectory name is a
good idea (as witnessed by the painful process of renaming some packages and
keeping backwards compatibility).

I've updated the files with the less concise but less magical version of
%mvn_alias :-)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

2020-08-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1868991



--- Comment #8 from Mat Booth  ---
Yeah, but I don't think the glassfish-el package was "correct." See
maven-resolver for another example where jars from many subpackages are being
installed into a single subdir:

$ ll /usr/share/java/maven-resolver
total 624
-rw-r--r-- 1 root root 151207 Jan 29  2020 maven-resolver-api.jar
-rw-r--r-- 1 root root  48152 Jan 29  2020 maven-resolver-connector-basic.jar
-rw-r--r-- 1 root root 185262 Jan 29  2020 maven-resolver-impl.jar
-rw-r--r-- 1 root root  40592 Jan 29  2020 maven-resolver-spi.jar
-rw-r--r-- 1 root root  35025 Jan 29  2020 maven-resolver-transport-wagon.jar
-rw-r--r-- 1 root root 169636 Jan 29  2020 maven-resolver-util.jar

$ for j in /usr/share/java/maven-resolver/* ; do rpm -qf $j ; done
maven-resolver-api-1.4.1-2.fc32.noarch
maven-resolver-connector-basic-1.4.1-2.fc32.noarch
maven-resolver-impl-1.4.1-2.fc32.noarch
maven-resolver-spi-1.4.1-2.fc32.noarch
maven-resolver-transport-wagon-1.4.1-2.fc32.noarch
maven-resolver-util-1.4.1-2.fc32.noarch

Note that the above is the default behaviour if there are no calls to mvn_file
at all, and was what jakarta-el was doing before you added the call to
mvn_file. So jakarta-el would be intentionally deviating from the default.

And I'll admit, I was rather enjoying the consistency all the jakarta-*
packages had to date:

 sh-5.0# ls -ld /usr/share/java/jakarta*
drwxr-xr-x 2 root root 4096 Aug 20 11:43 /usr/share/java/jakarta-activation
drwxr-xr-x 2 root root 4096 Aug 20 11:43 /usr/share/java/jakarta-annotations
drwxr-xr-x 2 root root 4096 Aug 20 11:43 /usr/share/java/jakarta-messaging
drwxr-xr-x 2 root root 4096 Aug 20 11:43 /usr/share/java/jakarta-persistence
drwxr-xr-x 2 root root 4096 Aug 20 11:43 /usr/share/java/jakarta-servlet
drwxr-xr-x 2 root root 4096 Aug 20 11:43 /usr/share/java/jakarta-ws-rs
drwxr-xr-x 2 root root 4096 Aug 20 11:43 /usr/share/java/jakarta-xml-ws

 sh-5.0# ls -l /usr/share/java/jakarta*/*
-rw-r--r-- 1 root root  45062 Jul 29 23:33
/usr/share/java/jakarta-activation/jakarta.activation-api.jar
-rw-r--r-- 1 root root  67376 Jul 29 23:33
/usr/share/java/jakarta-activation/jakarta.activation.jar
-rw-r--r-- 1 root root  24176 Aug 13 22:21
/usr/share/java/jakarta-annotations/jakarta.annotation-api.jar
-rw-r--r-- 1 root root  55011 Aug 17 15:03
/usr/share/java/jakarta-messaging/jakarta.jms-api.jar
-rw-r--r-- 1 root root 160454 Aug 17 15:14
/usr/share/java/jakarta-persistence/jakarta.persistence-api.jar
-rw-r--r-- 1 root root 397542 Aug 20 09:31
/usr/share/java/jakarta-servlet/jakarta.servlet-api.jar
-rw-r--r-- 1 root root 136987 Aug 17 14:46
/usr/share/java/jakarta-ws-rs/jakarta.ws.rs-api.jar
-rw-r--r-- 1 root root  55516 Aug 14 15:15
/usr/share/java/jakarta-xml-ws/jaxws-api.jar

Ahh, inexplicably pleasing :-D


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

2020-08-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1868991



--- Comment #7 from Fabio Valentini  ---
(In reply to Mat Booth from comment #6)
> Thanks for the updates, just two nits remaining:
> 
> 
> 1) The OSGi metadata does not export the jakarta.el package, because line 69
> completely overwrites the Export-Package value, not append to it. On line 69
> you want:
> 
> 'jakarta.el,javax.el;version="3.0.0"'
> 
> To ensure it exports both old and new packages.

Good catch, will fix.

> 2) The Java guidelines state that if the package provides multiple JAR
> files, they SHOULD be installed in a %{name} subdirectory (of %{_javadir})
> 
> So I would prefer if lines 85 and 86 read like this instead:
> 
> %mvn_file :jakarta.el %{name}/jakarta.el glassfish-el
> %mvn_file :jakarta.el-api %{name}/jakarta.el-api glassfish-el-api
> 
> Or slightly more concisely:
> 
> %mvn_file :{jakarta.el} %{name}/@1 glassfish-el
> %mvn_file :{jakarta.el-api} %{name}/@1 glassfish-el-api
> 
> And that would result in the following:
> 
> /usr/share/java/glassfish-el.jar -> ./jakarta-el/jakarta.el.jar
> /usr/share/java/glassfish-el-api.jar -> ./jakarta-el/jakarta.el-api.jar
> /usr/share/java/jakarta-el
> /usr/share/java/jakarta-el/jakarta.el.jar
> /usr/share/java/jakarta-el/jakarta.el-api.jar

Well, those two JARs are shipped by two *different* packages though?
Wasn't that the whole reason for splitting out -api as a subpackage? It's also
how it is currently handled in glassfish-el.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

2020-08-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1868991



--- Comment #6 from Mat Booth  ---
Thanks for the updates, just two nits remaining:


1) The OSGi metadata does not export the jakarta.el package, because line 69
completely overwrites the Export-Package value, not append to it. On line 69
you want:

'jakarta.el,javax.el;version="3.0.0"'

To ensure it exports both old and new packages.

2) The Java guidelines state that if the package provides multiple JAR files,
they SHOULD be installed in a %{name} subdirectory (of %{_javadir})

So I would prefer if lines 85 and 86 read like this instead:

%mvn_file :jakarta.el %{name}/jakarta.el glassfish-el
%mvn_file :jakarta.el-api %{name}/jakarta.el-api glassfish-el-api

Or slightly more concisely:

%mvn_file :{jakarta.el} %{name}/@1 glassfish-el
%mvn_file :{jakarta.el-api} %{name}/@1 glassfish-el-api

And that would result in the following:

/usr/share/java/glassfish-el.jar -> ./jakarta-el/jakarta.el.jar
/usr/share/java/glassfish-el-api.jar -> ./jakarta-el/jakarta.el-api.jar
/usr/share/java/jakarta-el
/usr/share/java/jakarta-el/jakarta.el.jar
/usr/share/java/jakarta-el/jakarta.el-api.jar


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

2020-08-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1868991



--- Comment #5 from Fabio Valentini  ---
After discussion on IRC:

I can confirm that glassfish-el and glassfish-el-api currently ship JAR files
in the /usr/share/java/ base directory:
- /usr/share/java/glassfish-el.jar
- /usr/share/java/glassfish-el-api.jar

So adding the compat symlinks with %mvn_file should do the correct thing in the
.spec.
These are the resulting symlinks:
- /usr/share/java/glassfish-el.jar → ./jakarta.el.jar
- /usr/share/java/glassfish-el-api.jar → ./jakarta.el-api.jar


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

2020-08-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1868991



--- Comment #4 from Fabio Valentini  ---
I've also added the same transitionary jakarta.el → javax.el copy in the -api
subpackage (similar to what you did for jakarta-servlet).

Another issue I came across was missing .jar symlinks for packages that
construct the classpath manually.
I've fixed that in jakarta-servlet and added the corresponding fix in this
package as well.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

2020-08-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1868991



--- Comment #3 from Fabio Valentini  ---
- created -api subpackage, shipping implementation in jakarta-el and API in
jakarta-el-api
- corrected %mvn_alias calls for impl and api

I've checked all the Provides that are currently there in glassfish-el{,-api}:

# provided as part of rename
glassfish-el = 3.0.1-0.13.b08.fc32
# no dependents in fedora
mvn(org.eclipse.jetty.orbit:com.sun.el) = 3.0.1.b08
# no dependents in fedora
mvn(org.eclipse.jetty.orbit:com.sun.el:pom:) = 3.0.1.b08
# no dependents in fedora
mvn(org.glassfish.web:javax.el) = 3.0.1.b08
# no dependents in fedora
mvn(org.glassfish.web:javax.el:pom:) = 3.0.1.b08
# %mvn_alias org.glassfish:jakarta.el org.glassfish:javax.el
mvn(org.glassfish:javax.el) = 3.0.1.b08
# no dependents in fedora
mvn(org.glassfish:javax.el-impl) = 3.0.1.b08
# no dependents in fedora
mvn(org.glassfish:javax.el-impl:pom:) = 3.0.1.b08
# no dependents in fedora
mvn(org.glassfish:javax.el:pom:) = 3.0.1.b08
osgi(com.sun.el.javax.el) = 3.0.0


# provided as part of rename
glassfish-el-api = 3.0.1-0.13.b08.fc32
# no dependents in fedora
mvn(javax.el:el-api) = 3.0.1.b08
# no dependents in fedora
mvn(javax.el:el-api:pom:) = 3.0.1.b08
# %mvn_alias jakarta.el:jakarta.el-api javax.el:javax.el-api
mvn(javax.el:javax.el-api) = 3.0.1.b08
# no dependents in fedora
mvn(javax.el:javax.el-api:pom:) = 3.0.1.b08
# no dependents in fedora
mvn(org.glassfish:javax.el-api) = 3.0.1.b08
# no dependents in fedora
mvn(org.glassfish:javax.el-api:pom:) = 3.0.1.b08
osgi(javax.el-api) = 3.0.0


I think the two aliases take care of the transition.


(Updated files at the original URLs.)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

2020-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1868991



--- Comment #2 from Fabio Valentini  ---
(In reply to Mat Booth from comment #1)
> Issues:
> 
> 1)
> 
> Missing obsoletes/provides -- package does not obsolete/provide
> glassfish-el-api, even though it ships both api and impl jars. The package
> you are renaming split the impl and api into separate sub-packages, was the
> consolidation into a single binary RPM here intentional?

No, that was not intentional. I missed it when creating a clean package from
scratch.
I'll build with `%mvn_build -s` and add an -api subpackage.

> 2)
> 
> Incorrect aliases -- it looks like you added "org.glassfish:javax.el" as an
> alias for the API jar, when it should be an alias for the impl jar. For
> example, comparing the old glassfish-el{,-api} packages:
> 
> $ xmvn-resolve org.glassfish:javax.el
> /usr/share/java/glassfish-el.jar
> $ xmvn-resolve org.glassfish:javax.el-api
> /usr/share/java/glassfish-el-api.jar
> 
> With your new package:
> 
> # xmvn-resolve org.glassfish:javax.el
> /usr/share/java/jakarta-el/jakarta.el-api.jar
> # xmvn-resolve org.glassfish:javax.el-api
> ERROR: Unable to resolve artifact org.glassfish:javax.el-api:jar:SYSTEM
> 
> So the "org.glassfish:javax.el" alias has different, incompatible behaviour.

Good catch. I'll re-check the artifact coordinates in glassfish-el and
glassfish-el-api and map them to the new artifact coordinates (correctly this
time, I hope).

> I assume once again the aliases you omitted are not required by anything
> currently in Fedora :-)

Yes. Any aliases I dropped were not depended on by anything.
But I will check that again, too, since I clearly was tired when I made this
package :-)


Thanks for the first review, I'll update files and come back here once I' ve
fixed the issues.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

2020-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1868991



--- Comment #1 from Mat Booth  ---
Issues:

1)

Missing obsoletes/provides -- package does not obsolete/provide
glassfish-el-api, even though it ships both api and impl jars. The package you
are renaming split the impl and api into separate sub-packages, was the
consolidation into a single binary RPM here intentional?

2)

Incorrect aliases -- it looks like you added "org.glassfish:javax.el" as an
alias for the API jar, when it should be an alias for the impl jar. For
example, comparing the old glassfish-el{,-api} packages:

$ xmvn-resolve org.glassfish:javax.el
/usr/share/java/glassfish-el.jar
$ xmvn-resolve org.glassfish:javax.el-api
/usr/share/java/glassfish-el-api.jar

With your new package:

# xmvn-resolve org.glassfish:javax.el
/usr/share/java/jakarta-el/jakarta.el-api.jar
# xmvn-resolve org.glassfish:javax.el-api
ERROR: Unable to resolve artifact org.glassfish:javax.el-api:jar:SYSTEM

So the "org.glassfish:javax.el" alias has different, incompatible behaviour.

I assume once again the aliases you omitted are not required by anything
currently in Fedora :-)




Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "*No copyright* Eclipse Public License
 2.0", "Eclipse Public License 2.0", "Apache License 2.0". 18 files
 have unknown license. Detailed output of licensecheck in
 /home/mbooth/fedora/1868991-jakarta-el/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[!]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see 

[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

2020-08-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1868991

Mat Booth  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mat.bo...@redhat.com
   Assignee|nob...@fedoraproject.org|mat.bo...@redhat.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

2020-08-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1868991

Fabio Valentini  changed:

   What|Removed |Added

 Blocks||1868992





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1868992
[Bug 1868992] Review Request: jakarta-server-pages - Jakarta Server Pages (JSP)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org