[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 --- Comment #20 from Fedora Update System --- FEDORA-EPEL-2020-ba5f43d4c6 has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 --- Comment #19 from Fedora Update System --- FEDORA-EPEL-2020-bbd9e24a34 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 --- Comment #18 from Fedora Update System --- FEDORA-2020-628a83992c has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 --- Comment #17 from Fedora Update System --- FEDORA-2020-e584a6f7d2 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-11-18 02:20:30 --- Comment #16 from Fedora Update System --- FEDORA-2020-c0c5de116c has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 --- Comment #15 from Fedora Update System --- FEDORA-2020-c0c5de116c has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-c0c5de116c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-c0c5de116c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 --- Comment #14 from Fedora Update System --- FEDORA-2020-e584a6f7d2 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-e584a6f7d2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e584a6f7d2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 --- Comment #13 from Fedora Update System --- FEDORA-EPEL-2020-ba5f43d4c6 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-ba5f43d4c6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 --- Comment #12 from Fedora Update System --- FEDORA-2020-628a83992c has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-628a83992c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-628a83992c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- FEDORA-EPEL-2020-bbd9e24a34 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-bbd9e24a34 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 --- Comment #10 from Fedora Update System --- FEDORA-EPEL-2020-ba5f43d4c6 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-ba5f43d4c6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 --- Comment #9 from Fedora Update System --- FEDORA-EPEL-2020-bbd9e24a34 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-bbd9e24a34 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 --- Comment #8 from Fedora Update System --- FEDORA-2020-628a83992c has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-628a83992c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 --- Comment #7 from Fedora Update System --- FEDORA-2020-e584a6f7d2 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e584a6f7d2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2020-c0c5de116c has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-c0c5de116c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/unrealircd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 --- Comment #4 from Robert Scheck --- Thank you for the package review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 --- Comment #2 from Robert Scheck --- (In reply to Robert-André Mauchin from comment #1) > unrealircd.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/unrealircd > ['/builddir/unrealircd/lib'] Fixed. > - The program reeds to use Fedora default SSL crypto: > > https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/ Fixed as suggested by bullet #1 by patching the default configuration. > - Please include this licensese and add a comment explaining the license > breakdown: Fixed, but IMHO the "Expat License" is effectively "MIT", especially as the "Expat License" is not mentioned at https://fedoraproject.org/wiki/Licensing:Main > - Please add a comment above each patch explaining why they are needed. Fixed. > - Don't mix tabs and spaces, lire 15 there is a tab Fixed. Spec URL: http://labs.linuxnetz.de/bugzilla/unrealircd.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/unrealircd-5.0.7-2.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review? --- Comment #1 from Robert-André Mauchin --- - Remove this Rpath: [!]: Rpath absent or only used for internal libs. Note: See rpmlint output unrealircd.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/unrealircd ['/builddir/unrealircd/lib'] - The program reeds to use Fedora default SSL crypto: https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/ unrealircd.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/unrealircd SSL_CTX_set_cipher_list Patch it where necessary: src/tls.c 383:if (SSL_CTX_set_cipher_list(ctx, tlsoptions->ciphers) == 0) src/crashreport.c 598:SSL_CTX_set_cipher_list(ctx_client, UNREALIRCD_DEFAULT_CIPHERS); src/modulemanager.c 83: SSL_CTX_set_cipher_list(ctx_client, UNREALIRCD_DEFAULT_CIPHERS); - Please include this licensese and add a comment explaining the license breakdown: BSD 3-clause "New" or "Revised" License --- unrealircd-5.0.7/include/mempool.h unrealircd-5.0.7/src/mempool.c Expat License - unrealircd-5.0.7/include/openssl_hostname_validation.h - Please add a comment above each patch explaining why they are needed. - Don't mix tabs and spaces, lire 15 there is a tab Source10: unrealircdctl Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [!]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v1.0 or later [obsolete FSF postal address (Mass Ave)]", "FSF Unlimited License [generated file]", "GNU General Public License v3.0 or later", "Public domain", "GNU General Public License v1.0 or later [obsolete FSF postal address (Mass Ave), obsolete FSF postal address (Mass Ave)]", "BSD 3-clause "New" or "Revised" License", "Expat License", "GNU General Public License v2.0 or later [obsolete FSF postal address (Mass Ave)]", "GNU General Public License v1.0 or later [generated file, obsolete FSF postal address (Mass Ave)]", "GNU General Public License", "*No copyright* [generated file]", "*No copyright* GNU General Public License v1.0 or later [obsolete FSF postal address (Mass Ave)]", "GNU General Public License v2.0 or later". 143 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/unrealircd/review- unrealircd/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation
[Bug 1891370] Review Request: unrealircd - Open Source IRC server
https://bugzilla.redhat.com/show_bug.cgi?id=1891370 Robert Scheck changed: What|Removed |Added Summary|Review Request: anope - IRC |Review Request: unrealircd |services designed for |- Open Source IRC server |flexibility and ease of use | Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
