[Bug 1894911] Review Request: perl-PDF-Builder - Creation and modification of PDF files in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1894911

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-PDF-Builder-3.019-2.fc
   ||34
 Resolution|--- |RAWHIDE
Last Closed||2021-02-03 08:17:48



--- Comment #9 from Petr Pisar  ---
Thank you for the review and the repository.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1894911] Review Request: perl-PDF-Builder - Creation and modification of PDF files in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1894911



--- Comment #8 from Mohan Boddu  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-PDF-Builder


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1894911] Review Request: perl-PDF-Builder - Creation and modification of PDF files in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1894911



--- Comment #7 from Petr Pisar  ---
https://pagure.io/releng/fedora-scm-requests/issue/31971


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1894911] Review Request: perl-PDF-Builder - Creation and modification of PDF files in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1894911

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Jitka Plesnikova  ---
Updated package looks good to me.

Approved


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1894911] Review Request: perl-PDF-Builder - Creation and modification of PDF files in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1894911

Petr Pisar  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?



--- Comment #5 from Petr Pisar  ---
I need a new review because the review is older than 60 days:

Spec URL:
https://ppisar.fedorapeople.org/perl-PDF-Builder/perl-PDF-Builder.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-PDF-Builder/perl-PDF-Builder-3.019-2.fc34.src.rpm

I kept the old sources and only clarified the license and corrected
Image::PNG::Libpng usage to past the tests. This should make comparing against
the original source package easy for you.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1894911] Review Request: perl-PDF-Builder - Creation and modification of PDF files in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1894911



--- Comment #4 from Petr Pisar  ---
I received a MIT license from the author of the Artistic-only code. This code
can be now added to Fedora.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1894911] Review Request: perl-PDF-Builder - Creation and modification of PDF files in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1894911

Petr Pisar  changed:

   What|Removed |Added

 Blocks|1893477 |





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1893477
[Bug 1893477] gscan2pdf-2.10.1 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1894911] Review Request: perl-PDF-Builder - Creation and modification of PDF files in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1894911
Bug 1894911 depends on bug 1894633, which changed state.

Bug 1894633 Summary: Review Request: perl-Image-PNG-Libpng - Perl interface to 
the libpng library
https://bugzilla.redhat.com/show_bug.cgi?id=1894633

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1894911] Review Request: perl-PDF-Builder - Creation and modification of PDF files in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1894911



--- Comment #3 from Petr Pisar  ---
A request for clarifying the original PDF-API2
.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1894911] Review Request: perl-PDF-Builder - Creation and modification of PDF files in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1894911



--- Comment #2 from Petr Pisar  ---
(In reply to Jitka Plesnikova from comment #1)
> License
> FIX: Please check the license text in files
>   * PDF-Builder-3.019/lib/PDF/Builder/Basic/PDF/*.pm
>  They contains:
> #   THIS IS A REUSED PERL MODULE, FOR PROPER LICENCING TERMS SEE BELOW:
> #
> #   Copyright Martin Hosken 
> #
> #   No warranty or expression of effectiveness, least of all regarding
> #   anyone's safety, is implied in this software or documentation.
> #
> #   This specific module is licensed under the Perl Artistic License.
> 
This was forked from PDF-API2 and the same license notice is in your
perl-PDF-API2-2.038 package.
I will ask the original upstream. Hopefully he mentioned the same Perl.
I will also notify the PDF-Builder forker because he's not aware about it.

>   * PDF-Builder-3.019/lib/PDF/Builder/Matrix.pm
> #   This library is free software; you can redistribute it
> #   and/or modify it under the same terms as Perl itself.
> 
Good catch. I missed it.

> $ rpmlint ./perl-PDF-Builder*
> perl-PDF-Builder.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/perl-PDF-Builder/examples/resources/pod2htmd.temp
> perl-PDF-Builder.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/perl-PDF-Builder/examples/resources/sample.txt
> 2 packages and 1 specfiles checked; 0 errors, 2 warnings.
> FIX: Could it be fix? Or are the files valid examples?
> 
I documented it in the spec file. Those are literal blobs to demonstrate that
the code can deal with CR-LF end of lines. Thus I believe we should not patch
them.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1894911] Review Request: perl-PDF-Builder - Creation and modification of PDF files in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1894911

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License
FIX: Please check the license text in files
  * PDF-Builder-3.019/lib/PDF/Builder/Basic/PDF/*.pm
 They contains:
#   THIS IS A REUSED PERL MODULE, FOR PROPER LICENCING TERMS SEE BELOW:
#
#   Copyright Martin Hosken 
#
#   No warranty or expression of effectiveness, least of all regarding
#   anyone's safety, is implied in this software or documentation.
#
#   This specific module is licensed under the Perl Artistic License.

  * PDF-Builder-3.019/lib/PDF/Builder/Matrix.pm
#   This library is free software; you can redistribute it
#   and/or modify it under the same terms as Perl itself.

Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-PDF-Builder-3.019-1.fc34.noarch.rpm | sort | uniq -c
| grep -v rpmlib | grep -v PDF::Builder
  1 perl(base)
  1 perl(Carp)
  1 perl(Compress::Zlib) >= 1
  1 perl(constant)
  1 perl(Encode)
  1 perl(Exporter)
  1 perl(File::Basename)
  1 perl(FileHandle)
  1 perl(File::Temp)
  1 perl(Font::TTF::Font)
  1 perl(IO::File)
  1 perl(List::Util)
  1 perl(Math::Trig)
  1 perl(:MODULE_COMPAT_5.32.0)
  1 perl(POSIX)
  1 perl(Scalar::Util)
  1 perl(strict)
  1 perl(Unicode::UCD)
  1 perl(vars)
  1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-PDF-Builder-3.019-1.fc34.noarch.rpm | sort | uniq -c
I do not add long list of all provides. Binary provides are Ok.

$ rpmlint ./perl-PDF-Builder*
perl-PDF-Builder.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/perl-PDF-Builder/examples/resources/pod2htmd.temp
perl-PDF-Builder.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/perl-PDF-Builder/examples/resources/sample.txt
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
FIX: Could it be fix? Or are the files valid examples?

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct 'FIX' items.

Resolution:
Approved


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1894911] Review Request: perl-PDF-Builder - Creation and modification of PDF files in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1894911

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1894911] Review Request: perl-PDF-Builder - Creation and modification of PDF files in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1894911

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1893477
 Depends On||1894633





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1893477
[Bug 1893477] gscan2pdf-2.10.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1894633
[Bug 1894633] Review Request: perl-Image-PNG-Libpng - Perl interface to the
libpng library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org