[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #31 from Fedora Update System --- FEDORA-2021-56fe02602d has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #30 from Fedora Update System --- FEDORA-2021-0e1c5bb517 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #29 from Fedora Update System --- FEDORA-2021-56fe02602d has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-56fe02602d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-56fe02602d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #28 from Fedora Update System --- FEDORA-2021-0e1c5bb517 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-0e1c5bb517` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-0e1c5bb517 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #27 from Fedora Update System --- FEDORA-2021-56fe02602d has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-56fe02602d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #26 from Fedora Update System --- FEDORA-2021-0e1c5bb517 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-0e1c5bb517 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-03-19 20:12:23 --- Comment #25 from Fedora Update System --- FEDORA-2021-ad6a063cce has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #24 from Fedora Update System --- FEDORA-2021-56fe02602d has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-56fe02602d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-56fe02602d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #23 from Fedora Update System --- FEDORA-2021-0e1c5bb517 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-0e1c5bb517` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-0e1c5bb517 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #22 from Fedora Update System --- FEDORA-2021-56fe02602d has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-56fe02602d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #21 from Fedora Update System --- FEDORA-2021-0e1c5bb517 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-0e1c5bb517 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #20 from Fedora Update System --- FEDORA-2021-ad6a063cce has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-ad6a063cce \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-ad6a063cce See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #19 from Fedora Update System --- FEDORA-2021-315b5a9a8f has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-315b5a9a8f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-315b5a9a8f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System --- FEDORA-2021-9221c9d18b has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-9221c9d18b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-9221c9d18b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #17 from Fedora Update System --- FEDORA-2021-315b5a9a8f has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-315b5a9a8f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #16 from Fedora Update System --- FEDORA-2021-9221c9d18b has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-9221c9d18b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #15 from Fedora Update System --- FEDORA-2021-ad6a063cce has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-ad6a063cce -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #14 from Tomas Hrcka --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/wdt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #13 from Davide Cavalca --- Thanks! I'll double check the library-path thing and fix it on import. $ fedpkg request-repo wdt 1922315 https://pagure.io/releng/fedora-scm-requests/issue/32711 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315
--- Comment #12 from Jaroslav Škarvada ---
hardcoded-library-path in %{_prefix}/lib/*.a
I think you should fix it to be arch, i.e. %{_libdir}.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 Gabriel Gaspar Becker changed: What|Removed |Added Flags|needinfo?(ggasparb@redhat.c |fedora-review+ |om) | --- Comment #11 from Gabriel Gaspar Becker --- Robert added a comment about the rpmlint error. That's is enough. Thanks for the update. I approve the request. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 Robert-André Mauchin changed: What|Removed |Added CC||ggasp...@redhat.com Flags||needinfo?(ggasparb@redhat.c ||om) --- Comment #10 from Robert-André Mauchin --- I would approve it but Gabriel Gaspar Becker is the assignee. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #9 from Jaroslav Škarvada --- (In reply to Davide Cavalca from comment #7) > - how do I add a waiver for rpmlint? To be honest I don't know. I saw some people adding .rpmlintrc files, but it didn't work for me. I would simply ignore them as false positives, or you can add comment to the spec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #8 from Davide Cavalca --- Spec URL: https://dcavalca.fedorapeople.org/review/wdt/wdt.spec SRPM URL: https://dcavalca.fedorapeople.org/review/wdt/wdt-1.32.1910230-2.20210128git6aec23c.fc35.src.rpm Changelog: - Fix typos in summary - Use more strict globbing for the soname version -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 --- Comment #7 from Davide Cavalca --- Thank you all for the review and comments! - yes, the last tagged release is ancient and doesn't build properly, so packaging tip is best here. - I'm packaging the static libraries because folly doesn't have a stable ABI, we do this for all libraries that depend on folly. See #1887621 for a discussion on that - I tried reenabling the tests but I still get spurious failures about half of the time, so I'm inclined to keep them off for now, at least until I can figure out how to make them more reliable - how do I add a waiver for rpmlint? - the exit() comes from TransferLogManager::checkLog(); I agree that this should be fixed if possible, I'll follow up with upstream to see what we can do about that -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #6 from Robert-André Mauchin ---
1) Please add comment explaining why this package has to use a specific commit
hash
Last release is from 2016, so I guess it's better to package the tip.
CMakeLists.txt contains the actual version.
3) Rpmlint is complaining about, please solve it or add a waiver:
wdt.src:119: E: hardcoded-library-path in %{_prefix}/lib
wdt.src:128: E: hardcoded-library-path in %{_prefix}/lib/*.a
Not an issue, they are renamed in the SPEC.
- Source0:
https://github.com/facebook/wdt/archive/%{commit}.tar.gz#/%{name}-%{commit}.tar.gz
→
Source0:
https://github.com/facebook/wdt/archive/%{commit}/%{name}-%{commit}.tar.gz
- To avoid unintentional soname bump, we recommend not globbing the soname
version:
%{_libdir}/*.so.1*
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 Ben Cotton changed: What|Removed |Added Blocks|182235 (FE-Legal) | --- Comment #5 from Ben Cotton --- Approved by Legal Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 Ben Cotton changed: What|Removed |Added CC||bcot...@redhat.com Blocks||182235 (FE-Legal) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315
--- Comment #4 from Jaroslav Škarvada ---
- Is there any need for the static subpackage? We shouldn't ship static libs
without strong reason, e.g. from the packaging guidelines [1]:
"In general, packagers SHOULD NOT ship static libraries."
- wdt-libs.x86_64: W: shared-lib-calls-exit
/usr/lib64/libwdt_min.so.1.32.1910230 exit@GLIBC_2.2.5
This is not good for shared library, it should be reported to upstream.
Generally, API errors shouldn't terminate the main program. But this is not
review blocker.
- Source0:
https://github.com/facebook/wdt/archive/%{commit}.tar.gz#/%{name}-%{commit}.tar.gz
This could be simplified to:
Source0:
https://github.com/facebook/wdt/archive/%{commit}/%{name}-%{commit}.tar.gz
- https://github.com/facebook/wdt/blob/master/PATENTS
This pose additional constraints to the license (line 14). Although I
personally think it's OK, I opened fedora-legal ticket [2] to be 100% sure.
[1]
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries
[2]
https://lists.fedoraproject.org/archives/list/le...@lists.fedoraproject.org/thread/2AVHXQD3C2JBSZQT7E6HK3HHQ4O5KBDV/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315
--- Comment #3 from Gabriel Gaspar Becker ---
Fedora 35 (rawhide) scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=63328734
Requests:
1) Please add comment explaining why this package has to use a specific commit
hash
2) There is a typo in the Summary of libs subpackage. ibraries -> libraries
3) Rpmlint is complaining about, please solve it or add a waiver:
wdt.src:119: E: hardcoded-library-path in %{_prefix}/lib
wdt.src:128: E: hardcoded-library-path in %{_prefix}/lib/*.a
Suggestions:
1) I have run tests a couple of times through koji builds and noticed that
x86_64 always completes successfully.
Did you have the same experience? If yes, the tests could be enabled on this
architecture so it would at least verify
in one of them.
e.g.: https://koji.fedoraproject.org/koji/taskinfo?taskID=63339323
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
License". 160 files have unknown license. Detailed output of
licensecheck in /tmp/1922315-wdt/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: Static libraries in -static or -devel subpackage, providing -devel if
present.
Note: Package has .a files: wdt-static.
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 Gabriel Gaspar Becker changed: What|Removed |Added Status|NEW |ASSIGNED CC||jskar...@redhat.com Assignee|nob...@fedoraproject.org|ggasp...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 Davide Cavalca changed: What|Removed |Added CC||kwiz...@gmail.com --- Comment #2 from Davide Cavalca --- *** Bug 1891040 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1922315] Review Request: wdt - Warp speed Data Transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1922315 Davide Cavalca changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Davide Cavalca --- Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=60767348 This is a replacement for https://bugzilla.redhat.com/show_bug.cgi?id=1891040 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
