[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081 --- Comment #17 from Fedora Update System --- FEDORA-2021-7e20a5478d has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-08-23 01:03:31 --- Comment #16 from Fedora Update System --- FEDORA-2021-7ebe4ed80e has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081 --- Comment #15 from Fedora Update System --- FEDORA-2021-7e20a5478d has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-7e20a5478d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-7e20a5478d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- FEDORA-2021-7ebe4ed80e has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-7ebe4ed80e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-7ebe4ed80e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081 --- Comment #13 from Fedora Update System --- FEDORA-2021-7e20a5478d has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-7e20a5478d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #12 from Fedora Update System --- FEDORA-2021-7ebe4ed80e has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-7ebe4ed80e -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081 --- Comment #11 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-gist -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081 --- Comment #10 from Georg Sauthoff --- Thank you for reviewing the package! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081 Jarek Prokop changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Jarek Prokop --- Package approved. Thanks! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081 --- Comment #8 from Georg Sauthoff --- >> I revisited it again, the rspec build-requires comes from my modified >> gem2rpm fedora template. So, I take this back: > no, that one should be there since that's what the test suite needs to run > (at according to gemspec as well). And that is the reason for the build > failure; the rubygem-rspec package is not present. Yes, this is what I thought, and what I observed a few weeks ago, when I created the package. > I was talking about the conditional `> 3`, since Fedora does not provide > rubygem-rspec <= 2, it is superfluous. I see, I misread that part. > > `Upload text to gist.github.com` > > Because it does not need to be code to upload it. Fair enough, what about 'content' then? I've updated the .spec file: https://raw.githubusercontent.com/gsauthof/copr-fedora/e7e3fe19107bb6de63c83c7e0527f035d3257af9/rubygem-gist/rubygem-gist.spec Corresponding Copr build (all green on rawhide/f33/f34): https://copr.fedorainfracloud.org/coprs/gsauthof/fedora/build/2504491/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081 --- Comment #7 from Jarek Prokop --- > I revisited it again, the rspec build-requires comes from my modified gem2rpm > fedora template. So, I take this back: no, that one should be there since that's what the test suite needs to run (at according to gemspec as well). And that is the reason for the build failure; the rubygem-rspec package is not present. I was talking about the conditional `> 3`, since Fedora does not provide rubygem-rspec <= 2, it is superfluous. > I still think that my summary/description is an improvement over the default > ones. It does descript the library better. Then I have only one small nit regarding Summary: `Upload code to gist.github.com` `Upload text to gist.github.com` Because it does not need to be code to upload it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081 --- Comment #6 from Georg Sauthoff --- As I wrote in my initial posting: > I started from a spec file generated by gem2rpm, but modified some > fields/sections where necessary. I revisited it again, the rspec build-requires comes from my modified gem2rpm fedora template. So, I take this back: > Sure, but if a requirement is indeed superfluous on fedora, then gem2rpm > could filter it, i.e. when using a fedora template. (since there is nothing to filter for gem2rpm) This is also the reason why you see the different summary/description. I still think that my summary/description is an improvement over the default ones. > ~~~ > Summary: Just allows you to upload gists > ~~~ > Which to me seems good enough. I disagree. If you don't already know what 'gists' are and that rubygem-gist uploads to github, then it doesn't tell you much. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081
--- Comment #5 from Georg Sauthoff ---
> Those are BuildRequires taken from gemspec, the maintainer should then decide
> what makes sense to be included and what does not ;)
Sure, but if a requirement is indeed superfluous on fedora, then gem2rpm could
filter it, i.e. when using a fedora template.
However,
> This minimal patch should work
> ~~~
> -%if 0%{?fedora} < 34
> -BuildRequires: rubygem(ronn)
> -%else
> -BuildRequires: rubygem(ronn-ng)
> -%endif
> +BuildRequires: %{_bindir}/ronn
> ~~~
No, it doesn't work. With that change the build fails on Copr:
+ rspec spec
/var/tmp/rpm-tmp.UCjJBV: line 33: rspec: command not found
https://copr.fedorainfracloud.org/coprs/gsauthof/fedora/build/2454151/
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081
--- Comment #4 from Jarek Prokop ---
(In reply to Georg Sauthoff from comment #3)
> Hm, the summary is pretty much what upstream provides:
>
> rpm: Upload code to gist.github.com
> upstream: upload code to https://gist.github.com
>
> So this is from the upstream readme/man page.
>
> Whereas the upstream help starts with another tag line:
>
> > Gist (v#{Gist::VERSION}) lets you upload to https://gist.github.com/
>
> However, I don't mind adding the https:// prefix to the RPM summary.
Hmm, fresh run of gem2rpm gives me:
~~~
Summary: Just allows you to upload gists
~~~
Which to me seems good enough.
and description:
~~~
%description
Provides a single function (Gist.gist) that uploads a gist.
~~~
JFTR the fresh specfile:
https://gist.github.com/jackorp/3e88a6abe5c5e57f933d6dc6130a1df2
IIRC both these values are taken from the gem's gemspec, which should be our
source of truth for these things (most of the time anyways).
>
> The RPM description basically summarizes the README.md. I think it is a
> better summary than just copying the Synopsis from the README/man page
> because it describes additional key points while still keeping it very short.
>
>
>
> I'll remove the vendored json and the superfluous rspec dependency.
>
> FWIW, the rspec depedency comes from the gem2rpm template.
Those are BuildRequires taken from gemspec, the maintainer should then decide
what makes sense to be included and what does not ;)
> I recommend querying upstream if they could include it in the built gem on
> RubyGems.
Just found out it was removed on purpose.
https://github.com/defunkt/gist/commit/b58ff3eb9dd8403af3f801be0eafcb2eb6f4ab2a
But I think we can still take the generated manpage from upstream (if they are
current that is), which eases up on build dependencies and we don't have to
generate it ourselves.
(Writing it again, as I forgot that it should be a raw textfile) `Source1:
https://raw.githubusercontent.com/defunkt/gist/v6.0.0/build/gist.1`
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081
--- Comment #3 from Georg Sauthoff ---
Hm, the summary is pretty much what upstream provides:
rpm: Upload code to gist.github.com
upstream: upload code to https://gist.github.com
So this is from the upstream readme/man page.
Whereas the upstream help starts with another tag line:
> Gist (v#{Gist::VERSION}) lets you upload to https://gist.github.com/
However, I don't mind adding the https:// prefix to the RPM summary.
The RPM description basically summarizes the README.md. I think it is a better
summary than just copying the Synopsis from the README/man page because it
describes additional key points while still keeping it very short.
I'll remove the vendored json and the superfluous rspec dependency.
FWIW, the rspec depedency comes from the gem2rpm template.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081
Jarek Prokop changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #2 from Jarek Prokop ---
if both packages provide the `ronn` binary, it is better to use `BuildRequires:
%{_bindir}/ronn`:
This minimal patch should work
~~~
-%if 0%{?fedora} < 34
-BuildRequires: rubygem(ronn)
-%else
-BuildRequires: rubygem(ronn-ng)
-%endif
+BuildRequires: %{_bindir}/ronn
~~~
JFTR upstream provides man pages which could be used as additional source
instead like this: `Source1:
https://github.com/defunkt/%{gem_name}/blob/v%{version}/build/%{gem_name}.1`
I recommend querying upstream if they could include it in the built gem on
RubyGems.
* The Summary and Descriptions seem to differ from the upstream, let's keep it
consistent with upstream.
* Vendored library `vendor/json.rb`
- While upstream has a use-case for this we do not as it is for homebrew
users (AFAICT from the repo), the file should be deleted for distribution in
Fedora Linux.
- There should probably be added a license header on that file and an
addition to the package's `License:` field if the file is kept in the resulting
RPM, since it looks like it was copied from merging 2 files from upstream Ruby:
https://github.com/flori/json/tree/master/lib/json/pure
And a small nit:
* The `BuildRequires: rubygem(rspec) > 3` restricting condition is probably not
needed as Fedora in general ships rubygem-rspec > 3.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081 Jarek Prokop changed: What|Removed |Added Assignee|nob...@fedoraproject.org|jpro...@redhat.com CC||jpro...@redhat.com Flags||fedora-review? --- Comment #1 from Jarek Prokop --- Taking this for a review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1979081] Review Request: rubygem-gist - Gist uploader command line utility for GitHub
https://bugzilla.redhat.com/show_bug.cgi?id=1979081 Georg Sauthoff changed: What|Removed |Added Summary|Review rubygem-gist - Gist |Review Request: |uploader command line |rubygem-gist - Gist |utility for GitHub |uploader command line ||utility for GitHub Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
