[Bug 2187670] Review Request: rust-cargo-options - Reusable common Cargo command line options
https://bugzilla.redhat.com/show_bug.cgi?id=2187670 Fabio Valentini changed: What|Removed |Added Resolution|--- |RAWHIDE Status|POST|CLOSED Fixed In Version||rust-cargo-options-0.6.0-1. ||fc39 Last Closed||2023-04-19 17:00:52 --- Comment #6 from Fabio Valentini --- Imported and built for rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2023-38a733702d -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2187670 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2187670] Review Request: rust-cargo-options - Reusable common Cargo command line options
https://bugzilla.redhat.com/show_bug.cgi?id=2187670 --- Comment #5 from Fedora Admin user for bugzilla script actions --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cargo-options -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2187670 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2187670] Review Request: rust-cargo-options - Reusable common Cargo command line options
https://bugzilla.redhat.com/show_bug.cgi?id=2187670 --- Comment #4 from Fabio Valentini --- Thanks for the review! > Hmm, should the tests be excluded from the package all together? Usually the test sources don't hurt, and we don't remove them unless they include problematic things like architecture-specific binaries or other large test fixtures like images. > but I'm not sure if Rust is different in this regard. Not really, but we don't have Guidelines for it, so it's more done on a case-by-case basis. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2187670 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2187670] Review Request: rust-cargo-options - Reusable common Cargo command line options
https://bugzilla.redhat.com/show_bug.cgi?id=2187670 --- Comment #3 from Maxwell G --- > (There are some warnings about zero length test files.) Hmm, should the tests be excluded from the package all together? In other packaging ecosystems I'm involved with (e.g. Python and Ansible collections), it's standard to remove the tests from the built package even if upstream installs them, but I'm not sure if Rust is different in this regard. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2187670 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2187670] Review Request: rust-cargo-options - Reusable common Cargo command line options
https://bugzilla.redhat.com/show_bug.cgi?id=2187670 Maxwell G changed: What|Removed |Added Assignee|nob...@fedoraproject.org|maxw...@gtmx.me CC||maxw...@gtmx.me Status|NEW |POST Flags||fedora-review+ Doc Type|--- |If docs needed, set a value --- Comment #2 from Maxwell G --- This package was generated using rust2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The specfile is sane. - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag uses the correct identifiers, and it reflects the package contents and Cargo metadata. - [x] The license text is included in the package and is marked with %license. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. (There are some warnings about zero length test files.) - [-] (Justified with a comment in the specfile) The package runs tests in %check. - [x] The package complies with the Rust and general Packaging Guidelines. Package approved. Thanks! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2187670 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 2187670] Review Request: rust-cargo-options - Reusable common Cargo command line options
https://bugzilla.redhat.com/show_bug.cgi?id=2187670 --- Comment #1 from Fabio Valentini --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=100098622 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2187670 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
