Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=494695
--- Comment #42 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info
2010-02-21 18:52:45 EST ---
(In reply to comment #41)
The spec could be more readable if it was formatted properly. Please use line
breaks at 80 charakters, especially in the descriptions. Otherwise they are
hard to read on a terminal or in the PackageKit UI.
Yes, I was nit enouth carefully and in qutim-plugman description some lines
exceedes 80 characters. Fixed. Thanks.
The name of the tag is URL, not Url.
Is it have any sence?
The group of the -devel package should be Development/Libraries instead of
Applications/Internet.
Thanks, fixed.
For the other subpackages you can omit the group tag
because it is the same than the one from the base package.
It was required before in each defined package. Some changed nowadays?
%descriptions should end with a dot. Exclamation marks are even worse than the
missing dots.
I'm do not see any worth in dot, especially in one line descriptions, but it is
not bad idea in any case. Ok.
There are a lot of linguistic and grammar errors in the English descriptions.
Ohh, yes, I known. I recheck it again. And if you can point to concrete
mistakes I'll fix it with pleasure.
The icon cache scriptlets are outdated, please use the latest version from
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
Updated.
Omit --add-category=Network from desktop-file-install because this is
already
in the file.
Ok.
Please preserve timestamps during %install,
install -p -m 644 icons/%{name}.png ...
...
make install DESTDIR=%{buildroot} INSTALL=install -p
see https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
Yes, this is my mistake. Thanks. Fixed.
Please use %global instead of %define, see
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
Just a hint, this is commented out currently.
Yes, it is not used now. BTW I replace it.
http://koji.fedoraproject.org/koji/taskinfo?taskID=2003770
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
