[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502358 --- Comment #26 from Kevin Fenzi ke...@tummy.com 2010-07-26 18:27:38 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502358 Iain Arnell iarn...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502358 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #22 from Ralf Corsepius rc040...@freenet.de 2010-07-24 02:01:27 EDT --- (In reply to comment #21) InitialCC: Why no perl-sig? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502358 --- Comment #23 from Iain Arnell iarn...@gmail.com 2010-07-24 02:13:13 EDT --- New Package CVS Request === Package Name: mojomojo Short Description: Catalyst DBIx::Class powered Wiki Owners: iarnell Branches: F-12 F-13 InitialCC: perl-sig (In reply to comment #22) Why no perl-sig? Because it looks like Chris' reviewtool only adds that automatically for perl- packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502358 --- Comment #24 from Ralf Corsepius rc040...@freenet.de 2010-07-24 02:48:43 EDT --- (In reply to comment #23) (In reply to comment #22) Why no perl-sig? Because it looks like Chris' reviewtool only adds that automatically for perl- packages. No idea what this reviewtool does, but I'd recommend to explicitly add it. This package clearly is a perl package (It's even CPAN hosted). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502358 --- Comment #25 from Iain Arnell iarn...@gmail.com 2010-07-24 03:00:00 EDT --- I added perl-sig to the request in comment #23. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502358 --- Comment #19 from Iain Arnell iarn...@gmail.com 2010-07-23 10:46:09 EDT --- Wow, Dan is fast! Today's rawhide already has selinux policy labels for mojomojo. And I've put together a better policy that has been sent upstream. So new build no longer contains selinux sub-package and has addressed the duplicate dependencies. I also tweaked the httpd config slightly to be more consistent using trailing slashes everywhere. Spec URL: http://fedorapeople.org/~iarnell/review/mojomojo.spec SRPM URL: http://fedorapeople.org/~iarnell/review/mojomojo-1.01-2.fc14.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2346709 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502358 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #20 from manuel wolfshant wo...@nobugconsulting.ro 2010-07-23 14:26:16 EDT --- APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502358 --- Comment #21 from Iain Arnell iarn...@gmail.com 2010-07-24 01:53:11 EDT --- New Package CVS Request === Package Name: mojomojo Short Description: Catalyst DBIx::Class powered Wiki Owners: iarnell Branches: F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502358 Iain Arnell iarn...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502358 --- Comment #16 from manuel wolfshant wo...@nobugconsulting.ro 2010-07-22 04:58:55 EDT --- I do not have a rawhide handy to test, but I've never seen before the construct that you have used in the config file for httpd, that is: Alias /mojomojo/ /usr/bin/mojomojo_fastcgi.pl/ Location /mojomojo Options ExecCGI Order allow,deny Allow from all AddHandler fcgid-script .pl /Location where /usr/bin/mojomojo_fastcgi.pl is a script, not a directory as the Alias directive might seem to indicate. http://httpd.apache.org/docs/2.2/mod/mod_alias.html#alias does not reference this type of use either. Is it really correct ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502358
manuel wolfshant wo...@nobugconsulting.ro changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|wo...@nobugconsulting.ro
Flag||fedora-review?
--- Comment #17 from manuel wolfshant wo...@nobugconsulting.ro 2010-07-22
05:37:24 EDT ---
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines.
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: devel/x86_64
[x] Rpmlint output:
source RPM:
mojomojo.src: W: spelling-error %description -l en_US fulltext - full text,
full-text, Fullerton
= ignorable
binary RPM:
mojomojo.noarch: W: spelling-error %description -l en_US fulltext - full text,
full-text, Fullerton
= ignorable
mojomojo.noarch: E: non-standard-dir-perm /var/lib/mojomojo/uploads 0750L
mojomojo.noarch: E: non-readable /etc/mojomojo.conf 0640L
mojomojo.noarch: E: non-standard-dir-perm /var/lib/mojomojo/index 0750L
mojomojo.noarch: E: non-readable /var/lib/mojomojo/mojomojo.db 0640L
= intended, security reasons
mojomojo-selinux.noarch: W: cross-directory-hard-link
/usr/share/selinux/strict/mojomojo.pp /usr/share/selinux/targeted/mojomojo.pp
= ignorable, chances for /targeted and strict to reside on different devices
are close to nil. Not to mention that the content of this package should be
transferred to selinux-policy.
[x] Package is not relocatable.
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPL+ or Artistic
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package match the upstream source, as provided
in the spec URL.
SHA1SUM of source file: eab857f0e22824dfbc16afba63dc70ec3612c87a
MojoMojo-1.01.tar.gz
[x] Package is not known to require ExcludeArch
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[!] Final provides and requires are sane.
I guess a bit of filtering is needed here, as we have, under requires:
perl(Catalyst)
perl(Catalyst) = 5.8000
perl(Data::Page)
perl(Data::Page) = 2.00
perl(DateTime)
perl(DateTime) = 0.28
perl(File::MMagic)
perl(File::MMagic) = 1.27
perl(HTML::Entities)
perl(HTML::Entities) = 3.60
perl(HTML::Strip)
perl(HTML::Strip) = 1.04
perl(MRO::Compat)
perl(MRO::Compat) = 0.10
perl(Text::Context)
perl(Text::Context) = 3.5
perl = 0:5.008004
/usr/bin/perl
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: devel, noarch
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on: devel, noarch
[?] Package functions as described.
[x] Scriptlets must be sane, if
[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502358 --- Comment #18 from Iain Arnell iarn...@gmail.com 2010-07-22 11:13:18 EDT --- (In reply to comment #16) Thanks for picking this one up. (And the rest you've done recently - I must owe you a whole bunch of shiny beads). I do not have a rawhide handy to test, but I've never seen before the construct that you have used in the config file for httpd, that is: Alias /mojomojo/ /usr/bin/mojomojo_fastcgi.pl/ Location /mojomojo Options ExecCGI Order allow,deny Allow from all AddHandler fcgid-script .pl /Location where /usr/bin/mojomojo_fastcgi.pl is a script, not a directory as the Alias directive might seem to indicate. http://httpd.apache.org/docs/2.2/mod/mod_alias.html#alias does not reference this type of use either. Is it really correct ? Yes, I didn't believe it when I first saw it either (I got the snippet from http://blog.hjksolutions.com/articles/2007/07/19/catalyst-deployment-with-apache-2-and-mod_fcgid). But it certainly works. The Catalyst::Engine::FastCGI docs claim that the trailing slashes are important for setting PATH_INFO properly. There should be no need to test under rawhide - this review has been around long enough that it works out of the box on F-13 (and probably F-12 too). I'll wait until I hear back from dwalsh on the selinux bits before posting an updated rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502358 manuel wolfshant wo...@nobugconsulting.ro changed: What|Removed |Added CC||wo...@nobugconsulting.ro --- Comment #15 from manuel wolfshant wo...@nobugconsulting.ro 2010-07-21 18:44:26 EDT --- minor nitpick, to be fixed before import: BuildRequires: perl(HTML::TagCloud) is included twice. bonus points for having the selinux part sorted, but I suggest to talk with dwalsh and have the policy included in fedora's selinux package. Time permitting. I'll try to look at this package this week. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502358 Iain Arnell iarn...@gmail.com changed: What|Removed |Added Status|ASSIGNED|NEW AssignedTo|cw...@alumni.drew.edu |nob...@fedoraproject.org --- Comment #14 from Iain Arnell iarn...@gmail.com 2010-07-08 23:37:29 EDT --- I'm throwing this back into the pool since Chris hasn't responded in a long while. New upstream release too. SRPM: http://iarnell.fedorapeople.org/review/mojomojo-1.01-1.fc14.src.rpm SPEC: http://iarnell.fedorapeople.org/review/mojomojo.spec KOJI: https://koji.fedoraproject.org/koji/taskinfo?taskID=2307741 The nasty looking error message generated by t/03podcoverage.t during %check can be safely ignored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 502358] Review Request: mojomojo - Catalyst DBIx::Class powered Wiki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502358 --- Comment #12 from Iain Arnell iarn...@gmail.com 2010-01-20 00:49:01 EST --- And now that I've got the latest new dependencies available, yet another upstream update. SRPM URL: http://iarnell.fedorapeople.org/review/mojomojo-0.999042-1.fc13.src.rpm SPEC URL: http://iarnell.fedorapeople.org/review/mojomojo.spec KOJI URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=1933200 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
