[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #47 from Orion Poplawski or...@cora.nwra.com 2011-06-24 10:38:36 EDT --- Package Change Request == Package Name: eclipse-ptp New Branches: el6 Owners: orion InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #48 from Jon Ciesla l...@jcomserv.net 2011-06-24 11:34:37 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2010-09-07 11:47:48 --- Comment #46 from Orion Poplawski or...@cora.nwra.com 2010-09-07 11:47:48 EDT --- rawhide build complete. F-14 building. Thanks everyone. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #41 from Andrew Overholt overh...@redhat.com 2010-09-03 11:03:05 EDT --- (In reply to comment #40) (In reply to comment #38) eclipse-photran.noarch: I: enchant-dictionary-not-found en_US No idea what's up here. You need to install hunspell-en and/or aspell-en I think. Correct you are :) eclipse-ptp.noarch: W: incoherent-version-in-changelog 4.0.3-0.2.v201009010938 ['4.0.3-0.2.RC2b.fc15', '4.0.3-0.2.RC2b'] Please fix this. Done. rpmlint can confirm that http://www.cora.nwra.com/~orion/fedora/eclipse-ptp.spec is fixed. As for the other rpmlint errors and warnings, I'm fine with the zero-length files if they're stubs but would like to see upstream queried as to why they're shipping them. The .c/.h files as you said are compiled on target machines so they're fine to ship as is. I wonder if upstream doesn't know about p2 touchpoints to do chmod operations ... either way, I don't see a big deal with the configure and various .sh scripts not having the execute bit set. I'll ping upstream about this. Great, thanks. eclipse-ptp.src: W: strange-permission finddeps.sh 0755L eclipse-ptp.src: W: strange-permission makesource.sh 0755L These are fine in my book since you use them to generate stuff for the build. eclipse-ptp.src: W: invalid-url Source0: org.eclipse.ptp-ptp_4_0.tar.gz I don't know what's wrong with this. It wants a url (e.g. http://). We don't have one, but we document how to generate the source tarball. Yeah, I just don't remember seeing that for other packages that have no full URLs like this. It's not a big deal. This package is approved. Thanks for the hard work, Orion! Please update https://fedoraproject.org/wiki/Features/F14EclipseHelios when it's built for F14 and rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #42 from Orion Poplawski or...@cora.nwra.com 2010-09-03 11:11:42 EDT --- New Package SCM Request === Package Name: eclipse-ptp Short Description: Eclipse Parallel Tools Platform Owners: orion Branches: f14 f13 f12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #43 from Andrew Overholt overh...@redhat.com 2010-09-03 11:17:41 EDT --- I'm sure you know this, Orion, but for F13 and F12 you'll need to build the Galileo version of PTP. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #44 from Orion Poplawski or...@cora.nwra.com 2010-09-03 11:22:29 EDT --- Yup. I'm hoping to whip my 3.0.X package into shape for those. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #35 from Orion Poplawski or...@cora.nwra.com 2010-09-02 12:38:47 EDT --- http://koji.fedoraproject.org/koji/taskinfo?taskID=2443163 http://www.cora.nwra.com/~orion/fedora/eclipse-ptp-4.0.2-1.fc13.src.rpm http://www.cora.nwra.com/~orion/fedora/eclipse-ptp.spec * Wed Sep 1 2010 Orion Poplawski or...@cora.nwra.com - 4.0.3-0.1.v201009010938 - Update snapshot - Re-work build I put all of the core ptp components into the main ptp package. There is a ptp-master package that will pull in all of the other packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #36 from Andrew Overholt overh...@redhat.com 2010-09-02 15:21:58 EDT --- It looks like there are a few inter-dependency errors: Error: Package: eclipse-ptp-etfw-tau-fortran-4.0.3-0.1.RC2b.fc15.noarch (/eclipse-ptp-etfw-tau-fortran-4.0.3-0.1.RC2b.fc15.noarch) Requires: eclipse-photran = 6.0.2-0.1.RC2b.fc15 Available: eclipse-photran-5.0.0-0.4.200910081739.fc13.noarch (fedora) Error: Package: eclipse-ptp-remote-rse-4.0.3-0.1.RC2b.fc15.noarch (/eclipse-ptp-remote-rse-4.0.3-0.1.RC2b.fc15.noarch) Requires: eclipse-ptp-remote = 4.0.3-0.1.RC2b.fc15 The former can be avoided with a bunch of disablerepo flags to yum localinstall but the latter looks to be a problem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #37 from Orion Poplawski or...@cora.nwra.com 2010-09-02 15:38:37 EDT --- http://www.cora.nwra.com/~orion/fedora/eclipse-ptp-4.0.3-0.2.RC2b.fc13.src.rpm http://www.cora.nwra.com/~orion/fedora/eclipse-ptp.spec * Thu Sep 2 2010 Orion Poplawski or...@cora.nwra.com - 4.0.3-0.2.v201009010938 - Fix remote-rse deps http://koji.fedoraproject.org/koji/taskinfo?taskID=2443893 This should fix the second one. As for the first, why aren't you getting eclipse-photran-6.0.2-0.1.RC2b.fc15 from the build as well? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #38 from Andrew Overholt overh...@redhat.com 2010-09-02 21:49:35 EDT --- (In reply to comment #37) http://koji.fedoraproject.org/koji/taskinfo?taskID=2443893 I got these RPMs and it installs fine. The upgrade from the existing eclipse-photran packages works, too. You've shown that it builds in koji which is great. I'm satisfied that build and install items in the review checklist are good to go. rpmlint still complains about a bunch of stuff (see attachment for full details): eclipse-photran.noarch: I: enchant-dictionary-not-found en_US No idea what's up here. eclipse-ptp.noarch: W: incoherent-version-in-changelog 4.0.3-0.2.v201009010938 ['4.0.3-0.2.RC2b.fc15', '4.0.3-0.2.RC2b'] Please fix this. As for the other rpmlint errors and warnings, I'm fine with the zero-length files if they're stubs but would like to see upstream queried as to why they're shipping them. The .c/.h files as you said are compiled on target machines so they're fine to ship as is. I wonder if upstream doesn't know about p2 touchpoints to do chmod operations ... either way, I don't see a big deal with the configure and various .sh scripts not having the execute bit set. eclipse-ptp.src: W: strange-permission finddeps.sh 0755L eclipse-ptp.src: W: strange-permission makesource.sh 0755L These are fine in my book since you use them to generate stuff for the build. eclipse-ptp.src: W: invalid-url Source0: org.eclipse.ptp-ptp_4_0.tar.gz I don't know what's wrong with this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #32 from Orion Poplawski or...@cora.nwra.com 2010-09-01 14:15:22 EDT --- Okay, so the magic needed seems to be -Dnoclean=true. This allows me to build features that are needed by other features earlier. So, the next question is how many binary packages should this really be broken up into? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #33 from Orion Poplawski or...@cora.nwra.com 2010-09-01 14:20:24 EDT --- FYI - the org.eclipse.ptp feature contains: eclipse/features/org.eclipse.ptp.core_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.debug.sdm_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.etfw_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.external_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.pldt_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.remote_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.remote.remotetools_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.remotetools_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.rm.ibm.ll_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.rm.ibm.pe_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.rm.mpich2_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.rm.openmpi_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.rm.pbs_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.rm.slurm_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.services_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.utils_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp.pldt.lapi_4.0.3.201009011159/feature.xml eclipse/features/org.eclipse.ptp_4.0.3.201009011159/feature.xml And org.eclipse.ptp.core consists other things as well. Lots of layers it seems. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #34 from Andrew Overholt overh...@redhat.com 2010-09-01 14:23:23 EDT --- I'm glad you got past the clean stuff. We generally recommend to break things up along feature lines. However, if you don't think Fedora users would ever install some of the smaller features, I think it's fine to break it up along larger feature lines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529278
--- Comment #26 from Andrew Overholt overh...@redhat.com 2010-08-31 09:18:58
EDT ---
They're building their master feature. See this line in build.xml:
ant antfile=build.xml dir=${pde.build.scripts}
property name=builder value=${basedir}/master /
/ant
If you can't get pdebuild.sh to work, you could always run this directly with
something like:
eclipse -nosplash -application org.eclipse.ant.core.antRunner \
-Dbuilder=$(pwd)/master \
-f
%{_libdir}/eclipse/dropins/sdk/plugins/org.eclipse.pde.build_*/scripts/build.xml
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #27 from Orion Poplawski or...@cora.nwra.com 2010-08-31 11:19:30 EDT --- + eclipse -nosplash -application org.eclipse.ant.core.antRunner -Dbuilder=/scratch/orion/redhat/eclipse-ptp-4.0.2/org.eclipse.ptp-ptp_4_0/releng/org.eclipse.ptp.releng/master -f /usr/lib64/eclipse/dropins/sdk/plugins/org.eclipse.pde.build_3.6.0.v20100603/scripts/build.xml CompilerOracle: exclude org/eclipse/core/internal/dtree/DataTreeNode.forwardDeltaWith CompilerOracle: exclude org/eclipse/jdt/internal/compiler/lookup/ParameterizedMethodBinding.init CompilerOracle: exclude org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPTemplates.instantiateTemplate CompilerOracle: exclude org/eclipse/cdt/internal/core/pdom/dom/cpp/PDOMCPPLinkage.addBinding CompilerOracle: exclude org/python/pydev/editor/codecompletion/revisited/PythonPathHelper.isValidSourceFile CompilerOracle: exclude org/python/pydev/ui/filetypes/FileTypesPreferencesPage.getDottedValidSourceFiles Buildfile: /usr/lib64/eclipse/dropins/sdk/plugins/org.eclipse.pde.build_3.6.0.v20100603/scripts/build.xml main: preBuild: BUILD FAILED /usr/lib64/eclipse/dropins/sdk/plugins/org.eclipse.pde.build_3.6.0.v20100603/scripts/build.xml:32: The following error occurred while executing this line: /usr/lib64/eclipse/dropins/sdk/plugins/org.eclipse.pde.build_3.6.0.v20100603/scripts/build.xml:47: Directory /usr/lib64/eclipse/dropins/sdk/plugins/org.eclipse.pde.build_3.6.0.v20100603/scripts/build creation was not successful for an unknown reason No idea how to get more info. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #28 from Andrew Overholt overh...@redhat.com 2010-08-31 11:23:27 EDT --- -debug -consolelog It looks like it's trying to create the build directory in the PDE Build scripts directory. Passing something like -data with a location in which to work would probably help. Note that what I said 2 comments ago wasn't intended to be a proper solution but rather a pointer to what _may_ work :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #29 from Orion Poplawski or...@cora.nwra.com 2010-08-31 14:07:08 EDT --- Yeah, but pdebuild has been failing due to dependency ordering. Gotten farther with the latest, but now it wants to checkout the project with cvs. Going to take a patched build script I think. Execute:Java13CommandLauncher: Executing 'cvs' with arguments: '-d:pserver:anonym...@dev.eclipse.org:/cvsroot/tools' '-q' 'export' '-r' 'ptp_4_0' 'org.eclipse.ptp/releng/org.eclipse.ptp.master/feature.xml' The ' characters around the executable and arguments are not part of the command. [null] Exiting /scratch/orion/redhat/eclipse-ptp-4.0.2/org.eclipse.ptp-ptp_4_0/results/retrieve.xml. [ant] Exiting /usr/lib64/eclipse/dropins/sdk/plugins/org.eclipse.pde.build_3.6.0.v20100603/scripts/genericTargets.xml. [ant] Exiting /scratch/orion/redhat/eclipse-ptp-4.0.2/org.eclipse.ptp-ptp_4_0/releng/org.eclipse.ptp.releng/master/customTargets.xml. [antcall] Exiting /usr/lib64/eclipse/dropins/sdk/plugins/org.eclipse.pde.build_3.6.0.v20100603/scripts/build.xml. Going back to pdebuild - I wonder if there is some issue with not being able to pick up features that have already been built. In the following build, I build ptp.utils, ptp.services, ptp.remote, then ptp. In the ptp build I get an error that it can't find ptp.utils: [javac] 1. ERROR in /var/tmp/orion/redhat/eclipse-ptp-4.0.2/org.eclipse.ptp-ptp_4_0/core/org.eclipse.ptp.proxy.protocol/src/org/eclipse/ptp/proxy/runtime/server/ElementIDGenerator.java (at line 16) [javac] import org.eclipse.ptp.utils.core.RangeSet; [javac]^ [javac] The import org.eclipse.ptp.utils cannot be resolved Or perhaps ptp.proxy.protocol isn't correctly specifying that it requires ptp.utils? http://koji.fedoraproject.org/koji/taskinfo?taskID=2438000 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #30 from Orion Poplawski or...@cora.nwra.com 2010-08-31 14:17:12 EDT --- Looking through the logs some more I see some clean statements that are cleaning up utils and other stuff: all.features: all.plugins: properties: init: clean: [delete] Deleting directory /builddir/build/BUILD/org.eclipse.ptp-ptp_4_0/core/org.eclipse.ptp.utils.core/@dot [delete] Deleting: /builddir/build/BUILD/org.eclipse.ptp-ptp_4_0/core/org.eclipse.ptp.utils.core/utils_core.jar [delete] Deleting directory /builddir/build/BUILD/org.eclipse.ptp-ptp_4_0/core/org.eclipse.ptp.utils.core/temp.folder Perhaps that is the issue? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #31 from Andrew Overholt overh...@redhat.com 2010-08-31 15:11:36 EDT --- Sorry, I don't know about the clean stuff. I think Mylyn (eclipse-mylyn) may do something similar to what you want to do with building multiple inter-dependent features. The CDT's .spec (eclipse-cdt) also builds multiple inter-dependent features by jamming the output of one into the other. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #23 from Orion Poplawski or...@cora.nwra.com 2010-08-30 17:36:24 EDT --- In releng/org.eclipse.ptp.releng/build.sh they build with: cd tools cvs -d:pserver:anonym...@dev.eclipse.org:/cvsroot/eclipse \ checkout -r v20100423 org.eclipse.releng.basebuilder cd .. # Let's go! java -jar tools/org.eclipse.releng.basebuilder/plugins/org.eclipse.equinox.launcher.jar \ -ws gtk -arch ppc -os linux -application org.eclipse.ant.core.antRunner $* Args are From http://wiki.eclipse.org/Platform-releng-faq it appears that it is able to determine build order. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #24 from Andrew Overholt overh...@redhat.com 2010-08-30 17:44:19 EDT --- What does their build.xml look like? PDE Build should indeed be able to determine build order without a problem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #25 from Orion Poplawski or...@cora.nwra.com 2010-08-30 18:30:54 EDT --- Created attachment 442053 -- https://bugzilla.redhat.com/attachment.cgi?id=442053 releng/org.eclipse.ptp.releng/build.xml We'll here is the main build.xml file (I think). It appears that I may be able to build the feature list from that with: features=$(grep 'tagmodule.*-feature' releng/org.eclipse.ptp.releng/build.xml | sed -e 's/^.* value=//' -e 's/-feature.*$//') But the build order still isn't correct. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #17 from Andrew Overholt overh...@redhat.com 2010-08-26 12:54:35 EDT --- I presume PTP is building from one master feature ... maybe you don't have the correct one? I'm downloading one of their builds now and I'll see if I can figure it out. I wrote the following before comment #16. I've gone through the packaging guidelines and things look pretty good to me. - licensing fine - Build/Requires okay - files section good - dependencies correct - %clean present - macros clean - versioning and sub-package dependencies looks okay - taking over providing of eclipse-photran looks correct - no locale files - no rpath - no .desktop file - no users/groups - not a web app. - all code built, none bundled - code, not content - no scriptlets - file locations correct - builds (except that one plugin) on x86_64 (for noarch) - can't test installation ATM - can't run rpmlint ATM -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #18 from Andrew Overholt overh...@redhat.com 2010-08-26 13:18:30 EDT --- I think this is the master feature you want: http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.ptp/releng/org.eclipse.ptp.master/feature.xml?view=markuprevision=1.47root=Tools_Projectsortby=rev This releng plugin is also of interest as it looks like it contains the maps they use and the shell scripts they use. I think Mat Booth created a shell script that reads .map files to do CVS exports. Look in eclipse-emf to see if I'm right. http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.ptp/releng/org.eclipse.ptp.releng/?root=Tools_Projectsortby=rev -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #19 from Orion Poplawski or...@cora.nwra.com 2010-08-26 13:38:29 EDT --- (In reply to comment #18) I think this is the master feature you want: http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.ptp/releng/org.eclipse.ptp.master/feature.xml?view=markuprevision=1.47root=Tools_Projectsortby=rev Yeah, that's what I used before, but now it doesn't contain all of the features and if I build in the order listed the org.eclipse.ptp.core feature fails because it is missing org.eclipse.ptp.utils stuff. Looks like at revision 1.45 they removed duplicate features. This releng plugin is also of interest as it looks like it contains the maps they use and the shell scripts they use. I think Mat Booth created a shell script that reads .map files to do CVS exports. Look in eclipse-emf to see if I'm right. http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.ptp/releng/org.eclipse.ptp.releng/?root=Tools_Projectsortby=rev I'll take a look. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #20 from Andrew Overholt overh...@redhat.com 2010-08-26 13:50:26 EDT --- (In reply to comment #19) (In reply to comment #18) I think this is the master feature you want: http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.ptp/releng/org.eclipse.ptp.master/feature.xml?view=markuprevision=1.47root=Tools_Projectsortby=rev Yeah, that's what I used before, but now it doesn't contain all of the features and if I build in the order listed the org.eclipse.ptp.core feature fails because it is missing org.eclipse.ptp.utils stuff. Looks like at revision 1.45 they removed duplicate features. Weird. I briefly looked at the list of features in their master zip and what's included in the cascaded list of that master feature and I thought they were all covered. Maybe something with flattendependencies in build.properties? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #21 from Orion Poplawski or...@cora.nwra.com 2010-08-26 15:02:11 EDT --- Yeah, I imagine the build system in use is able to handle it. I could build the master feature but then I end up with a single zip/package. Perhaps I could unpack it in the proper way? Build the master then find out what's in it and build those (which should be somewhat fast if the class/jars are still around)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #22 from Andrew Overholt overh...@redhat.com 2010-08-26 15:58:35 EDT --- I'm pretty sure PTP uses PDE Build like we do. You probably could do re-packaging like you're suggesting. Or you could manually move the files to the sub-package locations :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 Andrew Overholt overh...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|overh...@redhat.com Flag||fedora-review? --- Comment #15 from Andrew Overholt overh...@redhat.com 2010-08-25 20:04:32 EDT --- Sorry it's taken me so long to get back to this, Orion. Things actually look pretty good and I'm very impressed with the cleanliness of the .spec for this monster package! I'm building on top of the rawhide packages (Helios stuff) and get this build error in the org.eclipse.ptp.pldt.openmp.analysis plugin: 87. ERROR in /home/overholt/rpmbuild/BUILD/org.eclipse.ptp-v201004302110/tools/org.eclipse.ptp.pldt.openmp.analysis/src/org/eclipse/ptp/pldt/openmp/analysis/PAST/PASTPragma.java (at line 22) public class PASTPragma extends PASTNode implements IASTPreprocessorPragmaStatement ^^ The type PASTPragma must implement the inherited abstract method IASTPreprocessorPragmaStatement.isPragmaOperator() Have you seen this before? My only comment on the .spec is that the %descriptions are kind of long. I presume you just generated these from the feature files? I agree with the rpmlint reasons you give above (although I haven't re-examined its output since it doesn't build for me ATM). I'll go through the rest of the packaging guidelines but things seem alright. You can probably bump the release to 1 since this version of PTP was presumably released with Helios in June. Again, apologies for taking so long to get back to this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #16 from Orion Poplawski or...@cora.nwra.com 2010-08-26 00:33:20 EDT --- Okay, if we are working with Helios, we should bump to PTP 4.0.X. I've put a preliminary src.rpm and spec here: http://www.cora.nwra.com/~orion/fedora/eclipse-ptp-4.0.2-1.fc13.src.rpm http://www.cora.nwra.com/~orion/fedora/eclipse-ptp.spec The problem now is that my previous method for determining what features to build and in what order no longer works. The master feature.xml only lists a few items. Any ideas on how to pursue this? I suppose there must be some build tool that goes out and analyzes the dependencies to produce the proper build order. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 Andrew Overholt overh...@redhat.com changed: What|Removed |Added CC||overh...@redhat.com --- Comment #13 from Andrew Overholt overh...@redhat.com 2010-06-03 14:55:31 EDT --- I'm not going to be able to get to this until Eclipse Helios is released upstream. At first glance, though, things look good. rpmlint is quite unhappy with a lot of stuff, though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #14 from Orion Poplawski or...@cora.nwra.com 2010-06-03 15:54:40 EDT --- rpmlint by category: eclipse-ptp-debug-sdm.noarch: W: devel-file-in-non-devel-package /usr/share/eclipse/dropins/org.eclipse.ptp.debug.sdm/plugins/org.eclipse.ptp.debug.sdm_3.0.2.201006011254/include/dbg_event.h A couple of the component contain source code that is compiled on target machines (that my not be the machine where PTP is installed). eclipse-ptp-debug-sdm.noarch: E: non-executable-script /usr/share/eclipse/dropins/org.eclipse.ptp.debug.sdm/plugins/org.eclipse.ptp.debug.sdm_3.0.2.201006011254/libaif/missing 0644L /bin/sh Essentially same as above. I'm a bit puzzled as to why they don't have execute permissions, but that is how they are installed. eclipse-ptp-debug-sdm.noarch: E: zero-length /usr/share/eclipse/dropins/org.eclipse.ptp.debug.sdm/plugins/org.eclipse.ptp.debug.sdm_3.0.2.201006011254/libaif/ChangeLog Again related, upstream must have some boilerplate templates. Really don't cause a problem. eclipse-ptp-isp.noarch: W: spelling-error %description -l en_US interleavings - interleaving, inter leavings, inter-leavings with the possible exception of the above, these are all fine. And I really don't have a problem with this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|ASSIGNED|NEW AssignedTo|akurt...@redhat.com |nob...@fedoraproject.org Flag|fedora-review? | --- Comment #11 from Alexander Kurtakov akurt...@redhat.com 2010-06-01 14:44:21 EDT --- Sorry Orion, I wouldn't have time for it until maven is ready. I'm leaving the bug for someone with more time. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #12 from Orion Poplawski or...@cora.nwra.com 2010-06-01 15:25:14 EDT --- * Tue Jun 1 2010 Orion Poplawski or...@cora.nwra.com - 3.0.2-0.1.v201004302110 - Update snapshot - Add patch from cvs to fix exception in MPI project wizard http://www.cora.nwra.com/~orion/fedora/eclipse-ptp-3.0.2-0.1.v201004302110.fc13.src.rpm http://www.cora.nwra.com/~orion/fedora/eclipse-ptp.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #10 from Orion Poplawski or...@cora.nwra.com 2010-05-28 19:08:10 EDT --- http://www.cora.nwra.com/~orion/fedora/eclipse-ptp-3.0.1-1.fc13.src.rpm http://www.cora.nwra.com/~orion/fedora/eclipse-ptp.spec * Fri May 28 2010 Orion Poplawski or...@cora.nwra.com - 3.0.2-1 - Update to 3.0.1 final - Rework dependencies Alexander - do you still have time for this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #8 from Orion Poplawski or...@cora.nwra.com 2010-01-21 13:40:44 EST --- * Thu Jan 21 2010 Orion Poplawski or...@cora.nwra.com - 3.0.1-0.1.v201001152110 - Update to 3.0.1 snapshot - Split package - Make noarch http://www.cora.nwra.com/~orion/fedora/eclipse-ptp-3.0.1-0.1.v201001152110.fc12.src.rpm - The primary development location for libaif is here in ptp. - The devel-file/non-exec I would ignore. Some PTP packages ship the sources for code that is then compiled on the end user's machine. - The other OS/archs stuff consists of a small shell script used to build the shipped sources on the installed machine. I could patch them out but it doesn't seem worth it. Still need to handle replacing the existing photran packages (they now have a lower version number). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 --- Comment #9 from Orion Poplawski or...@cora.nwra.com 2010-01-21 18:20:00 EST --- http://www.cora.nwra.com/~orion/fedora/eclipse-ptp-3.0.1-0.2.v201001152110.fc12.src.rpm http://www.cora.nwra.com/~orion/fedora/eclipse-ptp.spec * Thu Jan 21 2010 Orion Poplawski or...@cora.nwra.com - 3.0.1-0.2.v201001152110 - Make photran versions 5.0.1, rephraserengine 1.0.1 So that should take care of the version issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
