[Bug 543151] Review Request: erlang-exmpp - A library for the eXtensible Messaging and Presence Protocol
https://bugzilla.redhat.com/show_bug.cgi?id=543151 Peter Lemenkov changed: What|Removed |Added Flags|needinfo?(lemen...@gmail.co | |m) | -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 543151] Review Request: erlang-exmpp - A library for the eXtensible Messaging and Presence Protocol
https://bugzilla.redhat.com/show_bug.cgi?id=543151 Peter Lemenkov changed: What|Removed |Added Status|NEW |CLOSED CC||pleme...@redhat.com Resolution|--- |NOTABUG Last Closed||2015-12-04 07:05:43 --- Comment #11 from Peter Lemenkov --- (In reply to James Hogarth from comment #10) > There has not been any comments on this bug in years. > > Peter are you still intending to do something with this? I've lost interest in this package. So I'm afraid it's better to close this for now. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 543151] Review Request: erlang-exmpp - A library for the eXtensible Messaging and Presence Protocol
https://bugzilla.redhat.com/show_bug.cgi?id=543151 James Hogarth changed: What|Removed |Added CC||james.hoga...@gmail.com, ||lemen...@gmail.com Flags||needinfo?(lemen...@gmail.co ||m) --- Comment #10 from James Hogarth --- There has not been any comments on this bug in years. Peter are you still intending to do something with this? As per policy if there is no response within a week this bug will be closed so that others may file a fresh review if interested. https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 543151] Review Request: erlang-exmpp - A library for the eXtensible Messaging and Presence Protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543151 --- Comment #9 from Jason Tibbitts 2010-11-29 12:50:12 EST --- Just for the record, because the ERPL and OpenSSL licenses are both a bit odd, I asked Fedora legal if there were any compatibility issues between them. They said that they didn't see anything, so at least that's not a problem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 543151] Review Request: erlang-exmpp - A library for the eXtensible Messaging and Presence Protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543151 Peter Lemenkov changed: What|Removed |Added Status Whiteboard||NotReady --- Comment #8 from Peter Lemenkov 2010-11-29 07:53:34 EST --- (In reply to comment #7) > I see you commented on the invalid-soname rpmlint complaints, and I agree that > they seem to be expected for erlang packages. But what about these: > > erlang-exmpp.x86_64: E: zero-length >/usr/share/doc/erlang-exmpp-0.9.5/exmpp_xml.html > > And the 68 undefined-non-weak-symbol complaints like: > > erlang-exmpp.x86_64: W: undefined-non-weak-symbol >/usr/lib64/erlang/lib/exmpp-0.9.5/priv/lib/exmpp_stringprep.so driver_alloc > > (install the package and run "rpmlint erlang-exmpp" to see those) > > Knowing very little about erlang and nothing of how it usually does linkage, I > don't know if those are expected or problematic. Thanks for the report - I'll take a look. Unfortunately the API of this package is still the subject to change (the project is still in somewhat immature state) so I would like to postpone it for a few months more. The next major ejabberd release (3.x.x) will be based on this library, so we definitely need this library in Fedora - that's why I prefer this ticket to remain open. So I'm raising NotReady flag here, and I'll clean it when it will be ready for release. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 543151] Review Request: erlang-exmpp - A library for the eXtensible Messaging and Presence Protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543151 --- Comment #7 from Jason Tibbitts 2010-11-24 21:38:21 EST --- I see you commented on the invalid-soname rpmlint complaints, and I agree that they seem to be expected for erlang packages. But what about these: erlang-exmpp.x86_64: E: zero-length /usr/share/doc/erlang-exmpp-0.9.5/exmpp_xml.html And the 68 undefined-non-weak-symbol complaints like: erlang-exmpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/erlang/lib/exmpp-0.9.5/priv/lib/exmpp_stringprep.so driver_alloc (install the package and run "rpmlint erlang-exmpp" to see those) Knowing very little about erlang and nothing of how it usually does linkage, I don't know if those are expected or problematic. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 543151] Review Request: erlang-exmpp - A library for the eXtensible Messaging and Presence Protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543151 --- Comment #6 from Peter Lemenkov 2010-09-09 07:38:10 EDT --- Ver. 0.9.5 http://peter.fedorapeople.org/erlang-exmpp.spec http://peter.fedorapeople.org/erlang-exmpp-0.9.5-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 543151] Review Request: erlang-exmpp - A library for the eXtensible Messaging and Presence Protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543151 --- Comment #5 from Peter Lemenkov 2010-04-11 09:59:42 EDT --- Ver. 0.9.3 http://peter.fedorapeople.org/erlang-exmpp.spec http://peter.fedorapeople.org/erlang-exmpp-0.9.3-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 543151] Review Request: erlang-exmpp - A library for the eXtensible Messaging and Presence Protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543151 --- Comment #4 from Peter Lemenkov 2010-01-17 05:36:18 EST --- (In reply to comment #3) > Some quick notes about your spec file : > > your %files section contains many many lines, this is bad for maintenance (if > the new version has changes in its documentation for example, you'd have to > check each file one by one…) I obviously didn't generate this list by hand - that would be quite silly :). In fact, I believe, that such large %files sections does help maintainership, because you know exactly which modules were added or removed at every upgrade (which, in turn, helps quickly resolving issues with potential ABI incompatibilities with other applications). Although, if you're insisting in simplifying this section, then I'll do this. > Also, you should use %global instead of %define (line 1) Good catch, thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 543151] Review Request: erlang-exmpp - A library for the eXtensible Messaging and Presence Protocol
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=543151
Florent Le Coz changed:
What|Removed |Added
CC||louizat...@fedoraproject.or
||g
--- Comment #3 from Florent Le Coz 2010-01-13
14:25:35 EST ---
Some quick notes about your spec file :
your %files section contains many many lines, this is bad for maintenance (if
the new version has changes in its documentation for example, you'd have to
check each file one by one…)
you could do, for example :
%doc doc/stylesheet.css
%doc doc/erlang.png
%doc doc/*.html
%{_libdir}/erlang/lib/%{realname}-%{version}
The last line says that your package owns the directory and all its content
(and sub-content), no need to specify each file
Also, you should use %global instead of %define (line 1)
Except from that, it's OK for me.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
