[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545720
--- Comment #31 from Leon Keijser 2010-04-13 02:02:58
EDT ---
(In reply to comment #30)
> You are still using the prebuilt locales. I think they will be built when if
> you remove them. There also seems to be an option to overwrite them, take a
> look at setup.py.
Okay, i have included an extra line in the %build section:
python setup.py i18n --force
right before the 'build' command. Comparing the resulting locale files'
timestamp, they now seem to be built correctly.
> > Note: since the python setup.py installs the icon file in
> > %{_datadir}/icons/googsystray.png , i chose to rm it in the %install section
>
> I would prefer a patch here because this is something that you can also send
> to
> upstream. In Fedora we try to take care of upstreaming our changes.
Could you help me with the reason for this? I'm willing to contact upstream and
ask him for the changes, but i'm not sure why :) From
http://fedoraproject.org/wiki/Packaging:Guidelines#Filesystem_Layout i looked
at
http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREARCHITECTUREINDEPENDENTDATA
but can't find the pixmaps dir (or icon dir, for that matter) specified.
> > No idea why the build line was there twice.
>
> It's not there twice, but --skip-build was missing in the setup.py call in
> %install.
Now i see what you meant. I've modified the line in the %install section to
match your suggestion.
http://leon.fedorapeople.org/files/googsystray/googsystray.spec
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545720
--- Comment #30 from Christoph Wickert 2010-04-12
05:25:30 EDT ---
(In reply to comment #27)
> All suggestions applied:
You are still using the prebuilt locales. I think they will be built when if
you remove them. There also seems to be an option to overwrite them, take a
look at setup.py.
> Note: since the python setup.py installs the icon file in
> %{_datadir}/icons/googsystray.png , i chose to rm it in the %install section
I would prefer a patch here because this is something that you can also send to
upstream. In Fedora we try to take care of upstreaming our changes.
> No idea why the build line was there twice.
It's not there twice, but --skip-build was missing in the setup.py call in
%install.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 --- Comment #29 from Leon Keijser 2010-04-12 04:50:17 EDT --- Yeah, i know ;) but i wanted to make sure the package is conform Christoph's suggestions before pushing update after update. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 --- Comment #28 from Peter Lemenkov 2010-04-12 04:44:28 EDT --- (In reply to comment #27) > All suggestions applied: Leon, just push new packages into repository - no need to upload them at fedorapeople :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545720
--- Comment #27 from Leon Keijser 2010-04-12 04:30:50
EDT ---
All suggestions applied:
SPEC: http://leon.fedorapeople.org/files/googsystray/googsystray.spec
SRPM:
http://leon.fedorapeople.org/files/googsystray/googsystray-1.1.4-3.fc12.src.rpm
Note: since the python setup.py installs the icon file in
%{_datadir}/icons/googsystray.png , i chose to rm it in the %install section
No idea why the build line was there twice. I don't have it in my own tree.
Must have slipped in at some point.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 --- Comment #26 from Leon Keijser 2010-04-12 02:21:59 EDT --- Hi Christoph, Thanks for the comments. I will modify the SPEC file accordingly and upload it as soon as i can. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545720
Christoph Wickert changed:
What|Removed |Added
CC||cwick...@fedoraproject.org
--- Comment #25 from Christoph Wickert 2010-04-11
20:01:10 EDT ---
@Mario: Some things got overlooked during this review, please read my comments
below. No need to worry, this is why we have sponsors and public mailing lists
for the commits.
@Leon:
Please don't use macros for trivial things like %{__rm} or %{__python}. This
was discussed on devel list recently, please read the thread that evolted after
this mail:
http://lists.fedoraproject.org/pipermail/devel/2010-March/133466.html
%{__python} setup.py install --root %{buildroot}
should normally be
%{__python} setup.py install -O1 --skip-build --root %{buildroot}
if you take a look at the buildlog, you will see that the build step is run
twice
The locales are not built built but the precompiled mo files are taken. You
will need to build them which required gettext and intltool.
%{_datadir}/applications/googsystray-settings.desktop
%{_datadir}/applications/googsystray.desktop
These files should have been installed desktop-file-install or at least be
validated with desktop-file-validate.
see https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
%{_datadir}/icons/googsystray.png
This file should go into %{_datadir}/pixmaps/
%{_datadir}/icons/hicolor/16x16/apps/googsystray.png
%{_datadir}/icons/hicolor/32x32/apps/googsystray.png
%{_datadir}/icons/hicolor/48x48/apps/googsystray.png
%{_datadir}/icons/hicolor/64x64/apps/googsystray.png
You should use wildcards here:
%{_datadir}/icons/hicolor/*/apps/googsystray.png
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 Fedora Update System changed: What|Removed |Added Fixed In Version||googsystray-1.1.4-2.fc13 Resolution|NEXTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 --- Comment #24 from Fedora Update System 2010-04-09 00:20:27 EDT --- googsystray-1.1.4-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 Leon Keijser changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 --- Comment #23 from Fedora Update System 2010-03-25 02:51:26 EDT --- googsystray-1.1.4-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/googsystray-1.1.4-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 --- Comment #22 from Kevin Fenzi 2010-03-23 23:19:37 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 Leon Keijser changed: What|Removed |Added Flag||fedora-cvs? --- Comment #21 from Leon Keijser 2010-03-23 08:07:51 EDT --- New Package CVS Request === Package Name: googsystray Short Description: A system tray application for various Google apps Owners: leon Branches: F-12 F-13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 Mario Ceresa changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #20 from Mario Ceresa 2010-03-23 07:18:05 EDT --- Hello Leon! You are right: removing the entire dir is not necessary, but it sometimes helped me to pick up include/linking issue, and was for this reason that I suggested it. Maybe for a python package was not really necessary. Everithing else seems good so the package is: APPROVED congratulations and thanks for your work, Mario -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 --- Comment #19 from Leon Keijser 2010-03-22 16:57:32 EDT --- Okay, got a reply [1] from Tom Callaway: """ Safe to ignore. rpmlint assumes all dependencies which contain the explicit string "lib" are traditional library (with .so files inside) packages and can be autodetected, as opposed to explicitly stated. In your case, the explicit Requires is correct. """ I have updated the SRPM and SPEC files: http://leon.fedorapeople.org/files/googsystray/googsystray.spec http://leon.fedorapeople.org/files/googsystray/googsystray-1.1.4-2.fc12.src.rpm [1] http://lists.fedoraproject.org/pipermail/devel/2010-March/133955.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 --- Comment #18 from Leon Keijser 2010-03-22 15:50:03 EDT --- (In reply to comment #17) > - python-sitelib, python_sitearch macro are now automatically defined in F13, > so the first line of the spec should be: -snip- Gotcha. I'll modify the spec accordingly. > - You should remove manually the gXlib dir in %prep section, after patching, > as > an additional security measure to be sure that it's gone at build/exec time Hm. I don't see the extra benefit of removing the directory, since setup.py won't include it in the build anyway. And it's not in the %files section, so if setup.py will change at some point in the future, the files don't get included anyway. But i guess that apart from the warning from rpmlint (dangerous cmd), it won't do any harm in removing the gXlib dir in %prep. > I don't know why rpm does not pick up automatically python-xlib. Maybe Peter > knows if we are missing something here. I'll post a msg to the list, to see if someone else has some insight. It's been 3 months since i first posted this review request, and Peter could be busy with other things. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545720
--- Comment #17 from Mario Ceresa 2010-03-21 09:29:46 EDT
---
Hello Leon,
I'm glad to hearing from you and I hope that nothing serious passed to your
family.
As for the review, I think we are very close to the approval: please note that
the python packaging guidelines at:
https://fedoraproject.org/wiki/Packaging:Python
have been recently updated.
In summary:
- python-sitelib, python_sitearch macro are now automatically defined in F13,
so the first line of the spec should be:
%if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif
- You should remove manually the gXlib dir in %prep section, after patching, as
an additional security measure to be sure that it's gone at build/exec time
%{__rm} -rf googsystray/gXlib/
+ Source code is the same as upstream
$ md5sum googsystray-1.1.4.tar.gz
2c079c139cdd2e5cbe733816bf27e8ae googsystray-1.1.4.tar.gz
$ md5sum rpmbuild/SOURCES/googsystray-1.1.4.tar.gz
2c079c139cdd2e5cbe733816bf27e8ae rpmbuild/SOURCES/googsystray-1.1.4.tar.gz
+ Builds ok on koji (F12, F13)
http://koji.fedoraproject.org/koji/taskinfo?taskID=2066494
http://koji.fedoraproject.org/koji/taskinfo?taskID=2066503
I don't know why rpm does not pick up automatically python-xlib. Maybe Peter
knows if we are missing something here.
Mario
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545720 --- Comment #16 from Leon Keijser 2010-03-19 06:19:07 EDT --- Hi Mario, Peter, Family issues and work prevented me from picking up where i left off. Should be all back to (relatively) normal again. I have updated everything to the latest version by upstream and (after some small modifications) applied Mario's patch. New files uploaded: SPEC: http://leon.fedorapeople.org/files/googsystray/googsystray.spec SRPM: http://leon.fedorapeople.org/files/googsystray/googsystray-1.1.4-1.fc12.src.rpm PATCH: http://leon.fedorapeople.org/files/googsystray/googsystray-nogxlib.patch RPM: http://leon.fedorapeople.org/files/googsystray/googsystray-1.1.4-1.fc12.noarch.rpm rpmlint shows this error though: $ rpmlint -i /tmp/fedora-pkg/googsystray-1.1.4-1.fc12.noarch.rpm googsystray.noarch: E: explicit-lib-dependency python-xlib You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. 1 packages and 0 specfiles checked; 1 errors, 0 warnings. If i don't specify the 'python-xlib' requirement, the package builds fine but then the application doesn't work. I'm not sure what's going wrong here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
