[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #35 from Fedora Update System upda...@fedoraproject.org 2010-11-08 17:32:07 EST --- ccd2iso-0.3-6.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ccd2iso-0.3-6.fc14 Resolution||ERRATA Last Closed||2010-11-08 17:32:15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #36 from Fedora Update System upda...@fedoraproject.org 2010-11-08 17:37:55 EST --- ccd2iso-0.3-6.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|ccd2iso-0.3-6.fc14 |ccd2iso-0.3-6.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #37 from Fedora Update System upda...@fedoraproject.org 2010-11-08 17:45:38 EST --- ccd2iso-0.3-6.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|ccd2iso-0.3-6.fc12 |ccd2iso-0.3-6.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #32 from Mohammed Safwat mohammed_elaf...@yahoo.com 2010-10-31 16:50:35 EDT --- I've received a mail today stating that the package couldn't be successfully untagged from dist-f14-updates-testing-pending; the mail looked like this Package: ccd2iso NVR: ccd2iso-0.3-6.fc14 User: bodhi Status: failed Tag Operation: untagged From Tag: dist-f14-updates-testing-pending ccd2iso-0.3-6.fc14 unsuccessfully untagged from dist-f14-updates-testing-pending by bodhi Operation failed with the error: koji.TagError: build ccd2iso-0.3-6.fc14 not in tag dist-f14-updates-testing-pending I've received similar mails for the f13 and f12 builds. However earlier today I received three other mails confirming that the package on the three targets were successfully untagged. Is there anything wrong that I can fix? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #33 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2010-10-31 16:56:32 EDT --- Don't worry about those emails. That is RelEng business. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #34 from Fedora Update System upda...@fedoraproject.org 2010-10-31 17:30:32 EDT --- ccd2iso-0.3-6.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ccd2iso'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/ccd2iso-0.3-6.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562585
--- Comment #27 from Mohammed Safwat mohammed_elaf...@yahoo.com 2010-10-30
15:22:10 EDT ---
Today I've imported the package into the rawhide and f14 branch. I've however
run into some annoyance with the f14 branch. I got confused as I was reading
two different approaches to import the package into different branches, one at
http://fedoraproject.org/wiki/PackageMaintainers/Join#Check_out_the_module by
checking out a different directory for each branch, and the other at
http://fedoraproject.org/wiki/Using_Fedora_GIT#Merging by checking out a single
combined tree for all the branches. This led me to request a build for the
package on the f14 branch at an early commit
66ab586444c33ac05f3d5863957aeaa88a53cfb0 and it passed successfully as seen at
https://koji.fedoraproject.org/koji/taskinfo?taskID=2564860. However later I
had a more recent commit 06534148c82c4015f2dc13362770b74bb4bd1a67 as seen at
http://pkgs.fedoraproject.org/gitweb/?p=ccd2iso.git;a=commit;h=06534148c82c4015f2dc13362770b74bb4bd1a67
and
http://pkgs.fedoraproject.org/gitweb/?p=ccd2iso.git;a=shortlog;h=f14/master.
However since the build task invoked earlier for the older commit succeeded, it
seems I can't request another build for that newer commit. When I invoke
`fedpkg build', I get the error
Could not initiate build: ccd2iso-0.3-6.fc14 has already been built
I even tried to request a koji build explicitly for this command by running
`koji build dist-f14-updates-candidate
git://pkgs.fedoraproject.org/ccd2iso?#06534148c82c4015f2dc13362770b74bb4bd1a67',
the created task fails with
GenericError: Build already exists (id=202527, state=COMPLETE): {'name':
'ccd2iso', 'task_id': 2564885, 'pkg_id': 10805, 'epoch': None,
'completion_time': None, 'state': 0, 'version': '0.3', 'owner': 1325,
'release': '6.fc14', 'id': 202527}
as it can be seen at
https://koji.fedoraproject.org/koji/taskinfo?taskID=2564885 for example. Now is
there any way to request a build against a specific commit for a branch that
has already passed a successful build? Appreciating any suggestions.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #28 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2010-10-30 16:03:21 EDT --- It looks like the F-15 and F-14 packages are built fine. If the packages are usable (e.g. generated from the same SPEC file) then you don't need to do anything in koji for F-14 and F-15. Next I see that you messed things up a little with merging, and f14/master is ahead of master. You can leave this as is now, or merge master with f14/master. Later on, when you update to a newer version, or when you fix a bug, I recommend merging everything to master. For now, if you want to build F-12 and F-13 packages, just switch to their branch and merge with master. Then proceed as usual. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #29 from Fedora Update System upda...@fedoraproject.org 2010-10-30 21:31:37 EDT --- ccd2iso-0.3-6.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ccd2iso-0.3-6.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #30 from Fedora Update System upda...@fedoraproject.org 2010-10-30 21:34:13 EDT --- ccd2iso-0.3-6.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/ccd2iso-0.3-6.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #31 from Fedora Update System upda...@fedoraproject.org 2010-10-30 21:35:59 EDT --- ccd2iso-0.3-6.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/ccd2iso-0.3-6.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #26 from Mohammed Safwat mohammed_elaf...@yahoo.com 2010-09-24 08:43:00 EDT --- Yes sorry, I know I'm quite late for this. It's just that I don't have a permanent internet connection(; most of the time I'm offline). When I get connected, most probably I don't have my fedora machine with me. Anyway, I'll try hard to get this package imported within a couple of weeks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #25 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2010-09-24 00:30:02 EDT --- I see that the package is still not imported. Mohammed, is there anything I can help you with? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #23 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2010-08-22 17:00:23 EDT --- Hello Mohammed, I see that you didn't import this on git yet. Is there a problem? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #24 from Mohammed Safwat mohammed_elaf...@yahoo.com 2010-08-22 21:55:52 EDT --- Ah, not actually. I just got busy for a while. I was also reading the instructions for using koji and the commands for using git(through fedpkg) as a replacement for CVS and getting myself familiar with the process. I'll make sure to proceed with importing the package into the appropriate repositories ASAP. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #22 from Kevin Fenzi ke...@tummy.com 2010-08-15 20:10:15 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 Mohammed Safwat mohammed_elaf...@yahoo.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #21 from Mohammed Safwat mohammed_elaf...@yahoo.com 2010-08-14 21:43:19 EDT --- New Package SCM Request === Package Name: ccd2iso Short Description: CloneCD image to ISO image file converter Owners: msk61 Branches: f12 f13 f14 InitialCC: msk61 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 Orcan 'oget' Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | Flag|fedora-review? |fedora-review+ --- Comment #20 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2010-08-11 20:19:51 EDT --- I see that you have made extensive unofficial reviews on bug 610073, bug 611328, and bug 611454. You did a good job, and you showed us that you are comfortable with following the guidelines. Now I am sponsoring you. Now that the hard part is over, you can now continue with submitting your package by following [1]. Afterwards please follow the guidelines to install koji tools and learn about their usage as described in [2] if you have not done so already. If you want to import this package to other branches of Fedora (12, 13, 14 for the time being) you might want to look at the Bodhi usage page in the wiki [3], which can be used both from the command line or through the web interface. Note that this is to be done after officially building the packages in koji in the respective branch(es). Also note that the master branch (which used to be called devel) corresponds to rawhide (F-15). Moreover, you can now do official reviews. You can also finish the reviews that you started, provided that the review request was filed by a sponsored contributor. Non-sponsored packagers need to wait for a sponsor for a review. From now on please use your fedorapeople.org account to post SPEC and SRPM files for review requests. At any point, if you have questions, feel free to contact me through email or IRC, or other contributors through IRC, or fedora-devel mailing list. Lifting FE-NEEDSPONSOR --- This package (ccd2iso) was APPROVED by oget --- Welcome to Fedora. [1] http://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner [2] http://fedoraproject.org/wiki/PackageMaintainers/Join#Install_the_Client_Tools_.28Koji.29 [3] http://fedoraproject.org/wiki/Bodhi_Guide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562585
Mohammed Safwat mohammed_elaf...@yahoo.com changed:
What|Removed |Added
Attachment #433155|0 |1
is obsolete||
--- Comment #18 from Mohammed Safwat mohammed_elaf...@yahoo.com 2010-07-28
07:04:12 EDT ---
Created an attachment (id=434980)
-- (https://bugzilla.redhat.com/attachment.cgi?id=434980)
SPEC file after removing %{name} macro from URL links
Some URL's are still difficult to simply copy/paste to a browser because they
contain the %{version} macro; I was asked to add it on comment 4
https://bugzilla.redhat.com/show_bug.cgi?id=562585#c4 earlier.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 Mohammed Safwat mohammed_elaf...@yahoo.com changed: What|Removed |Added Attachment #433156|0 |1 is obsolete|| --- Comment #19 from Mohammed Safwat mohammed_elaf...@yahoo.com 2010-07-28 07:05:41 EDT --- Created an attachment (id=434981) -- (https://bugzilla.redhat.com/attachment.cgi?id=434981) source RPM I'll try to accomplish the steps for getting sponsored by reviewing some other packages by the end of this week. Sorry for being late to do. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562585
--- Comment #17 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2010-07-23
23:53:54 EDT ---
Thanks Mohammed. The package is good. Just a little comment: avoiding the
%{name} macro in URL is okay, since it gives us the convenience to copy and
paste etc. But it is up to you.
Normally I would approve the package now, but since you are not sponsored yet,
we need to ask you for a little more work. I briefly explained this at the
beginning of comment #10. Feel free to ask questions if there is anything not
clear. Thanks.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 Mohammed Safwat mohammed_elaf...@yahoo.com changed: What|Removed |Added Attachment #407407|0 |1 is obsolete|| --- Comment #13 from Mohammed Safwat mohammed_elaf...@yahoo.com 2010-07-20 09:17:38 EDT --- Created an attachment (id=433155) -- (https://bugzilla.redhat.com/attachment.cgi?id=433155) SPEC file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 Mohammed Safwat mohammed_elaf...@yahoo.com changed: What|Removed |Added Attachment #408341|0 |1 is obsolete|| --- Comment #14 from Mohammed Safwat mohammed_elaf...@yahoo.com 2010-07-20 09:18:14 EDT --- Created an attachment (id=433156) -- (https://bugzilla.redhat.com/attachment.cgi?id=433156) source RPM -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #15 from Mohammed Safwat mohammed_elaf...@yahoo.com 2010-07-20 10:14:25 EDT --- I've addressed all the review remarks on the SPEC and source RPM files uploaded in comments 13 and 14 respectively. The only remaining thing is the manual page. The original software package didn't contain a manual page, besides the program is really very easy and doesn't have any options. The only usage scenario can be obtained by typing the program name without any parameters. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #16 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2010-07-20 10:26:20 EDT --- No problem. Missing manual page is not a blocker. I will evaluate your update as soon as possible. Meanwhile, let's get you sponsored. Please follow the second paragraph on comment #10 for us to make sure that you are comfortable with the guidelines. Let me know if you have any questions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 Mohammed Safwat mohammed_elaf...@yahoo.com changed: What|Removed |Added Flag|needinfo?(Mohammed_ElAfifi@ | |yahoo.com) | --- Comment #12 from Mohammed Safwat mohammed_elaf...@yahoo.com 2010-07-19 08:42:51 EDT --- (In reply to comment #11) Mohammed, any progress? Are you still interested in this package? Yes, I finished addressing the points you highlighted in your review. I'll upload the the new SPEC and SRPM files tomorrow. Sorry for the delay. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 Orcan 'oget' Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Flag||needinfo?(Mohammed_ElAfifi@ ||yahoo.com) --- Comment #11 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2010-07-19 00:15:59 EDT --- Mohammed, any progress? Are you still interested in this package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562585
Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||oget.fed...@gmail.com
AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com
Flag||fedora-review?
--- Comment #10 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2010-07-08
22:02:31 EDT ---
I am taking the review. The package is mostly in good shape. There are minor
things to fix. I made the review a little verbose since this is your first
package.
Since you need to be sponsored, we expect a little more from you. To show that
you understand and work comfortably with the Fedora guidelines, you will need
to do either some informal reviews on packages that are awaiting a review (this
is the preferred method)
http://fedoraproject.org/PackageReviewStatus/
or submit some other packages for review, that are preferably different type of
packages. For more detail, see
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
Here is the review:
- rpmlint says:
ccd2iso.x86_64: W: no-manual-page-for-binary ccd2iso
It would be nice to have a man page. But this is not a blocker.
! Usually the EOL encoding erros are fixed via sed or dos2unix. See
http://fedoraproject.org/wiki/Packaging/Guidelines#Rpmlint_Errors
A typical way of doing it is:
sed 's/\r//' TODO TODO.tmp
touch -r TODO TODO.tmp
mv -f TODO.tmp TODO
or
dos2unix -k TODO
So that you preserve the timestamp of the file. Note that for dos2unix, you
need to add a BuildRequires.
I would say the patch is okay since the file is really small, but I would have
preferred one of the above two.
! We don't package the INSTALL files, since they usually tell us how to compile
the source. This is not relevant for an RPM user.
* The license of the package is determined as follows:
- You look at the license file (if it is missing you notify upstream). This one
says GPLv2.
- We look at the source code. The source code is in directory src/ in this
case.
- The header of the source code files carry the phrase:
* This program is free software; you can redistribute it and/or modify *
* it under the terms of the GNU General Public License as published by *
* the Free Software Foundation; either version 2 of the License, or *
* (at your option) any later version. *
Since it says or any later version, the license of the package must be
GPLv2+.
(Sometimes the source code does not carry the or any later version phrase. In
that case we set the license tag to GPLv2. Sometimes the source code does not
even specify the GPL version. In this case, even if the COPYING file says GPLv2
or GPLv3, we set the license tag to GPL+, and we notify upstream to add the GPL
versions to the source file headers)
For more information, see
http://fedoraproject.org/wiki/Licensing#Good_Licenses
scroll down to GNU General Public License (no version)
! You can use the %{name} macro in %files to keep macro usage consistent.
* The compiler gives these warnings:
ccd2iso.c:61: warning: implicit declaration of function 'strcmp'
This can be avoided by adding a
#include string.h
ccd2iso.c:97: warning: format '%d' expects type 'int', but argument 2 has
type 'long unsigned int'
Replacing the %d with %zd will fix this warning.
You can write a patch to fix these and send it upstream.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #9 from Mohammed Safwat mohammed_elaf...@yahoo.com 2010-04-22 10:34:40 EDT --- Created an attachment (id=408341) -- (https://bugzilla.redhat.com/attachment.cgi?id=408341) source RPM matching the latest SPEC file I uploaded -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 Mohammed Safwat mohammed_elaf...@yahoo.com changed: What|Removed |Added Attachment #394502|0 |1 is obsolete|| --- Comment #8 from Mohammed Safwat mohammed_elaf...@yahoo.com 2010-04-18 10:58:25 EDT --- Created an attachment (id=407407) -- (https://bugzilla.redhat.com/attachment.cgi?id=407407) SPEC file It seems at some time I forgot to address Thomas Supra's comments. Anyway you'll find attached the new spec file addressing Spura's comments as well as Liberty's. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #5 from Mohammed Safwat mohammed_elaf...@yahoo.com 2010-02-16 05:50:46 EST --- Created an attachment (id=394502) -- (https://bugzilla.redhat.com/attachment.cgi?id=394502) new spec file to resolve the review findings Found it easier to attach the new spec file here, after resolving your remarks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562585
--- Comment #6 from Thomas Spura toms...@fedoraproject.org 2010-02-16
06:25:25 EST ---
Some other comments, I just noticed ;)
- better use 'make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p'
This way the timestamps are preserved, when installing.
- rpmlint is not clean:
ccd2iso.src:51: W: macro-in-%changelog %{version}
Use %%{version} in the changelog, so this will not be considered as a macro.
This can be done, when a sponsor wants to sponsor you.
I think, you should wait for one and do some other informal reviews of other
packages.
See:
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored#Reviewing_Packages
SPEC URL: http://tomspur.fedorapeople.org/other_review/ccd2iso.spec
SRPM URL:
http://tomspur.fedorapeople.org/other_review/ccd2iso-0.3-2.fc12.src.rpm
(Sponsor FYI: I get the source from the src.rpm he sended via mail and not via
spectool -g, so 'sources matches upstream' still needs to be verified.)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #2 from Mohammed Safwat mohammed_elaf...@yahoo.com 2010-02-15 05:10:14 EST --- It's mentioned under Accessing Your fedorapeople.org Space, that 2. You must be sponsored in a group (other than the CLA groups). I'm only a member in CLA groups. As I mentioned in my original review request description, this's my first package, so I amn't sponsored yet. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 --- Comment #3 from Thomas Spura toms...@fedoraproject.org 2010-02-15 05:20:55 EST --- Hmm, well that's a problem. I started as a translator, so then I already was in a non CLA group. E-Mail /me and I can put it on the web for you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562585
--- Comment #4 from Thomas Spura toms...@fedoraproject.org 2010-02-15
07:04:32 EST ---
I'm no sponsor, so just a comment:
- You should use %{version} macro in Source0, so you don't need to change that
url everytime a new version is out.
The rest looks ok at the first sight :)
SPEC URL: http://tomspur.fedorapeople.org/other_review/ccd2iso.spec
SRPM URL:
http://tomspur.fedorapeople.org/other_review/ccd2iso-0.3-1.fc12.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added CC||toms...@fedoraproject.org --- Comment #1 from Thomas Spura toms...@fedoraproject.org 2010-02-09 06:59:50 EST --- e.g. for hosting space: http://fedoraproject.org/wiki/Infrastructure/fedorapeople.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562585] Review Request: ccd2iso - CloneCD image to ISO image file converter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562585 Mohammed Safwat mohammed_elaf...@yahoo.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
