[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #25 from Fedora Update System 2010-06-30 10:25:14 EDT --- erlang-ibrowse-1.6.0-0.3.20100601git07153bc.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 Fedora Update System changed: What|Removed |Added Fixed In Version|erlang-ibrowse-1.6.0-0.3.20 |erlang-ibrowse-1.6.0-0.3.20 |100601git07153bc.fc13 |100601git07153bc.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 Fedora Update System changed: What|Removed |Added Fixed In Version|erlang-ibrowse-1.6.0-0.3.20 |erlang-ibrowse-1.6.0-0.3.20 |100601git07153bc.fc12 |100601git07153bc.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #24 from Fedora Update System 2010-06-21 09:04:48 EDT --- erlang-ibrowse-1.6.0-0.3.20100601git07153bc.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #23 from Fedora Update System 2010-06-21 08:58:41 EDT --- erlang-ibrowse-1.6.0-0.3.20100601git07153bc.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||erlang-ibrowse-1.6.0-0.3.20 ||100601git07153bc.fc12 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #22 from Fedora Update System 2010-06-14 17:54:18 EDT --- erlang-ibrowse-1.6.0-0.3.20100601git07153bc.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-ibrowse'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/erlang-ibrowse-1.6.0-0.3.20100601git07153bc.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #21 from Fedora Update System 2010-06-14 13:21:58 EDT --- erlang-ibrowse-1.6.0-0.3.20100601git07153bc.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-ibrowse'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/erlang-ibrowse-1.6.0-0.3.20100601git07153bc.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #20 from Fedora Update System 2010-06-14 13:16:37 EDT --- erlang-ibrowse-1.6.0-0.3.20100601git07153bc.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-ibrowse'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/erlang-ibrowse-1.6.0-0.3.20100601git07153bc.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #18 from Fedora Update System 2010-06-14 01:50:33 EDT --- erlang-ibrowse-1.6.0-0.3.20100601git07153bc.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/erlang-ibrowse-1.6.0-0.3.20100601git07153bc.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #17 from Fedora Update System 2010-06-14 01:50:28 EDT --- erlang-ibrowse-1.6.0-0.3.20100601git07153bc.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/erlang-ibrowse-1.6.0-0.3.20100601git07153bc.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #19 from Fedora Update System 2010-06-14 01:50:37 EDT --- erlang-ibrowse-1.6.0-0.3.20100601git07153bc.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/erlang-ibrowse-1.6.0-0.3.20100601git07153bc.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #16 from Kevin Fenzi 2010-06-14 00:23:57 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #15 from David Cantrell 2010-06-11 11:16:15 EDT --- No problem. Also, if you have time, I still have https://bugzilla.redhat.com/show_bug.cgi?id=593841 trying to finish up review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 Peter Lemenkov changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Peter Lemenkov 2010-06-11 11:15:47 EDT --- New Package CVS Request === Package Name: erlang-ibrowse Short Description: Erlang HTTP client Owners: peter Branches: F-12 F-13 EL-5 EL-6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #13 from Peter Lemenkov 2010-06-11 11:08:41 EDT --- Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 David Cantrell changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from David Cantrell 2010-06-11 11:02:08 EDT --- Looks good now. Sorry for the delay. I was on vacation for the first part of June. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #11 from Peter Lemenkov 2010-06-11 06:28:15 EDT --- Ping, David. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #10 from Peter Lemenkov 2010-06-01 04:03:40 EDT --- new src.rpm: http://peter.fedorapeople.org/erlang-ibrowse.spec http://peter.fedorapeople.org/erlang-ibrowse-1.6.0-0.2.20100601git07153bc.fc12.src.rpm Changes: * Licensing terms were clarified by the author - http://bit.ly/9x7X0v . * Proper naming scheme (proper alpha tag - with both date and git revision). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #9 from Peter Lemenkov 2010-05-31 08:37:33 EDT --- Asked upstream about licensing conditions. http://github.com/cmullaparthi/ibrowse/issues/#issue/4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=581279
--- Comment #8 from David Cantrell 2010-05-30 20:08:43
EDT ---
Actually, the %{alphatag} usage still needs a datestamp instead of just
".gita114ed3b"
Should be (for example):
%define alphatag 20100530gita114ed3b
Release: 0.1.%{alphatag}%{?dist}
Becase this is still considered a snapshot release given how the source is
pulled from git.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=581279
--- Comment #7 from David Cantrell 2010-05-30 20:02:20
EDT ---
There are some new rpmlint warnings too:
$ rpmlint erlang-ibrowse-1.6.0-0.1.gita114ed3b.fc13.src.rpm
erlang-ibrowse.src:15: W: macro-in-comment %{realname}
erlang-ibrowse.src:16: W: macro-in-comment %{name}
erlang-ibrowse.src:16: W: macro-in-comment %{version}
erlang-ibrowse.src:16: W: macro-in-comment %{gitver}
erlang-ibrowse.src:16: W: macro-in-comment %{name}
erlang-ibrowse.src:16: W: macro-in-comment %{version}
erlang-ibrowse.src:16: W: macro-in-comment %{gitver}
However, these are just in the comment lines, so I don't really care. If you
want to suppress the rpmlint warning, you can use %% in the comment like you
would in the %changelog section, though I don't really care. Your choice.
(The other warnings appearing are ones that we have already been over and are
ok for this package.)
If you can get clarification on the licensing issue, I'll approve the package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #6 from David Cantrell 2010-05-30 19:56:09 EDT --- (In reply to comment #5) > (In reply to comment #4) > > - MUST: The License field in the package spec file must match the actual > > license. > > > > The License field indicates 'BSD or LGPLv2' but it should be 'BSD and > > LGPLv2'. > > I'm afraid that you're wrong here. > > "ibrowse is available under two different licenses. LGPL and the BSD license." > > This sounds for me like ibrowse can be used either under LGPLv2+ (2+ is > explicitly stated in the attached license) or under BSD. That's not how I read the line in the README file. In fact, I believe the line is too ambiguous. The first sentence indicates the software is available under two licenses. The second sentence uses "and" to join the two licenses, and given that the first sentence doesn't clearly state that it is your choice of license, one can only safely conclude that the software is under both licenses. The source code does not make use of license boilerplate text, it's not easy to tell if the author meant that it is your choice of license or if some of the software is under the BSD license or some of it is under the LGPL license. However, if that was the case, the entire collection would constitute a derived work and only the LGPL would apply. Can you get clarification from the author on this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=581279
Peter Lemenkov changed:
What|Removed |Added
Flag|needinfo?(lemen...@gmail.co |
|m) |
--- Comment #5 from Peter Lemenkov 2010-05-27 12:02:47 EDT
---
(In reply to comment #4)
> [+] PASS[-] FAIL [N/A] Not Applicable
>
> - MUST: rpmlint must be run on every package. The output should be posted in
> the review.
>
> $ rpmlint erlang-ibrowse-1.5.6-2.fc13.src.rpm
> erlang-ibrowse.src: W: invalid-url Source0: erlang-ibrowse-1.5.6.tar.bz2
> 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
>
> The Source0 line needs to use the %{alphatag} naming format since you are
> pulling from git. I see you're pulling from a git commit, but if there's a
> tag
> for the 1.5.6 release, that might be better to use.
> https://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages
Done. I'm explicitly using git commit's name in tarball now.
> - MUST: The License field in the package spec file must match the actual
> license.
>
> The License field indicates 'BSD or LGPLv2' but it should be 'BSD and LGPLv2'.
I'm afraid that you're wrong here.
"ibrowse is available under two different licenses. LGPL and the BSD license."
This sounds for me like ibrowse can be used either under LGPLv2+ (2+ is
explicitly stated in the attached license) or under BSD.
> - MUST: The spec file for the package MUST be legible.
>
> These are really just my own opinion. In general I think the spec file is
> perfectly legible, but since we are in review, I figured I'd point out these
> things:
>
> 1) The Requires: lines do not use a tab character to indent the value to the
> 16th column like the Name through BuildRequires lines.
Fixed. I added all these 'Requires' automatically, by using script, so this
discrepancy can probably occur.
> 2) The iconv line in the %prep section is long. I would suggest breaking up
> the line because the spill over on an 80 column terminal makes the "rm -f
> README.utf8" appear to be its own line, when really it's part of the entire
> iconv line.
Splitted in two lines.
New srpm+spec:
http://peter.fedorapeople.org/erlang-ibrowse.spec
http://peter.fedorapeople.org/erlang-ibrowse-1.6.0-0.1.gita114ed3b.fc12.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=581279
David Cantrell changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flag||needinfo?(lemen...@gmail.co
||m)
--- Comment #4 from David Cantrell 2010-05-26 11:58:18
EDT ---
[+] PASS[-] FAIL [N/A] Not Applicable
- MUST: rpmlint must be run on every package. The output should be posted in
the review.
$ rpmlint erlang-ibrowse-1.5.6-2.fc13.src.rpm
erlang-ibrowse.src: W: invalid-url Source0: erlang-ibrowse-1.5.6.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
The Source0 line needs to use the %{alphatag} naming format since you are
pulling from git. I see you're pulling from a git commit, but if there's a tag
for the 1.5.6 release, that might be better to use.
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages
+ MUST: The package must be named according to the Package Naming Guidelines.
+ MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
+ MUST: The package must meet the Packaging Guidelines.
+ MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
- MUST: The License field in the package spec file must match the actual
license.
The License field indicates 'BSD or LGPLv2' but it should be 'BSD and LGPLv2'.
+ MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
+ MUST: The spec file must be written in American English.
- MUST: The spec file for the package MUST be legible.
These are really just my own opinion. In general I think the spec file is
perfectly legible, but since we are in review, I figured I'd point out these
things:
1) The Requires: lines do not use a tab character to indent the value to the
16th column like the Name through BuildRequires lines.
2) The iconv line in the %prep section is long. I would suggest breaking up
the line because the spill over on an 80 column terminal makes the "rm -f
README.utf8" appear to be its own line, when really it's part of the entire
iconv line.
+ MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
+ MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
$ koji build --scratch dist-f13 erlang-ibrowse-1.5.6-2.fc13.src.rpm
Uploading srpm: erlang-ibrowse-1.5.6-2.fc13.src.rpm
[] 100% 00:00:01 40.06 KiB 22.30 KiB/sec
Created task: 2211092
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2211092
None
Watching tasks (this may be safely interrupted)...
2211092 build (dist-f13, erlang-ibrowse-1.5.6-2.fc13.src.rpm): free
2211092 build (dist-f13, erlang-ibrowse-1.5.6-2.fc13.src.rpm): free -> open
(ppc04.phx2.fedoraproject.org)
2211094 buildArch (erlang-ibrowse-1.5.6-2.fc13.src.rpm, i686): free
2211093 buildArch (erlang-ibrowse-1.5.6-2.fc13.src.rpm, x86_64): free
2211093 buildArch (erlang-ibrowse-1.5.6-2.fc13.src.rpm, x86_64): free -> open
(x86-09.phx2.fedoraproject.org)
2211094 buildArch (erlang-ibrowse-1.5.6-2.fc13.src.rpm, i686): free -> open
(x86-04.phx2.fedoraproject.org)
2211094 buildArch (erlang-ibrowse-1.5.6-2.fc13.src.rpm, i686): open
(x86-04.phx2.fedoraproject.org) -> closed
0 free 2 open 1 done 0 failed
2211093 buildArch (erlang-ibrowse-1.5.6-2.fc13.src.rpm, x86_64): open
(x86-09.phx2.fedoraproject.org) -> closed
0 free 1 open 2 done 0 failed
2211092 build (dist-f13, erlang-ibrowse-1.5.6-2.fc13.src.rpm): open
(ppc04.phx2.fedoraproject.org) -> closed
0 free 0 open 3 done 0 failed
2211092 build (dist-f13, erlang-ibrowse-1.5.6-2.fc13.src.rpm) completed
successfully
N/A MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
+ MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
N/A MUST: The s
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 David Cantrell changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|dcantr...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #3 from Peter Lemenkov 2010-05-13 05:12:03 EDT --- New build: http://peter.fedorapeople.org/erlang-ibrowse.spec http://peter.fedorapeople.org/erlang-ibrowse-1.5.6-2.fc12.src.rpm Narrowed explicit requires. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 --- Comment #2 from Peter Lemenkov 2010-05-12 09:17:38 EDT --- The last rpmlint's message about non-utf file was already fixed in spec, uploaded to Fedorapeople (minor issue, so I won't make another koji build for that). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=581279
--- Comment #1 from Peter Lemenkov 2010-05-12 09:05:33 EDT
---
Koji scratchbuild:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2182777
rpmlint:
Sulaco ~/rpmbuild/SPECS: rpmlint
../RPMS/ppc/erlang-ibrowse-1.5.6-1.fc12.ppc.rpm
erlang-ibrowse.ppc: E: no-binary
erlang-ibrowse.ppc: W: only-non-binary-in-usr-lib
erlang-ibrowse.ppc: W: file-not-utf8 /usr/share/doc/erlang-ibrowse-1.5.6/README
1 packages and 0 specfiles checked; 1 errors, 2 warnings.
Sulaco ~/rpmbuild/SPECS:
Both messages *must* be ignored - in fact, application contains only
noarch-data, but installed into arch-specific %{_libdir}. Unlike python stuff
being divided into noarch and arch-dependent, every erlang package should be
installed into %{libdir}/erlang which makes every erlang package
arch-dependent.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581279 Peter Lemenkov changed: What|Removed |Added Blocks||581282 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
