[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

Mat Booth fed...@matbooth.co.uk changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE

--- Comment #23 from Mat Booth fed...@matbooth.co.uk 2010-05-20 17:21:30 EDT 
---
Built for F14, closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

Dennis Gilmore den...@ausil.us changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+

--- Comment #22 from Dennis Gilmore den...@ausil.us 2010-05-18 14:34:28 EDT 
---
CVS Done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

Stanislav Ochotnicky socho...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #9 from Stanislav Ochotnicky socho...@redhat.com 2010-05-14 
03:19:58 EDT ---
If no package in Fedora needs the legacy pom, is this still necessary? If
 org.apache.commons if the right way, I'd rather just do that.

Is it possible to find out in some easy way? For my future reference :-) You
are right though, it's good to avoid polluting the spec file if it's possible.
When I did this in my specs I added a big comment stating why it's there...But
this really is not a show-stopper. Since we are doing this in rawhide, we will
have time to find out if something doesn't work.

Thanks for explaining those OSGi bundles and your changes. 

Modified spec is good. This package is APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

--- Comment #10 from Stanislav Ochotnicky socho...@redhat.com 2010-05-14 
03:50:21 EDT ---
One small thing I realized: Please add Obsoletes (no Provides necessary) for
jakarta javadoc subpackage when you commit to CVS

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

--- Comment #11 from Mat Booth fed...@matbooth.co.uk 2010-05-14 05:14:14 EDT 
---
(In reply to comment #9)
 If no package in Fedora needs the legacy pom, is this still necessary? If
  org.apache.commons if the right way, I'd rather just do that.
 
 Is it possible to find out in some easy way? For my future reference :-) You
 are right though, it's good to avoid polluting the spec file if it's possible.
 When I did this in my specs I added a big comment stating why it's there...But
 this really is not a show-stopper. Since we are doing this in rawhide, we will
 have time to find out if something doesn't work.
 

Unfortunately I don't have an easy way to confirm this, but until very
recently, this package provided no pom at all. I only added when I took over
ownership of commons-codec, so I'd be surprised if there has been anything
added to Fedora in the last few months that depends on it.

 Thanks for explaining those OSGi bundles and your changes. 
 
 Modified spec is good. This package is APPROVED

Thanks

(In reply to comment #10)
 One small thing I realized: Please add Obsoletes (no Provides necessary) for
 jakarta javadoc subpackage when you commit to CVS

Will do, thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

Mat Booth fed...@matbooth.co.uk changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #12 from Mat Booth fed...@matbooth.co.uk 2010-05-14 05:18:56 EDT 
---
New Package CVS Request
===
Package Name: apache-commons-codec
Short Description: Implementations of common encoders and decoders
Owners: mbooth
Branches: devel
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

--- Comment #13 from Guido Grazioli guido.grazi...@gmail.com 2010-05-14 
05:28:35 EDT ---
(In reply to comment #11)
 (In reply to comment #9)
  If no package in Fedora needs the legacy pom, is this still necessary? If
   org.apache.commons if the right way, I'd rather just do that.
  
  Is it possible to find out in some easy way? For my future reference :-) You
  are right though, it's good to avoid polluting the spec file if it's 
  possible.
  When I did this in my specs I added a big comment stating why it's 
  there...But
  this really is not a show-stopper. Since we are doing this in rawhide, we 
  will
  have time to find out if something doesn't work.
  
 
 Unfortunately I don't have an easy way to confirm this, but until very
 recently, this package provided no pom at all. I only added when I took over
 ownership of commons-codec, so I'd be surprised if there has been anything
 added to Fedora in the last few months that depends on it.
 


The poms (for commons-* and jakarta-commons-*) are provided within
maven2-common-poms, which is used in the local repo as a backup pom/depmap
source (in /usr/share/maven/default_poms).
That was done to workaround packages not providing poms along jars, but if you
provide a pom file (which goes to /usr/share/maven/poms), that one will be
chosen first during build.

In this case about renaming, i'm not sure if letting the old named poms stay in
maven2-common-poms does any hurt. Btw, i think most if not all projects will
depend on commons-* and not apache|jakarta-commons-*

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

--- Comment #14 from Mat Booth fed...@matbooth.co.uk 2010-05-14 05:54:34 EDT 
---
Right, but in this case, maven2-common-poms has never carried a pom for
commons-codec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

--- Comment #15 from Mat Booth fed...@matbooth.co.uk 2010-05-14 06:01:48 EDT 
---
(In reply to comment #14)
 Right, but in this case, maven2-common-poms has never carried a pom for
 commons-codec.

Oops, that's a lie. I take it all back, there was a commons-codec pom in
maven2-common-poms. :-)

Would you like me add the legacy depmap to this package?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

--- Comment #16 from Alexander Kurtakov akurt...@redhat.com 2010-05-14 
06:13:13 EDT ---
Mat, please add it.
Guido, once this is in would you remove the codec pom and depmap from
commons-poms?

We should aim at making commons-poms unneeded

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

--- Comment #17 from Guido Grazioli guido.grazi...@gmail.com 2010-05-14 
06:13:45 EDT ---
Yep i was trying to clarify in general (to myself too :) ).

What i meant was that in this process of renaming from jakarta- to apache- ,
we have to be sure that any package provides the relevant pom along the jar
(i'm lurking around these reviews); after that i will drop any commons-* pom
(and depmap) from maven2-common-poms, but the parent pom, IIF that doesn't
break anything, but that shouldn't be the case.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

--- Comment #18 from Mat Booth fed...@matbooth.co.uk 2010-05-14 06:24:53 EDT 
---
(In reply to comment #16)
 Mat, please add it.

Will do, thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

--- Comment #19 from Alexander Kurtakov akurt...@redhat.com 2010-05-14 
06:26:17 EDT ---
(In reply to comment #17)
 Yep i was trying to clarify in general (to myself too :) ).
 
 What i meant was that in this process of renaming from jakarta- to apache- ,
 we have to be sure that any package provides the relevant pom along the jar
 (i'm lurking around these reviews); after that i will drop any commons-* pom
 (and depmap) from maven2-common-poms, but the parent pom, IIF that doesn't
 break anything, but that shouldn't be the case.


Hmm, which parent pom??
We should package every parent pom separately like we are doing for
forge-parent https://bugzilla.redhat.com/show_bug.cgi?id=591482

Once we have this we can make the parent pom package Requires everything
specified in it resulting in a much cleaner and simpler BR sections in
dependant packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

Guido Grazioli guido.grazi...@gmail.com changed:

   What|Removed |Added

 CC||guido.grazi...@gmail.com

--- Comment #20 from Guido Grazioli guido.grazi...@gmail.com 2010-05-14 
06:52:32 EDT ---
(In reply to comment #19)
 Hmm, which parent pom??
 We should package every parent pom separately like we are doing for
 forge-parent https://bugzilla.redhat.com/show_bug.cgi?id=591482

This one: /usr/share/maven2/default_poms/JPP-commons-parent.pom
http://svn.apache.org/viewvc/commons/proper/commons-parent/tags/commons-parent-15/
but i cant find a review request for it yet.

 Once we have this we can make the parent pom package Requires everything
 specified in it resulting in a much cleaner and simpler BR sections in
 dependant packages.

There is a profile in the apache parent to build all proper components, but
those are built individually afaik; if you package the parent pom alone in a
package, it wont buildrequire anything (empty %build, %install pom, %update
depmap),or am i completely wrong?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

--- Comment #21 from Mat Booth fed...@matbooth.co.uk 2010-05-14 13:37:51 EDT 
---
Ok for the record, this is the SPEC/SRPM I will be importing into CVS:

http://mbooth.fedorapeople.org/reviews/apache-commons-codec.spec
http://mbooth.fedorapeople.org/reviews/apache-commons-codec-1.4-8.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

Stanislav Ochotnicky socho...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

--- Comment #7 from Stanislav Ochotnicky socho...@redhat.com 2010-05-13 
10:46:30 EDT ---
Noted that this is re-review


OK: rpmlint must be run on every package. The output should be posted in the
review.
OUTPUT:
rpmlint ~/rpmbuild/{SRPMS,RPMS/noarch}/apache-commons-codec*-1.4-6*rpm
apache-commons-codec.noarch: W: non-conffile-in-etc
/etc/maven/fragments/apache-commons-codec
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

False positive, OK

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.  .
OK : The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
OK: Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: Large documentation files must go in a -doc subpackage. (The definition of
large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
OK: If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present.
OK: All filenames in rpm packages must be valid UTF-8.

Other problems:
- required for renames: check for proper Provides/Obsoletes was OK
- these are quite old:
 Provides:  %{short_name} = %{version}-%{release}
 Obsoletes: %{short_name}  %{version}-%{release}

And should be fairly safe to remove them for rawhide F14+ (currently on F-12
only plexus-xmlrpc does and it will have to be revised anyway)


What is the reason to have:
 # enable OSGi automatic dep solving
 %define _use_internal_dependency_generator 0
 %define __find_provides /usr/lib/rpm/osgideps.pl -p
 %define __find_requires /usr/lib/rpm/osgideps.pl -r
I believe they are not used/needed anywhere in the spec file. If they really
are needed, define them with %global. Isn't maven supposed to take care of
this?

- javadoc sub-package must have jpackage-utils in Requires (it is
 owner of javadoc directory
- jpackage-utils should be required in post/postun for %update_maven_depmap
- provide backward compatible pom file with old GROUP_ID/ARTIFACT_ID.
jakarta-commons-codec
 used %add_to_maven_depmap %{short_name} %{short_name} %{version} JPP
%{short_name}

Suggestions (Not required for + :-) ):
- since you are already using install for copying files, why not use
 it for creating dirs too? Instead of:
 mkdir -p %{buildroot}%{_javadocdir}/%{name}-%{version}
use
install -d -m 755 %{buildroot}%{_javadocdir}/%{name}-%{version}

- another one:
 (cd %{buildroot}%{_javadocdir}  ln -sf %{name}-%{version} %{name})

Why create subshell when simple
ln -s %{name}-%{version} %{buildroot}%{_javadocdir}/%{name}
would be enough?

- You also have more commons packages so I suggest you use %global to
define base_name as codec, short_name as commons-%{base_name} and use

[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

--- Comment #8 from Mat Booth fed...@matbooth.co.uk 2010-05-13 16:26:32 EDT 
---
(In reply to comment #7)
 Noted that this is re-review
 

Noted that you've noted that this is a re-review. ;-)

 Other problems:
 - required for renames: check for proper Provides/Obsoletes was OK
 - these are quite old:
  Provides:  %{short_name} = %{version}-%{release}
  Obsoletes: %{short_name}  %{version}-%{release}
 
 And should be fairly safe to remove them for rawhide F14+ (currently on F-12
 only plexus-xmlrpc does and it will have to be revised anyway)
 

Agreed, this provides/obsoletes is ancient. Consider it gone.

 
 What is the reason to have:
  # enable OSGi automatic dep solving
  %define _use_internal_dependency_generator 0
  %define __find_provides /usr/lib/rpm/osgideps.pl -p
  %define __find_requires /usr/lib/rpm/osgideps.pl -r
 I believe they are not used/needed anywhere in the spec file. If they really
 are needed, define them with %global. Isn't maven supposed to take care of
 this?
 

This is to boot-strap automatic dep-solving for RPMs that provide OSGi bundles
needed for Eclipse. Maven only generates the headers, it doesn't care about RPM
dependencies. It is not yet enabled by default, hence these lines. They will be
removed when it is ready. See bug #488352.

I have changed them to use global.


 - javadoc sub-package must have jpackage-utils in Requires (it is
  owner of javadoc directory

Done.

 - jpackage-utils should be required in post/postun for %update_maven_depmap

Done.

 - provide backward compatible pom file with old GROUP_ID/ARTIFACT_ID.
 jakarta-commons-codec
  used %add_to_maven_depmap %{short_name} %{short_name} %{version} JPP
 %{short_name}
 

If no package in Fedora needs the legacy pom, is this still necessary? If
org.apache.commons if the right way, I'd rather just do that.

 Suggestions (Not required for + :-) ):
 - since you are already using install for copying files, why not use
  it for creating dirs too? Instead of:
  mkdir -p %{buildroot}%{_javadocdir}/%{name}-%{version}
 use
 install -d -m 755 %{buildroot}%{_javadocdir}/%{name}-%{version}
 
 - another one:
  (cd %{buildroot}%{_javadocdir}  ln -sf %{name}-%{version} %{name})
 
 Why create subshell when simple
 ln -s %{name}-%{version} %{buildroot}%{_javadocdir}/%{name}
 would be enough?
 

Good ideas, done.

 - You also have more commons packages so I suggest you use %global to
 define base_name as codec, short_name as commons-%{base_name} and use
 base name in URL/Source0, elsewhere as needed. You will then be able to re-use
 spec file changes more easily in the future.

I don't normally have a problem search and replacing, but ok. :-)

New SPEC/SRPM:
http://mbooth.fedorapeople.org/reviews/apache-commons-codec.spec
http://mbooth.fedorapeople.org/reviews/apache-commons-codec-1.4-7.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

--- Comment #5 from Stanislav Ochotnicky socho...@redhat.com 2010-05-12 
03:40:42 EDT ---
The specfile your link points to is not the same as inside srpm, please fix
this

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

--- Comment #6 from Mat Booth fed...@matbooth.co.uk 2010-05-12 16:13:51 EDT 
---
Terribly sorry, try now. I've made no changes other than regenerating the SRPM,
so the links above are still valid.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

Mat Booth fed...@matbooth.co.uk changed:

   What|Removed |Added

 CC||nob...@fedoraproject.org

--- Comment #1 from Mat Booth fed...@matbooth.co.uk 2010-05-11 16:12:05 EDT 
---
*** Bug 225926 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591298] Review Request: apache-commons-codec - Implementations of common encoders and decoders

2010-05-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591298

Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

 CC||akurt...@redhat.com

--- Comment #2 from Alexander Kurtakov akurt...@redhat.com 2010-05-11 
16:23:30 EDT ---
Mat,
I don't think that #225926 is a duplicate of this one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review