[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #25 from Fedora Update System upda...@fedoraproject.org 2010-06-30 10:24:56 EDT --- pyjamas-0.7-6.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|pyjamas-0.7-5.fc13 |pyjamas-0.7-6.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #24 from Fedora Update System upda...@fedoraproject.org 2010-06-21 17:34:51 EDT --- pyjamas-0.7-5.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||pyjamas-0.7-5.fc13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #23 from luke kenneth casson leighton l...@lkcl.net 2010-06-14 08:44:21 EDT --- (In reply to comment #22) Excellent. Thanks for the info. :) no problem. Happy to adjust or tweak the fedora package to work better. cool. i have to do a 0.7p1 or 0.7.1 soon, there's a couple of niggling bugs in 0.7 but the actual packaging itself? it looks solid to me. Feel free to file bugs on it, or drop me email directly. willdo kevin. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #21 from luke kenneth casson leighton l...@lkcl.net 2010-06-13 17:59:05 EDT --- ok i can confirm that pyjamas-desktop works, which is a really nice surprise. right now we have a bit of a situation with python-xpcom / xulrunner on ubuntu: they've upgraded to xulrunner 1.9.2, and it's a dog's dinner, with _all_ reverse-dependencies being simply cut (including hulahop). python-xpcom has been _removed_ from xulrunner by the mozilla foundation, and the mozilla foundation is distinctly losing the plot, focussing on javascript, javascript, javascript, and speed, speed, speed. but please _don't_ do what ubuntu did, which was, on discovering the above, entirely remove pyjamas from ubuntu. lots of users are complaining: all they had to do was temporarily remove pyjamas-desktop, not the entire damn package. at some point it may be the case that pywebkitgtk gets its DOM bindings: pyjamas-desktop can then use that as a dependency. so, all is not lost. l. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #22 from Kevin Fenzi ke...@tummy.com 2010-06-13 23:59:20 EDT --- Excellent. Thanks for the info. :) Happy to adjust or tweak the fedora package to work better. Feel free to file bugs on it, or drop me email directly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 luke kenneth casson leighton l...@lkcl.net changed: What|Removed |Added CC||l...@lkcl.net --- Comment #19 from luke kenneth casson leighton l...@lkcl.net 2010-06-12 19:20:47 EDT --- (In reply to comment #0) pyjamas.noarch: W: no-manual-page-for-binary pyjsbuild there's a pyjsbuild.1 manpage in the debian packaging if you particularly want one. NOTE: This package overrides the normal python 'bytecompile everything ending in .py' because it has some library files that should not/cannot be byte compiled because they override system modules. yep. correct. or, more to the point, you can _try_ but the specialist version of imputil.py in pyjd will ignore them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #20 from luke kenneth casson leighton l...@lkcl.net 2010-06-12 19:24:16 EDT --- (In reply to comment #3) I found the above specfile comment a little unclear; it looks like it was copied from upstream instructions, but it immediately raises questions: do the pyjamas libraries get installed, and if so where? yeah, I copied this from upstream. Reworded it now. New wording: # NOTE: we only byte-compile the library files installed in the normal # fedora python_sitelib. All other .py files are left alone. # This is due to those files replacing/overriding core modules. # They should never be run from anything but pyjamas itself, nor # should they be byte compiled. that's a pretty good rewording. On licensing: - I think it does boil down to ASL2 - The pygwt.js should be ASL2 (at least google web toolkit is ASL2.0). yes. we had to ask the GWT about this, and they specifically placed all files with a copyright notice, ASL2, juuust for us, explicitly, whereas it was implicit before. - The contrib/copyright_check.py doesn't run, ohh... ah, that'll be... yes. change it to read ../copyright not ../debian/copyright and it'll work. l. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2010-06-09 11:48:45 EDT --- pyjamas-0.7-6.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pyjamas'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/pyjamas-0.7-6.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2010-06-07 18:18:09 EDT --- pyjamas-0.7-5.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pyjamas'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/pyjamas-0.7-5.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2010-06-04 15:28:27 EDT --- pyjamas-0.7-5.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/pyjamas-0.7-5.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2010-06-04 15:52:19 EDT --- pyjamas-0.7-6.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/pyjamas-0.7-6.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #14 from Kevin Fenzi ke...@tummy.com 2010-06-03 16:14:36 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Blocks|182235(FE-Legal)| --- Comment #10 from Tom spot Callaway tcall...@redhat.com 2010-06-02 12:33:42 EDT --- Here's what I see: pyjamas: License: ASL 2.0 and MIT (Which files are Python or ZPL?) pyjamas-desktop: License: ASL 2.0 and GPLv2+ and Python pyjamas-doc: License: ASL 2.0 pyjamas-examples: License: ASL 2.0 and BSD and GPL+ and GPLv2+ and LGPLv2+ and MIT and Python and (MPLv1.1+ or LGPLv2+ or GPLv2+) pyjamas-ui: License: ASL 2.0 Hope that helps. Lifting FE-Legal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #11 from Kevin Fenzi ke...@tummy.com 2010-06-02 15:24:41 EDT --- That all looks good to me. I'm not sure why I was thinking there were Python or ZPL files in the base package. ;( Anyhow, new spec: http://www.scrye.com/~kevin/fedora/pyjamas/pyjamas.spec Matches the above license tags. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 Dave Malcolm dmalc...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from Dave Malcolm dmalc...@redhat.com 2010-06-02 15:29:20 EDT --- Thanks - this looks good APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #7 from Dave Malcolm dmalc...@redhat.com 2010-05-28 17:27:36 EDT --- (In reply to comment #6) ok, I have the inconsistent time fixed. Looks good I _think_ I have the license tags right, but it's nicely complicated. Could you check it over or can we ask spot to doublecheck? Thanks. I agree that it's complicated :( I'm afraid I think that it still needs a little work. The copyright file in the upstream tarball appears to be a correct listing of the various licenses attached to the various files, though some of the files it lists aren't present anymore (e.g. jquery) I'm reading: https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios and it does seem like the package contains files which are under multiple, distinct, and independent licenses (as per that wiki page). My reading of that section is that each subpackage should have its own License field, listing all of the licenses with an and separator. Going through the subpackages - core subpackage: your license tag appears to be correct - desktop subpackage: pyjd has some GPL-2 files, so I think that needs adding - ui subpackage: seems to be all Apache, I think - examples subpackage: has Apache, GPL-2, MIT, (MPL-1.1 or LGPL-2.1 or GPL-2) - doc subpackage: apache, I think. I am not a lawyer. My recommendation is to ask for this to be doublechecked by https://admin.fedoraproject.org/mailman/listinfo/legal -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 Dave Malcolm dmalc...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #3 from Kevin Fenzi ke...@tummy.com 2010-05-27 14:16:31 EDT --- I found the above specfile comment a little unclear; it looks like it was copied from upstream instructions, but it immediately raises questions: do the pyjamas libraries get installed, and if so where? yeah, I copied this from upstream. Reworded it now. New wording: # NOTE: we only byte-compile the library files installed in the normal # fedora python_sitelib. All other .py files are left alone. # This is due to those files replacing/overriding core modules. # They should never be run from anything but pyjamas itself, nor # should they be byte compiled. Fixed description typo. Changed sitelib to not use a wildcard. On licensing: - I think it does boil down to ASL2 - The pygwt.js should be ASL2 (at least google web toolkit is ASL2.0). - The contrib/copyright_check.py doesn't run, and I can't see how it would be useful here, but it seems a pain to just do a special tar for this. Will ask upstream I guess. It looks like they may have just dropped this post 0.7. New spec at: http://www.scrye.com/~kevin/fedora/pyjamas/pyjamas.spec Should we ask spot to look over the licensing here? I could have missed something... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591730
--- Comment #4 from Dave Malcolm dmalc...@redhat.com 2010-05-27 18:51:31 EDT
---
Thanks - this is looking good.
There are a couple of issues I think need fixing:
(i) Please fix the python-bytecode-inconsistent-mtime from pylint as this will
make import pyjd slower than it could be
(ii) Please fix the License metadata (see below)
Details:
NEEDSWORK: rpmlint must be run on every package. The output should be posted in
the review.[1]
$ rpmlint ~/rpmbuild/RPMS/noarch/pyjamas-*0.7-3*
pyjamas.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyjs/pyjampiler.py 0644L /usr/bin/python
pyjamas.noarch: E: non-executable-script
/usr/share/pyjamas/pyjs/tests/test-coverage.py 0644L /usr/bin/env
pyjamas.noarch: E: non-executable-script
/usr/share/pyjamas/pyjs/src/pyjs/lib/base64.py 0644L /usr/bin/env
pyjamas.noarch: E: zero-length /usr/share/pyjamas/library/jsonrpc/json.py
pyjamas-desktop.noarch: W: no-documentation
pyjamas-desktop.noarch: E: python-bytecode-inconsistent-mtime
/usr/lib/python2.6/site-packages/pyjd/__init__.pyc 2010-05-27T18:07:12
/usr/lib/python2.6/site-packages/pyjd/__init__.py 2010-05-27T18:07:14
pyjamas-desktop.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyjd/idlparser.py 0644L /usr/bin/env
pyjamas-desktop.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyjd/modcompile.py 0644L /usr/bin/env
pyjamas-desktop.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyjd/pywebkitgtk.py 0644L /usr/bin/env
pyjamas-doc.noarch: W: no-documentation
pyjamas-examples.noarch: W: no-documentation
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/uitest/public/testLabelAdd.removelabel.txt
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/maparea/Hello.py
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/uitest/public/testButtonClick.removeButton.txt
pyjamas-examples.noarch: E: non-executable-script
/usr/share/pyjamas/examples/jsonrpc/public/PythonCGIServer.py 0644L
/usr/bin/env
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/maparea/Map.py
pyjamas-examples.noarch: E: script-without-shebang
/usr/share/pyjamas/examples/flowpanel/FlowPanel.py
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/uitest/public/testDivText.removeDiv.txt
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/uitest/public/testDivAdd.removeDiv.txt
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/maparea/public/Hello.html
pyjamas-examples.noarch: E: zero-length
/usr/share/pyjamas/examples/uitest/public/testDivHTML.removeDiv.txt
pyjamas-ui.noarch: W: no-documentation
5 packages and 0 specfiles checked; 18 errors, 4 warnings.
Please can you fix the python-bytecode-inconsistent-mtime error: this will
force Python to recompile pyjd/__init__.py every time you import it, if run as
non-root.
Everything else looks waivable to me.
OK: The package must be named according to the Package Naming Guidelines
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
NEEDSWORK: The License field in the package spec file must match the actual
license. [3]
The file copyright in the source tree handily lists the licences. Most files
are indeed under Apache, but there's a mixture of others: some GPL-2, Other,
ZPL-2.1, MIT, PSF, LGPL-2.1. All appear to be Fedora-approved licenses.
Note that each subpackage can have its own License tag; see
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
OK: The spec file must be written in American English. [5]
OK: The spec file for the package MUST be legible. [6]
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
$ md5sum pyjamas-0.7.tgz pyjamas-0.7-2.fc14.src/pyjamas-0.7.tgz
8441b60bb3c88051799537852cceefd0 pyjamas-0.7.tgz
8441b60bb3c88051799537852cceefd0 pyjamas-0.7-2.fc14.src/pyjamas-0.7.tgz
$ sha256sum pyjamas-0.7.tgz pyjamas-0.7-2.fc14.src/pyjamas-0.7.tgz
648f62c1ddf99392fb926ca8d3900c39109b09e06d93cc7de3668933d7084d2b
pyjamas-0.7.tgz
648f62c1ddf99392fb926ca8d3900c39109b09e06d93cc7de3668933d7084d2b
pyjamas-0.7-2.fc14.src/pyjamas-0.7.tgz
OK: The package MUST successfully compile and build
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #5 from Dave Malcolm dmalc...@redhat.com 2010-05-27 18:56:02 EDT --- I went ahead and added a link to this review to the list of Python runtimes here: https://fedoraproject.org/wiki/SIGs/Python#Python_Runtimes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591730
Dave Malcolm dmalc...@redhat.com changed:
What|Removed |Added
CC||dmalc...@redhat.com
AssignedTo|nob...@fedoraproject.org|dmalc...@redhat.com
--- Comment #2 from Dave Malcolm dmalc...@redhat.com 2010-05-26 17:32:03 EDT
---
Broadly-speaking, this looks like a sane packaging of pyjamas.
A few nits:
# NOTE: we only byte-compile the library files.
# This is because:
# DO NOT install the pyjamas libraries into /usr/share/python-support,
# /usr/lib/python2.N/site-packages or ANY location where the standard
# python interpreter could possibly pick them up. The pyjamas libraries
# have nothing to do with python libraries when used by the compiler,
# and contain replacements for sys.py, time.py and other modules that
# are critical to pyjamas. It goes without saying that if you overwrite
# the standard python modules with the pyjamas equivalents, you will run into
# massive problems. Don't do it.
I found the above specfile comment a little unclear; it looks like it was
copied from upstream instructions, but it immediately raises questions: do the
pyjamas libraries get installed, and if so where?
%description desktop
Typo: s/he /The /
In the %files for the core package, you use:
%{python_sitelib}/*
Is it possible to be a bit more explicit on this line? Especially with the
comment above, you've got me feeling paranoid about exactly what the payload of
the package is.
Pyjamas provides reimplementations of various parts of the standard library, in
a mix of pure python and JS (see pyjs/src/pyjs/lib/)
License may be more complex that the specfile indicates; there's lots of info
in the copyright file in the tarball, with a variety of licenses.
builder/boilerplate/pygwt.js has the comment // this is almost directly taken
from Google's GWT which is now open source: may want to clarify that this is
properly licensed.
Somewhat ironically, contrib/copyright_check.py (debian copyright file
checker) doesn't seem to have a license
(still reading through the tarball)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591730 --- Comment #1 from Kevin Fenzi ke...@tummy.com 2010-05-12 18:23:04 EDT --- *** Bug 591731 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
