[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608319
Mario Blättermann changed:
What|Removed |Added
CC||mari...@freenet.de
--- Comment #7 from Mario Blättermann 2011-04-30 16:35:35
EDT ---
$ rpmlint -v *
memaker.noarch: I: checking
memaker.noarch: I: checking-url https://launchpad.net/memaker (timeout 10
seconds)
memaker.noarch: W: hidden-file-or-dir
/usr/share/memaker/themes/glyphFace/Nose/..svg
memaker.noarch: W: no-manual-page-for-binary memaker
memaker.src: I: checking
memaker.src: I: checking-url https://launchpad.net/memaker (timeout 10 seconds)
memaker.src: W: invalid-url Source0: memaker-20100110-bzr.tar.gz
memaker.spec: W: invalid-url Source0: memaker-20100110-bzr.tar.gz
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
The mentioned hidden file isn't hidden really. It is the filename ~.svg, which
is erroneously recognized as hidden.
Please replace all occurences of the application name in the spec with %{name}.
Wouldn't it be better to use the "install" command instead of cp, especially to
keep timestamps?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608319
Martin Gieseking changed:
What|Removed |Added
CC||martin.giesek...@uos.de
--- Comment #8 from Martin Gieseking 2011-05-01
03:10:17 EDT ---
(In reply to comment #7)
> Please replace all occurences of the application name in the spec with
> %{name}.
That's optional and only useful in particular cases where the package name is
directly related to another entry in the spec file, e.g. the name of the
tarball.
Using %{name} in %install or %files is not required because there's no benefit
of doing so. If you want to use it there anyway, it should be consistent,
though (no mix between %{name} and the plain name string).
> Wouldn't it be better to use the "install" command instead of cp, especially
> to
> keep timestamps?
cp -a preserves the timestamps too.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 --- Comment #9 from Ankur Sinha 2011-05-04 13:30:26 EDT --- Hi Mario, Martin, Thanks for the comments. I've updated the spec. * Wed May 04 2011 Ankur Sinha - 20100110-1 - #608319 - replaced "memaker" with name macro - changed cp -v to cp -av to preserve timestamps - update to upstream dev http://ankursinha.fedorapeople.org/memaker/memaker.spec http://ankursinha.fedorapeople.org/memaker/memaker-20100110-1.fc15.src.rpm http://ankursinha.fedorapeople.org/memaker/memaker-20100110-1.fc15.noarch.rpm Regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608319
--- Comment #10 from Mario Blättermann 2011-05-07 13:03:22
EDT ---
(In reply to comment #3)
> %{_datadir}/%{name} seems also not to be owned.
Just put a / after this entry to let your package own this directory.
http://fedoraproject.org/wiki/Packaging:UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608319
--- Comment #11 from Ankur Sinha 2011-05-09 07:38:35
EDT ---
(In reply to comment #10)
> (In reply to comment #3)
> > %{_datadir}/%{name} seems also not to be owned.
>
> Just put a / after this entry to let your package own this directory.
>
> http://fedoraproject.org/wiki/Packaging:UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory
Hi Mario,
Updated spec:
http://ankursinha.fedorapeople.org/memaker/memaker.spec
SRPM:
http://ankursinha.fedorapeople.org/memaker/memaker-20100110-1.fc16.src.rpm
Rest of the results from my mock build can be found here:
http://ankursinha.fedorapeople.org/memaker/
Thanks,
Ankur
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 --- Comment #5 from Ankur Sinha 2011-01-04 07:14:53 EST --- Hi, I'm sorry this has been without comment for such a long period. I'll get down to this within the coming week. regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 --- Comment #6 from Ankur Sinha 2011-01-10 21:33:46 EST --- Hello, SPEC: http://ankursinha.fedorapeople.org/memaker/memaker.spec SRPM: http://ankursinha.fedorapeople.org/memaker/memaker-20100110-1.fc15.src.rpm RPM: http://ankursinha.fedorapeople.org/memaker/memaker-20100110-1.fc14.noarch.rpm rest of mock build results at: http://ankursinha.fedorapeople.org/memaker/ I've made this one from a bzr checkout. This has a setup.py and seems to work well. The setup.py isn't complete, but it installs most of the files correctly. Thank you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 Ankur Sinha changed: What|Removed |Added Status Whiteboard|StalledSubmitter| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mari...@freenet.de Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608319
Mario Blättermann changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #12 from Mario Blättermann 2011-07-28 15:05:31
EDT ---
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3236193
$ rpmlint -i -v *
memaker.noarch: I: checking
memaker.noarch: I: checking-url https://launchpad.net/memaker (timeout 10
seconds)
memaker.noarch: W: hidden-file-or-dir
/usr/share/memaker/themes/glyphFace/Nose/..svg
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.
memaker.noarch: W: no-manual-page-for-binary memaker
Each executable in standard binary directories should have a man page.
memaker.src: I: checking
memaker.src: I: checking-url https://launchpad.net/memaker (timeout 10 seconds)
memaker.src: W: invalid-url Source0: memaker-20100110-bzr.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.
memaker.spec: W: invalid-url Source0: memaker-20100110-bzr.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.
/home/mariobl/Arbeitsfläche/memaker/memaker-20100110-1.fc16.src/memaker.spec:
W: invalid-url Source0: memaker-20100110-bzr.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.
2 packages and 2 specfiles checked; 0 errors, 5 warnings.
For the »hidden« file, see comment #7.
Of course, the source package cannot be named as an URL. That's why, no real
issues.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPLv3+
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
c64b256c500f9eae6f78a03332087553 memaker-20100110-bzr.tar.gz
a432d5d0f771ccd2edf48f860249b25a memaker-20100110-bzr.tar.gz.packaged
The checksums doesn't match. I assume it is due to differing algorithms
in gzip, which is a common problem with other packages which are based
on a VCS checkout, too.
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- See Koji build above.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[+] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[+] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 --- Comment #13 from Ankur Sinha 2011-07-29 06:45:19 EDT --- Thank you for the review Mario! I'll remove the %defattr etc when I push it to scm. Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 Ankur Sinha changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Ankur Sinha 2011-07-29 06:53:30 EDT --- New Package SCM Request === Package Name: memaker Short Description: An avatar creator Owners: ankursinha Branches: f14 f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 --- Comment #15 from Jon Ciesla 2011-07-29 07:57:51 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 --- Comment #16 from Fedora Update System 2011-07-30 06:19:28 EDT --- memaker-20100110-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/memaker-20100110-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 --- Comment #18 from Fedora Update System 2011-07-30 06:19:44 EDT --- memaker-20100110-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/memaker-20100110-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 --- Comment #17 from Fedora Update System 2011-07-30 06:19:35 EDT --- memaker-20100110-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/memaker-20100110-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #19 from Fedora Update System 2011-08-01 16:17:43 EDT --- memaker-20100110-1.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 Ankur Sinha changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||CURRENTRELEASE Last Closed||2011-08-04 14:43:00 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 --- Comment #20 from Fedora Update System 2011-08-28 01:34:49 EDT --- memaker-20100110-1.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 Fedora Update System changed: What|Removed |Added Fixed In Version||memaker-20100110-1.fc16 Resolution|CURRENTRELEASE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 --- Comment #21 from Fedora Update System 2011-09-06 20:21:27 EDT --- memaker-20100110-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 Fedora Update System changed: What|Removed |Added Fixed In Version|memaker-20100110-1.fc16 |memaker-20100110-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 --- Comment #22 from Fedora Update System 2011-09-06 20:24:22 EDT --- memaker-20100110-1.fc14 has been pushed to the Fedora 14 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 Fedora Update System changed: What|Removed |Added Fixed In Version|memaker-20100110-1.fc15 |memaker-20100110-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 --- Comment #1 from Ankur Sinha 2010-06-26 16:00:46 EDT --- hey, There are some issues already: It's a python module, but doesn't use any setuptools etc. I've manually installed *all* files. Therefore, there are no egg files at the moment (I couldn't figure out how to generate them manually). regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608319
--- Comment #3 from Till Maas 2010-07-01 06:42:16 EDT ---
%{_datadir}/%{name} seems also not to be owned.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608319
Till Maas changed:
What|Removed |Added
CC||opensou...@till.name
--- Comment #2 from Till Maas 2010-07-01 06:41:34 EDT ---
(In reply to comment #1)
> There are some issues already:
>
> It's a python module, but doesn't use any setuptools etc. I've manually
> installed *all* files. Therefore, there are no egg files at the moment (I
> couldn't figure out how to generate them manually).
Imho the best solution is to ask upstream to use a setup.py file or write one
yourself and submit it upstream.
Btw. it looks to me that %{python_sitelib}/MeMaker/ is not owned, so a %dir
%{python_sitelib}/MeMaker/ needs to be added to %files.
And the patch should be submitted upstream if appropriate and a comment added
that explains it's upstream status or why it is not appropriate for upstream.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608319] Review Request: memaker - An avatar creator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608319 Jason Tibbitts changed: What|Removed |Added Status Whiteboard||StalledSubmitter --- Comment #4 from Jason Tibbitts 2010-11-23 15:05:43 EST --- It's been several months without response to the above commentary. I'll close this soon if there's no further progress. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
