[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|epris-0.2-4.fc15|epris-0.2-4.fc16 --- Comment #38 from Fedora Update System upda...@fedoraproject.org 2012-03-06 14:42:11 EST --- epris-0.2-4.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||epris-0.2-4.fc15 Resolution||ERRATA Last Closed||2012-03-06 14:29:19 --- Comment #37 from Fedora Update System upda...@fedoraproject.org 2012-03-06 14:29:19 EST --- epris-0.2-4.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #36 from Jon Ciesla limburg...@gmail.com 2012-03-02 09:08:43 EST --- Login to bodhi, https://admin.fedoraproject.org/updates/, and mark each update as stable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #35 from Ratnadeep Debnath rtn...@gmail.com 2012-03-01 01:34:28 EST --- Hi Jon, How can it be done? AFAIK, for my previous packages, I didn't have to do anything for the package to move to stable. Regards, rtnpro -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #34 from Jon Ciesla limburg...@gmail.com 2012-02-28 10:53:07 EST --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #33 from Jon Ciesla limburg...@gmail.com 2012-01-26 13:49:36 EST --- This can go to stable now, from the look of it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #30 from Fedora Update System upda...@fedoraproject.org 2011-12-31 12:16:41 EST --- epris-0.2-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/epris-0.2-4.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #31 from Fedora Update System upda...@fedoraproject.org 2011-12-31 12:16:53 EST --- epris-0.2-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/epris-0.2-4.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #32 from Fedora Update System upda...@fedoraproject.org 2011-12-31 15:24:27 EST --- epris-0.2-4.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 Ratnadeep Debnath rtn...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #27 from Ratnadeep Debnath rtn...@gmail.com 2011-12-15 13:30:59 EST --- Hi Jon, A: I didn't approve it yet. Are you sponsored? Yes. I already maintain two packages at Fedora: python-keyring and wordgroupz. I am also approved in the Fedora Packager GIT Commit Group. B: You didn't set the fedora-cvs flag. setting that now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #29 from Jon Ciesla limburg...@gmail.com 2011-12-15 13:48:00 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #28 from Jon Ciesla limburg...@gmail.com 2011-12-15 13:47:03 EST --- Ok, thanks. APPROVED. In the future, wait for approval before making SCM requests. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #24 from Ratnadeep Debnath rtn...@gmail.com 2011-12-14 14:38:04 EST --- Thanks Jon. Now, it's time for SCM request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #25 from Ratnadeep Debnath rtn...@gmail.com 2011-12-14 14:41:24 EST --- New Package SCM Request === Package Name: epris Short Description: A dbus service to listen to music Owners: rtnpro Branches: F-14 F-15 F-16 InitialCC: rtnpro -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #26 from Jon Ciesla limburg...@gmail.com 2011-12-14 15:02:30 EST --- A: I didn't approve it yet. Are you sponsored? B: You didn't set the fedora-cvs flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #23 from Jon Ciesla limburg...@gmail.com 2011-12-12 10:36:47 EST --- epris.spec:13: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 4) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. I still get the bad URL error, but it's good, you might file an rpmlint bug. So it's just the above, which is cosmetic. And you are sponsored now, correct? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #22 from Ratnadeep Debnath rtn...@gmail.com 2011-12-11 07:30:52 EST --- Thanks for the tip. I have updated the SPEC file accordingly and it works. The only gotcha is that I could not find any other download URL for epris other than the current one (which shows HTTP 404 warning in rpmlint). Nevertheless, the URL works from a browser. Here are the updated files: SPEC URL: http://rtnpro.fedorapeople.org/Packages/SPECS/epris.spec SRPM URL: http://rtnpro.fedorapeople.org/Packages/SRPMS/epris-0.2-4.fc16.src.rpm Thanks, Regards, rtnpro -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #20 from Ratnadeep Debnath rtn...@gmail.com 2011-12-07 04:49:40 EST --- I have added the doc files. I have also written a man page for epris. But it seems that the make file isn't configured for man pages. I have patched the source directory to include the man file. Is there a way to copy the man file directly without patching the makefiles? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608852
--- Comment #21 from Jon Ciesla limburg...@gmail.com 2011-12-07 07:58:28 EST
---
Sure, something like this (assuming 6, modify for 1, etc):
In install:
mkdir -p %{buildroot}%{_mandir}/man6
install -p -m644 filename.6 %{buildroot}%{_mandir}/man6/filename.6
In files:
%{_mandir}/man6/filename.6.gz
That should do it.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #19 from Jon Ciesla limburg...@gmail.com 2011-12-06 13:08:50 EST --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 Jon Ciesla l...@jcomserv.net changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@jcomserv.net Flag||fedora-review? --- Comment #17 from Jon Ciesla l...@jcomserv.net 2011-06-27 09:58:20 EDT --- I'll take this: Initially, Source URL is invalid: epris.src: W: invalid-url Source0: http://epris.googlecode.com/files/epris-0.2.tar.gz HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL. Additionally, some non-issue spelling errors, and: epris.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. epris.x86_64: W: no-manual-page-for-binary epr Each executable in standard binary directories should have a man page. Working on a mock build, will post results when complete. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #18 from Jon Ciesla l...@jcomserv.net 2011-06-27 10:20:42 EDT --- Good: - rpmlint checks return: Above^^^ Mock build good. - package meets naming guidelines - package meets packaging guidelines - license ( ) OK, text in not in %doc, not included but matches website. - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - nothing in %doc affects runtime - no need for .desktop file Fix docs and ideally manpage, but I'm not going to worry too much if other docs are present. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 Jon Ciesla l...@jcomserv.net changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|l...@jcomserv.net -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #15 from Ratnadeep Debnath rtn...@gmail.com 2011-02-04 05:44:53 EST --- (In reply to comment #14) It seams that your are still looking for a sponsor. Please follow https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group I got sponsored previously for two packages : wordroupz, python-keyring. I am now maintaining them in the Fedora repository. And the epris package is also correct. I don't why is it taking this long to get this package sponsored? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | Status Whiteboard|StalledSubmitter| --- Comment #16 from Jason Tibbitts ti...@math.uh.edu 2011-02-04 11:57:35 EST --- Several things: Packages aren't sponsored, people are. Once you are a packager you (or your sponsor) should remove the FE-NEEDSPONSOR blockers from any other tickets you may have open. Any packager can review this package; you do not need a sponsor to do it. This package doesn't appear in the list of packages to be reviewed because it's still listed as being stalled. You didn't clear the whiteboard when you posted your update, and then you sent a ping when it wasn't at all clear who you were pinging. I'll set the various fields appropriately; hopefully someone who is interested in this package will review it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #14 from Fabian Affolter fab...@bernewireless.net 2011-01-28 03:29:29 EST --- It seams that your are still looking for a sponsor. Please follow https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #13 from Ratnadeep Debnath rtn...@gmail.com 2010-12-11 00:12:40 EST --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Status Whiteboard||StalledSubmitter --- Comment #11 from Jason Tibbitts ti...@math.uh.edu 2010-11-23 15:12:28 EST --- It has been several months and there have been several good comments since the last response from the submitter. I will close this soon if there is no further progress. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #12 from Ratnadeep Debnath rtn...@gmail.com 2010-11-23 21:49:15 EST --- SPEC Url: http://rtnpro.fedorapeople.org/Packages/SPECS/epris.spec SRPM Url: http://rtnpro.fedorapeople.org/Packages/SRPMS/epris-0.2-3.fc14.src.rpm Koji scratch build Url: http://koji.fedoraproject.org/koji/taskinfo?taskID=2620526 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608852
Felipe Contreras felipe.contre...@gmail.com changed:
What|Removed |Added
CC||felipe.contre...@gmail.com
--- Comment #10 from Felipe Contreras felipe.contre...@gmail.com 2010-08-10
07:05:57 EDT ---
(In reply to comment #9)
%define gstreamer_version 0.10
%define dbus-glib_version 0.70
BuildRequires: gstreamer-devel gstreamer_version
BUildRequires: dbus-glib-devel dbus-glib_version
Requires: gstreamer gstreamer_version
This won't work. Did it even build and install?
Above you defined two macros, but below you didn't use them. So:
BuildRequires: gstreamer-devel %{gstreamer_version}
BUildRequires: dbus-glib-devel %{dbus-glib_version}
Requires: gstreamer %{gstreamer_version}
Further, using '' and not '=' is somewhat unclear. GStreamer is still in the
0.10 series for a long time, so would 0.10 be sufficient? Or does it strictly
need to be 0.10?
There is no GStreamer 0.10; should be =.
I recommend:
BuildRequires: gstreamer-devel = 0.10
BUildRequires: dbus-glib-devel = 0.70
This is not needed:
Requires: gstreamer %{gstreamer_version}
Because the binary would be linked to libgstreamer, so that would be automatic.
Obsoletes: epris 0.2
A comment would be good here. There is no such epris provided in the Fedora
package collection. *This* package is called epris. What's the reason for
the
Obsoletes tag?
Yeah, this should go away.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608852
--- Comment #9 from Michael Schwendt mschwe...@gmail.com 2010-08-05 07:38:28
EDT ---
Please do test your packages a little bit yourself, too. :( Reviewers are
there to add another pair of eyes, but basically *you* are supposed to practise
RPM packaging in accordance with Fedora's Packaging and Reviewing Guidelines.
%define gstreamer_version 0.10
%define dbus-glib_version 0.70
BuildRequires: gstreamer-devel gstreamer_version
BUildRequires: dbus-glib-devel dbus-glib_version
Requires: gstreamer gstreamer_version
This won't work. Did it even build and install?
Above you defined two macros, but below you didn't use them. So:
BuildRequires: gstreamer-devel %{gstreamer_version}
BUildRequires: dbus-glib-devel %{dbus-glib_version}
Requires: gstreamer %{gstreamer_version}
Further, using '' and not '=' is somewhat unclear. GStreamer is still in the
0.10 series for a long time, so would 0.10 be sufficient? Or does it strictly
need to be 0.10? Notice that if the package %release value is not specified
in such a versioned dependency, it is left out of RPM version comparison, too.
For example, 0.10-2.fc14 would not be 0.10
Btw, for safety reasons, notice:
https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define
Obsoletes: epris 0.2
A comment would be good here. There is no such epris provided in the Fedora
package collection. *This* package is called epris. What's the reason for the
Obsoletes tag?
%files
%defattr(-,root,root,-)
%doc
Absolutely no need to put an empty %doc there.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #7 from Ratnadeep Debnath rtn...@gmail.com 2010-06-30 14:30:34 EDT --- this should have a new release number?? Updated to epris-0.2-2.fc12.src.rpm SRPM: http://rtnpro.fedorapeople.org/Packages/SRPMS/epris-0.2-2.fc13.src.rpm SPEC: http://rtnpro.fedorapeople.org/Packages/SPECS/epris.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 Ankur Sinha sanjay.an...@gmail.com changed: What|Removed |Added CC||sanjay.an...@gmail.com --- Comment #4 from Ankur Sinha sanjay.an...@gmail.com 2010-06-29 03:05:59 EDT --- (In reply to comment #3) (In reply to comment #2) Does it really not require anything to run. I think Gstreamer and dbus must be needed. I referred to totem.spec and found that epris should require gstreamer during runtime, if it requiures gstreamer-devel during building. I also added an obsoletes line to remove any older version of epris if present in the system. I updated the the spec and srpm mentioned in comment#1 hi Ratnadeep, Since you've made changes to the SPEC, you need to bump the release version and add what you changed to the ChangeLog. Please provide links to the updated spec with the new release and the corresponding srpm. Again, it's a NEEDSPONSOR,we can only provide you with some tips and comments, you need to look for a sponsor for this package to be approved Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #5 from Ratnadeep Debnath rtn...@gmail.com 2010-06-29 10:19:13 EDT --- (In reply to comment #4) (In reply to comment #3) (In reply to comment #2) Since you've made changes to the SPEC, you need to bump the release version and add what you changed to the ChangeLog. Please provide links to the updated spec with the new release and the corresponding srpm. I have updated the spec and srpm files with updated changelogs. The Urls are the same as used in comment#1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #6 from Ankur Sinha sanjay.an...@gmail.com 2010-06-29 10:54:12 EDT --- (In reply to comment #5) (In reply to comment #4) (In reply to comment #3) (In reply to comment #2) Since you've made changes to the SPEC, you need to bump the release version and add what you changed to the ChangeLog. Please provide links to the updated spec with the new release and the corresponding srpm. I have updated the spec and srpm files with updated changelogs. The Urls are the same as used in comment#1 How can that be? http://rtnpro.fedorapeople.org/Packages/SRPMS/epris-0.2-1.fc13.src.rpm;? this should have a new release number?? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 --- Comment #1 from Ratnadeep Debnath rtn...@gmail.com 2010-06-28 14:52:28 EDT --- Koji scratch builds : f13 : https://koji.fedoraproject.org/koji/taskinfo?taskID=2278370 f14: https://koji.fedoraproject.org/koji/taskinfo?taskID=2278405 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 608852] Review Request: epris - a dbus service to listen to music
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608852 Rangeen Basu Roy Chowdhury sherry...@gmail.com changed: What|Removed |Added CC||sherry...@gmail.com --- Comment #2 from Rangeen Basu Roy Chowdhury sherry...@gmail.com 2010-06-28 15:57:03 EDT --- Does it really not require anything to run. I think Gstreamer and dbus must be needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
