[Bug 636041] Rename pycairo to python-cairo for Fedora 15.

2011-11-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636041

--- Comment #4 from Miroslav Suchý  2011-11-22 14:52:59 EST 
---
ping. 
any progress?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 636041] Rename pycairo to python-cairo for Fedora 15.

2010-12-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636041

--- Comment #2 from Matthew Barnes  2010-12-17 06:26:05 EST 
---
(In reply to comment #1)
> python-cairo.src: W: strange-permission py2cairo-1.8.10.tar.gz 0444L
> This should be probably 644

I'll fix the tarball permission the next time I upgrade the package.


> Your spec is named pycairo.spec, whereas you should use python-cairo.spec

I linked to python-cairo.spec but forgot to change it in the uploaded source
package.  I'll fix it when I actually rename the package.


> not sure, why you use %{cairo_version}, which is the same as %{version}

That's true for 1.8.10, but isn't necessarily always true.  "cairo_version"
refers to the minimum version of cairo needed to build the Python bindings for
cairo.


> there is huge list of rpmlint warning such as:
> python-cairo.x86_64: W: spurious-executable-perm
> /usr/share/doc/python-cairo-1.8.10/examples/cairo_snippets/snippets/set_line_join.py
> The file is installed with executable permissions, but was identified as one
> that probably should not be executable.  Verify if the executable bits are
> desired, and remove if not.
> I would tend to think that files in /usr/share/doc should not have executable
> bits sets. But I will not block review on this.

I can't reproduce these warnings.  All installed files use
%defattr(-,root,root,-).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 636041] Rename pycairo to python-cairo for Fedora 15.

2011-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636041

Miroslav Suchý  changed:

   What|Removed |Added

   Flag||needinfo?(mbar...@redhat.co
   ||m)

--- Comment #3 from Miroslav Suchý  2011-08-08 10:04:46 EDT 
---
ping. 
any progress?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 636041] Rename pycairo to python-cairo for Fedora 15.

2010-09-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636041

Matthew Barnes  changed:

   What|Removed |Added

   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 636041] Rename pycairo to python-cairo for Fedora 15.

2010-11-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636041

Miroslav Suchý  changed:

   What|Removed |Added

 CC||msu...@redhat.com
 AssignedTo|nob...@fedoraproject.org|msu...@redhat.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 636041] Rename pycairo to python-cairo for Fedora 15.

2010-11-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636041

Miroslav Suchý  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #1 from Miroslav Suchý  2010-11-01 15:29:07 EDT 
---
python-cairo.src: W: strange-permission py2cairo-1.8.10.tar.gz 0444L
This should be probably 644

python-cairo.src: E: invalid-spec-name
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name
Your spec is named pycairo.spec, whereas you should use python-cairo.spec

not sure, why you use %{cairo_version}, which is the same as %{version}

there is huge list of rpmlint warning such as:
python-cairo.x86_64: W: spurious-executable-perm
/usr/share/doc/python-cairo-1.8.10/examples/cairo_snippets/snippets/set_line_join.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.
I would tend to think that files in /usr/share/doc should not have executable
bits sets. But I will not block review on this.

beside mention items it looks good. Please fix at least first two.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review