[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 Christophe Fergeau cferg...@redhat.com changed: What|Removed |Added CC||cferg...@redhat.com Flag|fedora-cvs+ |fedora-cvs? --- Comment #17 from Christophe Fergeau cferg...@redhat.com 2011-05-25 11:31:27 EDT --- Package Change Request == Package Name: spice-gtk New Branches: el6 Owners: elmarco I'd like to build spice-gtk in epel6, I already have the .spec ready (based on the fedora one) and made a scratch build in epel6, but I can't push it because there is no branch for that yet (I'm a comaintainer of spice-gtk). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 --- Comment #18 from Jason Tibbitts ti...@math.uh.edu 2011-05-25 11:58:04 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2011-02-10 16:30:18 EST --- spice-gtk-0.5-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||spice-gtk-0.5-1.fc14 Resolution||ERRATA Last Closed||2011-02-10 16:30:25 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2011-01-27 17:50:59 EST --- spice-gtk-0.5-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/spice-gtk-0.5-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2011-01-10 16:28:44 EST --- spice-gtk-0.4-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update spice-gtk'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/spice-gtk-0.4-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-01-09 16:25:18 EST --- spice-gtk-0.4-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/spice-gtk-0.4-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 --- Comment #10 from Hans de Goede hdego...@redhat.com 2011-01-07 04:03:20 EST --- (In reply to comment #9) (In reply to comment #8) as soon as 0.4 is released. If you can give me your fas account name, then I'll add you to the packagers group and sponsor you. After that you can move forward with the SCM request: My FAS account is elmarco. As already mentioned on irc I've added you to the packagers group and sponsored you. I notice that your bugzilla account points to your @gmail.com address. You need to change it to your @redhat.com address, as that is what is in FAS. Or if you have 2 bugzilla accounts use the @redhat.com one to do the SCM request as that one will have the necessary rights. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 Marc-Andre Lureau marcandre.lur...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Marc-Andre Lureau marcandre.lur...@redhat.com 2011-01-07 09:07:15 EST --- New Package SCM Request === Package Name: spice-gtk Short Description: glib/gtk client libraries for SPICE Owners: elmarco Branches: f14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 --- Comment #12 from Jason Tibbitts ti...@math.uh.edu 2011-01-07 12:26:44 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Hans de Goede hdego...@redhat.com 2011-01-06 04:07:58 EST --- Hi, (In reply to comment #7) http://fedorapeople.org/gitweb?p=elmarco/public_git/spice-gtk.git;a=commitdiff;h=59051f0de1772fadf1fd5ad6661d595585148279;hp=16c5fea8350282425bfe4d36ce4d4c5a9e381304 Looks good now. Note though that it is custom to bump the spec file's release field and add a changelog entry whenever you make changes, even during the package review phase. The SRPM is actually made from a git snapshot of version 0.3.20, which has a broken python module bug. I propose we wait until 0.4 release. Waiting with importing and building till the 0.4 release is fine with me. But lets move forward with getting you sponsored and creating a git repo and bugzilla component, etc. for spice-gtk. So that it can get imported and build as soon as 0.4 is released. If you can give me your fas account name, then I'll add you to the packagers group and sponsor you. After that you can move forward with the SCM request: http://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 --- Comment #9 from Marc-Andre Lureau marcandre.lur...@gmail.com 2011-01-06 12:38:06 EST --- (In reply to comment #8) as soon as 0.4 is released. If you can give me your fas account name, then I'll add you to the packagers group and sponsor you. After that you can move forward with the SCM request: My FAS account is elmarco. cheers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||hdego...@redhat.com Blocks|177841(FE-NEEDSPONSOR) | AssignedTo|nob...@fedoraproject.org|hdego...@redhat.com --- Comment #5 from Hans de Goede hdego...@redhat.com 2011-01-05 03:59:34 EST --- Hi, I'll review this and sponsor you, taking bug and removing need sponsor blocker. Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=657403
Hans de Goede hdego...@redhat.com changed:
What|Removed |Added
Flag||fedora-review?
--- Comment #6 from Hans de Goede hdego...@redhat.com 2011-01-05 05:54:17 EST
---
Full review done:
Good:
- rpmlint checks return:
spice-gtk-python.x86_64: W: no-documentation
spice-gtk-tools.x86_64: W: no-documentation
spice-gtk-tools.x86_64: W: no-manual-page-for-binary snappy
spice-gtk-tools.x86_64: W: no-manual-page-for-binary spicy
6 packages and 0 specfiles checked; 0 errors, 4 warnings.
These can all be ignored.
- package meets naming guidelines
- package meets packaging guidelines
- license (LGPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r
Some minor nitpicks / should fix items:
- The Group tag for the main package should be: System Environment/Libraries
- Requires: %{name} = %{version} should be dropped
- The %description for the main package talks about a gtk client and libraries,
but the gtk client is part of the tools package
- Likewise the %description for tools does not mention the gtk client
- The Requires: %{name} = %{version} does not specify the release in the
package, when subpackages depend on other packages in the same SRPM the
requires should specify the full NEVR (name epoch version release) like the
Requires in the devel sub package
- The prefered form for the defattr is:
%defattr(-,root,root,-)
rather then:
%defattr(-, root, root)
- There is no need to specify dir owner ship and the files inside it if
you want the package to own the dir and all files, for example this:
%dir %{_includedir}/spice-client-glib/
%{_includedir}/spice-client-glib/*.h
Can be written simply as:
%{_includedir}/spice-client-glib
Likewise for spice-client-gtk, also you could consider using
wildcards, condensing the %files devel to:
%{_libdir}/libspice-client-g*.so
%{_includedir}/spice-client-g*
%{_libdir}/pkgconfig/spice-client-g*.pc
%{_datadir}/gir-1.0/SpiceClientG*-1.0.gir
%doc %{_datadir}/gtk-doc/html/*
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=657403
--- Comment #7 from Marc-Andre Lureau marcandre.lur...@gmail.com 2011-01-05
07:18:15 EST ---
(In reply to comment #6)
Full review done:
Some minor nitpicks / should fix items:
- The Group tag for the main package should be: System Environment/Libraries
done
- Requires: %{name} = %{version} should be dropped
done
- The %description for the main package talks about a gtk client and
libraries,
but the gtk client is part of the tools package
done: Client libraries for SPICE desktop servers.
- Likewise the %description for tools does not mention the gtk client
done: Simple clients for interacting with SPICE servers.
- The Requires: %{name} = %{version} does not specify the release in the
package, when subpackages depend on other packages in the same SRPM the
requires should specify the full NEVR (name epoch version release) like the
Requires in the devel sub package
fixed, for spice-gtk-python
- The prefered form for the defattr is:
%defattr(-,root,root,-)
rather then:
%defattr(-, root, root)
done
- There is no need to specify dir owner ship and the files inside it if
you want the package to own the dir and all files, for example this:
%dir %{_includedir}/spice-client-glib/
%{_includedir}/spice-client-glib/*.h
Can be written simply as:
%{_includedir}/spice-client-glib
Likewise for spice-client-gtk, also you could consider using
wildcards, condensing the %files devel to:
%{_libdir}/libspice-client-g*.so
%{_includedir}/spice-client-g*
%{_libdir}/pkgconfig/spice-client-g*.pc
%{_datadir}/gir-1.0/SpiceClientG*-1.0.gir
%doc %{_datadir}/gtk-doc/html/*
done
http://fedorapeople.org/gitweb?p=elmarco/public_git/spice-gtk.git;a=commitdiff;h=59051f0de1772fadf1fd5ad6661d595585148279;hp=16c5fea8350282425bfe4d36ce4d4c5a9e381304
The SRPM is actually made from a git snapshot of version 0.3.20, which has a
broken python module bug.
I propose we wait until 0.4 release.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=657403
Fabian Affolter fab...@bernewireless.net changed:
What|Removed |Added
CC||fab...@bernewireless.net
--- Comment #2 from Fabian Affolter fab...@bernewireless.net 2011-01-04
11:04:46 EST ---
Just some quick comments:
- You are mixing %{buildroot} and $RPM_BUILD_ROOT
- GUI tools should have a desktop file
(https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files)
- All documentation files (AUTHORS, README, COPYING, etc) must be added to %doc
- The latest release 0.3 according your spec file but the SOURCE RPM is 0.1.0
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=657403
--- Comment #3 from Marc-Andre Lureau marcandre.lur...@gmail.com 2011-01-04
12:38:36 EST ---
(In reply to comment #2)
- You are mixing %{buildroot} and $RPM_BUILD_ROOT
Fixed, replaced by %{buildroot}
- GUI tools should have a desktop file
(https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files)
I am not sure if we want to make spicy a featured client just now. Spice-Gtk is
rather a library. virt-viewer/virt-manager and hopefully others such as
vinagre, have .desktop and will support spice-gtk. So I would rather avoid
having a .desktop file for spicy now.
- All documentation files (AUTHORS, README, COPYING, etc) must be added to
%doc
Added in spice-gtk.
- The latest release 0.3 according your spec file but the SOURCE RPM is 0.1.0
It has been updated since then, please find latest srpm:
http://fedorapeople.org/~elmarco/spice-gtk-0.3-1.fc14.src.rpm
Thanks
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 --- Comment #4 from Marc-Andre Lureau marcandre.lur...@gmail.com 2011-01-04 16:38:49 EST --- successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2701218 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 Marc-Andre Lureau marcandre.lur...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657403] Review Request: spice-gtk - A GTK widget for SPICE clients
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 --- Comment #1 from Marc-Andre Lureau marcandre.lur...@gmail.com 2010-12-02 20:30:40 EST --- ping -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
