[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 veron changed: What|Removed |Added CC||sabayo...@gmail.com --- Comment #24 from veron 2011-06-23 10:46:55 EDT --- Anyone succeeded since January? I really badly need this program on Fedora 15 KDE. I tried to install from alien conversion but I failed. Even author himself http://www.giuspen.com/topic/rpm-for-fedora/ http://www.giuspen.com/cherrytree/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #25 from Robin Lee 2011-06-23 11:19:59 EDT --- I am the reviewer but not the requester of this package. But I just made a binary rpm based on the requester's specfile: RPM: http://cheeselee.fedorapeople.org/cherrytree-0.22.1-1.fc15.noarch.rpm SRPM: http://cheeselee.fedorapeople.org/cherrytree-0.22.1-1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #26 from veron 2011-06-23 11:40:35 EDT --- Million of thanks. I'm a new user of Fedora. Forgive me my ignorance, but what can we do to make this program get into the official Fedora repository or at least RPM fusion. It is developed continuously and and new versions are released frequently. On other distributions wishes are reported on their bugzilla sites. On Fedora there is https://fedoraproject.org/wiki/Package_maintainers_wishlist but it looks look packages wait quite long to be made, besides they request real name to register. Generally I wish I could have every new update of cherry tree available in repository for easy install. Is is possible at all in Fedora world? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #27 from Robin Lee 2011-06-23 11:56:48 EDT --- This is the very request for getting cherrytree into Fedora repository. But the requester, or who wants to maintain cherrytree in Fedora, has not paid attention to this request for a while. Or you can just join the Fedora packagers[1] if interested. And you can take over this request if the requester keeps unresponsive[2]. [1] https://fedoraproject.org/wiki/Join_the_package_collection_maintainers [2] https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews#Submitter_not_responding -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #28 from veron 2011-06-23 12:14:01 EDT --- I'm not a programmer, just a new Fedora user. But I think this is a great and useful program and many other Fedora users will be satisfied if they only have it available. I've been using it for a few months on Ubuntu and I must tell that I haven't found any better alternative. So, I may only confirm following the original requester that keeping it in repositories is a good idea. I will write to the author on his forum and ask if he can engage and keep an eye on it. cherrytree is also present here: http://gtk-apps.org/content/show.php/CherryTree?content=113350 I don't understand this: "And you can take over this request if the requester keeps unresponsive[2]." What doesn't mean to "take over" and to review? To test it? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #29 from Robin Lee 2011-06-23 12:27:17 EDT --- (In reply to comment #28) > What doesn't mean to "take over" and to review? To test it? Just mean that you have a way to take the maintainership of this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666954
--- Comment #30 from Christoph Wickert 2011-06-23
13:38:02 EDT ---
Sorry, I am extremely busy and I lost interest in this package. Nevertheless I
updated it and fixed some more rpmlint warnings. Here is what I got:
SPEC: http://cwickert.fedorapeople.org/review/cherrytree.spec
SRPM: http://cwickert.fedorapeople.org/review/cherrytree-0.22.1-1.fc16.src.rpm
$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/cherrytree-0.22.1-1.fc16.*
cherrytree.noarch: W: spelling-error %description -l en_US ctd -> ct, std, cad
cherrytree.noarch: W: no-manual-page-for-binary cherrytree
cherrytree.src: W: spelling-error %description -l en_US ctd -> ct, std, cad
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
I think the quickest is to finish this review but in long term I'd like to have
somebody else (co-)maintain this package because I don't really use it.
(In reply to comment #23)
> The main point is that if
> %{_datadir}/application-registry/%{name}.applications
> is included, then this package must require gnome-mime-data, which provides
> the
> directory %{_datadir}/application-registry/ .
For the record: This is not correct, the file and directory ownership
guidelines were revisited already in March 2010 and do allow multiple directory
ownership to avoid unnecessary deps. Nevertheless I dropped
%{_datadir}/{application-registry,mime-info} because nothing is using it
anymore these days. It was last used in GNOME 2.18.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 Robin Lee changed: What|Removed |Added Flag||needinfo?(cwickert@fedorapr ||oject.org) --- Comment #31 from Robin Lee 2011-06-23 14:01:27 EDT --- It seems you removed the python(abi) Requires which has been added in #20. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666954
Christoph Wickert changed:
What|Removed |Added
Flag|needinfo?(cwickert@fedorapr |
|oject.org) |
--- Comment #32 from Christoph Wickert 2011-06-23
14:39:31 EDT ---
I thought rpm would add it automatically when I drop the egg into
%{python_sitelib}. This didn't work but the manually added requirement doesn't
work in mock anymore because get_python_version() returns nothing and rpm will
fail building the srpm with
Error: line 22: Version required: Requires: python(abi) =
I guess python is no longer in the default build root, at least for the srpm.
Any ideas how to get the dep versioned?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #33 from Robin Lee 2011-06-23 15:30:59 EDT --- Created attachment 509599 --> https://bugzilla.redhat.com/attachment.cgi?id=509599 make cherrytree get a python(abi) requirement properly I met a similar situation before, and a method suggested by Toshio Kuratomi solved that problem[1]. But this one now seems worse, and we may need a trickier solution. [1] https://bugzilla.redhat.com/show_bug.cgi?id=567348#c21 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 Robin Lee changed: What|Removed |Added Attachment #509599|0 |1 is obsolete|| --- Comment #34 from Robin Lee 2011-06-23 15:47:00 EDT --- Created attachment 509600 --> https://bugzilla.redhat.com/attachment.cgi?id=509600 make cherrytree get a python(abi) requirement properly Shorter version -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #35 from Christoph Wickert 2011-06-23 17:19:31 EDT --- Thanks for these. I figured out that it was not the macro I used before but that is was placed within the %if clause. So I switched back and move the global 2 lines down. SPEC: http://cwickert.fedorapeople.org/review/cherrytree.spec SRPM: http://cwickert.fedorapeople.org/review/cherrytree-0.22.1-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #36 from Robin Lee 2011-06-23 23:50:54 EDT --- (In reply to comment #35) > Thanks for these. I figured out that it was not the macro I used before but > that is was placed within the %if clause. So I switched back and move the > global 2 lines down. > > SPEC: http://cwickert.fedorapeople.org/review/cherrytree.spec > SRPM: http://cwickert.fedorapeople.org/review/cherrytree-0.22.1-2.fc16.src.rpm That doesn't solve the issue, since Python isn't in the basic build root of F15 and Rawhide(F16). Mock build failed: http://koji.fedoraproject.org/koji/taskinfo?taskID=3157539 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 Christoph Wickert changed: What|Removed |Added CC||toms...@fedoraproject.org --- Comment #1 from Christoph Wickert 2011-01-03 15:21:40 EST --- Thomas, this is python. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 Robin Lee changed: What|Removed |Added Status|NEW |ASSIGNED CC||robinlee.s...@gmail.com AssignedTo|nob...@fedoraproject.org|robinlee.s...@gmail.com Flag||fedora-review? --- Comment #2 from Robin Lee 2011-01-03 21:05:49 EST --- /usr/share/cherrytree/glade/cherrytree.glade.h seems not necessary to be installed. The latest changelog is missed. And please paste the output of rpmlint run on all the rpms. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #3 from Robin Lee 2011-01-03 21:19:54 EST --- ASCII double quote is preferred in description like ".ctd". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 Christoph Wickert changed: What|Removed |Added Version|rawhide |1 --- Comment #4 from Christoph Wickert 2011-01-04 03:52:04 EST --- (In reply to comment #2) > /usr/share/cherrytree/glade/cherrytree.glade.h seems not necessary to be > installed. > > The latest changelog is missed. Both fixed, thanks > And please paste the output of rpmlint run on all the rpms. I always though this is part of the review when the reviewer tests is the package builds in mock, otherwise a requester can post 'faked' rpmlint output here. But here you are: rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/cherrytree-0.19-2.fc15.* cherrytree.noarch: W: spelling-error %description -l en_US xml -> XML, cml, ml cherrytree.noarch: W: spelling-error %description -l en_US ctd -> cts, ct, cd cherrytree.noarch: W: no-manual-page-for-binary cherrytree cherrytree.src: W: spelling-error %description -l en_US xml -> XML, cml, ml cherrytree.src: W: spelling-error %description -l en_US ctd -> cts, ct, cd 2 packages and 0 specfiles checked; 0 errors, 5 warnings. (In reply to comment #3) > ASCII double quote is preferred in description like ".ctd". Fixed, was a left over from copy & paste from the website. SPEC: http://cwickert.fedorapeople.org/review/cherrytree.spec SRPM: http://cwickert.fedorapeople.org/review/cherrytree-0.19-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #5 from Robin Lee 2011-01-04 05:54:52 EST --- With respect to deb/control and modules/core.py, this package depends on 7za, so please add /usr/bin/7za to requirement. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #6 from Christoph Wickert 2011-01-04 06:06:30 EST --- Will do. Would you mind doing a full review instead of step by step? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #7 from Robin Lee 2011-01-04 07:59:00 EST --- * TODO: python2-devel is now preferred to python-devel. https://fedoraproject.org/wiki/Packaging:Python#BuildRequires * Source tarball matches upstream: $ md5sum cherrytree-0.19.tar.gz f194c5f3b3016e2d1c9807e435bbf625 cherrytree-0.19.tar.gz * I hope you can convince upstream to rid of gtk requirement from setup.py. It should be an easy job. This package will be approved when the two last issues fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 John Poelstra changed: What|Removed |Added Version|1 |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666954
--- Comment #8 from Thomas Spura 2011-01-04
17:03:15 EST ---
(In reply to comment #1)
> Thomas, this is python. ;)
Hehe, nice ;-)
(In reply to comment #7)
> * I hope you can convince upstream to rid of gtk requirement from setup.py. It
> should be an easy job.
Not that easy...
gtk is not required in setup.py. They import the cons module to get the version
from there. So it would be best, if they would introduce a new *.py file for
the gtk variables and import it from there.
(patch below)
But I would suggest to not install into %{python_sitelib}, because upstream
(and so othere distributions don't do that too, but your choice ;-)
It's starting up, but it would be better to ask upstream, if the patch is ok...
SPEC: http://tomspur.fedorapeople.org/review/cherrytree.spec
PATCH:http://tomspur.fedorapeople.org/review/cherrytree-gtk-dep.patch
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #9 from Robin Lee 2011-01-05 02:03:11 EST --- This package uses glade mechanism, you'd better add pygtk2-libglade to requirement. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666954
--- Comment #10 from Christoph Wickert 2011-01-06
16:55:49 EST ---
(In reply to comment #7)
> * TODO: python2-devel is now preferred to python-devel.
> https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
AFAIK python-devel is a virtual provides that always defaults to the perferred
version of python. IMHO we should not hardcode a specific version.
> * I hope you can convince upstream to rid of gtk requirement from setup.py. It
> should be an easy job.
>
>
> This package will be approved when the two last issues fixed.
Are you blocking this review for an issue with the upstream code that can be
easy worked around? I have contacted upstream and sent him the patch, but if he
doesn't accept it I will not use it because of our commitment to upstream.
Nevertheless this should not block a review. It's a package review and not a
code review and as long as there are no security issues or severe bugs, this
should not be considered a blocker I think.
(In reply to comment #9)
> This package uses glade mechanism, you'd better add pygtk2-libglade to
> requirement.
You don't need to have pygtk2-libglade installed to run cherrytree.
(In reply to comment #8)
> But I would suggest to not install into %{python_sitelib}, because upstream
> (and so othere distributions don't do that too, but your choice ;-)
Fine with me.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666954
--- Comment #11 from Robin Lee 2011-01-07 02:03:24
EST ---
(In reply to comment #10)
> (In reply to comment #7)
> > * TODO: python2-devel is now preferred to python-devel.
> > https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
>
> AFAIK python-devel is a virtual provides that always defaults to the perferred
> version of python. IMHO we should not hardcode a specific version.
'python-devel' may change to be provided by 'python3-devel' at some time before
cherrytree gets prepared for Python 3. So it's better to hardcode the exact
version of Python required by cherrytree.
> (In reply to comment #9)
> > This package uses glade mechanism, you'd better add pygtk2-libglade to
> > requirement.
>
> You don't need to have pygtk2-libglade installed to run cherrytree.
OK.
>
> (In reply to comment #8)
> > But I would suggest to not install into %{python_sitelib}, because upstream
> > (and so othere distributions don't do that too, but your choice ;-)
>
> Fine with me.
And which path world you choose?
I also prefer not to patch much the original source.
And please post your final specfile for review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666954
--- Comment #12 from Christoph Wickert 2011-01-11
09:20:52 EST ---
cherrytree 0.19.1 was just released. It contains more or less the same patch as
Tomas proposed, see
http://code.google.com/p/giuspen-cherrytree/source/detail?r=2d2e8c770f15c86b2e3a12300380557526c1c29f
Upstream also confirmed that pygtk2-libglade is not necessary because he only
uses gtkuilder and not libglade itself.
However I have a problem/question now: When using setup.py, a egg is created.
What to do with it? Is it worth packaing when I install to
/usr/share/cherrytree instead of %{python_sitelib}?
Changes:
* Tue Dec 11 2011 Christoph Wickert - 0.19.1-1
- Update to 0.19.1
- Use setup.py instead of manual installation
- BR python2-devel instead of python-devel
SPEC: http://cwickert.fedorapeople.org/review/cherrytree.spec
I will post a final package one I know what do do with the egg.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666954
--- Comment #13 from Robin Lee 2011-01-11 10:32:13
EST ---
About eggs, refer to
http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns
.
In the case of cherrytree, it is the second case of the above definitions of
eggs.
Including the egg is a 'Should' but not a 'Must', and for cherrytree, the
egg-info file is useless.
But if nothing was installed to %{python_sitelib}, the 'python(abi)'
requirement will not be auto-generated.
After all, just include the egg.
New rpmlint result:
$ rpmlint ./cherrytree-0.19.1-1.fc14.noarch.rpm
cherrytree.noarch: W: spelling-error %description -l en_US xml -> XML, cml, ml
cherrytree.noarch: W: spelling-error %description -l en_US ctd -> cts, ct, cd
cherrytree.noarch: W: devel-file-in-non-devel-package
/usr/share/cherrytree/glade/cherrytree.glade.h
cherrytree.noarch: E: script-without-shebang
/usr/share/applications/cherrytree.desktop
cherrytree.noarch: W: no-manual-page-for-binary cherrytree
1 packages and 0 specfiles checked; 1 errors, 4 warnings.
* TODO: The header file is included again.
* TODO: Add 'chmod -x linux/cherrytree.desktop' to %prep and notify upstream.
And you may notify upstream of these issues.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666954
--- Comment #14 from Christoph Wickert 2011-01-17
06:22:17 EST ---
Guiseppe was so kind as to fix all remaining issues in cherrytree 0.19.3:
- Python modules are installed into %{python_sitelib} by default
- Desktop file is not executable
- cherrytree.glade.h was dropped.
$ rpmlint ../RPMS/noarch/cherrytree-0.19.3-1.fc14.noarch.rpm
cherrytree.noarch: W: spelling-error %description -l en_US xml -> XML, cml, ml
cherrytree.noarch: W: spelling-error %description -l en_US ctd -> cts, ct, cd
cherrytree.noarch: W: no-manual-page-for-binary cherrytree
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
$ rpmlint ../SRPMS/cherrytree-0.19.3-1.fc14.src.rpm
cherrytree.src: W: spelling-error %description -l en_US xml -> XML, cml, ml
cherrytree.src: W: spelling-error %description -l en_US ctd -> cts, ct, cd
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
SPEC: http://cwickert.fedorapeople.org/review/cherrytree.spec
SRPM: http://cwickert.fedorapeople.org/review/cherrytree-0.19.3-1.fc14.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666954
--- Comment #15 from Robin Lee 2011-01-17 07:54:31
EST ---
Python modules are not actually installed into %{python_sitelib} in your RPM.
TODO: No need to explicitly set the python(abi) requirement.
TODO: Please clean up the whitespaces at the end of lines.
TODO: I think Group better to be 'Applications/Editors'.
TODO: Useless comment should be deleted.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666954
--- Comment #16 from Christoph Wickert 2011-01-17
08:51:29 EST ---
(In reply to comment #15)
> Python modules are not actually installed into %{python_sitelib} in your RPM.
My bad, I looked at a wrong version of the
> TODO: No need to explicitly set the python(abi) requirement.
Will do once I'm home.
> TODO: Please clean up the whitespaces at the end of lines.
Which ones?
> TODO: I think Group better to be 'Applications/Editors'.
Similar applications like gjots2, kjots and notecase are in
Appications/Productivity, too.
> TODO: Useless comment should be deleted.
There is not a single comment in the spec. Are you sure you didn't look at a
cached version?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #17 from Robin Lee 2011-01-17 09:00:20 EST --- (In reply to comment #16) > (In reply to comment #15) > > TODO: Please clean up the whitespaces at the end of lines. > > Which ones? The first two lines of the description. > > > TODO: I think Group better to be 'Applications/Editors'. > > Similar applications like gjots2, kjots and notecase are in > Appications/Productivity, too. OK. > > > TODO: Useless comment should be deleted. > > There is not a single comment in the spec. Are you sure you didn't look at a > cached version? #chmod -x linux/cherrytree.desktop -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #18 from Thomas Spura 2011-01-19 02:36:11 EST --- (In reply to comment #17) > (In reply to comment #16) > > (In reply to comment #15) > > > TODO: Useless comment should be deleted. > > > > There is not a single comment in the spec. Are you sure you didn't look at a > > cached version? > #chmod -x linux/cherrytree.desktop $ whatis chmod chmod(1) - change file mode bits Are "file mode bits" related to "a cached version" or "a useless comment"? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #19 from Christoph Wickert 2011-01-19 03:03:10 EST --- Robin was right, there was indeed a comment because spec and srpm are not in sync. I will update the package later, but now I'm rather busy. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 --- Comment #20 from Christoph Wickert 2011-01-21 12:24:07 EST --- (In reply to comment #15) > TODO: Please clean up the whitespaces at the end of lines. These were there for a reason, but I removed them to make you feel better. I also removed the useless egg. It's not even a SHOULD because the python files of this package cannot be used by something else. I added the python(abi) requirement manually. SRPM: http://cwickert.fedorapeople.org/review/cherrytree-0.19.3-2.fc14.src.rpm SPEC: http://cwickert.fedorapeople.org/review/cherrytree.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666954
--- Comment #21 from Robin Lee 2011-01-21 14:56:37
EST ---
(In reply to comment #20)
> (In reply to comment #15)
> I also removed the useless egg. It's not even a SHOULD because the python
> files
> of this package cannot be used by something else. I added the python(abi)
> requirement manually.
OK.
TODO: With respect to deb/control and modules/core.py, this package depends on
7za, so please add /usr/bin/7za to requirement. I said this earlier.
TODO: %{_datadir}/application-registry/%{name}.applications and
%{_datadir}/mime-info/%{name}.* are redundant and should be excluded. Just
%{_datadir}/mime/packages/%{name}.xml and
%{_datadir}/applications/%{name}.desktop are useful with the current xdg
mimetype mechanism.
Refer to:
http://standards.freedesktop.org/shared-mime-info-spec/shared-mime-info-spec-latest.html
TODO: Typos: 'unclude', 'manually ad'.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666954
--- Comment #22 from Christoph Wickert 2011-01-21
17:17:18 EST ---
(In reply to comment #21)
> TODO: With respect to deb/control and modules/core.py, this package depends on
> 7za, so please add /usr/bin/7za to requirement. I said this earlier.
Indeed, you said this earlier, but I missed it due to the high number of
comments. I don't want to be impolite or sound ungrateful, but I would rather
prefer a *full* review instead of new pitfalls with every comment. I think this
would be easier and less time consuming for both me and you.
> TODO: %{_datadir}/application-registry/%{name}.applications and
> %{_datadir}/mime-info/%{name}.* are redundant and should be excluded. Just
> %{_datadir}/mime/packages/%{name}.xml and
> %{_datadir}/applications/%{name}.desktop are useful with the current xdg
> mimetype mechanism.
I agree that %{_datadir}/application-registry/ seems to be dead, but can we
really be sure all applications in Fedora are using shared-mime-info?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666954
--- Comment #23 from Robin Lee 2011-01-22 00:32:22
EST ---
(In reply to comment #22)
> (In reply to comment #21)
> > TODO: With respect to deb/control and modules/core.py, this package depends
> > on
> > 7za, so please add /usr/bin/7za to requirement. I said this earlier.
>
> Indeed, you said this earlier, but I missed it due to the high number of
> comments. I don't want to be impolite or sound ungrateful, but I would rather
> prefer a *full* review instead of new pitfalls with every comment. I think
> this
> would be easier and less time consuming for both me and you.
>
I am sorry. I will do better next time.
> > TODO: %{_datadir}/application-registry/%{name}.applications and
> > %{_datadir}/mime-info/%{name}.* are redundant and should be excluded. Just
> > %{_datadir}/mime/packages/%{name}.xml and
> > %{_datadir}/applications/%{name}.desktop are useful with the current xdg
> > mimetype mechanism.
>
> I agree that %{_datadir}/application-registry/ seems to be dead, but can we
> really be sure all applications in Fedora are using shared-mime-info?
Most of DE's and FM's should have been using this mechanism.
Refer to:
http://www.freedesktop.org/wiki/Specifications/shared-mime-info-spec?action=show&redirect=Standards%2Fshared-mime-info-spec#Currentstatus
The main point is that if %{_datadir}/application-registry/%{name}.applications
is included, then this package must require gnome-mime-data, which provides the
directory %{_datadir}/application-registry/ .
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 Germán Racca changed: What|Removed |Added CC||gra...@gmail.com --- Comment #37 from Germán Racca 2011-09-30 09:56:15 EDT --- I'd like to see this package in Fedora repos also...any progress? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 Robin Lee changed: What|Removed |Added Flag||needinfo?(cwickert@fedorapr ||oject.org) --- Comment #38 from Robin Lee 2011-11-02 02:17:20 EDT --- If you intended to give up this review, can I take over this package? We have already worked a lot on it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 Christoph Wickert changed: What|Removed |Added Flag|fedora-review? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 Christoph Wickert changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks||201449(FE-DEADREVIEW) Resolution||NOTABUG Flag|needinfo?(cwickert@fedorapr | |oject.org) | Last Closed||2011-11-02 04:50:47 --- Comment #39 from Christoph Wickert 2011-11-02 04:50:47 EDT --- I have no intentions of maintaining this package, I don't use it myself. If you are willing to do it, go ahead. Once you have opened a new review request mark this one a duplicate please. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666954] Review Request: cherrytree - Hierarchical note taking application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666954 Robin Lee changed: What|Removed |Added Resolution|NOTABUG |DUPLICATE --- Comment #40 from Robin Lee 2011-11-02 22:27:44 EDT --- *** This bug has been marked as a duplicate of bug 750961 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
