[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points

2011-08-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680174

--- Comment #11 from Fedora Update System upda...@fedoraproject.org 
2011-08-16 20:53:44 EDT ---
herqq-1.0.0-1.fc15 has been pushed to the Fedora 15 stable repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points

2011-08-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680174

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||herqq-1.0.0-1.fc15
 Resolution||ERRATA
Last Closed||2011-08-16 20:53:50

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points

2011-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680174

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #10 from Fedora Update System upda...@fedoraproject.org 
2011-08-08 21:30:32 EDT ---
herqq-1.0.0-1.fc15 has been pushed to the Fedora 15 testing repository.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points

2011-08-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680174

--- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-08-06 
11:08:30 EDT ---
herqq-1.0.0-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/herqq-1.0.0-1.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points

2011-08-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680174

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points

2011-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680174

--- Comment #6 from Jaroslav Reznik jrez...@redhat.com 2011-07-20 08:45:39 
EDT ---
Thanks Rex, fixed.

Spec URL: http://rezza.hofyland.cz/fedora/packages/herqq/herqq.spec
SRPM URL:
http://rezza.hofyland.cz/fedora/packages/herqq/herqq-0.9.1-3.fc14.src.rpm

* Wed Jul 20 2011 Jaroslav Reznik jrez...@redhat.com - 0.9.1-3
- fix license to LGPLv3+
- qt4 header dir for consistency
- shlib soname tracked in %files
- -devel should not duplicate COPYING

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points

2011-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680174

Jaroslav Reznik jrez...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #7 from Jaroslav Reznik jrez...@redhat.com 2011-07-20 08:47:32 
EDT ---
New Package SCM Request
===
Package Name: herqq
Short Description: A software library for building UPnP devices and control
points
Owners: jreznik
Branches: f14 f15
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points

2011-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680174

--- Comment #8 from Jon Ciesla l...@jcomserv.net 2011-07-20 09:30:08 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points

2011-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680174

Bug 680174 depends on bug 679401, which changed state.

Bug 679401 Summary: Review Request: qtsoap - The Simple Object Access Protocol 
Qt-based client side library
https://bugzilla.redhat.com/show_bug.cgi?id=679401

   What|Old Value   |New Value

 Resolution||RAWHIDE
 Status|ASSIGNED|CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points

2011-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680174

--- Comment #3 from Jaroslav Reznik jrez...@redhat.com 2011-07-19 09:09:57 
EDT ---
Spec URL: http://rezza.hofyland.cz/fedora/packages/herqq/herqq.spec
SRPM URL:
http://rezza.hofyland.cz/fedora/packages/herqq/herqq-0.9.1-2.fc14.src.rpm

* Tue Jul 19 2011 Jaroslav Reznik jrez...@redhat.com - 0.9.1-2
- qtsoap library
- cleanup SPEC file

For naming issues - some distros ships herqq package, some hupnp, so I will
stick with herqq here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points

2011-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680174

--- Comment #5 from Rex Dieter rdie...@math.unl.edu 2011-07-19 10:09:56 EDT 
---
oh, and

SHOULD: no need to include 
%doc hupnp/LICENSE_LGPLv3.txt
in both main and -devel subpkg (main is enough, imo).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points

2011-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680174

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #4 from Rex Dieter rdie...@math.unl.edu 2011-07-19 10:08:31 EDT 
---
$ rpmlint *.src.rpm x86_64/*.rpm
herqq.x86_64: W: file-not-utf8 /usr/share/doc/herqq-0.9.1/ChangeLog
herqq.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/herqq-0.9.1/LICENSE_LGPLv3.txt
herqq-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/herqq-devel-0.9.1/LICENSE_LGPLv3.txt
4 packages and 0 specfiles checked; 0 errors, 3 warnings.

mostly harmless


naming: ok

sources: ok
cb0d080da22b649a5916796bbf4d2c28  herqq-0.9.1.zip

scriptlets: ok

license: ok  , but seems all the source code does seem to include the or (at
your option) any later version. option (unless I missed something).

macros: OK, but..

SHOULD: for consistency, I'd recommend using %{_qt4_headerdir} in favor of
%{_includedir}

SHOULD: track shlib soname in %files, so not caught by surprise on abi changes
using something like this:
%{_qt4_libdir}/libHUpnp.so.0*


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points

2011-07-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680174

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||rdie...@math.unl.edu
 AssignedTo|nob...@fedoraproject.org|rdie...@math.unl.edu
   Flag||fedora-review?

--- Comment #2 from Rex Dieter rdie...@math.unl.edu 2011-07-06 11:22:51 EDT 
---
I can help review this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 680174] Review Request: herqq - A software library for building UPnP devices and control points

2011-02-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680174

Jaroslav Reznik jrez...@redhat.com changed:

   What|Removed |Added

 Depends on||679401

--- Comment #1 from Jaroslav Reznik jrez...@redhat.com 2011-02-24 09:50:44 
EST ---
rpmlint ../RPMS/x86_64/herqq-*
herqq.x86_64: W: file-not-utf8 /usr/share/doc/herqq-0.9.1/ChangeLog
herqq.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/herqq-0.9.1/LICENSE_LGPLv3.txt
herqq-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/herqq-devel-0.9.1/LICENSE_LGPLv3.txt
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

I'll contact upstream to fix this.

[jreznik@dhcp-31-154 SPECS]$ rpmlint ../SRPMS/herqq-0.9.1-1.fc14.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[jreznik@dhcp-31-154 SPECS]$ rpmlint herqq.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

What I'm not completely sure it package name - it's referred as herqq upnp or
hupnp. Distributed in herqq.zip with hupnp as a subproject library only with
another test application (not installed). HUPnP is mentioned in description.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review