[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682545 --- Comment #13 from Péter Sulyok 2011-03-15 12:12:34 EDT --- I increased release number, added man page and changelog line for the fixes since rel 1. This is the rpmlint output now: [peti@sutty rpm]$ rpmlint SPECS/nutrika.spec RPMS/x86_64/nutrika-* SRPMS/nutrika-0.2.1-2.fc14.src.rpm 3 packages and 1 specfiles checked; 0 errors, 0 warnings. The latest koji link is: http://koji.fedoraproject.org/koji/taskinfo?taskID=2913942 The spec file at http://peti.fedorapeople.org/ is also updated, and the latest src.rpm uploaded. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682545 --- Comment #12 from Raghu Udiyar 2011-03-14 20:21:29 EDT --- * The release has to be updated every time the spec file is changed, with the appropriate changelog entries, see : http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs > nutrika.x86_64: W: no-manual-page-for-binary nutrika * Please work with upstream to add a manpage : http://fedoraproject.org/wiki/Packaging:Guidelines#Man_pages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682545 --- Comment #11 from Péter Sulyok 2011-03-14 14:37:38 EDT --- (In reply to comment #10) > Please post the new SPEC/SRPM along with the rpmlint output and the koji > build. > Or is it the same link above? I see the changes, but the changelog and release > haven't been updated. I did not change the version/release number of the SPEC/SRPM just updated the previous files at http://peti.fedorapeople.org/ The rpmlint output is the following: [peti@sutty SPECS]$ rpmlint nutrika.spec ../SRPMS/nutrika-0.2.1-1.fc14.src.rpm ../*/*/*.rpm nutrika.x86_64: W: no-manual-page-for-binary nutrika 3 packages and 1 specfiles checked; 0 errors, 1 warnings. This is the link to koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2911747 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682545 Raghu Udiyar changed: What|Removed |Added CC||raghusidda...@gmail.com --- Comment #10 from Raghu Udiyar 2011-03-13 11:06:01 EDT --- Hello Péter, Please post the new SPEC/SRPM along with the rpmlint output and the koji build. Or is it the same link above? I see the changes, but the changelog and release haven't been updated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682545 Pavel Zhukov changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #9 from Pavel Zhukov 2011-03-11 01:34:38 EST --- Sorry, You need a sponsor, I cannot become sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682545 Pavel Zhukov changed: What|Removed |Added AssignedTo|pa...@zhukoff.net |nob...@fedoraproject.org Flag|fedora-review? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682545 Pavel Zhukov changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682545 Pavel Zhukov changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|pa...@zhukoff.net --- Comment #8 from Pavel Zhukov 2011-03-09 14:37:20 EST --- I'll review it -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=682545
--- Comment #7 from Péter Sulyok 2011-03-07 17:55:26 EST
---
I have
1) changed RPM_BUILD_ROOT to %{buildroot} for a consistent macro style
2) corrected License to GPLv3+
3) applied desktop-file-validate from desktop-file-install
4) removed unnecessary Requires tags
5) kept BuildRequires: gtk2-devel,sqlite-devel,gettext,desktop-file-utils,
because it is necessary for mock build
6) removed BuildRoot tag, cleaning in %install, and the %clean section (I do
not expect demand from EPEL5-)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=682545
--- Comment #6 from Carlo Teubner 2011-03-06 16:33:32
EST ---
True. I had assumed this was only for Fedora 14 because of the "Release:
1.fc14". Perhaps better to use %{dist} to make it generic? Then again, this
package is perhaps not that likely to end up in EPEL.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682545 --- Comment #5 from Pavel Zhukov 2011-03-06 16:06:45 EST --- > BuildRoot is unnecessary: > http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag It is necessary for EPEL for example > %clean is unnecessary: > http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean It's necessary for EPEL as well. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682545 Carlo Teubner changed: What|Removed |Added CC||ct.spamma...@gmail.com --- Comment #4 from Carlo Teubner 2011-03-06 15:16:32 EST --- You need to use desktop-file-install: http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files There's no need to explicitly list sqlite and gtk2 as "Requires:". The version of sqlite that came with Fedora 14 is 3.6.23.1, and for gtk2 it's 2.22.0. Since you appear to target F14 only, an explicit requires is unnecessary, and indeed discouraged in the guidelines: http://fedoraproject.org/wiki/Packaging/Guidelines#Requires BuildRoot is unnecessary: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag %clean is unnecessary: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=682545
Ralf Corsepius changed:
What|Removed |Added
CC||rc040...@freenet.de
--- Comment #2 from Ralf Corsepius 2011-03-06 12:27:51
EST ---
(In reply to comment #1)
> Only few comments:
>
> You're using RPM_BUILD_ROOT (variable style) and ?_smp_mflags (macro style)
> Mixing the two styles, while valid, is bad from a QA and usability point of
> view, and should not be done in Fedora packages.
You are confused:
The only variables which must not be mixed within a spec file is
$RPM_BUILD_ROOT and %buildroot.
There is nothing wrong with mixing %{?_smp_mflags} and $RPM_BUILD_ROOT.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682545 --- Comment #3 from Pavel Zhukov 2011-03-06 12:46:27 EST --- Quote from Guidelines "Mixing the two STYLES (not variables), while valid, is bad from a QA and usability point of view, and should not be done in Fedora packages." -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682545 Pavel Zhukov changed: What|Removed |Added CC||pa...@zhukoff.net --- Comment #1 from Pavel Zhukov 2011-03-06 12:18:51 EST --- Only few comments: You're using RPM_BUILD_ROOT (variable style) and ?_smp_mflags (macro style) Mixing the two styles, while valid, is bad from a QA and usability point of view, and should not be done in Fedora packages. http://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS License is GPLv3+ -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 682545] Review Request: nutrika - Nutrient content calculator and intake analyzer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=682545 Péter Sulyok changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
