[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #38 from Volker Fröhlich --- German, you never registered any of your builds as an update. Therefore, i4uc is not available in Fedora. The F15 and F16 builds were garbage collected and no newer builds exist, see the above post. Please create builds and register them as updates. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #39 from Volker Fröhlich --- Any news here? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
https://bugzilla.redhat.com/show_bug.cgi?id=717502 Volker Fröhlich changed: What|Removed |Added Flags||needinfo?(germanrs@fedorapr ||oject.org) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #22 from Guillermo Gómez 2011-11-14 05:17:14 EST --- (In reply to comment #20) > (In reply to comment #18) > > Any progress here? > > The last changes are here: 02-Nov > http://lletelier.fedorapeople.org/i4uc/ > > i wait next steps. Please include links to srpm/spec plus rpmlint output (must be a habit) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #23 from Larry Letelier 2011-11-14 12:58:32 EST --- (In reply to comment #22) > (In reply to comment #20) > > (In reply to comment #18) > > > Any progress here? > > > > The last changes are here: 02-Nov > > http://lletelier.fedorapeople.org/i4uc/ > > > > i wait next steps. > > Please include links to srpm/spec plus rpmlint output (must be a habit) Dear Guillermo, The rpmlint/srpm file was uploaded here: http://lletelier.fedorapeople.org/i4uc/ Thanks, --LL -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #24 from Guillermo Gómez 2011-11-14 14:11:42 EST --- I know the files are there (spec/srpm), however, if for any reason rpmlint outuput goes removed from such host, then there will be no evidence here about it. So just as a habit, please put here explicit links to both spec and srpm file and include here the rmplint output :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717502
--- Comment #25 from Guillermo Gómez 2011-11-14
14:25:00 EST ---
Specific:
[!] : MUST - Package contains a properly installed %{name}.desktop using
desktop-file-install file if it is a GUI application.
Please review: http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
It is not simply enough to just include the .desktop file in the package, one
MUST run desktop-file-install OR desktop-file-validate in %install (and have
BuildRequires: desktop-file-utils), to help ensure .desktop file safety and
spec-compliance.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 Larry Letelier changed: What|Removed |Added Flag||needinfo?(guillermo.gomez@g ||mail.com) --- Comment #26 from Larry Letelier 2012-02-24 10:46:50 EST --- Guillermo: Changes & updates: SPEC url: http://lletelier.fedorapeople.org/i4uc/i4uc.spec SRPM url: http://lletelier.fedorapeople.org/i4uc/i4uc-0.5.6-9.fc15.src.rpm RPM x86_64 url: http://lletelier.fedorapeople.org/i4uc/i4uc-0.5.6-9.fc15.x86_64.rpm rpmlint: http://lletelier.fedorapeople.org/i4uc/i4uc-0.5.6-9.fc15.x86_64.txt Thanks, --LL -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717502
Guillermo Gómez changed:
What|Removed |Added
Status|NEW |MODIFIED
Flag|needinfo?(guillermo.gomez@g |
|mail.com) |
--- Comment #27 from Guillermo Gómez 2012-02-26
08:05:27 EST ---
Please include rpmlint output for rpm binaries too in the future.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[!]: MUST Buildroot is not present
Note: Buildroot is not needed unless packager plans to package for EPEL5
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Package contains a properly installed %{name}.desktop using desktop-
file-install file if it is a GUI application.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST The spec file handles locales properly.
[ ]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint i4uc-0.5.6-9.fc16.x86_64.rpm
i4uc.x86_64: W: no-manual-page-for-binary i4uc-gtk
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
rpmlint i4uc-debuginfo-0.5.6-9.fc16.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint i4uc-0.5.6-9.fc16.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[!]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/gomix/rpmbuild/717502/i4uc-0.5.6.tar.bz2 :
MD5SUM this package : 44f9028a5779aea9aa729bd0b6f128cf
MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[!]: SHOULD Dist tag is present.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Spec use %global instead of %define.
Issues:
[!]: MUST Buildroot is not present (not blocking)
Note: Buildroot is not needed unless packager plans to package for EPEL5
[!]: MUST Rpmlint output is silent. (not blocking)
rpmlint i4uc-0.5.6-9.fc16.x86_64.rpm
i4uc.x86_64: W: no-manual-page-for-binary i4uc-gtk
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
rpmlint i4uc-debuginfo-0.5.6-9.fc16.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint i4uc-0.5.6-9.fc16.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[!]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 Guillermo Gómez changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #28 from Guillermo Gómez 2012-02-27 13:04:48 EST --- After some reviews with Larry, everything is clear to go, md5 issue was a problem in my latpop. This package (i4uc) is APPROVED by gomix -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 German Ruiz changed: What|Removed |Added CC||germa...@fedoraproject.org, ||larry.letel...@gmail.com Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717502
Volker Fröhlich changed:
What|Removed |Added
CC||volke...@gmx.at
--- Comment #1 from Volker Fröhlich 2011-06-29 01:58:04 EDT
---
Don't ship .la files. .so belong in a devel sub-package.
License is GPLv3+.
-n %{name}-%{version} is unnecessary.
Docs should be installed with the %doc macro in the files section.
Some BuildRequires are not needed, e.g. make (see packaging guidelines). I
guess the version requirements are unneeded too.
The version in the changelog entries are wrong.
Please check if all your files in %doc are useful. INSTALL is not.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 Guillermo Gómez changed: What|Removed |Added CC||guillermo.go...@gmail.com --- Comment #2 from Guillermo Gómez 2011-06-29 06:15:55 EDT --- Dont forget to include rpmlint output on your request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #3 from Guillermo Gómez 2011-06-29 06:51:17 EDT --- Im having rpaths issues: ERROR 0001: file '/usr/bin/i4uc-gtk' contains a standard rpath '/usr/lib64' in [/usr/lib64] Please fix it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #4 from Guillermo Gómez 2011-06-29 06:55:40 EDT --- I dont understand why the src.rpm has the arch in the name, im not able to reproduce with your spec and rpmbuild -bs . -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 Guillermo Gómez changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|guillermo.go...@gmail.com Flag||fedora-review? --- Comment #5 from Guillermo Gómez 2011-06-29 07:19:49 EDT --- I'll review, Toshio will sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #6 from German Ruiz 2011-06-30 00:16:52 EDT --- Here the files with the corrections... SPEC: http://lletelier.fedorapeople.org/i4uc/i4uc.spec SRPM: http://lletelier.fedorapeople.org/i4uc/i4uc-0.5.6-1.fc15.src.rpm RPM_F15_32bits: http://lletelier.fedorapeople.org/i4uc/i4uc-0.5.6-1.fc15.i686.rpm RPM_F15_64bits: http://lletelier.fedorapeople.org/i4uc/i4uc-0.5.6-1.fc15.x86_64.rpm rpmlint outputs: rpmlint -i SPECS/i4uc.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint -i RPMS/i686/i4uc-0.5.6-1.fc15.i686.rpm i4uc.i686: W: no-manual-page-for-binary i4uc-gtk Each executable in standard binary directories should have a man page. 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint -i SRPMS/i4uc-0.5.6-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -i SPECS/i4uc.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint -i SRPMS/i4uc-0.5.6-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -i RPMS/x86_64/i4uc-0.5.6-1.fc15.x86_64.rpm i4uc.x86_64: W: no-manual-page-for-binary i4uc-gtk Each executable in standard binary directories should have a man page. 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717502
--- Comment #7 from Guillermo Gómez 2011-06-30
06:48:32 EDT ---
Please increase your %realese with every change u make to your spec (or pile up
several changes in on release and make several changelog entries, i like the
more atomic approach)
Release: 1%{dist} < fix it please.
Your changelog actually is showing correct behaviour but release is wrong and
static. According your changelog, your release should be:
Release: 3%{dist}
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717502
--- Comment #8 from Guillermo Gómez 2011-06-30
07:04:20 EDT ---
U can also get rid of
%clean
make clean
rm -rf %{buildroot}
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717502
--- Comment #9 from Guillermo Gómez 2011-06-30
07:25:04 EDT ---
Please use macros in a consistent way:
rm -f $RPM_BUILD_ROOT/%{_docdir}/%{name}-%{version}/INSTALL
rm -rf %{buildroot}/%{_libdir}/%{name}/*.so
Choose between $RPM_BUILD_ROOT or %{buildroot}
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 Larry Letelier changed: What|Removed |Added Flag||needinfo? --- Comment #10 from Larry Letelier 2011-06-30 09:41:18 EDT --- All changes are done. The updates and new version of the files is in: http://lletelier.fedorapeople.org/i4uc/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #11 from Larry Letelier 2011-06-30 09:55:38 EDT --- All changes are done. The updates and new version of the files is in: http://lletelier.fedorapeople.org/i4uc/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 German Ruiz changed: What|Removed |Added Flag|needinfo? | --- Comment #12 from German Ruiz 2011-06-30 10:29:23 EDT --- Here the corrected SPEC file SPEC: http://lletelier.fedorapeople.org/i4uc/i4uc.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717502
--- Comment #13 from Guillermo Gómez 2011-07-04
23:23:50 EDT ---
%changelog release numbers are still wrong (all entries points to 0.5.6-1)
Release: 4%{dist}
...
%changelog
* Thu Jun 30 2011 lletelier - 0.5.6-1
- Fixed Release
- Sed RPM_BUILD_ROOT -> buildroot
- Clean, clean.
* Wed Jun 29 2011 lletelier - 0.5.6-1
- Fixed Licence GPLv3+
- Add doc macro section
- Remove .la static library
- Remove unnecessary entries
- Add i4uc.mo language file
* Mon Jun 27 2011 lletelier - 0.5.6-1
- Fixed docs
* Sun Jun 12 2011 germanrs - 0.5.6-1
- Initial package
Next time, fix old entries, bump the release and create a new changelog
(0.5.6-5)
Please post spec url, srpm url, and rpmlint outputs for the next time.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #14 from Larry Letelier 2011-07-05 10:33:42 EDT --- SPEC url: http://lletelier.fedorapeople.org/i4uc/i4uc.spec SRPM url: http://lletelier.fedorapeople.org/i4uc/i4uc-0.5.6-5.fc15.src.rpm rpmlint: http://lletelier.fedorapeople.org/i4uc/rpmlint_f15_0.5.6-5.txt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=717502
--- Comment #15 from Volker Fröhlich 2011-07-10 18:38:46 EDT
---
Please use the %doc macro instead of %{_docdir}/%{name}-%{version}/...!
You could also include THANKS.
I think the icon should go to %{_datadir}/pixmaps and the icon entry in the
desktop file should reflect that. Ideally, it should be stated as mentioned
here:
http://fedoraproject.org/wiki/Packaging:Guidelines#Icon_tag_in_Desktop_Files
Please change the permission of your spec file to 644.
mkdir -p %{buildroot}/%{_datadir}/locale/es/LC_MESSAGES -- Why that? You could
put in some comments.
"... for developing micro-controllers firmware" -- Shouldn't that be
"micro-controller"? Don't spell "Multiple" with a capital M in the description.
Descriptions normally end with a period.
You can drop the defattr line.
Since some of your BRs are not available in EPEL, you can remove:
- Build root definition
- rm -rf %{buildroot}
If you plan to get the missing dependencies into EPEL, please ignore that
suggestion.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #16 from German Ruiz 2011-07-11 13:37:15 EDT --- Larry Letelier is going to finish this package, so from now he is going to make all the changes and the ownership of the project. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #17 from Volker Fröhlich 2011-07-11 15:29:02 EDT --- He also needs a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #29 from Larry Letelier 2012-02-29 08:55:15 EST --- New Package SCM Request === Package Name: i4uc Short Description: Multiple platform IDE for developing micro-controller firmware Owners: lletelier Branches: f15 f16 f17 InitialCC: Lletelier Gomix -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 Larry Letelier changed: What|Removed |Added Flag|fedora-review+ | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #30 from Larry Letelier 2012-02-29 13:00:57 EST --- New Package SCM Request === Package Name: i4uc Short Description: Multiple platform IDE for developing micro-controller firmware Owners: lletelier Branches: f15 f16 f17 InitialCC: Lletelier Gomix -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 Guillermo Gómez changed: What|Removed |Added AssignedTo|guillermo.go...@gmail.com |nob...@fedoraproject.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 Dennis Gilmore changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 Larry Letelier changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|g...@xofica.cl Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #31 from Jon Ciesla 2012-03-02 12:21:46 EST --- Please include only valid FAS account names in InitialCC. gomix, please set fedora-review flag to +. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #32 from Larry Letelier 2012-03-02 12:31:02 EST --- New Package SCM Request === Package Name: i4uc Short Description: Multiple platform IDE for developing micro-controller firmware Owners: lletelier Branches: f15 f16 f17 InitialCC: Lletelier -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 Larry Letelier changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #33 from Jon Ciesla 2012-03-02 12:37:43 EST --- FAS usernames are case-sensitive, wait for review to be + before resetting cvs flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #34 from Larry Letelier 2012-03-02 12:47:23 EST --- New Package SCM Request === Package Name: i4uc Short Description: Multiple platform IDE for developing micro-controller firmware Owners: lletelier Branches: f15 f16 f17 InitialCC: lletelier -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 Dennis Gilmore changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 Dennis Gilmore changed: What|Removed |Added Flag||fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #35 from Jon Ciesla 2012-03-02 13:08:28 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #36 from Volker Fröhlich 2012-04-10 18:02:18 EDT --- Larry, I just saw, you haven't entered your builds into Bodhi yet. I also noticed there are no working builds for F17 and 18. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #37 from Volker Fröhlich 2012-04-10 18:17:49 EDT --- The problem seems to be in the pkgconfig file of new libgee. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #18 from Volker Fröhlich 2011-10-08 03:40:06 EDT --- Any progress here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #19 from Larry Letelier 2011-11-02 11:35:55 EDT --- i will doing the last changes and upload the new versions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #21 from Toshio Ernie Kuratomi 2011-11-02 13:49:07 EDT --- I'm willing to sponsor when the review is complete. Just let me know. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #20 from Larry Letelier 2011-11-02 13:46:59 EDT --- (In reply to comment #18) > Any progress here? The last changes are here: 02-Nov http://lletelier.fedorapeople.org/i4uc/ i wait next steps. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #40 from Volker Fröhlich --- I think you should either fix this package or it should be retired, so we can finally close this ticket. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aUcPER4RTU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=717502 Volker Fröhlich changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NOTABUG Flags|needinfo?(germanrs@fedorapr | |oject.org) | Last Closed||2013-04-26 10:49:26 --- Comment #41 from Volker Fröhlich --- No response, closing -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cjWFrWsBh1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 717502] Review Request: i4uc - IDE for developing micro-controllers firmware
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=717502 --- Comment #42 from Jason Tibbitts --- I retired and blocked the package. If anyone else wants to start this review process over, they'll need to remember to file the releng ticket to have the package unblocked. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1Z5b7Kr6MI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
