[Bug 741945] Review Request: python-isodate - An ISO 8601 date/time/duration parser and formater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741945 James Laska jla...@redhat.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #11 from James Laska jla...@redhat.com 2012-01-24 09:12:38 EST --- Package Change Request == Package Name: python-isodate New Branches: el6 f15 Owners: jlaska -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741945] Review Request: python-isodate - An ISO 8601 date/time/duration parser and formater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741945 --- Comment #12 from Jon Ciesla limburg...@gmail.com 2012-01-24 09:16:08 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741945] Review Request: python-isodate - An ISO 8601 date/time/duration parser and formater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741945 Mo Morsi mmo...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||CURRENTRELEASE Last Closed||2011-12-08 07:44:59 --- Comment #10 from Mo Morsi mmo...@redhat.com 2011-12-08 07:44:59 EST --- Closing this out as this is now in Fedora -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741945] Review Request: python-isodate - An ISO 8601 date/time/duration parser and formater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741945 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-10-09 15:39:37 EDT --- python-isodate-0.4.4-1.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741945] Review Request: python-isodate - An ISO 8601 date/time/duration parser and formater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741945 James Laska jla...@redhat.com changed: What|Removed |Added Blocks||743402 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741945] Review Request: python-isodate - An ISO 8601 date/time/duration parser and formater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741945 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2011-10-04 15:46:31 EDT --- python-isodate-0.4.4-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/FEDORA-2011-13548 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741945] Review Request: python-isodate - An ISO 8601 date/time/duration parser and formater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741945 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741945] Review Request: python-isodate - An ISO 8601 date/time/duration parser and formater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741945 James Laska jla...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mmo...@redhat.com Flag||needinfo?(mmo...@redhat.com ||) --- Comment #4 from James Laska jla...@redhat.com 2011-09-30 08:21:17 EDT --- Mo: anyone else you can think of who would like to be an owner/cc of this package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741945] Review Request: python-isodate - An ISO 8601 date/time/duration parser and formater
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=741945
--- Comment #3 from James Laska jla...@redhat.com 2011-09-30 08:19:54 EDT ---
(In reply to comment #2)
Overall looks good, koji build is green
Thanks for the review!
http://koji.fedoraproject.org/koji/taskinfo?taskID=3388155
A few nits
* BuildRoot is no longer needed and should be removed
Thanks, removed. I also replaced the use of $RPM_OPT_FLAGS with %{optflags}
for consistent macro use.
* same w/ the rm buildroot in the install and clean sections
Looks like that isn't required for F13 and newer. I'll probably leave this for
EL6 packages, unless I can confirm that it's no longer needed there either.
* Do we still need the exceptions for the older non-supported Fedora versions?
I see these in the python guidelines though so if they are required you can
just ignore this note
I left them mainly for EL5 or EL6 compat. I could be pedantic, and they're
just not needed anymore. I'll try to confirm.
* is python-devel required as a build time dependency (again see this in the
python guideliness, but this is my first python package review so I could be
mistaken)
Excellent catch. Normally, yes. The package python-devel provides the
distutils library which is needed by many python packages that 'import
distutils' from inside their setup.py. In the case of isodate, it's doing
'from setuptools import setup'. For that, I've added a BuildRequires:
python-setuptools.
*BUT*, I missed that I'm relying on distutils for the %{python_sitelib} macro.
So it is needed. Thanks!
From what I can tell, everything else looks good, so APPROVED
Thanks again. I updated the .spec and src.rpm posted from comment#0, and will
request SCM shortly.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741945] Review Request: python-isodate - An ISO 8601 date/time/duration parser and formater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741945 Mo Morsi mmo...@redhat.com changed: What|Removed |Added Flag|needinfo?(mmo...@redhat.com | |) | --- Comment #5 from Mo Morsi mmo...@redhat.com 2011-09-30 08:27:34 EDT --- Hrm not sure, since its a pulp dependency and not an aeolus one,probably don't have the cycles to take it on my plate. Perhaps ping'ing one of the pulp guys/gals? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741945] Review Request: python-isodate - An ISO 8601 date/time/duration parser and formater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741945 James Laska jla...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from James Laska jla...@redhat.com 2011-09-30 08:56:38 EDT --- New Package SCM Request === Package Name: python-isodate Short Description: An ISO 8601 date/time/duration parser and formater Owners: jlaska jmatthews Branches: f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741945] Review Request: python-isodate - An ISO 8601 date/time/duration parser and formater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741945 --- Comment #7 from Jon Ciesla l...@jcomserv.net 2011-09-30 09:27:38 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741945] Review Request: python-isodate - An ISO 8601 date/time/duration parser and formater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741945 Mo Morsi mmo...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mmo...@redhat.com Flag||fedora-review? --- Comment #1 from Mo Morsi mmo...@redhat.com 2011-09-29 10:26:26 EDT --- Taking this one -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 741945] Review Request: python-isodate - An ISO 8601 date/time/duration parser and formater
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=741945 Mo Morsi mmo...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #2 from Mo Morsi mmo...@redhat.com 2011-09-29 10:31:02 EDT --- Overall looks good, koji build is green http://koji.fedoraproject.org/koji/taskinfo?taskID=3388155 A few nits * BuildRoot is no longer needed and should be removed * same w/ the rm buildroot in the install and clean sections * Do we still need the exceptions for the older non-supported Fedora versions? I see these in the python guidelienss though so if they are required you can just ignore this note * is python-devel required as a build time dependency (again see this in the python guideliness, but this is my first python package review so I could be mistaken) From what I can tell, everything else looks good, so APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
