[Bug 742543] Review Request: perl-HTML-FormHandler - HTML forms using Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742543 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-HTML-FormHandler-0.350 ||03-2.fc15 Resolution||ERRATA Last Closed||2011-10-12 20:49:07 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2011-10-12 20:49:07 EDT --- perl-HTML-FormHandler-0.35003-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742543] Review Request: perl-HTML-FormHandler - HTML forms using Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742543 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|perl-HTML-FormHandler-0.350 |perl-HTML-FormHandler-0.350 |03-2.fc15 |03-2.fc16 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-10-13 00:36:11 EDT --- perl-HTML-FormHandler-0.35003-2.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742543] Review Request: perl-HTML-FormHandler - HTML forms using Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742543 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2011-10-04 16:48:16 EDT --- perl-HTML-FormHandler-0.35003-2.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742543] Review Request: perl-HTML-FormHandler - HTML forms using Moose
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=742543
Mario Blättermann mari...@freenet.de changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #6 from Mario Blättermann mari...@freenet.de 2011-10-03 13:39:23
EDT ---
(In reply to comment #5)
[...]
Means, we should skip rpmlint's blurb here? The output is similar to the one
before:
Yes. Upstream has deliberately hidden these modules which unfortunately, also
hides them from rpm's automatic dependency generator. They need to be
explicitly provided, but there is no version number.
OK, I'm convinced ;) After all, we speak about warnings, not about critical
errors.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPL+ or Artistic
[+] MUST: The License field in the package spec file must match the actual
license.
[.] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum *
ea8d91d19fb1871f6c0304a3b9f365b3 HTML-FormHandler-0.35003.tar.gz
ea8d91d19fb1871f6c0304a3b9f365b3 HTML-FormHandler-0.35003.tar.gz.packaged
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- Succesful Koji build available.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
I assume the packager has tested it. Don't know how to test it on my
system.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[+] SHOULD: Your package should contain man pages for binaries/scripts.
PACKAGE APPROVED
--
Configure bugmail:
[Bug 742543] Review Request: perl-HTML-FormHandler - HTML forms using Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742543 --- Comment #7 from Iain Arnell iarn...@gmail.com 2011-10-03 15:55:33 EDT --- New Package SCM Request === Package Name: perl-HTML-FormHandler Short Description: HTML forms using Moose Owners: iarnell Branches: f15 f16 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742543] Review Request: perl-HTML-FormHandler - HTML forms using Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742543 Iain Arnell iarn...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742543] Review Request: perl-HTML-FormHandler - HTML forms using Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742543 --- Comment #8 from Jon Ciesla l...@jcomserv.net 2011-10-03 16:00:37 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742543] Review Request: perl-HTML-FormHandler - HTML forms using Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742543 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2011-10-03 23:13:22 EDT --- perl-HTML-FormHandler-0.35003-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-HTML-FormHandler-0.35003-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742543] Review Request: perl-HTML-FormHandler - HTML forms using Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742543 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2011-10-03 23:13:31 EDT --- perl-HTML-FormHandler-0.35003-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-HTML-FormHandler-0.35003-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742543] Review Request: perl-HTML-FormHandler - HTML forms using Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742543 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742543] Review Request: perl-HTML-FormHandler - HTML forms using Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742543 Iain Arnell iarn...@gmail.com changed: What|Removed |Added Blocks||742560 Mario Blättermann mari...@freenet.de changed: What|Removed |Added CC||mari...@freenet.de --- Comment #1 from Mario Blättermann mari...@freenet.de 2011-10-02 11:20:56 EDT --- $ rpmlint -i -v *perl-HTML-FormHandler.noarch: I: checking perl-HTML-FormHandler.noarch: I: checking-url http://search.cpan.org/dist/HTML-FormHandler/ (timeout 10 seconds) perl-HTML-FormHandler.noarch: E: useless-provides perl(HTML::FormHandler::Field::Compound) This package provides 2 times the same capacity. It should only provide it once. perl-HTML-FormHandler.src: I: checking perl-HTML-FormHandler.src: I: checking-url http://search.cpan.org/dist/HTML-FormHandler/ (timeout 10 seconds) perl-HTML-FormHandler.src:44: W: unversioned-explicit-provides perl(HTML::FormHandler::Field::Compound) The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. perl-HTML-FormHandler.src:45: W: unversioned-explicit-provides perl(HTML::FormHandler::Meta::Role) The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. perl-HTML-FormHandler.src:47: W: unversioned-explicit-provides perl(HTML::FormHandler::Params) The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. perl-HTML-FormHandler.src: I: checking-url http://www.cpan.org/authors/id/G/GS/GSHANK/HTML-FormHandler-0.35003.tar.gz (timeout 10 seconds) perl-HTML-FormHandler.spec:44: W: unversioned-explicit-provides perl(HTML::FormHandler::Field::Compound) The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. perl-HTML-FormHandler.spec:45: W: unversioned-explicit-provides perl(HTML::FormHandler::Meta::Role) The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. perl-HTML-FormHandler.spec:47: W: unversioned-explicit-provides perl(HTML::FormHandler::Params) The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. perl-HTML-FormHandler.spec: I: checking-url http://www.cpan.org/authors/id/G/GS/GSHANK/HTML-FormHandler-0.35003.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 1 errors, 6 warnings. Seems to be that rpmlint wants to have explicit versioning of the Provides entries. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742543] Review Request: perl-HTML-FormHandler - HTML forms using Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742543 --- Comment #2 from Iain Arnell iarn...@gmail.com 2011-10-02 11:44:49 EDT --- (In reply to comment #1) $ rpmlint -i -v *perl-HTML-FormHandler.noarch: I: checking perl-HTML-FormHandler.noarch: I: checking-url http://search.cpan.org/dist/HTML-FormHandler/ (timeout 10 seconds) perl-HTML-FormHandler.noarch: E: useless-provides perl(HTML::FormHandler::Field::Compound) This package provides 2 times the same capacity. It should only provide it once. Good call. This should be an explicit Provides: perl(HTML::FormHandler::Field::Repeatable::Instance) I must have copy/pasted the wrong line somehow. Update coming [big snip] Seems to be that rpmlint wants to have explicit versioning of the Provides entries. Yes. and I understand why. But rpmlint /doesn't/ complain about all the automatically detected unversioned provides (this package has ~70). The explicit provides are consistent with those automatically detected, and necessary since other packages may depend on them. Versioning them would be a lie since upstream hasn't given them explicit version (and where upstream has versioned specific packages, the version numbers bear no relation to the overall version of the distribution itself). (And as an aside, thanks as ever for the reviews. I'm busy trying to update cweyl's packages at the minute, but will try to return the favour). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742543] Review Request: perl-HTML-FormHandler - HTML forms using Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742543 --- Comment #3 from Iain Arnell iarn...@gmail.com 2011-10-02 11:55:42 EDT --- Spec URL: http://fedorapeople.org/~iarnell/review/perl-HTML-FormHandler.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-HTML-FormHandler-0.35003-2.fc15.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3397209 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742543] Review Request: perl-HTML-FormHandler - HTML forms using Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742543 Mario Blättermann mari...@freenet.de changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mari...@freenet.de Flag||fedora-review? --- Comment #4 from Mario Blättermann mari...@freenet.de 2011-10-02 12:23:36 EDT --- (In reply to comment #2) Yes. and I understand why. But rpmlint /doesn't/ complain about all the automatically detected unversioned provides (this package has ~70). The explicit provides are consistent with those automatically detected, and necessary since other packages may depend on them. Versioning them would be a lie since upstream hasn't given them explicit version (and where upstream has versioned specific packages, the version numbers bear no relation to the overall version of the distribution itself). Means, we should skip rpmlint's blurb here? The output is similar to the one before: $ rpmlint -i -v *perl-HTML-FormHandler.src: I: checking perl-HTML-FormHandler.src: I: checking-url http://search.cpan.org/dist/HTML-FormHandler/ (timeout 10 seconds) perl-HTML-FormHandler.src:44: W: unversioned-explicit-provides perl(HTML::FormHandler::Meta::Role) The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. perl-HTML-FormHandler.src:46: W: unversioned-explicit-provides perl(HTML::FormHandler::Params) The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. perl-HTML-FormHandler.src:47: W: unversioned-explicit-provides perl(HTML::FormHandler::Field::Repeatable::Instance) The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. perl-HTML-FormHandler.src: I: checking-url http://www.cpan.org/authors/id/G/GS/GSHANK/HTML-FormHandler-0.35003.tar.gz (timeout 10 seconds) perl-HTML-FormHandler.noarch: I: checking perl-HTML-FormHandler.noarch: I: checking-url http://search.cpan.org/dist/HTML-FormHandler/ (timeout 10 seconds) perl-HTML-FormHandler.spec:44: W: unversioned-explicit-provides perl(HTML::FormHandler::Meta::Role) The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. perl-HTML-FormHandler.spec:46: W: unversioned-explicit-provides perl(HTML::FormHandler::Params) The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. perl-HTML-FormHandler.spec:47: W: unversioned-explicit-provides perl(HTML::FormHandler::Field::Repeatable::Instance) The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible. perl-HTML-FormHandler.spec: I: checking-url http://www.cpan.org/authors/id/G/GS/GSHANK/HTML-FormHandler-0.35003.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 6 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 742543] Review Request: perl-HTML-FormHandler - HTML forms using Moose
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742543 --- Comment #5 from Iain Arnell iarn...@gmail.com 2011-10-02 23:09:52 EDT --- (In reply to comment #4) (In reply to comment #2) Yes. and I understand why. But rpmlint /doesn't/ complain about all the automatically detected unversioned provides (this package has ~70). The explicit provides are consistent with those automatically detected, and necessary since other packages may depend on them. Versioning them would be a lie since upstream hasn't given them explicit version (and where upstream has versioned specific packages, the version numbers bear no relation to the overall version of the distribution itself). Means, we should skip rpmlint's blurb here? The output is similar to the one before: Yes. Upstream has deliberately hidden these modules which unfortunately, also hides them from rpm's automatic dependency generator. They need to be explicitly provided, but there is no version number. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
