[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #1 from Adam Huffman 2011-12-02 15:08:10 EST --- I will review this package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Adam Huffman changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Adam Huffman changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Adam Huffman changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|bl...@verdurin.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Matthias Clasen changed: What|Removed |Added CC||mcla...@redhat.com --- Comment #2 from Matthias Clasen 2011-12-21 08:39:30 EST --- Adam, will you get to this soon ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #3 from Adam Huffman 2011-12-21 08:50:43 EST --- Yes, sorry for the delay - hoping to review properly on Friday. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #4 from Daniel Berrange 2011-12-21 09:30:46 EST --- Updated to 0.0.4 release, specfile in same location as before : http://berrange.fedorapeople.org/review/libosinfo/libosinfo-0.0.4-1.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Christophe Fergeau changed: What|Removed |Added Blocks||770152 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756772
--- Comment #5 from Adam Huffman 2011-12-23 11:54:29 EST
---
I'll add my own comments separately. Below is the output of fedora-review:
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[ ]: MUST Package does not contain kernel modules.
[ ]: MUST Package contains no static executables.
[ ]: MUST Rpath absent or only used for internal libs.
[ ]: MUST Package is not relocatable.
[x]: MUST Development .so files in -devel subpackage, if present.
Generic
[ ]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[!]: MUST Buildroot is not present
Note: Buildroot is not needed unless packager plans to package for EPEL5
[ ]: MUST Package contains no bundled libraries.
[ ]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[ ]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
Note: defattr() present in %files devel section. This is OK if
packaging for EPEL5. Otherwise not needed
[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
[ ]: MUST Package requires other packages for directories it uses.
[ ]: MUST Package uses nothing in %doc for runtime.
[ ]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[!]: MUST Spec file lacks Packager, Vendor, PreReq tags.
Note: Found : Packager: Adam Huffman
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[ ]: MUST License field in the package spec file matches the actual license.
[ ]: MUST License file installed when any subpackage combination is installed.
[ ]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[ ]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[ ]: MUST Package does not generates any conflict.
[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
[ ]: MUST Package must own all directories that it creates.
[ ]: MUST Package does not own files or directories owned by other packages.
[ ]: MUST Package installs properly.
[!]: MUST Package requires pkgconfig, if .pc files are present. (EPEL5)
Note: Only applicable for EL-5
[ ]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint libosinfo-devel-0.0.4-1.fc17.x86_64.rpm
libosinfo-devel.x86_64: W: spelling-error %description -l en_US virtualization
-> visualization, actualization, vitalization
libosinfo-devel.x86_64: W: spelling-error %description -l en_US hypervisor ->
hyper visor, hyper-visor, supervisory
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint libosinfo-0.0.4-1.fc17.src.rpm
libosinfo.src: W: spelling-error Summary(en_US) virtualization ->
visualization, actualization, vitalization
libosinfo.src: W: spelling-error %description -l en_US virtualization ->
visualization, actualization, vitalization
libosinfo.src: W: spelling-error %description -l en_US hypervisor -> hyper
visor, hyper-visor, supervisory
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
rpmlint libosinfo-debuginfo-0.0.4-1.fc17.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint libosinfo-0.0.4-1.fc17.x86_64.rpm
libosinfo.x86_64: W: spelling-error Summary(en_US) virtualization ->
visualization, actualization, vitalization
libosinfo.x86_64: W: spelling-error %description -l en_US virtualization ->
visualization, actualization, vitalization
libosinfo.x86_64: W: spelling-error %description -l en_US hypervisor -> hyper
visor, hyper-visor, supervisory
libosinfo.x86_64: W: no-manual-page-for-binary osinfo-usbids-convert
libosinfo.x86_64: W: no-manual-page-for-binary osinfo-detect
libosinfo.x86_64: W: no-manual-page-for-binary osinfo-pciids-conve
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #6 from Adam Huffman 2011-12-23 12:02:28 EST --- 1. Could you explain the extra_release tag, that doesn't seem to be referred to elsewhere in the spec? 2. Most of the rpmlint errors are just spelling and can be ignored. However, it would be nice to have manpages or other documentation - not that this is a reason to hold up the package. 3. I'm assuming it depends upon too many new things to be suitable for EPEL5, so those warnings can be ignored. 4. Could those %define statements be %global instead? I've been led to believe %global is preferred now: http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #7 from Daniel Berrange 2012-01-03 07:15:17 EST --- 1. The 'extra_release' tag enables creation of easy one-off test builds with unique nevr. This is common across most virt related RPMs in Fedora. 2. manpages are an RFE for a future upstream release 3. Yes, this isn't even suitable for EPEL6, due to requirement for gobject introspection support 4. Yes, we can likely use %global with no illeffects -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #8 from Daniel Berrange 2012-01-03 09:57:38 EST --- On closer examination I just removed the global macros, since there is no value in being able to disable introspection, and attempting to disable it would break the build of the -vala sub-RPM anyway. Updated SPEC file at same URL as before http://berrange.fedorapeople.org/review/libosinfo/libosinfo-0.0.4-2.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #9 from Adam Huffman 2012-01-04 06:28:10 EST --- Looks okay now, though I think it's a little odd that you have the directory /usr/share/gtk-doc/html/Libosinfo/, when everything else uses the name in all lower-case. Is that deliberate? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #10 from Daniel Berrange 2012-01-04 06:41:40 EST --- That docs naming is just what the upstream Makefile produces. I'll re-examine it for a future upstream release. BTW, If you consider this approved, could you twiddle the fedora-review=+ flag on the BZ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Adam Huffman changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #11 from Adam Huffman 2012-01-04 06:58:34 EST --- Just wanted to clarify that point first. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Daniel Berrange changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Daniel Berrange 2012-01-04 07:37:28 EST --- New Package SCM Request === Package Name: libosinfo Short Description: A library for managing OS information for virtualization Owners: berrange Branches: f15 f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #13 from Jon Ciesla 2012-01-04 08:40:20 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #14 from Fedora Update System 2012-01-04 09:59:42 EST --- libosinfo-0.0.4-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/libosinfo-0.0.4-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #16 from Daniel Berrange 2012-01-04 10:02:24 EST --- Built into rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 --- Comment #15 from Fedora Update System 2012-01-04 10:00:31 EST --- libosinfo-0.0.4-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libosinfo-0.0.4-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Daniel Berrange changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||RAWHIDE Last Closed||2012-01-04 10:02:39 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Fedora Update System changed: What|Removed |Added Fixed In Version||libosinfo-0.0.4-2.fc15 Resolution|RAWHIDE |ERRATA --- Comment #17 from Fedora Update System 2012-01-16 16:25:50 EST --- libosinfo-0.0.4-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 756772] Review Request: libosinfo - A library for managing OS information for virtualization
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756772 Fedora Update System changed: What|Removed |Added Fixed In Version|libosinfo-0.0.4-2.fc15 |libosinfo-0.0.4-2.fc16 --- Comment #18 from Fedora Update System 2012-01-16 16:27:08 EST --- libosinfo-0.0.4-2.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
