[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
https://bugzilla.redhat.com/show_bug.cgi?id=789055 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-07-15 17:25:16 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- japa-0.6.0-3.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
https://bugzilla.redhat.com/show_bug.cgi?id=789055 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- japa-0.6.0-3.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
https://bugzilla.redhat.com/show_bug.cgi?id=789055 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- japa-0.6.0-3.fc16 has been pushed to the Fedora 16 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
https://bugzilla.redhat.com/show_bug.cgi?id=789055 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Brendan Jones brendan.jones...@gmail.com --- New Package SCM Request === Package Name: japa Short Description: JACK and ALSA Perceptual Analyser Owners: bsjones Branches: f16 f17 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
https://bugzilla.redhat.com/show_bug.cgi?id=789055 Richard Shaw hobbes1...@gmail.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|hobbes1...@gmail.com --- Comment #8 from Richard Shaw hobbes1...@gmail.com --- (In reply to comment #7) Richard, please take ownership of review BZs. Thanks! Whoops! Fixed. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
https://bugzilla.redhat.com/show_bug.cgi?id=789055 --- Comment #9 from Brendan Jones brendan.jones...@gmail.com --- Thanks for the review Richard. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
https://bugzilla.redhat.com/show_bug.cgi?id=789055 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
https://bugzilla.redhat.com/show_bug.cgi?id=789055 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- japa-0.6.0-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/japa-0.6.0-3.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
https://bugzilla.redhat.com/show_bug.cgi?id=789055 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- japa-0.6.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/japa-0.6.0-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789055 Richard Shaw hobbes1...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Richard Shaw hobbes1...@gmail.com 2012-04-20 15:25:59 EDT --- +: OK -: must be fixed =: should be fixed (at your discretion) ?: Question or clairification needed N: not applicable MUST: [+] rpmlint output: shown in comment. [+] follows package naming guidelines [+] spec file base name matches package name [+] package meets the packaging guidelines [+] package uses a Fedora approved license: GPLv2+ [+] license field matches the actual license. [+] license file is included in %doc: COPYING [+] spec file is in American English [+] spec file is legible [+] sources match upstream: md5sum matches (ed7d752924bfecdb76786bcbde223bc8) [+] package builds on at least one primary arch: Tested F16/rawhide x86_64 [N] appropriate use of ExcludeArch [+] all build requirements in BuildRequires [N] spec file handles locales properly [N] ldconfig in %post and %postun [+] no bundled copies of system libraries [+] no relocatable packages [+] package owns all directories that it creates [+] no files listed twice in %files [+] proper permissions on files [+] consistent use of macros [+] code or permissible content [N] large documentation in -doc [+] no runtime dependencies in %doc [N] header files in -devel [N] static libraries in -static [N] .so in -devel [N] -devel requires main package [+] package contains no libtool archives [+] package contains a desktop file, uses desktop-file-install/validate [+] package does not own files/dirs owned by other packages [+] all filenames in UTF-8 SHOULD: [+] query upstream for license text [N] description and summary contains available translations [+] package builds in mock [+] package builds on all supported arches: Tested x86_64 [?] package functions as described: Not tested [+] sane scriptlets [N] subpackages require the main package [N] placement of pkgconfig files [+] file dependencies versus package dependencies [N] package contains man pages for binaries/scripts The two problems in comment 4 should be taken care of but they're not blockers. *** APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789055 Richard Shaw hobbes1...@gmail.com changed: What|Removed |Added CC||hobbes1...@gmail.com --- Comment #2 from Richard Shaw hobbes1...@gmail.com 2012-04-19 10:00:24 EDT --- Looks like the links are bad... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789055 --- Comment #3 from Brendan Jones brendan.jones...@gmail.com 2012-04-19 10:06:00 EDT --- Sorry, good now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789055 Richard Shaw hobbes1...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-review? --- Comment #4 from Richard Shaw hobbes1...@gmail.com 2012-04-19 14:14:20 EDT --- Spec looks good and it did build for rawhide for me in mock. Rpmlint produces some output, largely FSF address related: japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/rngen.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/audio.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/messages.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/styles.cc japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/gobjects.cc japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/analyser.cc japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/analyser.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/gobjects.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/audio.cc japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/prbsgen.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/mainwin.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/mainwin.cc japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/japa.cc japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/styles.h japa-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/japa-0.6.0/rngen.cc Those should be reported upstream... Also, desktop-file-install complains a little but fixes the problem. This should probably be reported upstream as well: + desktop-file-install --dir /builddir/build/BUILDROOT/japa-0.6.0-2.fc18.x86_64/usr/share/applications /builddir/build/SOURCES/japa.desktop /builddir/build/SOURCES/japa.desktop: warning: key Categories is a list and does not have a semicolon as trailing character, fixing I'll start the formal review as soon as I get a little time. For now, back to work for me! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789055 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Blocks||805236(FedoraAudio) Depends on|805236(FedoraAudio) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789055 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Depends on||805236(FedoraAudio) Bug 789055 depends on bug 788718, which changed state. Bug 788718 Summary: Review Request: clalsadrv - An ALSA driver C++ library https://bugzilla.redhat.com/show_bug.cgi?id=788718 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789055 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Depends on||788718 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789055] Review Request: japa - JACK and ALSA Perceptual Analyser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789055 --- Comment #1 from Brendan Jones brendan.jones...@gmail.com 2012-02-09 11:42:17 EST --- This also depends on clalsadrv, currently on the review list here (bug 788718.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
