[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840253 Matt Spaulding mspauldin...@gmail.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-03-02 11:26:36 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Nz0NdRgWZLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- fourterm-1.0.6-1.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 --- Comment #13 from Lukas Zapletal l...@redhat.com --- Ok finally made upstream changes, 1.0.6 is going in the wild. Many thanks Matt with this! http://koji.fedoraproject.org/koji/taskinfo?taskID=4363456 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- fourterm-1.0.6-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fourterm-1.0.6-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- fourterm-1.0.6-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fourterm-1.0.6-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 --- Comment #12 from Lukas Zapletal l...@redhat.com --- Sorry for the delay, I want to implement one latest feature before sending this in the wild. I hope this week before my PTO :-) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 Matt Spaulding mspauldin...@gmail.com changed: What|Removed |Added Whiteboard|NotReady| --- Comment #11 from Matt Spaulding mspauldin...@gmail.com --- Removed NotReady from the whiteboard. I don't think there's any reason for it now. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 Matt Spaulding mspauldin...@gmail.com changed: What|Removed |Added Component|pachi |Package Review Assignee|mspauldin...@gmail.com |nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 Matt Spaulding mspauldin...@gmail.com changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 Matt Spaulding mspauldin...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Matt Spaulding mspauldin...@gmail.com --- Thanks for fixing issues. Everything looks good to me. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 Lukas Zapletal l...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Lukas Zapletal l...@redhat.com --- Thank you again. New Package SCM Request === Package Name: fourterm Short Description: Lightweight split-screen terminal emulator with vim key mappings Owners: lzap Branches: f16 f17 el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). Matt, don't forget to take ownership of review BZs. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 Matt Spaulding mspauldin...@gmail.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|mspauldin...@gmail.com --- Comment #10 from Matt Spaulding mspauldin...@gmail.com --- Hey Jon, sorry bout that. I'm assigned now :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 Lukas Zapletal l...@redhat.com changed: What|Removed |Added CC||hdego...@redhat.com Component|Package Review |pachi Flags|fedora-review? | --- Comment #6 from Lukas Zapletal l...@redhat.com --- Corrected all five issues. Plus I have brand new release.sh script that prevents from forgetting to upload the tarball :-) http://lzap.fedorapeople.org/fedora-packaging/fourterm/1.0.6/fourterm.spec http://lzap.fedorapeople.org/projects/fourterm/releases/fourterm-1.0.6-1.fc16.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=4269110 Thank you for your review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253
Matt Spaulding mspauldin...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|mspauldin...@gmail.com
Flags||fedora-review?
--- Comment #5 from Matt Spaulding mspauldin...@gmail.com ---
Below is my package review. Please correct items listed under Issues and that
should be good.
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines.
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: Fedora 17 and Rawhide on x86_64
[x] Rpmlint output:
fourterm.spec:13: W: macro-in-comment %{_tmppath}
fourterm.spec:13: W: macro-in-comment %{name}
fourterm.spec:13: W: macro-in-comment %{version}
fourterm.spec:13: W: macro-in-comment %{release}
fourterm.spec:13: W: macro-in-comment %{__id_u}
fourterm.spec:45: W: macro-in-comment %{__rm}
fourterm.spec:73: W: macro-in-comment %{__rm}
fourterm.spec: W: invalid-url Source0:
http://lzap.fedorapeople.org/projects/fourterm/releases/fourterm-1.0.5.tar.gz
HTTP Error 404: Not Found
fourterm.x86_64: W: no-manual-page-for-binary fourterm
fourterm.x86_64: W: install-file-in-docs /usr/share/doc/fourterm-1.0.5/INSTALL
fourterm.src:11: W: macro-in-comment %{_tmppath}
fourterm.src:11: W: macro-in-comment %{name}
fourterm.src:11: W: macro-in-comment %{version}
fourterm.src:11: W: macro-in-comment %{release}
fourterm.src:11: W: macro-in-comment %{__id_u}
fourterm.src:43: W: macro-in-comment %{__rm}
fourterm.src:71: W: macro-in-comment %{__rm}
fourterm.src: W: invalid-url Source0:
http://lzap.fedorapeople.org/projects/fourterm/releases/fourterm-1.0.5.tar.gz
HTTP Error 404: Not Found
2 packages and 1 specfiles checked; 0 errors, 18 warnings.
[x] Package is not relocatable.
[x] Buildroot is not set.
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPLv3+
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[!] Sources used to build the package matches the upstream source, as provided
in the spec URL.
[x] Package is not known to require ExcludeArch, OR:
[!] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[-] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package does not have %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[x] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[!] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: Fedora 17 and rawhide on x86_64
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on: x86_64
[x] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files are correct.
[-] File based requires are sane.
=== Issues ===
1. Like you mention, the Requires for libgee and glib2 are not necessary.
Please remove them.
2. Debuginfo packages cannot be generated for Vala code. Please disable the
debug
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 --- Comment #3 from Lukáš Zapletal l...@redhat.com --- Ah I can see it too: http://kojipkgs.fedoraproject.org//work/tasks/1534/4241534/build.log Looks like Rawhide issue, will investigate and poke you. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253
--- Comment #4 from Lukáš Zapletal l...@redhat.com ---
Matt, thanks for your report. Now this is fixed - rawhide (maybe F17 too) use
different builder tool (waf) which slightly changed some options for vala. I
fixed this.
Please note version was changed upstream - I bumped version number thus.
http://lzap.fedorapeople.org/fedora-packaging/fourterm/1.0.5/fourterm.spec
http://lzap.fedorapeople.org/fedora-packaging/fourterm/1.0.5/fourterm-1.0.5-1.fc16.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=4242234
$ rpmlint *rpm
fourterm-debuginfo.x86_64: E: empty-debuginfo-package
fourterm.src:11: W: macro-in-comment %{_tmppath}
fourterm.src:11: W: macro-in-comment %{name}
fourterm.src:11: W: macro-in-comment %{version}
fourterm.src:11: W: macro-in-comment %{release}
fourterm.src:11: W: macro-in-comment %{__id_u}
fourterm.src:43: W: macro-in-comment %{__rm}
fourterm.src:71: W: macro-in-comment %{__rm}
fourterm.x86_64: E: explicit-lib-dependency glib2
fourterm.x86_64: E: explicit-lib-dependency libgee
fourterm.x86_64: W: no-manual-page-for-binary fourterm
fourterm.x86_64: W: install-file-in-docs /usr/share/doc/fourterm-1.0.4/INSTALL
3 packages and 0 specfiles checked; 3 errors, 9 warnings.
I guess libgee and glib2 should be removed (?) from Requires section?
I can write the man page if needed, not sure if this is needed for program that
does no support any option.
I can remove the install file.
I don't know if the empty debuginfo is an issue.
Thanks for help.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 --- Comment #1 from Lukáš Zapletal l...@redhat.com --- More info and screenshot here: https://github.com/lzap/fourterm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840253] Review Request: fourterm - Lightweight split-screen terminal emulator with vim key mappings
https://bugzilla.redhat.com/show_bug.cgi?id=840253 Matt Spaulding mspauldin...@gmail.com changed: What|Removed |Added CC||mspauldin...@gmail.com Whiteboard||NotReady --- Comment #2 from Matt Spaulding mspauldin...@gmail.com --- Hi Lukáš, I tried to build your package with rawhide x86_64 mock environment and it failed. When you get that fixed I'll do a formal review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
