[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845107 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|ERRATA |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SAZKIzpR08a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #31 from Fedora Update System upda...@fedoraproject.org --- rubygem-openshift-origin-msg-broker-mcollective-1.1.6-2.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z7xLrcaE1ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #30 from Fedora Update System upda...@fedoraproject.org --- rubygem-openshift-origin-msg-broker-mcollective-1.1.6-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-openshift-origin-msg-broker-mcollective-1.1.6-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #29 from Fedora Update System upda...@fedoraproject.org --- rubygem-openshift-origin-msg-broker-mcollective-1.0.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-openshift-origin-msg-broker-mcollective-1.0.1-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-09-27 01:08:20 --- Comment #28 from Fedora Update System upda...@fedoraproject.org --- rubygem-openshift-origin-msg-broker-mcollective-0.1.1-9.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 David Nalley da...@gnsa.us changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #21 from David Nalley da...@gnsa.us --- Adam: Sorry for the lag (and thanks for pinging me on the issue) This looks good now. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 Adam Miller admil...@redhat.com changed: What|Removed |Added Flags|fedora-review+ | Flags||fedora-review? --- Comment #22 from Adam Miller admil...@redhat.com --- New Package SCM Request === Package Name: rubygem-openshift-origin-msg-broker-mcollective Short Description: OpenShift Origin plugin for mcollective Owners: maxamillion tdawson brenton Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 Adam Miller maxamill...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #23 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added CC||limburg...@gmail.com Flags|fedora-review? | Flags||fedora-review+ --- Comment #24 from Jon Ciesla limburg...@gmail.com --- Fixed review flag. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #25 from Fedora Update System upda...@fedoraproject.org --- rubygem-openshift-origin-msg-broker-mcollective-0.1.1-9.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-openshift-origin-msg-broker-mcollective-0.1.1-9.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #26 from Fedora Update System upda...@fedoraproject.org --- rubygem-openshift-origin-msg-broker-mcollective-0.1.1-9.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-openshift-origin-msg-broker-mcollective-0.1.1-9.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #27 from Fedora Update System upda...@fedoraproject.org --- rubygem-openshift-origin-msg-broker-mcollective-0.1.1-9.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #20 from Adam Miller admil...@redhat.com --- SPEC URL: http://maxamillion.fedorapeople.org/rubygem-openshift-origin-msg-broker-mcollective.spec SRPM URL: http://maxamillion.fedorapeople.org/rubygem-openshift-origin-msg-broker-mcollective-0.1.1-9.fc17.src.rpm removed ghost perms on mcollective config file, it has been resolved in mcollective package https://bugzilla.redhat.com/show_bug.cgi?id=853574 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #18 from Troy Dawson tdaw...@redhat.com --- SPEC URL: http://tdawson.fedorapeople.org/openshift-origin/rubygem-openshift-origin-msg-broker-mcollective.spec SRPM URL: http://tdawson.fedorapeople.org/openshift-origin/rubygem-openshift-origin-msg-broker-mcollective-0.1.1-7.fc18.src.rpm - Fixed final package requiring ruby(abi) 1.8 and 1.9.1 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #19 from Troy Dawson tdaw...@redhat.com --- SPEC URL: http://tdawson.fedorapeople.org/openshift-origin/rubygem-openshift-origin-msg-broker-mcollective.spec SRPM URL: http://tdawson.fedorapeople.org/openshift-origin/rubygem-openshift-origin-msg-broker-mcollective-0.1.1-8.fc18.src.rpm - Renamed libraries to correct names -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #17 from Troy Dawson tdaw...@redhat.com --- SPEC URL: http://tdawson.fedorapeople.org/openshift-origin/rubygem-openshift-origin-msg-broker-mcollective.spec SRPM URL: http://tdawson.fedorapeople.org/openshift-origin/rubygem-openshift-origin-msg-broker-mcollective-0.1.1-6.fc18.src.rpm - converted from using a tarball to using a gem -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #14 from Vít Ondruch vondr...@redhat.com --- What is the reason to not use the gem as a Source0 for the package? Why are you using the tarball? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #15 from Adam Miller admil...@redhat.com --- I've always had the impression of Must Build From Source when it comes to Fedora packages and have generally defaulted to the tarballs from upstream projects, I'm still rather new to packaging up Ruby bits so if that's not preferred I can switch to the gem. -AdamM -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #16 from Vít Ondruch vondr...@redhat.com --- If the gem is platform independent, it always contains the source code. In Ruby world, there is typically no tarball available, so your package would be an exception. And as a last point, guidelines says The Source of the package must be the full URL to the released Gem archive. Although you could use the archive word as a justification, I believe that this word is inappropriate in that sentence and I asked FPC to reword this formulation [1]. [1] https://fedorahosted.org/fpc/ticket/205 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107
--- Comment #11 from Vít Ondruch vondr...@redhat.com ---
(In reply to comment #9)
Vit - I've updated with your feedback.
Thank you.
* ruby_sitelib is not needed.
* You should not own %{gem_dir}
- The idea is to own %{gem_instdir}, i.e. %dir %{gem_instdir} and later own
everything contained in this directory explicitly, e.g. %{gem_libdir},
%doc %{gem_instdir}/LICENSE.
- This would unveil to you, that you are duplicating the LICENSE file in the
output package for example
* Keep the license and readme in original location
- i.e. you should replace %doc LICENSE with %doc %{gem_instdir}/LICENSE
(although there is currently discussion about this topic on packaging
list).
* Are selinux-policy-targeted and policycoreutils-python required?
- I did not dug into it too deeply, but are these really needed?
* Test suite
- What about the test suite? I expect that it will not be that easy, due to
nature of this package, but I'd like to know at least some feedback (it
would cover your back at the end)
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 Troy Dawson tdaw...@redhat.com changed: What|Removed |Added CC||tdaw...@redhat.com Depends On||839064 --- Comment #12 from Troy Dawson tdaw...@redhat.com --- One little thing. Looks like you missed changing rubygem(stickshift-common) to rubygem(openshift-origin-common) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #13 from Adam Miller admil...@redhat.com --- SPEC URL: http://maxamillion.fedorapeople.org/rubygem-openshift-origin-msg-broker-mcollective.spec SRPM URL: http://maxamillion.fedorapeople.org/rubygem-openshift-origin-msg-broker-mcollective-0.1.1-4.fc17.src.rpm - Removed unneeded ruby_sitelib - moved license and readme to original location - removed policycoreutils-python and selinux-policy-targeted as deps After speaking with the upstream author, it was agreed upon that these were not hard requirements. - changed stickshift-common dep to openshift-origin-common for F18 pkg naming This was a complete oversight on my part, apologies - added doc subpackage Was looking at the package manifest and the docs were overpowering so I moved them. On the topic of a test suite, there currently are not any unit tests listed under the rake task. I spoke with upstream and this is still being planned, currently the testing is done using cucumber in the upstream CI environment and requires a running system/environment to test against so it wouldn't be applicable to the package currently. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added CC||vondr...@redhat.com --- Comment #7 from Vít Ondruch vondr...@redhat.com --- (In reply to comment #5) I have no idea where these are coming from or if they are legitimately an issue: /usr/share/gems/doc/openshift-origin-msg-broker-mcollective-0.1.1/ri/ GearChanger/MCollectiveApplicationContainerProxy/has_uid_or_gid%3f-i.ri %3f This is rpmlint's false positive. * BuildRoot, defattrs and %clean section are not required, even for EPEL6 if I am not mistaken. * Would be nice if you can run a test suite. * Although you nicely specified the gem macros on the top of the file, you are not using them later in the %files section. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107
--- Comment #8 from Adam Miller admil...@redhat.com ---
David, I don't entirely follow ... I install %{SOURCE1} on line 78 of the spec
file and the %ghost file was specified by the upstream author of the plugin. I
will ask for clarification.
No real reason on the naming, I'll rename the specfile.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #9 from Adam Miller admil...@redhat.com --- SPEC URL: http://maxamillion.fedorapeople.org/rubygem-openshift-origin-msg-broker-mcollective.spec SRPM URL: http://maxamillion.fedorapeople.org/rubygem-openshift-origin-msg-broker-mcollective-0.1.1-4.fc17.src.rpm Vit - I've updated with your feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #10 from Adam Miller admil...@redhat.com --- David, I got clarification on the %ghost file entry. That file originates from, and it provided by, the mcollective package but is required by this package. The configuration file can be modified using an utility provided within this plugin. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #6 from David Nalley da...@gnsa.us --- I am more confused. You moved from heredoc to source1 - but you don't do anything with it. (e.g. there is no 'copy'. Then you use %ghost in files to tell RPM 'I am not installing this but you still need to know about and own it' Also the name of your spec file is still problematic. It's a rubygem, the RPM is rubygem-openshift-origin-msg-broker-mcollective - why are you dropping the rubygem part of that for the spec file name? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #5 from Adam Miller admil...@redhat.com --- Fixed the heredoc (no idea .. don't ask, that was a multi-person oversight) and also fixed the chown/chmod garble in %post. I have no idea where these are coming from or if they are legitimately an issue: /usr/share/gems/doc/openshift-origin-msg-broker-mcollective-0.1.1/ri/GearChanger/MCollectiveApplicationContainerProxy/has_uid_or_gid%3f-i.ri %3f I am getting the following against the SRPM but I've unpacked, attempted to find/grep for anything .src and came up empty so I don't know what's going on there.: rubygem-openshift-origin-msg-broker-mcollective.src: E: invalid-spec-name Otherwise I think this version is *much* more acceptable. :) Spec URL: http://maxamillion.fedorapeople.org/openshift-origin-msg-broker-mcollective.spec SRPM URL: http://maxamillion.fedorapeople.org/rubygem-openshift-origin-msg-broker-mcollective-0.1.1-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 David Nalley da...@gnsa.us changed: What|Removed |Added Status|NEW |ASSIGNED CC||da...@gnsa.us Assignee|nob...@fedoraproject.org|da...@gnsa.us --- Comment #2 from David Nalley da...@gnsa.us --- I will take this one, and have a review done shortly -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107
--- Comment #3 from David Nalley da...@gnsa.us ---
[ ] MUST: rpmlint must be run on the source rpm and all binary rpms the
build produces. The output should be posted in the review.(refer to
[ke4qqq@mba SPECS]$ rpmlint ./openshift-origin-msg-broker-mcollective.spec
../RPMS/noarch/rubygem-openshift-origin-msg-broker-mcollective-0.1.1-2.fc17.noarch.rpm
../SRPMS/rubygem-openshift-origin-msg-broker-mcollective-0.1.1-2.fc17.src.rpm
./openshift-origin-msg-broker-mcollective.spec:76: W:
mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 76)
./openshift-origin-msg-broker-mcollective.spec: W: invalid-url Source0:
https://mirror.openshift.com/pub/crankcase/source/rubygem-openshift-origin-msg-broker-mcollective/rubygem-openshift-origin-msg-broker-mcollective-0.1.1.tar.gz
HTTP Error 404: Not Found
rubygem-openshift-origin-msg-broker-mcollective.noarch: W: unexpanded-macro
/usr/share/gems/doc/openshift-origin-msg-broker-mcollective-0.1.1/ri/GearChanger/MCollectiveApplicationContainerProxy/has_app%3f-i.ri
%3f
rubygem-openshift-origin-msg-broker-mcollective.noarch: W: unexpanded-macro
/usr/share/gems/doc/openshift-origin-msg-broker-mcollective-0.1.1/ri/GearChanger/MCollectiveApplicationContainerProxy/has_uid_or_gid%3f-i.ri
%3f
rubygem-openshift-origin-msg-broker-mcollective.noarch: W: unexpanded-macro
/usr/share/gems/doc/openshift-origin-msg-broker-mcollective-0.1.1/ri/GearChanger/MCollectiveApplicationContainerProxy/has_embedded_app%3f-i.ri
%3f
rubygem-openshift-origin-msg-broker-mcollective.noarch: W: unexpanded-macro
/usr/share/gems/doc/openshift-origin-msg-broker-mcollective-0.1.1/ri/GearChanger/MCollectiveApplicationContainerProxy/blacklisted_in_impl%3f-c.ri
%3f
rubygem-openshift-origin-msg-broker-mcollective.noarch: E:
script-without-shebang
/usr/share/gems/gems/openshift-origin-msg-broker-mcollective-0.1.1/lib/gearchanger-mcollective-plugin/gearchanger/mcollective_application_container_proxy.rb
rubygem-openshift-origin-msg-broker-mcollective.noarch: W:
dangerous-command-in-%post chown
rubygem-openshift-origin-msg-broker-mcollective.src: E: invalid-spec-name
rubygem-openshift-origin-msg-broker-mcollective.src:76: W:
mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 76)
rubygem-openshift-origin-msg-broker-mcollective.src: W: invalid-url Source0:
https://mirror.openshift.com/pub/crankcase/source/rubygem-openshift-origin-msg-broker-mcollective/rubygem-openshift-origin-msg-broker-mcollective-0.1.1.tar.gz
HTTP Error 404: Not Found
2 packages and 1 specfiles checked; 2 errors, 9
warnings.http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint)
A few things to fix there
[OK] MUST: The package must be named according to the
http://fedoraproject.org/wiki/Packaging/NamingGuidelines
[FIX] MUST: The spec file name must match the base package
code%{name}/code, in the format code%{name}.spec/code unless
your
package has an exemption. (refer to
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name).
[OK] MUST: The package must meet the
http://fedoraproject.org/wiki/Packaging/Guidelines.
[OK] MUST: The package must be licensed with a Fedora approved license and
meet the http://fedoraproject.org/wiki/Packaging/LicensingGuidelines.
[OK] MUST: The License field in the package spec file must match the actual
license. (refer to
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShortNames)
Since you are part of upstream, please consider asking them to add a
license header to the source files.
[OK] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in
code%doc/code.(refer to
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License
Text)
[OK] MUST: The spec file must be written in American English. (refer to
http://fedoraproject.org/wiki/Packaging/Guidelines#summary)
[OK] MUST: The spec file for the package '''MUST''' be legible. (refer to
http://fedoraproject.org/wiki/Packaging/Guidelines#Spec_Legibility)
[FIX] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for
this task.
If no upstream URL can be specified for this package, please see the
http://fedoraproject.org/wiki/Packaging/SourceURL for how to deal with
this.
The URL in source has disappeared, no idea where the source is, as me
manually looking around that site didn't find it either.
[OK] MUST: The package '''MUST''' successfully compile and build into
binary rpms on at least one primary architecture. (refer to
http://fedoraproject.org/wiki/Packaging/Guidelines#Architecture_Support)
[NA] MUST: If the package does not successfully compile,
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 David Nalley da...@gnsa.us changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 --- Comment #4 from Adam Miller admil...@redhat.com --- Thanks for picking this up! I've spoken with the upstream author on this and I swear we discussed the reasons for both the heredoc file creation and the chmod/chown in %post but now neither of us can recollect the motivations. I will be doing some heavy refactoring and will get an update to this asap. -AdamM -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845107] Review Request: rubygem-openshift-origin-msg-broker-mcollective - OpenShift Origin plugin for mcollective service
https://bugzilla.redhat.com/show_bug.cgi?id=845107 Adam Miller admil...@redhat.com changed: What|Removed |Added CC||maxamillion@fedoraproject.o ||rg --- Comment #1 from Adam Miller admil...@redhat.com --- *** Bug 841641 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
