[Bug 845115] python-django-recaptcha

2012-08-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=845115

Bohuslav "Slavek" Kabrda  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||bkab...@redhat.com
   Assignee|nob...@fedoraproject.org|bkab...@redhat.com
  Flags||fedora-review?

--- Comment #2 from Bohuslav "Slavek" Kabrda  ---
I'll take this review. Matthias's comments are completely relevant, please fix
them and post the updated spec/srpm before we can continue this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845115] python-django-recaptcha

2012-08-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=845115

Matthias Runge  changed:

   What|Removed |Added

 CC||mru...@matthias-runge.de

--- Comment #1 from Matthias Runge  ---
Some drive-by comments:
- you need an obsoletes:
- no need to clean up the build-root any more
- why did you remove the old changelog entries? They still belong to the
package
- defattrs not required
- you should enable the tests in a %check section

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review