[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 --- Comment #22 from Fedora Update System --- prepaid-manager-applet-0.0.3.1-6.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 Fedora Update System changed: What|Removed |Added Resolution|NEXTRELEASE |ERRATA --- Comment #21 from Fedora Update System --- prepaid-manager-applet-0.0.3.1-6.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 --- Comment #20 from Fedora Update System --- prepaid-manager-applet-0.0.3.1-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/prepaid-manager-applet-0.0.3.1-6.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 --- Comment #19 from Fedora Update System --- prepaid-manager-applet-0.0.3.1-6.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/prepaid-manager-applet-0.0.3.1-6.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 --- Comment #18 from Kai Engert (:kaie) --- It would be great if people interested in this package could please get the package, and... please give karma. That's necessary to get the package pushed to the stable update area. See the links in comment 15 and 16. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 Kai Engert (:kaie) changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2012-08-30 06:58:28 --- Comment #17 from Kai Engert (:kaie) --- Ankur Sinha, you have full rights for the package, thanks a lot for your initial work. Mario, thanks a lot for your help with the package review. Jon, thanks for creating the package in git, I confirm things work well! f17 http://koji.fedoraproject.org/koji/taskinfo?taskID=4437248 f18 http://koji.fedoraproject.org/koji/taskinfo?taskID=4437240 Closing. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 --- Comment #16 from Fedora Update System --- prepaid-manager-applet-0.0.3.1-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/prepaid-manager-applet-0.0.3.1-5.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 --- Comment #15 from Fedora Update System --- prepaid-manager-applet-0.0.3.1-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/prepaid-manager-applet-0.0.3.1-5.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 Kai Engert (:kaie) changed: What|Removed |Added Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 --- Comment #14 from Jon Ciesla --- Git done (by process-git-requests). Mario, please take ownership of review BZs, thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 Kai Engert (:kaie) changed: What|Removed |Added Flags||fedora-cvs? --- Comment #13 from Kai Engert (:kaie) --- New Package SCM Request === Package Name: prepaid-manager-applet Short Description: An applet for the GNOME Desktop for GSM mobile prepaid SIM cards Owners: kengert ankursinha Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551
Mario Blättermann changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #12 from Mario Blättermann ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4432324
$ rpmlint -i -v *
prepaid-manager-applet.src: I: checking
prepaid-manager-applet.src: I: checking-url
https://honk.sigxcpu.org/piki/projects/ppm/ (timeout 10 seconds)
prepaid-manager-applet.src: I: checking-url
http://honk.sigxcpu.org/projects/ppm/tarballs/prepaid-manager-applet-0.0.3.1.tar.xz
(timeout 10 seconds)
prepaid-manager-applet.noarch: I: checking
prepaid-manager-applet.noarch: I: checking-url
https://honk.sigxcpu.org/piki/projects/ppm/ (timeout 10 seconds)
prepaid-manager-applet.noarch: E: incorrect-fsf-address
/usr/share/prepaid-manager-applet/ppm/accountdb.py
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
prepaid-manager-applet.noarch: E: incorrect-fsf-address
/usr/share/prepaid-manager-applet/ppm/provider.py
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
prepaid-manager-applet.noarch: E: incorrect-fsf-address
/usr/share/prepaid-manager-applet/ppm/providerdb.py
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
prepaid-manager-applet.noarch: E: incorrect-fsf-address
/usr/share/prepaid-manager-applet/ppm/modemproxy.py
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
prepaid-manager-applet.noarch: E: incorrect-fsf-address
/usr/share/prepaid-manager-applet/prepaid-manager-applet.py
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
prepaid-manager-applet.noarch: W: no-manual-page-for-binary
prepaid-manager-applet
Each executable in standard binary directories should have a man page.
prepaid-manager-applet.spec: I: checking-url
http://honk.sigxcpu.org/projects/ppm/tarballs/prepaid-manager-applet-0.0.3.1.tar.xz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 5 errors, 1 warnings.
No real issues. The wrong FSF addresses have been discussed earlier, and no man
page is no review blocker.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv3+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
76b2a5668f419dbfe889d84b54deb18d536c1b5c1f2d3970ca687290f1048f66
prepaid-manager-applet-0.0.3.1.tar.xz
76b2a5668f419dbfe889d84b54deb18d536c1b5c1f2d3970ca687290f1048f66
prepaid-manager-applet-0.0.3.1.tar.xz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/wor
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 --- Comment #11 from Kai Engert (:kaie) --- > %doc AUTHORS COPYING NEWS README TODO I probably made a mistake in my earlier testing, I confirm it works now. Spec URL: http://kuix.de/fedora/ppm/prepaid-manager-applet.spec SRPM URL: http://kuix.de/fedora/ppm/prepaid-manager-applet-0.0.3.1-5.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551
--- Comment #10 from Mario Blättermann ---
(In reply to comment #9)
> > Add the following line to %files:
> > %doc AUTHORS COPYING NEWS README TODO
>
> I believe it's not as simple as you think,
> because the upstream installation scripts don't install these files into the
> area that will be used as the base for packaging.
>
> I added copy commands to %install that copy those files to
> %{_docdir}/%{name}/
> and added appropriate entries to %files
>
Not needed at all. If you use that line as is, the %doc macro picks up the
appropriate files and puts them into the right folder automatically. In case of
that the install script from the tarball puts them anywhere else, just use the
%exclude macro in the file list to avoid installing duplicates.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551
--- Comment #9 from Kai Engert (:kaie) ---
> Wrong FSF addresses and missing man pages, no real problems.
I've mailed the upstream maintainer and asked to get the FSF license headers
updated in a future release.
> Add the following line to %files:
> %doc AUTHORS COPYING NEWS README TODO
I believe it's not as simple as you think,
because the upstream installation scripts don't install these files into the
area that will be used as the base for packaging.
I added copy commands to %install that copy those files to %{_docdir}/%{name}/
and added appropriate entries to %files
> Change the license to GPLv3+ according to some file headers in the source
> tarball.
Ok.
> Don't forget to track your changes in the %changelog, as already mentioned.
ok
Updated:
Spec URL: http://kuix.de/fedora/ppm/prepaid-manager-applet.spec
SRPM URL:
http://kuix.de/fedora/ppm/prepaid-manager-applet-0.0.3.1-4.fc17.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 --- Comment #8 from Mario Blättermann --- New scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4416747 $ rpmlint -i -v * prepaid-manager-applet.src: I: checking prepaid-manager-applet.src: I: checking-url https://honk.sigxcpu.org/piki/projects/ppm/ (timeout 10 seconds) prepaid-manager-applet.src: I: checking-url http://honk.sigxcpu.org/projects/ppm/tarballs/prepaid-manager-applet-0.0.3.1.tar.xz (timeout 10 seconds) prepaid-manager-applet.noarch: I: checking prepaid-manager-applet.noarch: I: checking-url https://honk.sigxcpu.org/piki/projects/ppm/ (timeout 10 seconds) prepaid-manager-applet.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. prepaid-manager-applet.noarch: E: incorrect-fsf-address /usr/share/prepaid-manager-applet/ppm/accountdb.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. prepaid-manager-applet.noarch: E: incorrect-fsf-address /usr/share/prepaid-manager-applet/ppm/provider.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. prepaid-manager-applet.noarch: E: incorrect-fsf-address /usr/share/prepaid-manager-applet/ppm/providerdb.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. prepaid-manager-applet.noarch: E: incorrect-fsf-address /usr/share/prepaid-manager-applet/prepaid-manager-applet.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. prepaid-manager-applet.noarch: E: incorrect-fsf-address /usr/share/prepaid-manager-applet/ppm/modemproxy.py The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. prepaid-manager-applet.noarch: W: no-manual-page-for-binary prepaid-manager-applet Each executable in standard binary directories should have a man page. 2 packages and 0 specfiles checked; 5 errors, 2 warnings. Wrong FSF addresses and missing man pages, no real problems. But still some recognizable issues: Add the following line to %files: %doc AUTHORS COPYING NEWS README TODO Change the license to GPLv3+ according to some file headers in the source tarball. Don't forget to track your changes in the %changelog, as already mentioned. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? --- Comment #7 from Mario Blättermann --- (In reply to comment #3) > Requires: mobile-broadband-provider-info ModemManager gtk3 > Requires: dbus-python pygobject3 gtk3 > > I'm surprised you call that "a lot". > I removed the duplicate gtk3. > Why is it a problem to list requirements explicity? Usually there's almost nothing in "Requires" because most of the requirements will be picked up automatically while building the package. Exceptions are modules of Python, Perl and similar scripting languages and some other cases. Packages which use Autotools don't need adding runtime requirements in most cases, and according to the packaging guidelines you must not add them manually if there's another way to pick them up. (In reply to comment #4) > I did that and ran a scratch build, and the requires list for that build is: > > $ rpm -qp --requires prepaid-manager-applet-0.0.3.1-2.fc17.noarch.rpm > /bin/sh > /bin/sh > /bin/sh > /bin/sh > /usr/bin/python > rpmlib(CompressedFileNames) <= 3.0.4-1 > rpmlib(FileDigests) <= 4.6.0-1 > rpmlib(PartialHardlinkSets) <= 4.0.4-1 > rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > rpmlib(PayloadIsXz) <= 5.2-1 OK, in this case you can keep all the requirements excepting the duplicate of gtk3. I will do a formal review soon. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 Kai Engert (:kaie) changed: What|Removed |Added Version|9 |17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 --- Comment #6 from Kai Engert (:kaie) --- f17 http://koji.fedoraproject.org/koji/taskinfo?taskID=4406920 f18 http://koji.fedoraproject.org/koji/taskinfo?taskID=4406936 both completed -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 --- Comment #5 from Kai Engert (:kaie) --- Updated: Spec URL: http://kuix.de/fedora/ppm/prepaid-manager-applet.spec SRPM URL: http://kuix.de/fedora/ppm/prepaid-manager-applet-0.0.3.1-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 --- Comment #4 from Kai Engert (:kaie) --- > There are a lot of entries in Requires. You should build your package > without them and check what is picked up automatically. Then add those which > are not found by rpm. I did that and ran a scratch build, and the requires list for that build is: $ rpm -qp --requires prepaid-manager-applet-0.0.3.1-2.fc17.noarch.rpm /bin/sh /bin/sh /bin/sh /bin/sh /usr/bin/python rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551
--- Comment #3 from Kai Engert (:kaie) ---
> You have to replace all occurences of pygobject2 with pygobject3 in
> BuildRequires and Requires.
done
> Moreover, you can drop the following from BuildRequires:
> gettext: needed by intltool
ok
> python2-devel: obsolete, has to be python3-devel actually, but it is not
> needed because the Python build stack (setup.py etc.) is not used here, the
> package uses autotools
removed
> glib2-devel: needed by Gtk anyway, the v2 is obsolete for the newest sources
removed
> There are a lot of entries in Requires. You should build your package
> without them and check what is picked up automatically. Then add those which
> are not found by rpm.
We had:
Requires: mobile-broadband-provider-info ModemManager gtk3
Requires: dbus-python pygobject3 gtk3
I'm surprised you call that "a lot".
I removed the duplicate gtk3.
Why is it a problem to list requirements explicity?
I'll try to run the try-and-error experiments you've asked for, if they're not
requiring too much time.
> The initial cleaning of %{buildroot} in the %install section and the
> %defattr line in %files are obsolete. Please drop them
removed
> Some files are installed in %{_datadir}/icons/hicolor/, you have to add the
> following scripts to update the icon cache:
added
> To install the desktop file correctly, you have to add desktop-file-utils to
> BuildRequires.
It was already there.
> And last but not least: Please don't forget to log your changes in the
> Changelog!
will do
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551
--- Comment #2 from Mario Blättermann ---
Scratch build fails for f17 and f18:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4400046
http://koji.fedoraproject.org/koji/taskinfo?taskID=4400294
From build.log:
> configure: error: Package requirements (glib-2.0 >= 2.25.6
> gtk+-3.0 >= 3.0.0
> pygobject-3.0 >= 3.0) were not met:
> No package 'pygobject-3.0' found
You have to replace all occurences of pygobject2 with pygobject3 in
BuildRequires and Requires. Moreover, you can drop the following from
BuildRequires:
gettext: needed by intltool
python2-devel: obsolete, has to be python3-devel actually, but it is not needed
because the Python build stack (setup.py etc.) is not used here, the package
uses autotools
glib2-devel: needed by Gtk anyway, the v2 is obsolete for the newest sources
There are a lot of entries in Requires. You should build your package without
them and check what is picked up automatically. Then add those which are not
found by rpm.
The initial cleaning of %{buildroot} in the %install section and the %defattr
line in %files are obsolete. Please drop them unless you would want to provide
your package for EPEL 5 (which is impossible due to unresolvable dependencies).
Some files are installed in %{_datadir}/icons/hicolor/, you have to add the
following scripts to update the icon cache:
%post
touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
%postun
if [ $1 -eq 0 ] ; then
touch --no-create %{_datadir}/icons/hicolor &>/dev/null
gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
fi
%posttrans
gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
To install the desktop file correctly, you have to add desktop-file-utils to
BuildRequires.
And last but not least: Please don't forget to log your changes in the
Changelog!
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848551] Review Request: prepaid-manager-applet - An applet for the GNOME Desktop for GSM mobile prepaid SIM cards
https://bugzilla.redhat.com/show_bug.cgi?id=848551 Kai Engert (:kaie) changed: What|Removed |Added CC||sanjay.an...@gmail.com --- Comment #1 from Kai Engert (:kaie) --- *** Bug 691635 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
