[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 Matthew Farrellee m...@redhat.com changed: What|Removed |Added Blocks||985087 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=985087 [Bug 985087] Review Request: hadoop - A software platform for processing vast amounts of data -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rSsm2WwHARa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-07-19 09:25:17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eDxePisSdja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- groovy18-1.8.9-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/groovy18-1.8.9-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tQ1qgiDseKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- groovy18-1.8.9-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MP5OL7xsx6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bjoern.es...@gmail.com Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PAYzDAPg0ea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127
Björn Esser bjoern.es...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #4 from Björn Esser bjoern.es...@gmail.com ---
Package is fine, besides two small non-blockers to be OK when fixed in SCM:
* spelling-error %description: 's!bytecode!byte-code!'
* javadoc subpackages should not have Requires: jpackage-utils
#
Package Review
==
Legend:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Javadoc subpackages should not have Requires: jpackage-utils
Note: jpackage-utils requires are automatically generated by the buildsystem
See: https://fedoraproject.org/wiki/Packaging:Java
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
groovy18-javadoc
--- false positive
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), BSD (2 clause), Unknown or generated. 177 files have
unknown license. Detailed output of licensecheck in
/home/bjoern.esser/fedora/review/858127-groovy18/licensecheck.txt
--- everything is fine here.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[!]: Requires correct, justified where necessary.
--- javadoc must not Requires: jpackage-utils, see above
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 40960 bytes in 5 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadocs are placed in
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from gil cattaneo punto...@libero.it --- Thanks! Spec URL: http://gil.fedorapeople.org/groovy18.spec SRPM URL: http://gil.fedorapeople.org/groovy18-1.8.9-1.fc18.src.rpm - removed jpackage-utils references from javadoc subpackages - fixed spelling error New Package SCM Request === Package Name: groovy18 Short Description: Dynamic language for the Java Platform Owners: gil Branches: f18 f19 f20 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Xq6Ati5xO1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127
--- Comment #6 from Mikolaj Izdebski mizde...@redhat.com ---
I want to highlight that this package does NOT follow packaging guidelines.
Groovy is already packaged for Fedora (package name groovy) and I am a
co-maintainer.
I perfectly understand that there is a need to maintain two versions of Groovy
because some packages need version 2.x and some need 1.x and these two lines
are incompatible. But in this case groovy18 should be packaged as a
compatibility package and follow packaging guidelines for compat packages [1].
This means that all JAR and POM files MUST be versioned (have -%{version}
suffix). If this rule is not followed then installing both groovy and groovy18
can lead to non-obvious errors during build or runtime of dependant packages.
I would like to ask you to fix and re-review the package to follow the
guidelines in [1].
[1] http://fedoraproject.org/wiki/Packaging:Java#Compatibility_packages
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=PSNqi0cxDXa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 --- Comment #7 from Björn Esser bjoern.es...@gmail.com --- Created attachment 759559 -- https://bugzilla.redhat.com/attachment.cgi?id=759559action=edit Java Compat-pkg Sorry, my bad. Missed that point. Attached patch should fix this problem, I suppose? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=f76YZ6HOura=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 --- Comment #8 from Mikolaj Izdebski mizde...@redhat.com --- (In reply to Björn Esser from comment #7) Attached patch should fix this problem, I suppose? Yes, with this patch the spec file looks fine in terms of compatibility package guidelines. I suppose there may be other problems (wrong license tag, missing license files), wich I have recently fixed in groovy package and which should be backported. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9rNaT357THa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 --- Comment #9 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/groovy18.spec SRPM URL: http://gil.fedorapeople.org/groovy18-1.8.9-2.fc18.src.rpm - packaged as a compatibility package -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l9ieNrwAk2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 --- Comment #10 from gil cattaneo punto...@libero.it --- (In reply to Mikolaj Izdebski from comment #8) (In reply to Björn Esser from comment #7) Attached patch should fix this problem, I suppose? Yes, with this patch the spec file looks fine in terms of compatibility package guidelines. alredy fixed I suppose there may be other problems (wrong license tag, missing license files), wich I have recently fixed in groovy package and which should be backported. already fixed regards -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oz3xRJBvLga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 --- Comment #11 from Björn Esser bjoern.es...@gmail.com --- (In reply to Mikolaj Izdebski from comment #8) I suppose there may be other problems (wrong license tag, missing license files), wich I have recently fixed in groovy package and which should be backported. Checking the ~180 files with unknown license from source does not show or miss any license mentioned in spec-file. So this seems OK to me. (In reply to gil cattaneo from comment #9) Spec URL: http://gil.fedorapeople.org/groovy18.spec SRPM URL: http://gil.fedorapeople.org/groovy18-1.8.9-2.fc18.src.rpm - packaged as a compatibility package re-reviewing shows objected compat-pkg issues are solved: * jar and pom are properly suffixed * no new issues So finally (flag was set already): APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vl2JsKiazJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 --- Comment #12 from gil cattaneo punto...@libero.it --- thanks! New Package SCM Request === Package Name: groovy18 Short Description: Dynamic language for the Java Platform Owners: gil Branches: f18 f19 f20 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SVDXEuoTUFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oQp5FUIsfva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mzNCOeAXw6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- groovy18-1.8.9-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/groovy18-1.8.9-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5Obqh67MqEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UI2kGgCKRja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 Matthew Farrellee m...@redhat.com changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LgbsaCtYvIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858127 --- Comment #3 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/groovy18.spec SRPM URL: http://gil.fedorapeople.org/groovy18-1.8.9-1.fc18.src.rpm - Update to 1.8.9 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZJXYPQ2n0Ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858127 Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed: What|Removed |Added CC||pa...@hubbitus.info --- Comment #1 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- 1.8.7 groovy already in Fedora (and 1.8.8 in rawhide). Is it this request stil actual? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BwGYKWyIQta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858127 --- Comment #2 from gil cattaneo punto...@libero.it --- yes because groovy 2.x (requires asm4) break a lot of packages... e.g. gradle, gmaven, ... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=izMcCZmotRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858127] Review Request: groovy18 - Dynamic language for the Java Platform
https://bugzilla.redhat.com/show_bug.cgi?id=858127 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
