[Bug 858841] Review Request: owncloud - Private file sync and share server

2014-11-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841



--- Comment #54 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2014-11-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2014-11-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Adam Williamson (Fedora) adamw+fed...@happyassassin.net changed:

   What|Removed |Added

 CC||adamw+fedora@happyassassin.
   ||net
  Flags||fedora-cvs?



--- Comment #53 from Adam Williamson (Fedora) adamw+fed...@happyassassin.net 
---
Package Change Request
==
Package Name: owncloud
New Branches: epel7
Owners: adamwill

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-08-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Bug 858841 depends on bug 858946, which changed state.

Bug 858946 Summary: selinux blocks write access on /etc/owncloud
https://bugzilla.redhat.com/show_bug.cgi?id=858946

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |WONTFIX



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=FcTuKNvTDna=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-04-22 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Vincent Danen vda...@redhat.com changed:

   What|Removed |Added

  Alias|owncloud|

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=nEiZyiXjF6a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-03-07 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Bug 858841 depends on bug 858946, which changed state.

Bug 858946 Summary: selinux blocks write access on /etc/owncloud
https://bugzilla.redhat.com/show_bug.cgi?id=858946

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|ERRATA  |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HG5T2wsMIZa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-03-04 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #52 from Jon Ciesla limburg...@gmail.com ---
Un-setting flag.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=6mht2hUkA2a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-03-03 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Gregor Tätzner gre...@freenet.de changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
  Flags|fedora-cvs+ |
  Flags||fedora-cvs?
Last Closed||2013-03-03 15:28:16

--- Comment #51 from Gregor Tätzner gre...@freenet.de ---
imported into rawhide

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=rCJ22kOXGQa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-03-01 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=8ywVejmY7Ba=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-03-01 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #50 from Fedora Update System upda...@fedoraproject.org ---
owncloud-csync-0.70.4-1.fc18, mirall-1.2.1-2.fc18 has been submitted as an
update for Fedora 18.
https://admin.fedoraproject.org/updates/owncloud-csync-0.70.4-1.fc18,mirall-1.2.1-2.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=RlTAP7ltqya=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-02-27 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 Blocks|182235 (FE-Legal)   |
  Flags|needinfo?(tcallawa@redhat.c |
   |om) |

--- Comment #46 from Tom spot Callaway tcall...@redhat.com ---
Sorry, jslint is gone now, so lifting FE-Legal.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=mXSkbbpqCia=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-02-27 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #47 from Rex Dieter rdie...@math.unl.edu ---
Great!

things look swell from my perspective, APPROVED.


we can haggle any remaining runtime wrinkles post-review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kwj5Q6Zmpqa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-02-27 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Gregor Tätzner gre...@freenet.de changed:

   What|Removed |Added

 CC|tingp...@tingping.se|
  Flags||fedora-cvs?

--- Comment #48 from Gregor Tätzner gre...@freenet.de ---
New Package SCM Request
===
Package Name: owncloud
Short Description: Private file sync and share server
Owners: brummbq
Branches: f18 el6
InitialCC:

thanks to everyone involved in this review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=afLvRgHv5Pa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-02-27 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #49 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=67wfWhI4iAa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-02-26 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Flags|fedora-review-  |
  Flags||fedora-review?
  Flags||needinfo?(tcallawa@redhat.c
   ||om)

--- Comment #45 from Rex Dieter rdie...@math.unl.edu ---
1. as long as it's included in src.rpm and clearly documented what it's purpose
is, fine with me.


ps.  don't mess with the bz review flag, that's for the reviewer only. :)
? = currently under review
- = review failed
+ = review accepted


Spot, any eta on clearing the FE-Legal blocker?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=XDWb2WzZ19a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-02-25 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Gregor Tätzner gre...@freenet.de changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review-

--- Comment #44 from Gregor Tätzner gre...@freenet.de ---
Spec URL: http://brummbq.fedorapeople.org/owncloud.spec
SRPM URL: http://brummbq.fedorapeople.org/owncloud-4.5.7-2.fc17.src.rpm

(In reply to comment #43)
 # removed any occurences of jslint
 Source0:%{name}-%{version}-repack.tar.bz2
 
 SHOULD: so tarball creation is readily reproducible and verifiable, please
 include more detail on what what excluded exactly or (ideally) include a
 script to do it.

see new bash script in the srpm, am I supposed to ship that?

 
 
 2.  scriptlets: mostly ok, but
 
 SHOULD: for f18+ consider following macro'ized systemd scriptlets per
 https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd

disagreed, I'm just reloading httpd in the sub-package. Those macros seem to do
all kind of fancy stuff

 
 
 3. runtime: (apparently?) not OK.  followed owncloud-README.fedora,
 installed, pointed browser at http://localhost/owncloud/, and get 403
 Forbidden Error

bad rdieter, you're using httpd 2.4 ;)
have not tested on F18 yet, but should work now

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=hYAGaMGxKWa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-02-24 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #41 from Gregor Tätzner gre...@freenet.de ---
jump to owncloud 4.5.x

Spec URL: http://brummbq.fedorapeople.org/owncloud.spec
SRPM URL: http://brummbq.fedorapeople.org/owncloud-4.5.7-1.fc17.src.rpm

@rdieter:
You still wanna help out?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=EsESMkNGSEa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-02-24 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

   Assignee|mat...@redhat.com   |rdie...@math.unl.edu
  Flags|fedora-review-  |
  Flags||fedora-review?

--- Comment #42 from Rex Dieter rdie...@math.unl.edu ---
OK, will carve out some time today.


would appreciate any recipricol/swap reviews for anything blocking,
https://bugzilla.redhat.com/show_bug.cgi?id=kde-reviews ,
qaccessibilityclient/simon or qt5-* stuff in particular.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=AxnKHcHYT6a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-02-24 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #43 from Rex Dieter rdie...@math.unl.edu ---
naming: ok

1.  Sources: ok
but,
# removed any occurences of jslint
Source0:%{name}-%{version}-repack.tar.bz2

SHOULD: so tarball creation is readily reproducible and verifiable, please
include more detail on what what excluded exactly or (ideally) include a script
to do it.


2.  scriptlets: mostly ok, but

SHOULD: for f18+ consider following macro'ized systemd scriptlets per
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd


builds/installs: ok


3. runtime: (apparently?) not OK.  followed owncloud-README.fedora, installed,
pointed browser at http://localhost/owncloud/, and get 403 Forbidden Error

/var/log/httpd/error_log contained,
[Sun Feb 24 16:21:25.387065 2013] [authz_core:error] [pid 32560] [client
127.0.0.1:49753] AH01630: client denied by server configuration:
/usr/share/owncloud/

but, won't consider this a blocker for now (won't rule out user-error on my
part), hopefully can tweak/polish things in the meantime to get this to work
reliably.


licensing: oh boy, looks accurate according to my quick verification with
licensecheck tool, will leave this to FE-Legal blocker to be authoritative.



That's my first pass looking this over. So far, no MUST blockers found.  Feel
free to humor me and address mentioned SHOULD items in the meantime.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=aY3GJlmiEQa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-02-18 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #39 from Rex Dieter rdie...@math.unl.edu ---
Mathew, are you able/willing to continue on this pkg review?  I heard rumors
you might be busy, so I can help out if that's the case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=lLrfjYRMI3a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-02-18 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #40 from Matthew Miller mat...@redhat.com ---
(In reply to comment #39)
 Mathew, are you able/willing to continue on this pkg review?  I heard rumors
 you might be busy, so I can help out if that's the case.

I think the rumors are kind of correct. If you've got spare cycles to take
over, it's all yours!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=mlId9UEUhOa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-01-19 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Bug 858841 depends on bug 886261, which changed state.

Bug 886261 Summary: Review Request: php-when - Date/Calendar recursion library 
for PHP 5.2+
https://bugzilla.redhat.com/show_bug.cgi?id=886261

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=uQmlZZboKfa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-01-19 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Bug 858841 depends on bug 886230, which changed state.

Bug 886230 Summary: Review Request: php-phpass - Portable password hashing 
framework for use in PHP applications
https://bugzilla.redhat.com/show_bug.cgi?id=886230

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ZVSf5JbNoca=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2013-01-13 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #38 from Gregor Tätzner gre...@freenet.de ---
small update, properly handling of selinux context on rhel

Spec URL: http://brummbq.fedorapeople.org/owncloud.spec
SRPM URL: http://brummbq.fedorapeople.org/owncloud-4.0.8-7.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=M9EWJD3wk0a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-12-18 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #37 from Gregor Tätzner gre...@freenet.de ---
here we go:

Spec URL: http://brummbq.fedorapeople.org/owncloud.spec
SRPM URL: http://brummbq.fedorapeople.org/owncloud-4.0.8-6.fc17.src.rpm

- php-when and phpass (pronounced ph-pass ;)) are out
FPC-ticket: https://fedorahosted.org/fpc/ticket/236
- we don't need to remove the js-libs, there are no guidelines
- the php class smb4php is adjusted to owncloud, I wouldn't dare to replace it
with a genuine

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=5olBBbZLmza=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-12-11 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Gregor Tätzner gre...@freenet.de changed:

   What|Removed |Added

 Depends On||886261, 886230

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tHgSJNGgKia=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-12-08 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #36 from Gregor Tätzner gre...@freenet.de ---
(In reply to comment #35)
 Should config.sample.php go in %doc instead of the config directory? I don't
 have a strong feeling here; I think we're inconsistent as a distro and I
 don't see a guideline offhand.

agreed, moved to doc

 
 Shouldn't PEAR5.php and PEAR-LICENSE be removed along with the other pear
 files?

thanks, I've overlooked those

 
 And, I'm sorry for not saying this sooner, but I was re-reading the bundled
 libraries rules and I think we need to either split out or go through the
 bundled-library-exception process for the remaining stuff under 3rdparty. (A
 lot of it may fall under copylibs
 https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Copylibs) (I
 know you're working on jquery at bug #857992). This may have the benefit of
 making the License field less insane. :)

okay let's see what we have left:
3 php libs:
smb4php (single php class, newest release, 5 years old)
php-when (single php class, 2 years old)
phpass (2 files, probably dead upstream)

How should I cope with them? The copylib rule doesn't apply here I suppose?

Also there are 3 js-libs (chosen, fullcalender and timepicker) that I don't
want to touch. I will try to get an exception...

 
 
 
 On a less difficult note, maybe some of the text from
 http://owncloud.org/about/ could go in the description?

aye

 
 
 I think it'd be nice for the description of the database subpackages to make
 clear that it's intentional for them to be empty. Alternately, they could
 contain doc files for configuration with that particular database? Not a
 review blocker.

good idea, I'll write some database configuration instructions (actually you
just need to create an user and a database)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kBuznL6EREa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-12-07 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #35 from Matthew Miller mat...@redhat.com ---
Should config.sample.php go in %doc instead of the config directory? I don't
have a strong feeling here; I think we're inconsistent as a distro and I don't
see a guideline offhand.

Shouldn't PEAR5.php and PEAR-LICENSE be removed along with the other pear
files?

And, I'm sorry for not saying this sooner, but I was re-reading the bundled
libraries rules and I think we need to either split out or go through the
bundled-library-exception process for the remaining stuff under 3rdparty. (A
lot of it may fall under copylibs
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Copylibs) (I know
you're working on jquery at bug #857992). This may have the benefit of making
the License field less insane. :)



On a less difficult note, maybe some of the text from
http://owncloud.org/about/ could go in the description?


I think it'd be nice for the description of the database subpackages to make
clear that it's intentional for them to be empty. Alternately, they could
contain doc files for configuration with that particular database? Not a review
blocker.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=iEHy2iExv5a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-20 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Bug 858841 depends on bug 859731, which changed state.

Bug 859731 Summary: Review Request: php-channel-sabredav - adds the SabreDAV 
channel to php-pear
https://bugzilla.redhat.com/show_bug.cgi?id=859731

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-20 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Bug 858841 depends on bug 869121, which changed state.

Bug 869121 Summary: Review Request: php-sabredav-Sabre_CalDAV - CalDAV plugin 
for Sabre_DAV
https://bugzilla.redhat.com/show_bug.cgi?id=869121

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-20 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Bug 858841 depends on bug 869123, which changed state.

Bug 869123 Summary: Review Request: php-sabredav-Sabre_CardDAV - CardDAV plugin 
for Sabre_DAV
https://bugzilla.redhat.com/show_bug.cgi?id=869123

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-14 Thread bugzilla
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Bug 858841 depends on bug 859713, which changed state.

Bug 859713 Summary: Review Request: php-cloudfiles - PHP API for the Cloud 
Files storage system
https://bugzilla.redhat.com/show_bug.cgi?id=859713

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Bug 858841 depends on bug 858946, which changed state.

Bug 858946 Summary: selinux blocks write access on /etc/owncloud
https://bugzilla.redhat.com/show_bug.cgi?id=858946

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #29 from Remi Collet fed...@famillecollet.com ---
As I understand, this is not a fork, but a new driver (MDB2_Driver_sqlite3).

Of course, it will be great to have this one propose as a new PEAR extension
(we probably should encourage upstream to do this).

So, for now, I don't see any need to unbundle something which is not bundled.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #30 from Remi Collet fed...@famillecollet.com ---
 I could move it to the owncloud-sqlite subpackage
Yes.

And please requires php-sqlite3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #31 from Remi Collet fed...@famillecollet.com ---
Created attachment 640645
  -- https://bugzilla.redhat.com/attachment.cgi?id=640645action=edit
phpci-fullreport.txt

Output result of phpci print --report full --recursive owncloud

Note:
This eport only detects known extensions (and there is some it doesn't know
yet), and can have false positive.

So according to it, requires should be (at least)

php-curl
php-date
php-dom
php-exif
php-fileinfo
php-filter (Warning: not yet available on RHEL)
php-gd
php-gmp
php-iconv
php-json
php-ldap
php-mbstring
php-openssl
php-pcre
php-pdo
php-session
php-simplexml
php-spl
php-zip
# optional
php-bcmath

Ignored : php-pgsql, php-mysql, php-sqlite3 moved to sub-package

Ignored : php-xml (this extension is provided by php-common and is also a
package which provides others extension... yes this is ugly)

From the code, I don't see any need for php-posix.

Note: it is better to request extension rather than package, as this could
change in the future.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #32 from Remi Collet fed...@famillecollet.com ---
So, for sqlite sub package (probably a better name would be sqlite3),
requires should be.

php-pcre
php-sqlite3
php-pear(MDB2)


Note : it is also preferable to use php-pear(xxx) rather than php-pear-xxx.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #33 from Gregor Tätzner gre...@freenet.de ---
(In reply to comment #30)
  I could move it to the owncloud-sqlite subpackage
 Yes.
 
 And please requires php-sqlite3

done, do you excuse, if I don't upload a new package for every little change

another open point is 3rdparty/phpass. I'm hesitating to unbundle it, because
it looks like an abandoned and unmaintained lib. The last release was over 2
years ago.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #34 from Gregor Tätzner gre...@freenet.de ---
Spec URL: http://brummbq.fedorapeople.org/owncloud.spec
SRPM URL: http://brummbq.fedorapeople.org/owncloud-4.0.8-5.fc17.src.rpm

- reworked the php and pear dependencies
- note also the new dist conditionals

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Matthew Miller mat...@redhat.com changed:

   What|Removed |Added

 Depends On||869123

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Matthew Miller mat...@redhat.com changed:

   What|Removed |Added

 Depends On||869121

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #25 from Matthew Miller mat...@redhat.com ---
Where is php-pear-MDB2-Driver-sqlite coming from? I don't see a review
request

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #26 from Remi Collet fed...@famillecollet.com ---
php-pear-MDB2-Driver-sqlite requires php sqlite extension (v2) which is
deprecated for years (pdo_sqlite and sqlite3 exists), moved from php 5.4
sources to pecl (but unmaintained), and removed from fedora (for years).

So the sqlite sub package could probably be dropped.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #27 from Gregor Tätzner gre...@freenet.de ---
Guys, did you spotted /owncloud/lib/MDB2/Driver/... ?
They have their own sqlite driver included. I'm not sure where did that came
from. Is it some sort of fork? If yes, I could move it to the owncloud-sqlite
subpackage.

So for the moment, I can just drop the req to php-pear-MDB2-Driver-sqlite
without disabling sqlite

(In reply to comment #26)
 So the sqlite sub package could probably be dropped.

We still want a sqlite subpackage in order to not pull in mysql or postgresql

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #28 from Matthew Miller mat...@redhat.com ---
(In reply to comment #27)
 Guys, did you spotted /owncloud/lib/MDB2/Driver/... ?
 They have their own sqlite driver included. I'm not sure where did that came
 from. Is it some sort of fork? If yes, I could move it to the
 owncloud-sqlite subpackage.


I dunno. I'm just looking at the dependencies in the spec file.

But if it's some sort of fork, we should look at whether it should be
unbundled.


 (In reply to comment #26)
  So the sqlite sub package could probably be dropped.
 We still want a sqlite subpackage in order to not pull in mysql or postgresql

+1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #20 from Matthew Miller mat...@redhat.com ---
(In reply to comment #19)
 Another issue is that I can't patch the compressed js files without
 recompressing them from the uncompressed files. Unless there is an js
 compression tool in fedora that I don't know of.

That seems bad in a practical sense from an open source point of view. If we
can't reasonably patch the software, it's a big problem. I hate to add more
blockers, but

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #21 from Gregor Tätzner gre...@freenet.de ---
(In reply to comment #20)
 That seems bad in a practical sense from an open source point of view. If we
 can't reasonably patch the software, it's a big problem. I hate to add more
 blockers, but

Of course we could skip that minify step and serve uncompressed js files,
though that would increase the net traffic. This would be as open source as it
can be :)

So I don't see a blocker here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #22 from Kevin Kofler ke...@tigcc.ticalc.org ---
If the minify step consists of running jsMin, then I can only strongly
recommend skipping that step, because jsMin is infected with the same silly no
Evil license clause as jsLint/jsHint.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #23 from Matthew Miller mat...@redhat.com ---
(In reply to comment #21)
 Of course we could skip that minify step and serve uncompressed js files,
 though that would increase the net traffic. This would be as open source as
 it can be :)

Let's do that, and then maybe eventually use yuicompressor?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #24 from Gregor Tätzner gre...@freenet.de ---
(In reply to comment #23)
 Let's do that, and then maybe eventually use yuicompressor?

Thats the way debian does it. But as long as we don't need to modify js files
and don't have a yuicompressor package this discussion is rather academic? ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Matthew Miller mat...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mat...@redhat.com
   Assignee|nob...@fedoraproject.org|mat...@redhat.com
  Flags||fedora-review-

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #19 from Gregor Tätzner gre...@freenet.de ---
(In reply to comment #17)
 A patch is not suitable to delete unacceptably-licensed code, you should
 repackage the tarball to get rid of it entirely.

Spec URL: http://brummbq.fedorapeople.org/owncloud.spec
SRPM URL: http://brummbq.fedorapeople.org/owncloud-4.0.8-4.fc17.src.rpm

(In reply to comment #18)
 So, one issue is that the bundled old version of the ace editor bundles
 JSHint into the same file as the rest of the JavaScript worker. In the
 current upstream code, it is a separate file, which would be much easier to
 get rid of without removing other functionality (rm the file from the
 tarball, then apply a patch to remove its uses).

Are you suggesting to replace the bundled aceeditor with the current upstream
one?

Another issue is that I can't patch the compressed js files without
recompressing them from the uncompressed files. Unless there is an js
compression tool in fedora that I don't know of.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #16 from Gregor Tätzner gre...@freenet.de ---
spec file with longest license tag ever:

Spec URL: http://brummbq.fedorapeople.org/owncloud.spec
SRPM URL: http://brummbq.fedorapeople.org/owncloud-4.0.8-3.fc17.src.rpm

(In reply to comment #14)
 I think the simplest fix would be to rip out the JavaScript mode from
 aceeditor

Well, some other modes are also using that jslint-javascript-worker. I've just
deleted those files, which means that the syntax highlighting doesn't work any
more for these file types. But you are still able to edit them.

If you can come up with a better patch, feel free to attach it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #17 from Kevin Kofler ke...@tigcc.ticalc.org ---
A patch is not suitable to delete unacceptably-licensed code, you should
repackage the tarball to get rid of it entirely.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #18 from Kevin Kofler ke...@tigcc.ticalc.org ---
So, one issue is that the bundled old version of the ace editor bundles JSHint
into the same file as the rest of the JavaScript worker. In the current
upstream code, it is a separate file, which would be much easier to get rid of
without removing other functionality (rm the file from the tarball, then apply
a patch to remove its uses). With this code, the repackaging script will need
to use some sed or awk to remove the offending lines by number (because it
cannot mention the code to be removed if it is to be shipped in the SRPM), then
a patch can be applied. (Or you have to delete the whole worker_javascript.js
as you did now with the patch and then deal with the fallout, but that breaks a
lot more functionality than needed. :-( )

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #12 from Gregor Tätzner gre...@freenet.de ---
Created attachment 637034
  -- https://bugzilla.redhat.com/attachment.cgi?id=637034action=edit
copyright file extracted from debian owncloud package

Spec URL: http://brummbq.fedorapeople.org/owncloud.spec
SRPM URL: http://brummbq.fedorapeople.org/owncloud-4.0.8-2.fc17.src.rpm

this is for the legal folks:
I've updated the license field in the spec. Is it ok? Am I missing something
important? I've attached also the copyright file from debian. They have
searched through the source code and listed all licenses, I suppose. Note that
most of the 3rdparty libs are stripped out at build time with exception of
phpass and the js stuff.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Gregor Tätzner gre...@freenet.de changed:

   What|Removed |Added

 Blocks||182235 (FE-Legal)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 CC||tcall...@redhat.com

--- Comment #13 from Tom spot Callaway tcall...@redhat.com ---
One big showstopper:

- jslint rears its ugly head again.
apps/files_texteditor/js/aceeditor/worker-javascript.js contains the jslint
code (well, the jshint derived code) and that license is non-free because of
the infamous The Software shall be used for Good, not Evil.

No code under that license is Free, and is not acceptable for Fedora. I'm not
sure if there is a way to remove this portion of the code (or maybe just the
aceeditor code altogether), but it cannot go into Fedora as is. (And we know
from previous attempts that Douglas will not waive the problematic clause.)


A few minor notes:

- There are other aceeditor js files which are (MPLv1.1 or GPLv2+ or LGPLv2+).
- some of the jquery plugins are (MIT or GPL+)
- others (timepicker) are (MIT or GPLv2)
- The ODF icons are ASL 2.0 [see: core/img/filetypes/readme-2.txt]
- The Silk icons are CC-BY
- The kde-look icons are CC-BY-SA

All of those licenses need to be reflected in the License tag (the ones in
parenthesis need to be listed with their parenthesis).

**
I realize that it is a moot point if the jslint issue is not resolved, but I
figured I'd go ahead and finish looking for licenses while I was in there. 

Leaving blocked on FE-Legal.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #14 from Kevin Kofler ke...@tigcc.ticalc.org ---
I think the simplest fix would be to rip out the JavaScript mode from
aceeditor, or at least the parts that use jshint (in
lib/ace/mode/javascript-worker.js, and of course
lib/ace/mode/javascript/jshint.js needs to be zapped entirely).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-11-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #15 from Kevin Kofler ke...@tigcc.ticalc.org ---
(The file names in comment #14 are from current upstream, it looks like the
bundled code is older and uses different file names.)

FWIW, the ace editor is arguably in violation of the JSLint/JSHint license,
considering that:
* according to the license, The Software shall be used for Good, not Evil.
* according to http://www.jslint.com/lint.html , eval is evil
* https://github.com/ajaxorg/ace/blob/master/lib/ace/mode/javascript_worker.js
contains both a call to JSHint and the following:
eval(throw 0; + str);
:-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-10-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Gregor Tätzner gre...@freenet.de changed:

   What|Removed |Added

 Blocks||656997 (kde-reviews)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-10-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Kevin Kofler ke...@tigcc.ticalc.org changed:

   What|Removed |Added

 CC||ke...@tigcc.ticalc.org
  Alias||owncloud

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-10-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #11 from Gregor Tätzner gre...@freenet.de ---
I'm planning to stick to the 4.0.x series for now and update to 4.5
post-review, provided that this review doesn't take forever...

btw still in the need of a reviewer for
https://bugzilla.redhat.com/show_bug.cgi?id=859713

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-10-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #10 from Xavier Bachelot xav...@bachelot.org ---
Maybe you want to concentrate on the 4.0.x series, however 4.5.0 has been
released on October, 11th.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-10-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #9 from Gregor Tätzner gre...@freenet.de ---
owncloud-4.0.8

Spec URL: http://brummbq.fedorapeople.org/owncloud.spec
SRPM URL: http://brummbq.fedorapeople.org/owncloud-4.0.8-1.fc17.src.rpm

(In reply to comment #8)
 I'll review this this weekend during FUDCon.
maybe *this* weekend? ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-10-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Gregor Tätzner gre...@freenet.de changed:

   What|Removed |Added

 Depends On||859731

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-10-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Bug 858841 depends on bug 859740, which changed state.

Bug 859740 Summary: php-getid3 ships an unsupported development version
https://bugzilla.redhat.com/show_bug.cgi?id=859740

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NEXTRELEASE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-10-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #8 from Christoph Wickert cwick...@fedoraproject.org ---
I'll review this this weekend during FUDCon. If somebody else is quicker, go
ahead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-10-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #6 from Gregor Tätzner gre...@freenet.de ---
Spec URL: http://brummbq.fedorapeople.org/owncloud.spec
SRPM URL: http://brummbq.fedorapeople.org/owncloud-4.0.7-4.fc17.src.rpm

-unbundle php-getid3
-fixes selinux error in combination with latest selinux-policy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-10-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #7 from Gregor Tätzner gre...@freenet.de ---
correct links:

Spec URL: http://brummbq.fedorapeople.org/owncloud.spec
SRPM URL: http://brummbq.fedorapeople.org/owncloud-4.0.7-5.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-10-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #5 from Gregor Tätzner gre...@freenet.de ---
Spec URL: http://brummbq.fedorapeople.org/owncloud.spec
SRPM URL: http://brummbq.fedorapeople.org/owncloud-4.0.7-4.fc17.src.rpm

small update

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-09-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #4 from Gregor Tätzner gre...@freenet.de ---
(In reply to comment #3)
 just a few drive-by comments:
 - is that main package functional without any of those database
 sub-packages?
No, not really. Though you can't install owncloud without at least one database
sub-package because the main pkg requires: %{name}-database =
%{version}-%{release}

 - you also need to require rsyslog (for dir /etc/rsyslog.d), 
   note: there's also syslog-ng, you're fine to uninstall rsyslog from your
 system
I think I will switch back to the internal logging mechanism of owncloud. It
doesn't require any kind of syslog, so we don't have to bother with the correct
dependencies :) 

 - the svg-editor is also LGPLv3 and MIT
oc 4.0 does not yet include svg-edit, but I've added a note

thanks for the comment

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-09-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Matthias Runge mru...@redhat.com changed:

   What|Removed |Added

 CC||mru...@redhat.com

--- Comment #3 from Matthias Runge mru...@redhat.com ---
just a few drive-by comments:
- is that main package functional without any of those database sub-packages? 
- you also need to require rsyslog (for dir /etc/rsyslog.d), 
  note: there's also syslog-ng, you're fine to uninstall rsyslog from your
system
- same for that logrotate-snippet
- the svg-editor is also LGPLv3 and MIT
https://github.com/owncloud/apps/blob/master/files_svgedit/README

http://fedoraproject.org/wiki/Licensing#Good_Licenses lists, LGPLv3 is only
sort of compatible with AGPL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-09-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #2 from Gregor Tätzner gre...@freenet.de ---
Spec URL: http://brummbq.fedorapeople.org/owncloud.spec
SRPM URL: http://brummbq.fedorapeople.org/owncloud-4.0.7-3.fc17.src.rpm

third iteration, I've added also database subpackagesso you don't have to
install all db drivers anymore.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-09-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Gregor Tätzner gre...@freenet.de changed:

   What|Removed |Added

 Depends On||859713

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-09-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Gregor Tätzner gre...@freenet.de changed:

   What|Removed |Added

 Depends On||859740

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-09-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

Gregor Tätzner gre...@freenet.de changed:

   What|Removed |Added

 Depends On||858946

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858841] Review Request: owncloud - Private file sync and share server

2012-09-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858841

--- Comment #1 from Gregor Tätzner gre...@freenet.de ---
Spec URL: http://brummbq.fedorapeople.org/owncloud.spec
SRPM URL: http://brummbq.fedorapeople.org/owncloud-4.0.7-2.fc17.src.rpm

bump...feedback welcome :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review