[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-12-20 Thread bugzilla 
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864941

--- Comment #13 from Fedora Update System  ---
subsurface-2.1-1.fc18 has been pushed to the Fedora 18 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=doJMRkzkIv&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-12-20 Thread bugzilla 
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=864941

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-12-20 10:26:49

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=vOheYWdd9u&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-10-23 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=864941

--- Comment #12 from Fedora Update System  ---
subsurface-2.1-1.fc18 has been pushed to the Fedora 18 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-10-23 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=864941

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-10-23 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=864941

--- Comment #11 from Fedora Update System  ---
subsurface-2.1-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/subsurface-2.1-1.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-10-22 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=864941

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-10-22 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=864941

--- Comment #10 from Fedora Update System  ---
subsurface-2.1-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/subsurface-2.1-1.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-10-20 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=864941

--- Comment #9 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-10-19 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=864941

Pierre-YvesChibon  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #8 from Pierre-YvesChibon  ---
Thanks for the review


New Package SCM Request
===
Package Name: subsurface
Short Description: Rough divelog in C and Gtk
Owners: pingou
Branches: F-17 F-18 devel
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-10-19 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=864941

Mario Blättermann  changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #7 from Mario Blättermann  ---
New scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4608865

$ rpmlint -i -v *subsurface.src: I: checking
subsurface.src: W: spelling-error Summary(en_US) divelog -> dive log, dive-log,
livelong
The value of this tag appears to be misspelled. Please double-check.

subsurface.src: W: spelling-error %description -l en_US libxml -> Librium
The value of this tag appears to be misspelled. Please double-check.

subsurface.src: W: spelling-error %description -l en_US libdivecomputer ->
microcomputer
The value of this tag appears to be misspelled. Please double-check.

subsurface.src: I: checking-url https://github.com/torvalds/subsurface (timeout
10 seconds)
subsurface.src: W: invalid-url Source0:
torvalds-subsurface-v2.0.1-0-g14856aa.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

subsurface.i686: I: checking
subsurface.i686: W: spelling-error Summary(en_US) divelog -> dive log,
dive-log, livelong
The value of this tag appears to be misspelled. Please double-check.

subsurface.i686: W: spelling-error %description -l en_US libxml -> Librium
The value of this tag appears to be misspelled. Please double-check.

subsurface.i686: I: checking-url https://github.com/torvalds/subsurface
(timeout 10 seconds)
subsurface.x86_64: I: checking
subsurface.x86_64: W: spelling-error Summary(en_US) divelog -> dive log,
dive-log, livelong
The value of this tag appears to be misspelled. Please double-check.

subsurface.x86_64: W: spelling-error %description -l en_US libxml -> Librium
The value of this tag appears to be misspelled. Please double-check.

subsurface.x86_64: I: checking-url https://github.com/torvalds/subsurface
(timeout 10 seconds)
subsurface-debuginfo.i686: I: checking
subsurface-debuginfo.i686: I: checking-url
https://github.com/torvalds/subsurface (timeout 10 seconds)
subsurface-debuginfo.x86_64: I: checking
subsurface-debuginfo.x86_64: I: checking-url
https://github.com/torvalds/subsurface (timeout 10 seconds)
subsurface.spec: W: invalid-url Source0:
torvalds-subsurface-v2.0.1-0-g14856aa.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

5 packages and 1 specfiles checked; 0 errors, 9 warnings.


No recognizable issues anymore.

-
key:

[+] OK
[.] OK, not applicable
[X] needs work
-

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2
[.] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
c915ce10fa9b932eb71f43df96458b1e8b4af313ffcde1b83234db4ad14b8a62 
torvalds-subsurface-v2.0.1-0-g14856aa.tar.gz
c915ce10fa9b932eb71f43df96458b1e8b4af313ffcde1b83234db4ad14b8a62 
torvalds-subsurface-v2.0.1-0-g14856aa.tar.gz.packaged

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[+] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales p

[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-10-18 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=864941

--- Comment #6 from Pierre-YvesChibon  ---
- License changed
- %{buildroot} replaced by $RPM_BUILD_ROOT

Updated files:
Spec URL: http://pingou.fedorapeople.org/RPMs//subsurface.spec
SRPM URL: http://pingou.fedorapeople.org/RPMs//subsurface-2.0.1-3.fc17.src.rpm

Thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-10-17 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=864941

--- Comment #5 from Mario Blättermann  ---
New scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4601057

$ rpmlint -i -v *
subsurface.src: I: checking
subsurface.src: W: spelling-error Summary(en_US) divelog -> dive log, dive-log,
livelong
The value of this tag appears to be misspelled. Please double-check.

subsurface.src: W: spelling-error %description -l en_US libxml -> Librium
The value of this tag appears to be misspelled. Please double-check.

subsurface.src: W: spelling-error %description -l en_US libdivecomputer ->
microcomputer
The value of this tag appears to be misspelled. Please double-check.

subsurface.src: I: checking-url https://github.com/torvalds/subsurface (timeout
10 seconds)
subsurface.src: W: invalid-url Source0:
torvalds-subsurface-v2.0.1-0-g14856aa.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

subsurface.i686: I: checking
subsurface.i686: W: spelling-error Summary(en_US) divelog -> dive log,
dive-log, livelong
The value of this tag appears to be misspelled. Please double-check.

subsurface.i686: W: spelling-error %description -l en_US libxml -> Librium
The value of this tag appears to be misspelled. Please double-check.

subsurface.i686: I: checking-url https://github.com/torvalds/subsurface
(timeout 10 seconds)
subsurface.x86_64: I: checking
subsurface.x86_64: W: spelling-error Summary(en_US) divelog -> dive log,
dive-log, livelong
The value of this tag appears to be misspelled. Please double-check.

subsurface.x86_64: W: spelling-error %description -l en_US libxml -> Librium
The value of this tag appears to be misspelled. Please double-check.

subsurface.x86_64: I: checking-url https://github.com/torvalds/subsurface
(timeout 10 seconds)
subsurface-debuginfo.i686: I: checking
subsurface-debuginfo.i686: I: checking-url
https://github.com/torvalds/subsurface (timeout 10 seconds)
subsurface-debuginfo.x86_64: I: checking
subsurface-debuginfo.x86_64: I: checking-url
https://github.com/torvalds/subsurface (timeout 10 seconds)
subsurface.spec: W: invalid-url Source0:
torvalds-subsurface-v2.0.1-0-g14856aa.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

5 packages and 1 specfiles checked; 0 errors, 9 warnings.


Some ignorable spelling errors. Some remaining issues, though:

Don't mix $RPM_BUILD_ROOT and %{buildroot}.

Regarding the license, the README file says GPLv2, and "licensecheck -r ./"
delivers no file header which could contain the "newer versions" clause.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-10-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=864941

--- Comment #4 from Pierre-YvesChibon  ---
Thanksfor the feed-back, there is the update:

Spec URL: http://pingou.fedorapeople.org/RPMs//subsurface.spec
SRPM URL: http://pingou.fedorapeople.org/RPMs//subsurface-2.0.1-2.fc17.src.rpm

Changes:
- Use the macro libdc_version in the R and BR
- Add desktop-file-utils as BR
(and the files section)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-10-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=864941

--- Comment #3 from Mario Blättermann  ---
Scratch build fails for Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4592224

/var/tmp/rpm-tmp.p9rc6U: line 37: desktop-file-install: command not found

The package desktop-file-utils has to be added to BuildRequires.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-10-10 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=864941

--- Comment #2 from Pierre-YvesChibon  ---
These are details which are not blocking for the review, I will change them at
import or all in one go if there are other changes to make.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 864941] Review Request: subsurface - Rough divelog in C and Gtk

2012-10-10 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=864941

Mario Blättermann  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mario.blaetterm...@gmail.co
   ||m
   Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
   ||m
  Flags||fedora-review?

--- Comment #1 from Mario Blättermann  ---
Taking this for review. Be patient, could need some days.

I had a first look at the spec. Some issues:

%{_mandir}/man1/%{name}.1.gz

Currently our man pages are gzipped, but this could change in the future.
Please use

%{_mandir}/man1/%{name}.1.*

and remove the trailing whitespace.



To make sure that subsurface picks up the right version of libdivecomputer in
any case, you could use a %global definition:

%global libdivecomputerversion 0.2.0
...
BuildRequires:  libdivecomputer-devel == %{libdivecomputerversion}
BuildRequires:  libdivecomputer-static == %{libdivecomputerversion}
...
Requires:   libdivecomputer == %{libdivecomputerversion}


glib2-devel is a recursive dependency of gtk2-devel, you might drop it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review