[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 Fedora Update System changed: What|Removed |Added Fixed In Version|springframework-batch-2.1.9 |springframework-batch-2.1.9 |-2.fc20 |-1.fc19 --- Comment #18 from Fedora Update System --- springframework-batch-2.1.9-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||springframework-batch-2.1.9 ||-2.fc20 Resolution|--- |ERRATA Last Closed||2013-11-11 19:42:28 --- Comment #17 from Fedora Update System --- springframework-batch-2.1.9-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System --- springframework-batch-2.1.9-2.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 --- Comment #15 from Fedora Update System --- springframework-batch-2.1.9-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/springframework-batch-2.1.9-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 --- Comment #14 from Fedora Update System --- springframework-batch-2.1.9-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/springframework-batch-2.1.9-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 --- Comment #13 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 --- Comment #12 from gil cattaneo --- (In reply to Michal Srb from comment #10) > The package looks good, just one non-blocker: > [!]: Latest version is packaged. > Latest stable version is 2.2.2: > https://github.com/spring-projects/spring-batch/releases yes, but for now there are unavailable build deps org.springframework.data depend on querydsl http://gil.fedorapeople.org/querydsl-3.2.2-1.fc19.src.rpm http://gil.fedorapeople.org/querydsl.spec spring-data-commons spring-data-mongodb spring-data-neo4j spring-data-gemfire spring-data-redis org.springframework.amqp: spring-amqp spring-rabbit besides the fact that it depends on springframework 3.2.0.RELEASE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from gil cattaneo --- Thanks! yes, sure New Package SCM Request === Package Name: springframework-batch Short Description: Tools for enterprise batch or bulk processing Owners: gil msrb Branches: f19 f20 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753
Michal Srb changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #10 from Michal Srb ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: If tests are skipped during package build explain why it was needed in a
comment
[x]: Pom files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
springframework-batch-javadoc
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license t
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 Bug 881753 depends on bug 877152, which changed state. Bug 877152 Summary: Review Request: springframework-ws - Spring Web Services https://bugzilla.redhat.com/show_bug.cgi?id=877152 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 --- Comment #9 from gil cattaneo --- found a patch for hsqldb 2.x but is NOT applicable to this release see https://github.com/spring-projects/spring-batch/pull/145 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 --- Comment #8 from gil cattaneo --- in my system (f19) is not available hsqldb 2.x, and i not sure if with the changes that you ask of me, there are no problems of compatibility. for now leave hsqldb 1.x Spec URL: http://gil.fedorapeople.org/springframework-batch.spec SRPM URL: http://gil.fedorapeople.org/springframework-batch-2.1.9-1.fc19.src.rpm Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6094671 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 --- Comment #7 from Michal Srb --- It seems like people prefer springframework-* naming [1], so let's keep the name as it is. [1]: https://lists.fedoraproject.org/pipermail/java-devel/2013-October/004967.html Looks like there is some problem with hsqldb and springframework-batch. Probably due to fact that hsqldb1 is a compat package. "Could not resolve dependencies for project org.springframework.batch:spring-batch-core:jar:2.1.9.RELEASE: Cannot access central (http://repo.maven.apache.org/maven2) in offline mode and the artifact hsqldb:hsqldb:jar:SYSTEM has not been downloaded from it before." However, instead of fixing this problem I would recommend updating this package to version 2.2.2 which depends on hsqldb 2.x. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 --- Comment #6 from Michal Srb --- (In reply to gil cattaneo from comment #5) > for me it is not a problem, but the so called to make sure that users do not > confuse it with the packages related to spring(rts) > http://pkgs.fedoraproject.org/cgit/spring.git/ > i have already similar problem with hibernate packages, user confused this > one with pm-hibernate (pm-utils) > regards Never heard of spring RTS before. I am convinced that spring technologies are popular enough and people will not confuse "spring-batch - Tools for enterprise batch or bulk processing" with RTS game called spring. But like I said, it's up to you. If you like "springframework-batch" more, then I am OK with that. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 --- Comment #5 from gil cattaneo --- (In reply to Michal Srb from comment #4) > I have a suggestion here. I would rename the package to "spring-batch". > "springframework-batch" is not wrong, but we already have packages like > spring-ldap, now spring-retry. These are standalone libraries that can be > easily used outside of spring framework. However, if you don't agree it's > not really a deal breaker for me. I will do the review anyway. for me it is not a problem, but the so called to make sure that users do not confuse it with the packages related to spring(rts) http://pkgs.fedoraproject.org/cgit/spring.git/ i have already similar problem with hibernate packages, user confused this one with pm-hibernate (pm-utils) regards -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 --- Comment #4 from Michal Srb --- I have a suggestion here. I would rename the package to "spring-batch". "springframework-batch" is not wrong, but we already have packages like spring-ldap, now spring-retry. These are standalone libraries that can be easily used outside of spring framework. However, if you don't agree it's not really a deal breaker for me. I will do the review anyway. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 --- Comment #3 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/springframework-batch.spec SRPM URL: http://gil.fedorapeople.org/springframework-batch-2.1.9-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 Michal Srb changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@redhat.com Assignee|nob...@fedoraproject.org|m...@redhat.com Flags||fedora-review? --- Comment #2 from Michal Srb --- I will also need this package, taking this review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
https://bugzilla.redhat.com/show_bug.cgi?id=881753 gil cattaneo changed: What|Removed |Added Blocks||968136 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ehw5ckdgzq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881753 --- Comment #1 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/springframework-batch.spec SRPM URL: http://gil.fedorapeople.org/springframework-batch-2.1.9-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YwPS8B26x3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881753 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ie4xTJNlKj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881753 Bug 881753 depends on bug 866239, which changed state. Bug 866239 Summary: Review Request: gemini-blueprint - Reference Implementation of the OSGi Blueprint Service https://bugzilla.redhat.com/show_bug.cgi?id=866239 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ywifut14c1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 881753] Review Request: springframework-batch - Tools for enterprise batch or bulk processing
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881753 gil cattaneo changed: What|Removed |Added Depends On||877152, 866239 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
