[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #34 from Fedora Update System upda...@fedoraproject.org --- msitools-0.91-3.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UxyOeN4CX2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-03-05 18:28:44 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cm1ZU28cNVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=S7bJJ5nkXVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #32 from Fedora Update System upda...@fedoraproject.org --- msitools-0.91-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/msitools-0.91-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=b7GV2hWxova=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jcSauMHefha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #33 from Fedora Update System upda...@fedoraproject.org --- msitools-0.91-3.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RliPGfNDNHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #27 from Marc-Andre Lureau marcandre.lur...@redhat.com --- Paolo, would you like some help? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6bYsA0fUira=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 Paolo Bonzini pbonz...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #28 from Paolo Bonzini pbonz...@redhat.com --- New Package SCM Request === Package Name: msitools Short Description: msitools inspect and create Windows Installer files Owners: pbonzini elmarco Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=STw9rU2LNZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #29 from Jon Ciesla limburg...@gmail.com --- WARNING: pbonzini is not a valid FAS account. WARNING: Invalid branch f19 requested -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5zYZuoMOA7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 Paolo Bonzini pbonz...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #30 from Paolo Bonzini pbonz...@redhat.com --- New Package SCM Request === Package Name: msitools Short Description: msitools inspect and create Windows Installer files Owners: bonzini elmarco Branches: f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5ozzCfXLVNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #31 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=beA6ZuXYdna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #24 from Simone Caronni negativ...@gmail.com --- Hello, any progress? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sNzISdfJlOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #25 from Paolo Bonzini pbonz...@redhat.com --- Spec URL: http://bonzini.fedorapeople.org/msitools.spec SRPM URL: http://bonzini.fedorapeople.org/msitools-0.91-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=huJ0KXaCxYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 Simone Caronni negativ...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #26 from Simone Caronni negativ...@gmail.com --- Perfect, package approved! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HJXrt0tFxia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #19 from Paolo Bonzini pbonz...@redhat.com --- Oops, sorry. http://bonzini.fedorapeople.org/msitools-0.91-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UtDMLxQWpNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #20 from Simone Caronni negativ...@gmail.com --- Just for fedora-review, or it doesn't work: Spec URL: http://bonzini.fedorapeople.org/msitools.spec SRPM URL: http://bonzini.fedorapeople.org/msitools-0.91-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sESvrvgqasa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #21 from Simone Caronni negativ...@gmail.com --- Package Review == Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated = MUST items = C/C++: [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [!]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 61440 bytes in 3 files. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. [x]: SourceX / PatchY prefixed with %{name}. [x]: SourceX is a working URL. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #22 from Simone Caronni negativ...@gmail.com --- msitools.src: W: spelling-error %description -l en_US mingw - mingy, mining msitools.x86_64: W: spelling-error %description -l en_US mingw - mingy, mining msitools.x86_64: W: no-manual-page-for-binary msiextract msitools.x86_64: W: no-manual-page-for-binary wixl msitools.x86_64: W: no-manual-page-for-binary wixl-heat msitools.x86_64: W: no-manual-page-for-binary msiinfo msitools.x86_64: W: no-manual-page-for-binary msibuild libmsi1.x86_64: W: spelling-error %description -l en_US libmsi - flimsily libmsi1-devel.x86_64: W: no-dependency-on libmsi1/libmsi1-libs/liblibmsi1 libmsi1-devel.x86_64: W: spelling-error %description -l en_US libmsi - flimsily libmsi1-devel.x86_64: W: no-documentation -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KNNo4IrLoKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #23 from Simone Caronni negativ...@gmail.com --- Issues: === [!]: Requires correct, justified where necessary. libmsi1-devel.x86_64: W: no-dependency-on libmsi1/libmsi1-libs/liblibmsi1 It's as you posted earlier, but please use: Requires: libmsi1%{?_isa} = %{version}-%{release} Or the dependency it's on the msitools base package. === Please widen the description of the packages to 80 columns (comment #18). === Add the missing changelog line for 0.91-1. After those, the package is approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Huy0VZBFsaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #10 from Simone Caronni negativ...@gmail.com --- Hello, I planned to do the review yesterday but I was stuck in a meeting all day. I assigned myself the 12th afternoon and now is 14th morning, please wait a sec.. Doing the review now. --Simone -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=A4Mnvqsg5ta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #11 from Simone Caronni negativ...@gmail.com --- A few issues before building: 1) gcab has renamed the library to libgcab1-devel; so that should be used as BuildRequires. 2) Line 52; please avoid the %make_install macro. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used 3) Change the subpackages names from libmsi-1.0* to something else (like libmsi1*, as MA Lureau did for gcab) as the . character is not valid with package names. https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators 4) Remove the Group tag from line 26 and 35 as they are needed only for EPEL5. 5) Line 37 should be removed, requirements for the correct shared library are added automatically when building. 6) Please sort the BuildRequires. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m8KVgamARxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #12 from Simone Caronni negativ...@gmail.com --- (In reply to comment #11) 2) Line 52; please avoid the %make_install macro. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ Guidelines#Why_the_.25makeinstall_macro_should_not_be_used Well, this is optional, is the %makeinstall macro which is forbidden. If you want to leave it as is, that's fine. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MGXpu948Esa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #13 from Ralf Corsepius rc040...@freenet.de --- (In reply to comment #12) (In reply to comment #11) 2) Line 52; please avoid the %make_install macro. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ Guidelines#Why_the_.25makeinstall_macro_should_not_be_used Well, this is optional, is the %makeinstall macro which is forbidden. If you want to leave it as is, that's fine. Not quite: Fedora's RPM includes a %makeinstall macro but it must NOT be used when make install DESTDIR=%{buildroot} works. must NOT be used = %make_install is only allowed as last resort, if a package does not support make DESTDIR=... install. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SDJuyd1b9Ja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #14 from Simone Caronni negativ...@gmail.com --- You're(In reply to comment #13) Fedora's RPM includes a %makeinstall macro but it must NOT be used when make install DESTDIR=%{buildroot} works. must NOT be used = %make_install is only allowed as last resort, if a package does not support make DESTDIR=... install. It's the same thing I thought, but if you read carefully you're mixing %makeinstall with %make_install. The former is forbidden, the latter is allowed. The guidelines say: Fedora's RPM includes a %makeinstall macro but it must NOT be used when make install DESTDIR=%{buildroot} works. Instead, Fedora packages should use: %make_install (Note the _ !), make DESTDIR=%{buildroot} install or make DESTDIR=$RPM_BUILD_ROOT install. Those all do the same thing. In fact I thought also the one with the underscore was forbidden, but apparently not. Regards, --Simone -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rCsBsG3scPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #16 from Simone Caronni negativ...@gmail.com --- (In reply to comment #15) rpmlint complains if you leave this out (no-version-dependency-on, I think). I changed it to the standard form which is: If you remove the lines entirely, rpmbuild packs in the soname with major/minor as requirement and rpmlint does not complain. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mZ8M1KyYAYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #15 from Paolo Bonzini pbonz...@redhat.com --- 5) Line 37 should be removed, requirements for the correct shared library are added automatically when building. rpmlint complains if you leave this out (no-version-dependency-on, I think). I changed it to the standard form which is: Requires: %{name} = %{version}-%{release} -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JA53nlnL1Ea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #17 from Paolo Bonzini pbonz...@redhat.com --- Nope, rpmlint complains if you leave it out. The soname is not enough for this check. However, it is not no-version-dependency-on, it is no-dependency-on: libmsi1-devel.x86_64: W: no-dependency-on libmsi1/libmsi1-libs/liblibmsi1 I uploaded a new version. Spec URL: http://bonzini.fedorapeople.org/msitools.spec SRPM URL: http://bonzini.fedorapeople.org/msitools-0.91-1.fc18.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4973908 rpmlint results: libmsi1-devel.x86_64: W: spelling-error %description -l en_US libmsi - flimsily libmsi1-devel.x86_64: W: no-documentation libmsi1.x86_64: W: spelling-error %description -l en_US libmsi - flimsily msitools.x86_64: W: spelling-error %description -l en_US mingw - mingy, mining msitools.x86_64: W: no-manual-page-for-binary msiextract msitools.x86_64: W: no-manual-page-for-binary wixl msitools.x86_64: W: no-manual-page-for-binary wixl-heat msitools.x86_64: W: no-manual-page-for-binary msiinfo msitools.x86_64: W: no-manual-page-for-binary msibuild msitools.src: W: spelling-error %description -l en_US mingw - mingy, mining 4 packages and 0 specfiles checked; 0 errors, 11 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PUwFDXW9QWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #18 from Simone Caronni negativ...@gmail.com --- (In reply to comment #17) Nope, rpmlint complains if you leave it out. The soname is not enough for this check. However, it is not no-version-dependency-on, it is no-dependency-on: libmsi1-devel.x86_64: W: no-dependency-on libmsi1/libmsi1-libs/liblibmsi1 Doh, that's new for me. Then leave it. I uploaded a new version. Spec URL: http://bonzini.fedorapeople.org/msitools.spec SRPM URL: http://bonzini.fedorapeople.org/msitools-0.91-1.fc18.src.rpm The spec file is missing changelog for 0.91-1; and the rpm still points to 0.91-1. 0.91-2 throws a 404 in the same place. I need the links to run fedora-review. The spec file is ok though, so i don't think there's any problem; as the link is available it should pass the review. What you could do just to improve it a little bit is widen the description of the packages to 80 columns and format line 36. Thanks, --Simone -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xGSUoXUSYta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #9 from Marc-Andre Lureau marcandre.lur...@redhat.com --- Hey, any reviewer help would be greatly appriciated! thanks :D -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tZl7r0ZY5fa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 Simone Caronni negativ...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||negativ...@gmail.com Assignee|nob...@fedoraproject.org|negativ...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6vBKwaVuZ0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 Bug 896011 depends on bug 895757, which changed state. Bug 895757 Summary: Review Request: gcab - GObject Cabinet library and tool https://bugzilla.redhat.com/show_bug.cgi?id=895757 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|NEXTRELEASE |--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jMyB2NlBcfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 Bug 896011 depends on bug 895757, which changed state. Bug 895757 Summary: Review Request: gcab - GObject Cabinet library and tool https://bugzilla.redhat.com/show_bug.cgi?id=895757 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2n92IS6ejEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 Bug 896011 depends on bug 895757, which changed state. Bug 895757 Summary: Review Request: gcab - GObject Cabinet library and tool https://bugzilla.redhat.com/show_bug.cgi?id=895757 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=r4jqZaYL37a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #6 from Paolo Bonzini pbonz...@redhat.com --- Updated spec and SRPM: Spec URL: http://bonzini.fedorapeople.org/msitools.spec SRPM URL: http://bonzini.fedorapeople.org/msitools-0.91-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pxIkEgw8EUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #7 from Marc-Andre Lureau marcandre.lur...@redhat.com --- It is missing libuuid-devel requires. Why do you run autogen? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JDRSywffSYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #8 from Paolo Bonzini pbonz...@redhat.com --- Fixed both. (I usually do autoreconf or autogen in case some of the patches affect configure.ac) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NoizwzXCYda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #5 from Paolo Bonzini pbonz...@redhat.com --- Yes, will fix. At the time of submission there was no stable source URL yet, then Marc-André proposed the package to GNOME. Is everything else okay? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nqSM452MaSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #4 from Susi Lehtola susi.leht...@iki.fi --- You need to follow https://fedoraproject.org/wiki/Packaging:SourceURL -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zxPTouLNvOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added CC||susi.leht...@iki.fi --- Comment #2 from Susi Lehtola susi.leht...@iki.fi --- What's the real source URL? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ac1hG47Yxha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 --- Comment #3 from Marc-Andre Lureau marcandre.lur...@redhat.com --- (In reply to comment #2) What's the real source URL? The last tarball http://ftp.gnome.org/pub/GNOME/sources/msitools/0.90/msitools-0.90.tar.xz The git: git://git.gnome.org/msitools -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DfhddIsLlPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 Paolo Bonzini pbonz...@redhat.com changed: What|Removed |Added CC||pbonz...@redhat.com Depends On||895757 Summary|Review Request: main |Review Request: msitools - |package name here - short |Windows Installer Tools |summary here | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=evVnx0DC9Ta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 896011] Review Request: msitools - Windows Installer Tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896011 Marc-Andre Lureau marcandre.lur...@redhat.com changed: What|Removed |Added CC||marcandre.lur...@redhat.com --- Comment #1 from Marc-Andre Lureau marcandre.lur...@redhat.com --- Would be nice to add msitools-completion.sh :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i3ZQINmz4za=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review