[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EFRYU9GjPxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-27 23:47:19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qwL7cqB1Qua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #22 from Fedora Update System upda...@fedoraproject.org --- openshift-java-client-2.0.3-3.20130320git7073708.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3TNroqK4lxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 Tomas Radej tra...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #16 from Tomas Radej tra...@redhat.com --- Sorry for the delay. The package is good to go. *** APPROVED *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YrkgMRRyuna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=E6oPaY9NtEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- openshift-java-client-2.0.3-3.20130320git7073708.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p5ejoSd0Gba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #17 from Gerard Ryan ger...@ryan.lt --- (In reply to comment #16) Sorry for the delay. The package is good to go. *** APPROVED *** Thanks a lot! :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qVJSHXflkya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Flags||fedora-cvs? --- Comment #18 from Gerard Ryan ger...@ryan.lt --- New Package SCM Request === Package Name: openshift-java-client Short Description: OpenShift Java Client Owners: galileo Branches: f19, f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EJkzUAADioa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #19 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kRuzLYUXDua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eZF5S6BwbSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rrbqfqyEYla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- openshift-java-client-2.0.3-3.20130320git7073708.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/openshift-java-client-2.0.3-3.20130320git7073708.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ecOlz9coqFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=902017
--- Comment #15 from Gerard Ryan ger...@ryan.lt ---
(In reply to comment #14)
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: Changelog in prescribed format.
There must either be a space on both sides of the delimiting dash, or
no delimiting dash at all. I. e.
...t.org - 2.0.3-2
or
...t.org 2.0.3-2
Fixed.
[!]: Package complies to the Packaging Guidelines
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
you should include
%doc license epl-v10.html
in %files and %files javadoc
Oops. I don't know how that got removed, thanks for pointing it out. Fixed.
Notes:
==
[!]: Requires correct, justified where necessary.
You don't need to specify Requires when building with %mvn_build
Fixed. I've left in Requires on jsch since it doesn't have a maven POM.
DIFF of specfile since previous uploaded version
===
@@ -4,7 +4,7 @@
Name: openshift-java-client
Version:2.0.3
-Release:2.%{checkout}%{?dist}
+Release:3.%{checkout}%{?dist}
Summary:OpenShift Java Client
Group: Development/Libraries
@@ -13,7 +13,6 @@ URL:http://openshift.redhat.com
Source0:
https://github.com/openshift/%{name}/archive/%{commit}/%{name}-%{version}-%{shortcommit}.tar.gz
BuildArch: noarch
-BuildRequires: java-devel
BuildRequires: maven-local
BuildRequires: jsch
BuildRequires: mvn(org.easytesting:fest-assert)
@@ -25,11 +24,6 @@ BuildRequires: mvn(log4j:log4j)
BuildRequires: mvn(org.codehaus.mojo:properties-maven-plugin)
BuildRequires: mvn(commons-io:commons-io)
Requires: jsch
-Requires: mvn(org.jboss:jboss-dmr)
-Requires: mvn(org.slf4j:slf4j-log4j12)
-Requires: mvn(commons-io:commons-io)
-Requires: mvn(org.codehaus.mojo:properties-maven-plugin)
-Requires: java
%description
This is a client for OpenShift written in java. It pretty much offers all
@@ -57,13 +51,20 @@ API documentation for %{name}.
%files -f .mfiles
%dir %{_javadir}/%{name}
+%doc license epl-v10.html
%files javadoc -f .mfiles-javadoc
+%doc license epl-v10.html
%changelog
-* Wed Mar 20 2013 Gerard Ryan gali...@fedoraproject.org -2.0.3-2
+* Fri Mar 29 2013 Gerard Ryan gali...@fedoraproject.org - 2.0.3-3
+- Fix changelog.
+- Remove unneeded Requires.
+- Added epl-v10.html as a doc to main and javadoc packages.
+
+* Wed Mar 20 2013 Gerard Ryan gali...@fedoraproject.org - 2.0.3-2
- Update to fix licensing and new Base64Coder implementation.
- Use new maven macros.
-* Sun Jan 20 2013 Gerard Ryan gali...@fedoraproject.org -2.0.3-1
+* Sun Jan 20 2013 Gerard Ryan gali...@fedoraproject.org - 2.0.3-1
- Initial package.
=
Spec URL:
http://galileo.fedorapeople.org/openshift-java-client/2.0.3-3/openshift-java-client.spec
SRPM URL:
http://galileo.fedorapeople.org/openshift-java-client/2.0.3-3/openshift-java-client-2.0.3-3.20130320git7073708.fc18.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=FVqKaTXzF0a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=902017
Tomas Radej tra...@redhat.com changed:
What|Removed |Added
Flags|needinfo?(tra...@redhat.com |
|) |
--- Comment #14 from Tomas Radej tra...@redhat.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: Changelog in prescribed format.
There must either be a space on both sides of the delimiting dash, or
no delimiting dash at all. I. e.
...t.org - 2.0.3-2
or
...t.org 2.0.3-2
[!]: Package complies to the Packaging Guidelines
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
you should include
%doc license epl-v10.html
in %files and %files javadoc
Notes:
==
[!]: Requires correct, justified where necessary.
You don't need to specify Requires when building with %mvn_build
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[!]: Package complies to the Packaging Guidelines
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), Unknown or generated. 2 files have unknown license.
Detailed output of licensecheck in /home/tradej/reviews/openshift-java-
client/review-openshift-java-client/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Java:
[x]: Fully versioned dependency in subpackages, if present.
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #10 from Gerard Ryan ger...@ryan.lt --- Even better! :) Thanks for that André. I'll update this package proposal after work today then. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=faasYqIsh2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #11 from Andre Dietisheim adiet...@redhat.com --- great, thanks :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DqrdCH9KtXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Flags||needinfo?(tra...@redhat.com ||) --- Comment #12 from Gerard Ryan ger...@ryan.lt --- Spec URL: http://galileo.fedorapeople.org/openshift-java-client/2.0.3-2/openshift-java-client.spec SRPM URL: http://galileo.fedorapeople.org/openshift-java-client/2.0.3-2/openshift-java-client-2.0.3-2.20130320git7073708.fc18.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5150244 (license tag in spec is wrong for this build, but is correct for the spec/srpm above) - Updated to include all the changes that have happened upstream -- Licensing fixed. -- André has removed the bundled Base64Coder class - Updated to use new maven macros. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sQHxZxKmA9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #13 from Gerard Ryan ger...@ryan.lt --- I think it's ready now Tomas, please have a look when you get a chance, thanks! :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c6MtFJMifwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #7 from Andre Dietisheim adiet...@redhat.com --- Hi Gerard thanks for pointing this out and replacing the forked version by a proper maven dependency. Nevertheless one important goal in the openshift-java-client is to have as little 3rd party dependencies as possible. Deep diving into this issue made me find a way to use JDK means to decode/encode base64 rather than relying on an external class. I'll therefore reject your pull-request and correct openshift-java-client to use the jdk for the (de)coding. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sfa07yZowma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #8 from Andre Dietisheim adiet...@redhat.com --- I filed this to our JIRA in https://issues.jboss.org/browse/JBIDE-13812 so that we can easily keep track of it. Can you please add this reference to the jboss issue tracker (I cannot) so that we get updates to this bugzilla in our issue? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W33TFmOfS4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added CC||socho...@redhat.com External Bug ID||JBoss Issue Tracker ||JBIDE-13812 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LHRijAzzHha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #9 from Andre Dietisheim adiet...@redhat.com --- I fixed the issue by using the JDK means to decode/encode base64 rather uisng the external class: https://github.com/openshift/openshift-java-client/pull/33 patch was pushed to master -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yOlkvfJHhsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #4 from Tomas Radej tra...@redhat.com --- Hi, the blocking bug was private by mistake. It is viewable now. I am sorry for the inconvenience. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nbGZypTHAJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #5 from Gerard Ryan ger...@ryan.lt --- No problem, I figured it was accidental :) Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YvUtfMlOpea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 Bug 902017 depends on bug 917656, which changed state. Bug 917656 Summary: License field in openshift-java-client POM confusing https://bugzilla.redhat.com/show_bug.cgi?id=917656 What|Removed |Added Status|NEW |CLOSED Resolution|--- |UPSTREAM -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=otPH8PB3Qna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #6 from Gerard Ryan ger...@ryan.lt --- Licensing problem fixed upstream. I've also just submitted a pull request to unbundle base64coder: https://github.com/openshift/openshift-java-client/pull/32 If/when that gets merged, I'll update the spec and srpm here, and we'll see if we can get any further along with this. :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sJ3f7BHhVAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #3 from Gerard Ryan ger...@ryan.lt --- Hi, Tomas, any update on this? I was without a net connection for the past few weeks so I couldn't check up anything with it. For some reason I don't seem to be able to access bug #917656 that this has been marked dependent on, is that intentional? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aZPpu45JYNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 Tomas Radej tra...@redhat.com changed: What|Removed |Added Depends On||917656 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2MdfNUA1xaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 --- Comment #2 from Tomas Radej tra...@redhat.com --- Hi, there are some licensing problems with this package - POM file declares the license to be ASL 2.0, but the ./license file and most of the files say EPL, Base64Coder is a class available in the base64coder package already in Fedora etc., so I will talk to upstream (I am a Red Hat employee) to correct this before I proceed with the review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cGDOtWkHU7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 Tomas Radej tra...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||tra...@redhat.com Assignee|nob...@fedoraproject.org|tra...@redhat.com Flags||fedora-review? --- Comment #1 from Tomas Radej tra...@redhat.com --- I'll do it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=90hIVM2bZna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 902017] Review Request: openshift-java-client - OpenShift Java Client
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=902017 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Summary|Review Request: main |Review Request: |package name here - short |openshift-java-client - |summary here |OpenShift Java Client -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gdzPw1I6vYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
