[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=927269 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added CC||limburg...@gmail.com Flags|fedora-cvs? | Flags||fedora-cvs+ --- Comment #27 from Jon Ciesla limburg...@gmail.com --- No owner specified. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KikjlfM4Q9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=927269 Adam Jackson a...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #26 from Adam Jackson a...@redhat.com --- Package Change Request == Package name: xorg-x11-glamor Branches: f18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NQxCvB8qk6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=927269 Adam Jackson a...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #28 from Adam Jackson a...@redhat.com --- Package Change Request == Package name: xorg-x11-glamor Owners: glisse airlied xgl-maint Branches: f18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oTftvJZq9Ia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #29 from Jon Ciesla limburg...@gmail.com --- Package Change Request == Package Name: xorg-x11-glamor Owners: glisse airlied xgl-maint Branches: f18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gRCZwoPG5Wa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #30 from Jon Ciesla limburg...@gmail.com --- Package Change Request == Package Name: xorg-x11-glamor Owners: glisse airlied xgl-maint New Branches: f18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tfw9MSrmHma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=927269 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cHp6MMeliaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #31 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). Note corrected formatting. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rCooEVaqxWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=927269 Dominik 'Rathann' Mierzejewski domi...@greysector.net changed: What|Removed |Added CC||domi...@greysector.net --- Comment #25 from Dominik 'Rathann' Mierzejewski domi...@greysector.net --- Can we get this on Fedora 18, too? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TDwzFIlSFka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 Jerome Glisse jgli...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-04-10 12:07:11 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pWF4y8LRgua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 Jerome Glisse jgli...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #23 from Jerome Glisse jgli...@redhat.com --- New Package SCM Request === Package Name: xorg-x11-glamor Short Description: glamor provides xorg-x11 acceleration using OpenGL Owners: glisse airlied xgl-maint Branches: f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LRuiHhncIja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ik4PGBqQKqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #24 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=siYCUA4rO3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #22 from Michal Schmidt mschm...@redhat.com --- (In reply to comment #21) I am gonna talk with Keith and maybe our lawyer to simplify the header maybe. Thank you. To be clear: I don't think there would be any problem if they refused to do any simplification. The missing licence headers in glamor_gldispatch.h and glamor_largepixmap.c are slightly more important. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=N358rd3uWfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #14 from Jerome Glisse jgli...@redhat.com --- Updated spec and srpm: http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor.spec http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor-0.5.0-3.20130401git81aadb8.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VBvgczyOI7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #15 from Michal Schmidt mschm...@redhat.com --- The src.rpm link points to the previous version. I see the correct link works: http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor-0.5.0-4.20130401git81aadb8.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0kZ1AqyPava=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #17 from Jerome Glisse jgli...@redhat.com --- I don't see any issue left ? Is there something specific that bother you ? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=23FOn15v4Ia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927269
--- Comment #16 from Michal Schmidt mschm...@redhat.com ---
I'm pasting the result of a semi-automated, hand-edited review (using the
fedora-review tool):
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
MIT/X11 (BSD like), Unknown or generated. 2 files have unknown
license. Detailed output of licensecheck in
/home/michich/927269-xorg-x11-glamor/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
NOTE: xorg-x11-glamor is not identical to the upstream
project/tarball/repository name, but it matches the xorg-x11-* naming
pattern
used in Fedora.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
NOTE: The multiple ownership of /usr/include/xorg is fine.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]:
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 Michal Schmidt mschm...@redhat.com changed: What|Removed |Added Assignee|dan.mas...@gmail.com|mschm...@redhat.com Flags|fedora-review? | --- Comment #18 from Michal Schmidt mschm...@redhat.com --- No. I asked Dan on IRC if I can just reassign this review to myself, but he has not responded yet. So I'll just go ahead, because I consider this review complete. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3CBknh04iwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 Michal Schmidt mschm...@redhat.com changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FOWSGd1E1ha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 Michal Schmidt mschm...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=181ey6j021a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #19 from Michal Schmidt mschm...@redhat.com --- fedora-review+ set. You may proceed with your SCM request. I suggest you to make the dependency on xorg-x11-server-Xorg an arch-specific one and add a comment explaining why the dependency exists. I did not want to block the review on this minor issue. Also I would be interested in any upstream activity related to the issues pointed out during this review (the missing licence headers in a couple of files, the exit() call in library code), but these are no blockers either. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T0b43wb9PSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #20 from Dan Mashal dan.mas...@gmail.com --- Thanks Michal for picking this up! Sorry I couldn't get to this sooner. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VQ8ROSEruja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #21 from Jerome Glisse jgli...@redhat.com --- The exit one is really a panic for case that should not happen, it's more like an assert i guess but using exit trigger Xorg trace stuff so often you end up with something usefull in the xorg log. I am gonna talk with Keith and maybe our lawyer to simplify the header maybe. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sZNlZxgL7Aa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #11 from Michal Schmidt mschm...@redhat.com --- From the spec: # No need to call to ldconfig for post installation/uninstallation as # the libglamor libglamoregl are dynamicly load through dl open by the # xserver or ddx driver. But to silence rpmlint just call them. Are you sure this comment is accurate? I can see that it is valid for libglamoregl.so, which gets dlopen'd by the X server using a full path, but this .so then depends on libglamor.so.0, which gets resolved using the standard dynamic linker search order. So I'd say ldconfig is in fact needed and not just to silence rpmlint. The -devel subpackage should require the base package using an arch-specific dependency. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package The explicit Requires: pkgconfig is redundant, because rpmbuild automatically added a requirement for /usr/bin/pkg-config for you. The explicit Requires: mesa-libEGL is redundant, because the devel subpackage depends on the main package, which in turn already requires libEGL.so.1()(64bit) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DXmibInDoSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #12 from Jerome Glisse jgli...@redhat.com --- I am pretty sure that given how X implement stuff it's not necessary but i don't feel like diving in that code again so i removed the comment. Fixed dependency http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor.spec http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor-0.5.0-3.20130401git81aadb8.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HkVMsE0Nvna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927269
--- Comment #13 from Michal Schmidt mschm...@redhat.com ---
Let's check the ownership of directories
(https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership):
%files
...
%{_libdir}/xorg/modules/libglamoregl.so
%{_datadir}/X11/xorg.conf.d/glamor.conf
These two directories you install files into are neither owned by your package
nor by any of the required packages. A possible way to prevent creating unowned
directories is to Require xorg-x11-server-Xorg, which owns them.
%files devel
%{_includedir}/xorg/glamor.h
/usr/include/xorg is multiply owned by several packages. You can make your
package own it too.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=mCp1BgRfq7a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #5 from Michal Schmidt mschm...@redhat.com --- Thanks for adding make-git-snapshot.sh and the comment in the spec on how to use it. That's helpful. Regarding the Release tag: A leading zero usually indicates a pre-release snapshot (see the NamingGuidelines) of the stated Version. However, your snapshot is newer than version 0.5.0, so the release should not start with a zero. You forgot to add a %changelog entry. Most importantly, the package does not build in mock: ... checking for EGL... no ... Processing files: xorg-x11-glamor-0.5.0-0.20130401git81aadb8.fc20.x86_64 error: File not found: /builddir/build/BUILDROOT/xorg-x11-glamor-0.5.0-0.20130401git81aadb8.fc20.x86_64/usr/lib64/xorg/modules/libglamoregl.so File not found: /builddir/build/BUILDROOT/xorg-x11-glamor-0.5.0-0.20130401git81aadb8.fc20.x86_64/usr/lib64/xorg/modules/libglamoregl.so RPM build errors: Child return code was: 1 My guess is you're missing some BuildRequires. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TEnsgKcVGua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #6 from Jerome Glisse jgli...@redhat.com --- Should i update the changelog even now as package is not accepted yet. It would leave a trace of all my mistake making package thought ;) Updated spec with proper dependency and version but did not updated changelog section: http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor.spec SRPM: http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor-0.5.0-1.20130401git81aadb8.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OKmFjFmaHta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #7 from Michal Schmidt mschm...@redhat.com --- (In reply to comment #6) Should i update the changelog even now as package is not accepted yet. It would leave a trace of all my mistake making package thought ;) Indeed it would and it's customary to do that. However, I won't insist on having multiple changelog entries during this review. At the very least, please keep the version-release of your %changelog entry consistent with the actual values, OK? (In the latest spec you already do that, good!). The SRPM now builds successfully, which allowed me to run rpmlint on it. Some issues to fix (or explain why they're not a problem): - xorg-x11-glamor.x86_64: W: shared-lib-calls-exit /usr/lib64/libglamor.so.0.0.0 exit@GLIBC_2.2.5 This is something to consider upstream. - xorg-x11-glamor.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libglamor.so - xorg-x11-glamor.x86_64: E: library-without-ldconfig-postin /usr/lib64/libglamor.so.0.0.0 See: https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries - There's a whole bunch of warnings like: xorg-x11-glamor.x86_64: W: undefined-non-weak-symbol /usr/lib64/libglamor.so.0.0.0 serverClient If these are expected, please explain why. Also please use %global instead of %define. See https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ik1wtp2tTaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 Dan Mashal dan.mas...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #8 from Dan Mashal dan.mas...@gmail.com --- Sorry for the delay on a comment from me, and thanks everyone else for their helpful comments. I will try to get this review started, if not finished by this weekend. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nzZc3v9Lqoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #9 from Michal Schmidt mschm...@redhat.com --- Some more stuff I found: - Upstream ships a COPYING file which you are not packaging as %doc. See https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text The licence text itself looks very MIT-like, which is good. - glamor_copyarea.c, glamor_copywindow.c, glamor_fill.c, glamor_fillspans.c, glamor_window.c have different licence headers than the rest of the files. They specifically speak about Keith Packard (his name not to be used in advertising, him disclaiming warranties, etc.). I don't think it's an actual problem, though it is a little odd. It might make sense to ask Keith kindly to update the licence headers to match the usual form. - glamor_eglmodule.c contains an additional requirement about the name of the XFree86 Project not to be used in advertising. This is perfectly acceptable, as far as I know. I'm just mentioning it for completeness. - glamor_glyphs.c contains two almost identical licence headers. One speaks about Red Hat, the other about SuSE. Perhaps the authors could agree on changing this to the unified standard form? - glamor_gldispatch.h, glamor_largepixmap.c have no license headers. The headers should be added by upstream. I have just bought a small computer with a AMD E2-1800 APU, with a AMD Radeon HD 7340. Should I be able to test this package on it? How would I do that? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=O5HyTlkh34a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #10 from Jerome Glisse jgli...@redhat.com --- Fixed devel package. Added ld-config post/unpost to silence rpmlint and added explanation on why it's not needed. Added doc. The undefined symbol are expected. This can only be loaded by the xserver or ddx through dlopen, the undefined symbol are part of the xserver and thus know at load time. To be thorough it's libglamor-egl which is dynamicly loaded, idea being we could have in a futur a libglamor-glx, difference would be in the glue both would use most of the same code that is in libglamor. You don't need glamor for HD7340, it's only needed for = HD77xx You can still try to use it but you would need to rebuild the ddx with : --enable-glamor once this glamor package is accepted and available i will update the xorg-x11-drv-ati to build with glamor and add automatic use of glamor on hd7xxx Updated spec and SRPM: http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor.spec http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor-0.5.0-2.20130401git81aadb8.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1FHldnFLDEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 Jerome Glisse jgli...@redhat.com changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #4 from Jerome Glisse jgli...@redhat.com --- Updated spec : http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor.spec SRPM: http://fedorapeople.org/~glisse/glamor/xorg-x11-glamor-0.5.0-0.20130401git81aadb8.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=38Dwp2BDr6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 Dan Mashal dan.mas...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||dan.mas...@gmail.com Assignee|nob...@fedoraproject.org|dan.mas...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=63hhf9yTJPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927269
--- Comment #3 from Michal Schmidt mschm...@redhat.com ---
Version: 0.5.0
Release: 0%{?dist}
Glamor 0.5.0 was released last year. You are packaging a more recent git
snapshot, so the versioning must follow the rules for snapshots:
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
# source tarball has to be created from git (not ftp/http tar archive) at :
# http://cgit.freedesktop.org/xorg/driver/glamor/
The instructions should be more specific to allow anyone to recreate the same
tarball. See:
https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
%description
glamor provide xorg-x11 acceleration using the OpenGL driver.
s/provide/provides/ ?
find $RPM_BUILD_ROOT -type f -name '*.la' | xargs rm -f -- || :
Looks like you could simplify the command if you just used find's -delete
action.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=4ZsLvgftfda=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 Michal Schmidt mschm...@redhat.com changed: What|Removed |Added CC||mschm...@redhat.com --- Comment #1 from Michal Schmidt mschm...@redhat.com --- Just looking at the spec: - The Group tag is optional. You may keep it or drop it. - If possible, use a full URL in Source0. - Please extend %description. - The manual cleaning of the build root at the beginning of %install is redundant. So is the %clean section. - The %check section is empty, so drop it. - %defattr is no longer necessary. - Please maintain a %changelog. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2F89a0WW9Oa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927269] Review Request: xorg-x11-glamor - xorg x11 acceleration using OpenGL
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927269 --- Comment #2 from Jerome Glisse jgli...@redhat.com --- Thank you for you review i have updated spec file and srpm same url. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IlMWayPn7Fa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
