[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #23 from Fedora Update System --- pyode-1.2.0-4.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TYHvIg4ARr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
https://bugzilla.redhat.com/show_bug.cgi?id=927611 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||pyode-1.2.0-4.el6 Resolution|--- |ERRATA Last Closed||2013-05-21 23:19:05 --- Comment #22 from Fedora Update System --- pyode-1.2.0-4.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NmTSMHYcdL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=riSbgVJrRV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #21 from Fedora Update System --- pyode-1.2.0-4.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2x3rj0dpa8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #20 from Fedora Update System --- pyode-1.2.0-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/pyode-1.2.0-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nN3YjCkMks&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #19 from Fedora Update System --- pyode-1.2.0-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/pyode-1.2.0-4.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sWd9deGOy4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #18 from Fedora Update System --- pyode-1.2.0-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/pyode-1.2.0-4.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=88vhpYF7Bv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #17 from Fedora Update System --- pyode-1.2.0-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/pyode-1.2.0-4.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kx83fP7MPL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=657w0XSJLp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #16 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KLgNpUiFkd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1XMe0fYxOC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 Ankur Sinha (FranciscoD) changed: What|Removed |Added Flags||fedora-cvs? --- Comment #15 from Ankur Sinha (FranciscoD) --- Thanks John. Setting the scm flag and pasting the request text (just to ensure that the reporter does it, not sure the script checks but better to be safe :) ) New Package SCM Request === Package Name: pyode Short Description: Open-source Python bindings for The Open Dynamics Engine Owners: ankursinha zultron Branches: f17 f18 f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hGHlGUed5y&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 John Morris changed: What|Removed |Added Flags||fedora-review+ --- Comment #14 from John Morris --- Looks great, Ankur. Thanks for the hard work! APPROVED Here's the SCM request to move things along. New Package SCM Request === Package Name: pyode Short Description: Open-source Python bindings for The Open Dynamics Engine Owners: ankursinha zultron Branches: f17 f18 f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9XOZgrx5GA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #13 from Ankur Sinha (FranciscoD) --- Updated ChangeLog too Ankur -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8R6TBozlXg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #12 from Ankur Sinha (FranciscoD) --- Hi John, Updated spec/srpm: http://ankursinha.fedorapeople.org/pyode/pyode-1.2.0-4.fc20.src.rpm http://ankursinha.fedorapeople.org/pyode/pyode.spec I'm more than happy to co-maintain the package with you. I don't generally maintain packages for epel any way :) * Fri Apr 26 2013 Ankur Sinha 1.2.0-4 - Add another patch to use almost equal assertion - Fix wrong end of line file encoding rpmlint error I also removed pyrex from Requires:, but forgot to add it to the changelog :| Thanks, Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1wThQK7Prw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #11 from John Morris --- These two should be the last items. Thanks for hanging on during this whole process! I'd like to be co-maintainer, by the way, and I'll be happy to help run this through the process of getting into the stable repos. John -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CyKD1JLhSC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #10 from John Morris --- Created attachment 740048 --> https://bugzilla.redhat.com/attachment.cgi?id=740048&action=edit patch to fix rounding errors in %check script Fix rounding-error test failures on Fedora 17-20 (but not el6!) (64-bit only?) Differences of 5*10^-8, as shown in below output, cause tests to fail. Fix by adding new check 'assertFloatListsAlmostEqual' which recursively sorts through lists/tuples and compares floats with 'assertAlmostEqual'. http://docs.python.org/2/library/unittest.html#unittest.TestCase.assertAlmostEqual == FAIL: testAMotorAxes3 (__main__.TestJointParser) -- Traceback (most recent call last): File "tests/test_xode.py", line 594, in testAMotorAxes3 self.assertEqual(ref, axes) AssertionError: Lists differ: [(1.0, 0.0, 0.0), (0.0, 1.0, 0... != [(0.999403953552, 0.0, 0.0... First differing element 0: (1.0, 0.0, 0.0) (0.999403953552, 0.0, 0.0) - [(1.0, 0.0, 0.0), (0.0, 1.0, 0.0), (0.0, 0.0, 1.0)] + [(0.999403953552, 0.0, 0.0), + (0.0, 0.999403953552, 0.0), + (0.0, 0.0, 0.999403953552)] -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CtnfjTD4TP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #9 from John Morris --- Heh, differs by 6e-8, so it fails. Patch coming up. I realize that Pyrex should not be in the Requires: section, only in the BuildRequires: section. My apologies, I was wrong about that. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QTCKyELhkn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #8 from Ankur Sinha (FranciscoD) --- I've applied the patch, but the tests still fail: + /usr/bin/python tests/test_xode.py ..FFFF.F.. == FAIL: testPlaneParams (__main__.TestGeomParser) -- Traceback (most recent call last): File "tests/test_xode.py", line 674, in testPlaneParams self.assertEqual(self.geom4.getParams(), ((0.0, 1.0, 0.0), 17.0)) AssertionError: Tuples differ: ((0.0, 0.999403953552, 0.0... != ((0.0, 1.0, 0.0), 17.0) First differing element 0: (0.0, 0.999403953552, 0.0) (0.0, 1.0, 0.0) - ((0.0, 0.999403953552, 0.0), 16.98092651367) + ((0.0, 1.0, 0.0), 17.0) == FAIL: testAMotorAxes1 (__main__.TestJointParser) -- Traceback (most recent call last): File "tests/test_xode.py", line 588, in testAMotorAxes1 self.assertEqual(ref, axis1) AssertionError: Tuples differ: (0.0, 1.0, 0.0) != (0.0, 0.999403953552, 0.0) First differing element 1: 1.0 0.99940395 - (0.0, 1.0, 0.0) + (0.0, 0.999403953552, 0.0) == FAIL: testAMotorAxes3 (__main__.TestJointParser) -- Traceback (most recent call last): File "tests/test_xode.py", line 594, in testAMotorAxes3 self.assertEqual(ref, axes) AssertionError: Lists differ: [(1.0, 0.0, 0.0), (0.0, 1.0, 0... != [(0.999403953552, 0.0, 0.0... First differing element 0: (1.0, 0.0, 0.0) (0.999403953552, 0.0, 0.0) - [(1.0, 0.0, 0.0), (0.0, 1.0, 0.0), (0.0, 0.0, 1.0)] + [(0.999403953552, 0.0, 0.0), + (0.0, 0.999403953552, 0.0), + (0.0, 0.0, 0.999403953552)] == FAIL: testHingeAxis (__main__.TestJointParser) -- Traceback (most recent call last): File "tests/test_xode.py", line 534, in testHingeAxis self.assertEqual(self.joint5.getAxis(), (1.0, 0.0, 0.0)) AssertionError: Tuples differ: (0.999403953552, 0.0, 0.0) != (1.0, 0.0, 0.0) First differing element 0: 0.99940395 1.0 - (0.999403953552, 0.0, 0.0) + (1.0, 0.0, 0.0) == FAIL: testSliderAxis (__main__.TestJointParser) -- Traceback (most recent call last): File "tests/test_xode.py", line 540, in testSliderAxis self.assertEqual(self.joint6.getAxis(), (0.0, 1.0, 0.0)) AssertionError: Tuples differ: (0.0, 0.999403953552, 0.0) != (0.0, 1.0, 0.0) First differing element 1: 0.99940395 1.0 - (0.0, 0.999403953552, 0.0) + (0.0, 1.0, 0.0) -- Ran 110 tests in 0.502s FAILED (failures=5) RPM build errors: Not sure what to do about this. I guess we'll have to have another chat with upstream. Anyway, updated spec/srpm here: http://ankursinha.fedorapeople.org/pyode/pyode.spec http://ankursinha.fedorapeople.org/pyode/pyode-1.2.0-3.fc19.src.rpm At least the packaging part looks OK now. Thanks, Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rIVrcDpGom&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #7 from Ankur Sinha (FranciscoD) --- Hi John, Thanks for the patch. I'll update the srpm/spec tonight and post updated versions. Thanks, Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IFxkY3haUZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927611
--- Comment #6 from John Morris ---
Created attachment 739265
--> https://bugzilla.redhat.com/attachment.cgi?id=739265&action=edit
Fix GC-related segfault
This patch fixes the xode test segfault described toward the end of comment #4.
More information:
http://comments.gmane.org/gmane.comp.python.pyode.user/174
The check can be enabled as such with all tests passing, and no final segfault:
%check
export PYTHONPATH=build/lib.linux-%{_target_cpu}-%{python_version}
%{__python} tests/test_xode.py
I am notifying upstream, and sending the patch in unified format as an
attachment. :P
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=hwanGA4qZF&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 --- Comment #5 from John Morris --- Hi Ankur, let me know if there's anything I can do to help. The point about %check above is not as straight-forward. I'll check with upstream about it. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8aFvyUlEY6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927611
John Morris changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|j...@zultron.com
--- Comment #4 from John Morris ---
Created attachment 735771
--> https://bugzilla.redhat.com/attachment.cgi?id=735771&action=edit
fedora-review results with reviewer notes
Here's the review. These comments may also be found at the bottom of the
attached file.
Reviewer notes
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
Rpmlint: pyode.x86_64: W: no-documentation
- No documentation
%doc should include AUTHORS ChangeLog LICENSE LICENSE-BSD README examples
--
[!]: Requires correct, justified where necessary.
- Need Requires: ode and Pyrex
--
[!]: Package meets the Packaging Guidelines::Python
- Python3 support: Infra is in specfile; does it work, and if so,
should it be turned on?
--
[!]: %check is present and all tests pass.
- Has this package been tested? This %check script fails with a
segfault, as does running the tests after install:
%check
export PYTHONPATH=build/lib.linux-%{_target_cpu}-%{python_version}
%{__python} tests/test_xode.py
--
Rpmlint: pyode.x86_64: W: non-standard-group Unspecified
- Main package missing Group: tag (though python3 package includes
it). I want this to be included in EPEL, where Group: is not
optional.
http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=XEDf4fSGy3&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927611
--- Comment #3 from John Morris ---
> > - If you remove execute permissions from ode.so, you won't have to bother
> > with the '%{?filter_setup:...' business. (Why do you set them in %install?)
>
> To get rid of this rpmlint error:
> pyode.x86_64: E: non-standard-executable-perm
> /usr/lib64/python2.7/site-packages/ode.so 0775L
>
> The permissions must be correct, and since it's an internally used shared
> object, it must be removed from provides.
Hmm, I learned something new. For regular packages containing modules, if the
module perms are set 0644, the filter_provides_in macro ignores them. Not so
with python modules.
> > - Nitpick: (I was dinged for this on my last pkg) Double spaces before
> > %description, %prep, %build, etc. make the specfile more readable.
>
> I don't think this is required. The spec is readable enough :)
Sure.
> > - Those comments about the tests might be more clear if they were prefaced
> > with a line like this that indicates they're the reason for not running
> > tests, despite the existence of a 'tests' directory:
> > #%%check
> Added phony check section line.
I'm addressing %check differently in the review.
Stay tuned...
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=qer9rN90nq&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927611
--- Comment #2 from Ankur Sinha (FranciscoD) ---
(In reply to comment #1)
> Hi Ankur, I was just about to package this, but you've done it for me! I'll
> be happy to help with the review. What are you doing with this? I want it
> for PyCAM (also in review).
The pybrain package recommends using pyode :)
>
> Quick drive-by before the real review:
>
> - This URL may help with the 'W: invalid-url' problem
> https://downloads.sourceforge.net/project/pyode/pyode/snapshot-2010-03-22/
> PyODE-snapshot-2010-03-22.tar.gz
Thanks. Updated.
>
> - If you remove execute permissions from ode.so, you won't have to bother
> with the '%{?filter_setup:...' business. (Why do you set them in %install?)
To get rid of this rpmlint error:
pyode.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.7/site-packages/ode.so 0775L
The permissions must be correct, and since it's an internally used shared
object, it must be removed from provides.
>
> - Nitpick: %description lacking a trailing '.'.
Corrected
>
> - Nitpick: (I was dinged for this on my last pkg) Double spaces before
> %description, %prep, %build, etc. make the specfile more readable.
I don't think this is required. The spec is readable enough :)
>
> - The %files section really does need blank lines to separate it from the
> %install script.
Added.
>
> - Those comments about the tests might be more clear if they were prefaced
> with a line like this that indicates they're the reason for not running
> tests, despite the existence of a 'tests' directory:
> #%%check
Added phony check section line.
[ankur@localhost SRPMS]$ rpmlint ../SPECS/pyode.spec
./pyode-1.2.0-2.fc18.src.rpm /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
pyode.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 0 errors, 1 warnings.
[ankur@localhost SRPMS]$
New spec/srpm:
http://ankursinha.fedorapeople.org/pyode/pyode.spec
http://ankursinha.fedorapeople.org/pyode/pyode-1.2.0-2.fc20.src.rpm
Thanks,
Warm regards,
Ankur
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=mPXvYVrRK9&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927611
John Morris changed:
What|Removed |Added
CC||j...@zultron.com
--- Comment #1 from John Morris ---
Hi Ankur, I was just about to package this, but you've done it for me! I'll be
happy to help with the review. What are you doing with this? I want it for
PyCAM (also in review).
Quick drive-by before the real review:
- This URL may help with the 'W: invalid-url' problem
https://downloads.sourceforge.net/project/pyode/pyode/snapshot-2010-03-22/PyODE-snapshot-2010-03-22.tar.gz
- If you remove execute permissions from ode.so, you won't have to bother with
the '%{?filter_setup:...' business. (Why do you set them in %install?)
- Nitpick: %description lacking a trailing '.'.
- Nitpick: (I was dinged for this on my last pkg) Double spaces before
%description, %prep, %build, etc. make the specfile more readable.
- The %files section really does need blank lines to separate it from the
%install script.
- Those comments about the tests might be more clear if they were prefaced with
a line like this that indicates they're the reason for not running tests,
despite the existence of a 'tests' directory:
#%%check
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Edpcs4oy2s&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 Ankur Sinha (FranciscoD) changed: What|Removed |Added Blocks||923035 (pybrain) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DxQZB7jlUf&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927611] Review Request: pyode - Open-source Python bindings for The Open Dynamics Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927611 Ankur Sinha (FranciscoD) changed: What|Removed |Added Alias||pyode -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7Fxe4JH5yd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
