[Bug 951496] Review Request: gimplensfun - gimp plugin to correct lens distortion
https://bugzilla.redhat.com/show_bug.cgi?id=951496 Graham White graham_al...@hotmail.com changed: What|Removed |Added URL||http://grahamwhiteuk.fedora ||people.org/pkgreviews/gimp- ||lensfun/ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FchV66b0CYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951496] Review Request: gimplensfun - gimp plugin to correct lens distortion
https://bugzilla.redhat.com/show_bug.cgi?id=951496 --- Comment #7 from Graham White graham_al...@hotmail.com --- Spec URL: http://grahamwhiteuk.fedorapeople.org/pkgreviews/gimp-lensfun/gimp-lensfun.spec SRPM URL: http://grahamwhiteuk.fedorapeople.org/pkgreviews/gimp-lensfun/gimp-lensfun-0.2.3-1.fc18.src.rpm Successful Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5413262 Change Summary: * Bumped to official 0.2.3 build * Removed git build stuff Since building the git version (above) the 0.2.3 official release of gimp-lensfun has happened. This is an updated spec file and rebuilt srpm. Successful Koji build against rawhide instead of F18 this time. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YVHmmr1PeZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951496] Review Request: gimplensfun - gimp plugin to correct lens distortion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951496 --- Comment #6 from Graham White graham_al...@hotmail.com --- Spec URL: http://grahamwhiteuk.fedorapeople.org/pkgreviews/gimp-lensfun/gimp-lensfun.spec SRPM URL: http://grahamwhiteuk.fedorapeople.org/pkgreviews/gimp-lensfun/gimp-lensfun-0.2.2-2.20130423git6ab226c12a.fc18.src.rpm Successful Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5301586 Change Summary: * %optflags added to the build * updated to postrelease code (changed package version) * changed package name The addition of %optflags has been done by a merged upstream pull request to fix the makefile. Hence, the package has been moved to a postrelease version from git and follows the Fedora Packaging Naming Guidelines for the updated version string. It would be nice to get a 0.2.3 release but upstream have not given me an outlook on when this might be available. I have also changed the package name from gimplensfun to gimp-lensfun. This has been done to fit in with the upstream name change following the same convention (i.e. they have introduced a hyphen into the name). Conveniently, this seems to fit better with Fedora's package naming and other gimp plugin names. The package name change has not been added to the changelog in the spec file since this change has not been seen by clients given this package isn't included in Fedora yet. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5Cgaqxp3Tna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951496] Review Request: gimplensfun - gimp plugin to correct lens distortion
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=951496
--- Comment #4 from Antonio Trande anto.tra...@gmail.com ---
(In reply to comment #3)
Thanks Antonio for the feedback.
I have updated the spec and rebuilt the SRPM for the GPLv3+ license.
The use of %{optflags} is problematic with this package.
The makefile sets:
CFLAGS = -O3 -Wall $(shell gimptool-2.0 --cflags pkg-config --cflags
lensfun exiv2) -fopenmp
It's importing CFLAGS from gimptool and pkg-config that include links to
libraries via the -I flag. Therefore, a straight use of
CFLAGS=%{optflags} breaks the build as the libraries cannot be found.
I presume the gimp-lqr-plugin RPM had a similar issue as it also does not
use %{optflags}.
I could still include %{optflags} if I run gimptool and pkg-config in the
spec file and pass the result into the call to make - would this be
preferred to omitting %{optflags} altogether?
Try to:
- Patch Makefile into %prep section with a simple replacement of -O3 -Wall
with @@OPTFLAGS@@
- In %build, add
sed -e 's|@@OPTFLAGS@@|%{optflags}|g' -i Makefile'
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ITCzjDngEla=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951496] Review Request: gimplensfun - gimp plugin to correct lens distortion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951496 --- Comment #5 from Michael Schwendt mschwe...@gmail.com --- Correct. Note that http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags is a MUST item, also with regard to what must be done when filtering/adding to the set of flags. That's because some of the flags are security related, and e.g. -g is required for automatic generation of -debuginfo packages: https://fedoraproject.org/wiki/Packaging:Guidelines#Debuginfo_packages $ rpm --eval %optflags -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CGCcoW5Hcxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951496] Review Request: gimplensfun - gimp plugin to correct lens distortion
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=951496
Antonio Trande anto.tra...@gmail.com changed:
What|Removed |Added
CC||anto.tra...@gmail.com
--- Comment #2 from Antonio Trande anto.tra...@gmail.com ---
Hi Graham.
Just some comments.
- Compilers used to build packages must honor the applicable compiler flags
set in the system rpm configuration. For C, C++, and Fortran code, the
%{optflags} macro contains these flags.
http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
See that Makefile uses right flags.
- Source archive contains files released with GPLv3+ (see src/gimplensfun.c,
src/LUT.h files). I think License tag must be GPLv3+.
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Mixed_Source_Licensing_Scenario
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=UrDGXILvYda=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951496] Review Request: gimplensfun - gimp plugin to correct lens distortion
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=951496
--- Comment #3 from Graham White graham_al...@hotmail.com ---
Thanks Antonio for the feedback.
I have updated the spec and rebuilt the SRPM for the GPLv3+ license.
The use of %{optflags} is problematic with this package.
The makefile sets:
CFLAGS = -O3 -Wall $(shell gimptool-2.0 --cflags pkg-config --cflags lensfun
exiv2) -fopenmp
It's importing CFLAGS from gimptool and pkg-config that include links to
libraries via the -I flag. Therefore, a straight use of CFLAGS=%{optflags}
breaks the build as the libraries cannot be found.
I presume the gimp-lqr-plugin RPM had a similar issue as it also does not use
%{optflags}.
I could still include %{optflags} if I run gimptool and pkg-config in the spec
file and pass the result into the call to make - would this be preferred to
omitting %{optflags} altogether?
I guess another approach would be for me to submit something upstream to alter
their makefile so we can pass CFLAGS in more easily in the spec. The current
git version of the makefile has changed from the release version I'm building
here anyway but is still using gimptool and pkg-config in CFLAGS.
If it's deemed best to leave %{optflags} out then I will add a comment to the
spec to document why it's not there.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=cp3EVfgXOya=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951496] Review Request: gimplensfun - gimp plugin to correct lens distortion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951496 --- Comment #1 from Graham White graham_al...@hotmail.com --- Successful Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5253393 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XhmG4dp6rua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951496] Review Request: gimplensfun - gimp plugin to correct lens distortion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=951496 Graham White graham_al...@hotmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ngNmZgVCbEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
