[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
https://bugzilla.redhat.com/show_bug.cgi?id=957568 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X0nBes94mqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
https://bugzilla.redhat.com/show_bug.cgi?id=957568 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-05-31 18:43:58 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BJegrtSa9ka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
https://bugzilla.redhat.com/show_bug.cgi?id=957568 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- python-carddav-0.4.1-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Esd27Yg0MMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957568 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- python-carddav-0.4.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-carddav-0.4.1-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ks1Skjc3Ota=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957568 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7tctqFLDcea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957568 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lAjZD5p8s0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957568
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #10 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5332335
$ rpmlint -i -v *
python-carddav.src: I: checking
python-carddav.src: I: checking-url http://lostpackets.de/pycarddav/ (timeout
10 seconds)
python-carddav.src: I: checking-url
http://lostpackets.de/pycarddav/downloads/pyCardDAV-0.4.1.tar.gz (timeout 10
seconds)
python-carddav.noarch: I: checking
python-carddav.noarch: I: checking-url http://lostpackets.de/pycarddav/
(timeout 10 seconds)
python-carddav.noarch: W: no-manual-page-for-binary pycard-import
Each executable in standard binary directories should have a man page.
python-carddav.noarch: W: no-manual-page-for-binary pycardsyncer
Each executable in standard binary directories should have a man page.
python-carddav.noarch: W: no-manual-page-for-binary pc_query
Each executable in standard binary directories should have a man page.
python-carddav.spec: I: checking-url
http://lostpackets.de/pycarddav/downloads/pyCardDAV-0.4.1.tar.gz (timeout 10
seconds)
2 packages and 1 specfiles checked; 0 errors, 3 warnings.
Nothing of interest.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
MIT
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
460106dfbafb7ab47b41fb9be91b2c5be3cc9f2ce6543fa73af4943e8c89ad35
pyCardDAV-0.4.1.tar.gz
460106dfbafb7ab47b41fb9be91b2c5be3cc9f2ce6543fa73af4943e8c89ad35
pyCardDAV-0.4.1.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957568 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Flags|fedora-review+ | Flags||fedora-review? Flags||fedora-cvs? --- Comment #11 from Patrick Uiterwijk puiterw...@gmail.com --- New Package SCM Request === Package Name: python-carddav Short Description: Python CardDAV client compatible with mutt Owners: puiterwijk Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wXP6wLXlPfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957568 --- Comment #9 from Patrick Uiterwijk puiterw...@gmail.com --- pycard.conf.sample has been moved to %doc, thanks for pointing that out. Regarding Source: vs Source0:, this is just kind of personal style as far as I know. Although, if you can link me to any page saying I am required to do Source0, please link them to me, and I will change accordingly. Spec URL: http://puiterwijk.fedorapeople.org/python-carddav.spec SRPM URL: http://puiterwijk.fedorapeople.org/python-carddav-0.4.1-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MJN6zqZHXNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957568
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
CC||mario.blaetterm...@gmail.co
||m
--- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com ---
%build
# Remove CFLAGS=... for noarch packages (unneeded)
CFLAGS=%{optflags} %{__python} setup.py build
Your package is noarch, so the CFLAGS statement is unneeded, as the spec
template says.
%files
...
/usr/bin/pc_query
/usr/bin/pycard-import
/usr/bin/pycardsyncer
Use macros instead of hardcoded paths:
%{_bindir}/pc_query
%{_bindir}/pycard-import
%{_bindir}/pycardsyncer
Please remove the upstream provided egginfo so that it gets rebuilt. See the
packaging guidelines:
http://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs
Your packages doesn't ship documentation. Add README.rst as %doc.
The source rpm is not built from the spec file provided by you. The %changelog
is empty.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=5kv2P9quSya=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957568 --- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com --- (In reply to comment #2) Your packages doesn't ship documentation. Add README.rst as %doc. Sorry for the blurb. The README files are already included in %doc. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gHK0sC0wmYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957568 --- Comment #4 from Patrick Uiterwijk puiterw...@gmail.com --- The issues you noted have been fixed, new urls: Spec URL: http://puiterwijk.fedorapeople.org/python-carddav.spec SRPM URL: http://puiterwijk.fedorapeople.org/python-carddav-0.4.1-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mTSfGByEt5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957568
--- Comment #5 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build for Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5327305
$ rpmlint -i -v *
python-carddav.src: I: checking
python-carddav.src: E: no-changelogname-tag
There is no %changelog tag in your spec file. To insert it, just insert a
'%changelog' in your spec file and rebuild it.
python-carddav.src: I: checking-url http://lostpackets.de/pycarddav/ (timeout
10 seconds)
python-carddav.src: I: checking-url
http://lostpackets.de/pycarddav/downloads/pyCardDAV-0.4.1.tar.gz (timeout 10
seconds)
python-carddav.noarch: I: checking
python-carddav.noarch: E: no-changelogname-tag
There is no %changelog tag in your spec file. To insert it, just insert a
'%changelog' in your spec file and rebuild it.
python-carddav.noarch: I: checking-url http://lostpackets.de/pycarddav/
(timeout 10 seconds)
python-carddav.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/pycarddav/carddav.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed. If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.
python-carddav.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/pycarddav/model.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed. If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.
python-carddav.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/pycarddav/backend.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed. If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.
python-carddav.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/pycarddav/__init__.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed. If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.
python-carddav.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/pycarddav/controllers.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed. If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.
python-carddav.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/pycarddav/ui.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed. If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.
python-carddav.noarch: W: no-manual-page-for-binary pycard-import
Each executable in standard binary directories should have a man page.
python-carddav.noarch: W: no-manual-page-for-binary pycardsyncer
Each executable in standard binary directories should have a man page.
python-carddav.noarch: W: no-manual-page-for-binary pc_query
Each executable in standard binary directories should have a man page.
python-carddav.spec: I: checking-url
http://lostpackets.de/pycarddav/downloads/pyCardDAV-0.4.1.tar.gz (timeout 10
seconds)
2 packages and 1 specfiles checked; 8 errors, 3 warnings.
The changelog tag in the srpm's spec file is still empty. Please make sure you
are using the right spec file to build the srpm. When you run rpmbuild -bs it
could happen that it uses the backup spec (created by your text editor) instead
of the new one. Remove any backups before.
Remove the shebangs from the mentioned files. Python scripts in
%{python_sitelib}/ don't need a shebang at all.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=w4RPXxXxzqa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957568 --- Comment #6 from Patrick Uiterwijk puiterw...@gmail.com --- Sorry, the SRPM url should have been http://puiterwijk.fedorapeople.org/python-carddav-0.4.1-2.fc18.src.rpm I will create a new one with removed shebangs. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aUY03eaXMMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957568 --- Comment #7 from Patrick Uiterwijk puiterw...@gmail.com --- Shebangs have been patched out: Spec URL: http://puiterwijk.fedorapeople.org/python-carddav.spec SRPM URL: http://puiterwijk.fedorapeople.org/python-carddav-0.4.1-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xFEROCkmHTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957568
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review?
--- Comment #8 from Mario Blättermann mario.blaetterm...@gmail.com ---
Some more issues:
cp pycard.conf.sample %{buildroot}%{_sysconfdir}/pycard.conf.sample
Either mark it as a config file by prepending %config(noreplace), or place it
in %doc. Normally, users will create their own config files, that's why it
would be sufficient to have it in %doc. I'm in doubt if it would work
out-of-the-box as a config file due to the *.sample file extension.
Source: should be Source0: independent from the actual count of source
files.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=PIuHXjVWX6a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957568] Review Request: python-carddav - Python CardDAV client compatible with mutt
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957568 --- Comment #1 from Patrick Uiterwijk puiterw...@gmail.com --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5311136 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JCKCZmugpZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
