[Bug 963074] Review Request: librime - Rime Input Method Engine Library
https://bugzilla.redhat.com/show_bug.cgi?id=963074 Fedora Update System changed: What|Removed |Added Fixed In Version|ibus-rime-0.9.9-2.fc18 |ibus-rime-0.9.9-2.fc19 --- Comment #11 from Fedora Update System --- ibus-rime-0.9.9-2.fc19, brise-0.22-2.fc19, librime-0.9.8-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4lJK0xGDFX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine Library
https://bugzilla.redhat.com/show_bug.cgi?id=963074 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ibus-rime-0.9.9-2.fc18 Resolution|--- |ERRATA Last Closed||2013-05-27 20:59:45 --- Comment #10 from Fedora Update System --- ibus-rime-0.9.9-2.fc18, brise-0.22-2.fc18, librime-0.9.8-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NR65nES2LX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine Library
https://bugzilla.redhat.com/show_bug.cgi?id=963074 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- ibus-rime-0.9.9-2.fc19, brise-0.22-2.fc19, librime-0.9.8-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Qzrezt1o8v&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine Library
https://bugzilla.redhat.com/show_bug.cgi?id=963074 --- Comment #8 from Fedora Update System --- ibus-rime-0.9.9-2.fc19,brise-0.22-2.fc19,librime-0.9.8-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ibus-rime-0.9.9-2.fc19,brise-0.22-2.fc19,librime-0.9.8-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kY0DWUhPaC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine Library
https://bugzilla.redhat.com/show_bug.cgi?id=963074 --- Comment #7 from Fedora Update System --- ibus-rime-0.9.9-2.fc18,brise-0.22-2.fc18,librime-0.9.8-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ibus-rime-0.9.9-2.fc18,brise-0.22-2.fc18,librime-0.9.8-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zuvdX48pTD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine Library
https://bugzilla.redhat.com/show_bug.cgi?id=963074 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dqqfU5AoMZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine Library
https://bugzilla.redhat.com/show_bug.cgi?id=963074 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=twYqFgGYOq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine Library
https://bugzilla.redhat.com/show_bug.cgi?id=963074 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5zc8GuqbrD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine Library
https://bugzilla.redhat.com/show_bug.cgi?id=963074 Peng Wu changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Peng Wu --- New Package SCM Request === Package Name: librime Short Description: Rime Input Method Engine Library Owners: pwu Branches: f18 f19 InitialCC: i18n-team petersen -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vphOIZNkgP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963074 Parag AN(पराग) changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from Parag AN(पराग) --- Suggestions: 1) #Requires: line should be removed as its not needed though its a comment. 2) every patch line should have some text written in spec about why the original tarball needed to be patched. 3) Good to add what things got changed from previous release in %changelog 4) In %description, don't put some space for complete sentences like write as Support for shape-based and phonetic-based input methods, including those for Chinese dialects. A selected dictionary in Traditional Chinese, powered by opencc for Simplified Chinese output. All other looks good. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BgBu6hlwvX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963074 --- Comment #3 from Peng Wu --- Fixed, Please review it again. Spec URL: http://pwu.fedorapeople.org/rime/librime.spec SRPM URL: http://pwu.fedorapeople.org/rime/librime-0.9.8-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YXqF3fndPm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963074 Peng Wu changed: What|Removed |Added Summary|Review Request: librime - |Review Request: librime - |Rime Input Method Engine|Rime Input Method Engine ||Library -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GWoV4AwHlF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963074 --- Comment #2 from Parag AN(पराग) --- 4) Add some description more like say features from README but make sure all lines in %description limited to 80 characters otherwise rpmlint will complain -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mUZCOT1jNy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=963074
--- Comment #1 from Parag AN(पराग) ---
Review:-
+ Koji scratch build f20 ->
http://koji.fedoraproject.org/koji/taskinfo?taskID=5383022
+ rpmlint on rpms gave
librime.src: W: invalid-url Source0:
http://rimeime.googlecode.com/files/librime-0.9.8.tar.gz HTTP Error 404: Not
Found
librime.x86_64: W: no-manual-page-for-binary rime_dict_manager
librime.x86_64: W: no-manual-page-for-binary rime_deployer
librime-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 4 warnings.
==> Source is downloadable so no issues.
+ Source verified with upstream as
http://rimeime.googlecode.com/files/librime-0.9.8.tar.gz :
CHECKSUM(SHA256) this package :
94092a7d1990b949efe6b4bcf8e8351cee64a3abe7838770a775ecb02a1ef065
CHECKSUM(SHA256) upstream package :
94092a7d1990b949efe6b4bcf8e8351cee64a3abe7838770a775ecb02a1ef065
+ License is valid and its text is include in LICENSE file
Suggestions:-
1) Add -tools subpackage which will install rime_deployer and
rime_dict_manager and let it
Requires: %{name}%{?_isa} = %{version}-%{release}
2) package need to own directory %{_datadir}/cmake/rime
3) I don't think you need following for this package
BuildRequires: xorg-x11-proto-devel, zlib-devel
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=h3mp85u42J&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963074 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qOhGrxpghq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963074 Parag AN(पराग) changed: What|Removed |Added Blocks||963077 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lJqteAsZed&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963074 Parag AN(पराग) changed: What|Removed |Added Blocks||963078 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=P8fmhHxUbo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963074 Peng Wu changed: What|Removed |Added Assignee|nob...@fedoraproject.org|panem...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vSPx3AS139&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
