[Bug 963604] Review Request: python-pdfrw - Python library to read and write PDF files

2013-05-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=963604

Sergio Pascual sergio.pa...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #3 from Sergio Pascual sergio.pa...@gmail.com ---
New Package SCM Request
===
Package Name: python-pdfrw
Short Description: Python library to read and write PDF files
Owners: sergiopr
Branches: f17 f18 f19
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=H9r5DD1EMea=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 963604] Review Request: python-pdfrw - Python library to read and write PDF files

2013-05-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=963604

--- Comment #2 from Sergio Pascual sergio.pa...@gmail.com ---
Thanks for the review, I have updated the spec to follow your suggestions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=7V3zkMe9oCa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 963604] Review Request: python-pdfrw - Python library to read and write PDF files

2013-05-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=963604

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |
  Flags||fedora-cvs+

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=SDmDYON6UAa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 963604] Review Request: python-pdfrw - Python library to read and write PDF files

2013-05-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=963604

--- Comment #4 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=kCJjQt4nw5a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 963604] Review Request: python-pdfrw - Python library to read and write PDF files

2013-05-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=963604

Sergio Pascual sergio.pa...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2013-05-23 10:06:45

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=sZs3ISyG3ka=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 963604] Review Request: python-pdfrw - Python library to read and write PDF files

2013-05-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=963604

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+

--- Comment #1 from Parag AN(पराग) panem...@gmail.com ---
Review:

+ mock build succeeded for rawhide

+ rpmlint on rpms gave
python-pdfrw.noarch: W: spelling-error %description -l en_US reportlab -
report lab, report-lab, reportorial
python-pdfrw.src: W: spelling-error %description -l en_US reportlab - report
lab, report-lab, reportorial
python-pdfrw.src: W: invalid-url Source0:
http://pdfrw.googlecode.com/files/pdfrw_0.1.zip HTTP Error 404: Not Found
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as 
http://pdfrw.googlecode.com/files/pdfrw_0.1.zip :
  CHECKSUM(SHA256) this package :
4dbb4017b179f1ecee947501d178a90e1ff0aaf6444ef24b5a630ee68e884919
  CHECKSUM(SHA256) upstream package :
4dbb4017b179f1ecee947501d178a90e1ff0aaf6444ef24b5a630ee68e884919

+ Package follows packaging guidelines.

suggestions:
1) you don't need following in %install in spec now for Fedora branches.
rm -rf %{buildroot}

2) See if you can package examples directory as %docs but this will make
rpmlint to complain doc-file-dependency warning which can be fixed by 
sed -i '1d' required files to be removed /usr/bin/env


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ADUteUhwIXa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 963604] Review Request: python-pdfrw - Python library to read and write PDF files

2013-05-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=963604

Sergio Pascual sergio.pa...@gmail.com changed:

   What|Removed |Added

 Blocks||957835

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=6Gl1O2zKyla=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review