[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Last Closed|2013-06-13 02:34:27 |2014-11-29 05:44:31 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 --- Comment #19 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Flags|fedora-cvs+ |fedora-cvs? Keywords||Reopened --- Comment #18 from Wolfgang Ulbrich chat-to...@raveit.de --- Package Change Request == Package Name: mintmenu New Branches: epel7 Owners: raveit65 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mintmenu-5.4.9-6.fc19 Resolution|--- |ERRATA Last Closed||2013-06-13 02:34:27 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- mintmenu-5.4.9-6.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wEuFYSQASka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|mintmenu-5.4.9-6.fc19 |mintmenu-5.4.9-6.fc17 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- mintmenu-5.4.9-6.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ln81iD3kGNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|mintmenu-5.4.9-6.fc17 |mintmenu-5.4.9-6.fc18 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- mintmenu-5.4.9-6.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZvG5635bAqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- mintmenu-5.4.9-6.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZlxZE7981wa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PAC3iSdImla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LqZFBivWaNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- mintmenu-5.4.9-6.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mintmenu-5.4.9-6.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oH32TARgbda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- mintmenu-5.4.9-6.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mintmenu-5.4.9-6.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wwV2TEuXxZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- mintmenu-5.4.9-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mintmenu-5.4.9-6.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p6Hm1dVdg6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YAa7tAqNHua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 --- Comment #7 from Wolfgang Ulbrich chat-to...@raveit.de --- Hi Eduardo, https://github.com/linuxmint/mintmenu/commit/e91b4774a5a247c957768e98266c1334319e7dfc This is what i could deal with upstream, hope this is sufficiently for fedora. New mock build. * Sat Jun 01 2013 Wolfgang Ulbrich chat-to...@raveit.de - 5.4.9-5 - add runtime require python-xlib - add valid license file Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mintmenu.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mintmenu-5.4.9-5.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=78rMrZeLu8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568
Eduardo Echeverria echevemas...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #8 from Eduardo Echeverria echevemas...@gmail.com ---
Hi Wolfgang:
mintmenu.noarch: E: explicit-lib-dependency python-xlib
this is a rpmlint false positive, rpmlint assumes all dependencies which
contain the string lib are traditional library (with .so files inside)
packages and can be autodetected, it's no applicable in this case
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: glib-compile-schemas is run if required
Note: gschema file(s) in mintmenu
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
MIT/X11 (BSD like), Unknown or generated. 17 files have unknown
license. Detailed output of licensecheck in
/home/makerpm/967568-mintmenu/licensecheck.txt
Contains header license of GPLv2, packager should contact to upstream to add
the boilerplatre
[x]: The spec file handles locales properly.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 40960 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[-]: Python eggs must not download any dependencies during the build process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]:
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Wolfgang Ulbrich chat-to...@raveit.de --- New Package SCM Request === Package Name: mintmenu Short Description: Advanced Menu for the MATE Desktop Owners: raveit65 Branches: f17 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m5iDsraYLRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 --- Comment #5 from Wolfgang Ulbrich chat-to...@raveit.de --- New mock build. * Tue May 28 2013 Wolfgang Ulbrich chat-to...@raveit.de - 5.4.9-4 - add runtime require mate-menu-editor - remove require -lang subpackage - remove virtual provides -lang subpackage - simplify rpm scriptlets - add comment to license line Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mintmenu.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mintmenu-5.4.9-4.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m2UgMKhTXCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 --- Comment #6 from Eduardo Echeverria echevemas...@gmail.com --- Hi Wolfgang, = MUST items = [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Please see https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Please ask to upstream for include the text of the license (boilerplate), upstream only have to put on a branch on github, and you download it from there and put it in sourceX, Only fix that and approve it -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sV83F8n767a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 --- Comment #4 from Wolfgang Ulbrich chat-to...@raveit.de --- my last open issue report for mintmenu. https://github.com/linuxmint/mintmenu/issues/36 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Pd3sIbDApta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568
--- Comment #3 from Wolfgang Ulbrich chat-to...@raveit.de ---
Thank you Eduardo for reviewing.
(In reply to Eduardo Echeverria from comment #2)
Hi @Wolfgang, there are some issues:
- The virtual provides of lang package aren't sane, since the subpackage not
exist as such
- Likewise with the Obsoletes
- Remove %{name}-lang = %{version}-%{release} (for the same reasons)
I will remove the unnecessary virtual provides, the obsoleting line i need to
updating the package from my external additional repo.
Here the package contains a -lang subpackage.
The require i forgot to remove.
- There are some missing Requires, according to my research:
* mozo (replacing alacarte)
Thanks for you hint, i will do it.
* Gconf2
Mintmenu is ported to gsettings, and dconf is called with mate-panel and other
MATE packages.
* mate-deskbar-applet (but can't find it in the packages database)
This was former needed for the keybindings to the superL key for opening the
menu. Upstream has add a own libary for this.
https://github.com/linuxmint/mintmenu/commit/cab7f82899180e1bde54b5b51c0e355694c605e8
Please add comment explain the multiple licensing scenario.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/
LicensingGuidelines#Multiple_Licensing_Scenarios
I understand that the only file that is under MIT is keybinding.py
Ok, i will do it.
- the package doesn't contains a boilerplate of the license GPLv2+, ask to
upstream for include it
I'm not shure if i understand you correct (sorry my bad english), you mean a
COPYING file. Shure i can open a issue report at github.
Cheers
cheers,
Wolfgang
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=n3pGv0lILoa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 --- Comment #1 from Wolfgang Ulbrich chat-to...@raveit.de --- New mock build. * Mon May 27 2013 Wolfgang Ulbrich chat-to...@raveit.de - 5.4.9-3 - update mintmenu-new_recent_icon.patch - remove mintmenu_terminal-icon.patch - remove mintmenu_desktop-icon.patch Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/mintmenu.spec SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/mintmenu-5.4.9-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4HTb6jZ1ANa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568
--- Comment #2 from Eduardo Echeverria echevemas...@gmail.com ---
Hi @Wolfgang, there are some issues:
- The virtual provides of lang package aren't sane, since the subpackage not
exist as such
- Likewise with the Obsoletes
- Remove %{name}-lang = %{version}-%{release} (for the same reasons)
- There are some missing Requires, according to my research:
* mozo (replacing alacarte)
* Gconf2
* mate-deskbar-applet (but can't find it in the packages database)
Please add comment explain the multiple licensing scenario.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios
I understand that the only file that is under MIT is keybinding.py
- the package doesn't contains a boilerplate of the license GPLv2+, ask to
upstream for include it
Cheers
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=QNNfj6VYzBa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967568] Review Request: mintmenu - Advanced Menu for the MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=967568 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||echevemas...@gmail.com Assignee|nob...@fedoraproject.org|echevemas...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NnyzVQfRhaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
