[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793
Bug 976793 depends on bug 1972445, which changed state.

Bug 1972445 Summary: Review Request: servus - Zeroconf discovery in C++
https://bugzilla.redhat.com/show_bug.cgi?id=1972445

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Otto Urpelainen  changed:

   What|Removed |Added

  Flags||needinfo?(jskarvad@redhat.c
   ||om)



--- Comment #27 from Otto Urpelainen  ---
Now that Servus has been finalized, this review can continue. Some update is
needed because of servus.so versioning difficulties, I now get this:

CMake Error at /usr/share/Servus/CMake/ServusTargets.cmake:88 (message):
  The imported target "Servus" references the file

 "/usr/lib64/libServus.so.1.6.0"

  but this file does not exist.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Otto Urpelainen  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #26 from Otto Urpelainen  ---
Thank you, the fixes look good. Since the Servus review looks almost complete,
I will wait until that is available in Rawhide. That should fix my build issues
and allow running fedora-review.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793



--- Comment #25 from Jaroslav Škarvada  ---
Spec URL: https://jskarvad.fedorapeople.org/lunchbox/lunchbox.spec
SRPM URL:
https://jskarvad.fedorapeople.org/lunchbox/lunchbox-1.17.0-2.fc33.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Jaroslav Škarvada  changed:

   What|Removed |Added

  Flags|needinfo?(jskarvad@redhat.c |
   |om) |



--- Comment #24 from Jaroslav Škarvada  ---
(In reply to Otto Urpelainen from comment #23)
> I started reviewing this. Running fedora-review is waiting for Servus
> dependency to appear in Rawhide, so full review can only happen after that.
> But some initial comments:
> 
> > LICENSE.txt
> 
> License issues here, just like there were in Servus.
> This file contains this sentence "See file LGPL.txt for the full license".
> But that file does not exist.
> Also, LGPL is a layer on top of GPL, so full text of that is required also.
> Need to contact upstream here,
> and possibly add patch the missing licenses if upstream is not active.
>
https://github.com/Eyescale/Lunchbox/issues/331
Updated the spec.

> > # https://github.com/Eyescale/Lunchbox/issues/330
> > #%%check
> > #cd %{_vpath_builddir}
> > #make test
> 
> If only some test cases fail, patch to disable them and execute the rest.
> Much better than blindly disabling everything.
>
Re-enabled test-suite.

> > %cmake -DCOMMON_DOC_DIR=%{_docdir}/%{name}
> 
> When I try to build (after installing servus and servus-devel dependencies),
> I get the following error:
> 
> > CMake Error at CMake/common/SubProject.cmake:86 (message):
> >   Subproject Servus not found in
> >   /builddir/build/BUILD/Lunchbox-1.17.0/Servus, do:
> > 
> >   cmake -DCLONE_SUBPROJECTS=ON
> > 
> >   to git-clone it automatically.
> > Call Stack (most recent call first):
> >   CMake/common/SubProject.cmake:148 (add_subproject)
> >   .gitsubprojects:2 (git_subproject)
> >   CMake/common/SubProject.cmake:161 (include)
> >   CMake/common/Common.cmake:161 (include)
> >   CMakeLists.txt:28 (include)

I cannot reproduce. I am building for rawhide, but it shouldn't matter. It
seems the cmake macro cannot find servus-devel files, but I don't know why it
doesn't work on your system.

It seems there is the same problem with the strange library versioning:
https://github.com/Eyescale/Lunchbox/issues/332


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Otto Urpelainen  changed:

   What|Removed |Added

  Flags||needinfo?(jskarvad@redhat.c
   ||om)



--- Comment #23 from Otto Urpelainen  ---
I started reviewing this. Running fedora-review is waiting for Servus
dependency to appear in Rawhide, so full review can only happen after that. But
some initial comments:

> LICENSE.txt

License issues here, just like there were in Servus.
This file contains this sentence "See file LGPL.txt for the full license".
But that file does not exist.
Also, LGPL is a layer on top of GPL, so full text of that is required also.
Need to contact upstream here,
and possibly add patch the missing licenses if upstream is not active.

> # https://github.com/Eyescale/Lunchbox/issues/330
> #%%check
> #cd %{_vpath_builddir}
> #make test

If only some test cases fail, patch to disable them and execute the rest.
Much better than blindly disabling everything.

> %cmake -DCOMMON_DOC_DIR=%{_docdir}/%{name}

When I try to build (after installing servus and servus-devel dependencies),
I get the following error:

> CMake Error at CMake/common/SubProject.cmake:86 (message):
>   Subproject Servus not found in
>   /builddir/build/BUILD/Lunchbox-1.17.0/Servus, do:
> 
>   cmake -DCLONE_SUBPROJECTS=ON
> 
>   to git-clone it automatically.
> Call Stack (most recent call first):
>   CMake/common/SubProject.cmake:148 (add_subproject)
>   .gitsubprojects:2 (git_subproject)
>   CMake/common/SubProject.cmake:161 (include)
>   CMake/common/Common.cmake:161 (include)
>   CMakeLists.txt:28 (include)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793



--- Comment #22 from Otto Urpelainen  ---
Jaroslav,

Thank you for continuing this effort. For the tests, consider disabling only
the problematic test and let others run, either by patching of whatever
filtering option the test runner may have. We want to know that everything else
is still working even if that single case is having issues.

I will take a look at Servus review request.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793



--- Comment #21 from Jaroslav Škarvada  ---
Spec URL: https://jskarvad.fedorapeople.org/lunchbox/lunchbox.spec
SRPM URL:
https://jskarvad.fedorapeople.org/lunchbox/lunchbox-1.17.0-1.fc33.src.rpm

I used lunchbox name with lowercase 'l' which seemed better to me. It's
bundling some cmake macros from the Lunchbox upstream. Currently I don't know
what to do with it, so I bundled them and encouraged upstream to bundle it to
the release package. Another variant is to package it to individual package and
encourage upstream to add it as a dep (currently upstream consumes it as a
submodule). For the bundling probably FESCO exception will be needed. I also
opened several upstream bugs, see the comments in the spec.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793



--- Comment #20 from Jaroslav Škarvada  ---
Tests temporary disabled due to:
https://github.com/Eyescale/Lunchbox/issues/330


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Jaroslav Škarvada  changed:

   What|Removed |Added

 Depends On||1972445





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1972445
[Bug 1972445] Review Request: servus - Zeroconf discovery in C++
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793



--- Comment #19 from Jaroslav Škarvada  ---
Unfortunately upstream complicates it even more. Now it requires Servus (bug
1972445) and what's worse it's bundling it as a git submodule. I encouraged
upstream to add support for building with the system Servus. I could patch it
myself, but at first we need Servus to get in.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Jaroslav Škarvada  changed:

   What|Removed |Added

  Flags|needinfo?(jskarvad@redhat.c |
   |om) |



--- Comment #18 from Jaroslav Škarvada  ---
Rebasing to 1.17.0, the latest released upstream version.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Otto Urpelainen  changed:

   What|Removed |Added

 CC||otu...@iki.fi
  Flags||needinfo?(jskarvad@redhat.c
   ||om)



--- Comment #17 from Otto Urpelainen  ---
Adding needinfo flag for the reporter, so the review can either progress or be
closed automatically in one month.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Mattia Verga  changed:

   What|Removed |Added

 CC||mattia.ve...@protonmail.com



--- Comment #16 from Mattia Verga  ---
Could you provide an updated spec and srpm, so that I can try to review this?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

needinfo canceled: [Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Jaroslav Škarvada  has canceled Package Review
's request for Jaroslav Škarvada
's needinfo:
Bug 976793: Review Request: libLunchbox - C++ library for multi-threaded
programming
https://bugzilla.redhat.com/show_bug.cgi?id=976793



--- Comment #15 from Jaroslav Škarvada  ---
I am still going to handle it.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Jaroslav Škarvada  changed:

   What|Removed |Added

  Flags|needinfo?(jskarvad@redhat.c |
   |om) |



--- Comment #15 from Jaroslav Škarvada  ---
I am still going to handle it.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

James Hogarth  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|i...@cicku.me  |nob...@fedoraproject.org
  Flags|fedora-review?  |
   |needinfo?(i...@cicku.me)   |



--- Comment #13 from James Hogarth  ---
It's been over a week with no response from the reviewer to the NeedsInfo flag.

Resetting the review flag an unassigning as per policy.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

James Hogarth  changed:

   What|Removed |Added

  Flags||needinfo?(i...@cicku.me)



--- Comment #12 from James Hogarth  ---
Christopher do you still want to review this?

If not best to unset the assignee and flag so someone else can take over.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Jaroslav Škarvada  changed:

   What|Removed |Added

  Flags|needinfo?(jskarvad@redhat.c |
   |om) |



--- Comment #10 from Jaroslav Škarvada  ---
(In reply to James Hogarth from comment #9)
> This bug has not had an update in a long time.
> 
> Are you still intending to progress this?
> 
> As per policy if there is no update this bug will be closed.
> 
> https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

Hi,

I still want to get it into Fedora. IMHO it's waiting on the reviewer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793



--- Comment #11 from Jaroslav Škarvada  ---
(In reply to Jonathan Wakely from comment #8)
> I wondered why the upstream still has its own thread library, instead of
> using std::thread / boost::thread etc.
> 
> And indeed the upstream API docs say the Lunchbox classes are deprecated.

IIRC it's there mainly for the 'bino' [1] from the rpmfusion [2], which can use
'Equalizer', which IIRC uses 'Lunchbox', from the upstream docs [3]:

> Lunchbox is a C++ library for multi-threaded programming, providing OS
> abstraction, utility classes and high-performance primitives, such as atomic
> variables, spin locks and lock-free containers. It is used as a base library
> for Collage and Equalizer. 

Thus I think this package is still useful.

[1] http://bino3d.org/
[2]
http://download1.rpmfusion.org/free/fedora/releases/22/Everything/x86_64/os/bino-1.4.4-6.fc22.x86_64.rpm
[3] http://www.equalizergraphics.com/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

James Hogarth  changed:

   What|Removed |Added

 CC||james.hoga...@gmail.com
  Flags||needinfo?(jskarvad@redhat.c
   ||om)



--- Comment #9 from James Hogarth  ---
This bug has not had an update in a long time.

Are you still intending to progress this?

As per policy if there is no update this bug will be closed.

https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Jonathan Wakely jwak...@redhat.com changed:

   What|Removed |Added

 CC||jwak...@redhat.com



--- Comment #8 from Jonathan Wakely jwak...@redhat.com ---
I wondered why the upstream still has its own thread library, instead of using
std::thread / boost::thread etc.

And indeed the upstream API docs say the Lunchbox classes are deprecated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Jaroslav Škarvada jskar...@redhat.com changed:

   What|Removed |Added

  Flags|needinfo?(jskarvad@redhat.c |
   |om) |



--- Comment #7 from Jaroslav Škarvada jskar...@redhat.com ---
(In reply to Christopher Meng from comment #6)
 I'm still confused with pkgconfig explicit requires now.
 
It's installing pkgconfig files and the basedir is provided by pkgconfig.

 And can you update this package to 1.6.0 version?
 
I upgraded it to 1.9.1:
Spec URL: http://jskarvad.fedorapeople.org/libLunchbox.spec
SRPM URL: http://jskarvad.fedorapeople.org/libLunchbox-1.9.1-1.fc20.src.rpm

But I am afraid it would require re-packing according to MPI guidelines, will
look on it later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC||jskar...@redhat.com
  Flags||fedora-review?
   ||needinfo?(jskarvad@redhat.c
   ||om)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|cicku...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC||cicku...@gmail.com



--- Comment #6 from Christopher Meng cicku...@gmail.com ---
I'm still confused with pkgconfig explicit requires now.

And can you update this package to 1.6.0 version?

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

--- Comment #5 from Michael Schwendt mschwe...@gmail.com ---
Rest assured, it wouldn't be the first project to do that. Project name foo
releases library with SONAME libfoo.so.N in tarball libfoo with headers in
/usr/include/foo (#include foo/blubb.h) and using root directories such as
/usr/share/foo.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=1Lqu0eDE93a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

--- Comment #3 from Jaroslav Škarvada jskar...@redhat.com ---
(In reply to Michael Schwendt from comment #2)
Thanks for the comments, I will try to go through them probably during next
week and provide new version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=8J1W64iAYna=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

--- Comment #4 from Jaroslav Škarvada jskar...@redhat.com ---
Reply from Stefan regarding the rename to libLunchbox:

 Hi Jaroslav,

 I've looked into Lunchbox vs. libLunchbox and came to the conclusion that 
 only the package name should change, the rest should stay:

 include/Lunchbox/...
 libLunchbox
 share/Lunchbox/...

 Do you agree? If so, what do I need to do?

 Changing the project name to libLunchbox doesn't make sense to me, since it 
 entails:

 find_package(libLunchbox)
 include/libLunchbox/...
 liblibLunchbox...

 and so on for consistency.

 
 Cheers,

 Stefan.

I am +1 for the package name only change. Any comments?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=qfBH6P6xNia=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

Summary|Review Request: Lunchbox -  |Review Request: libLunchbox
   |C++ library for |- C++ library for
   |multi-threaded programming  |multi-threaded programming

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=vjk8fuUyWXa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 976793] Review Request: libLunchbox - C++ library for multi-threaded programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=976793

--- Comment #2 from Michael Schwendt mschwe...@gmail.com ---
This will be non-trivial to review, and I dunno whether I will find enough time
this weekend to do everything. How deeply have you reviewed the package
already?


rpmlint tells:
libLunchbox.src: E: description-line-too-long C Lunchbox is C++ library for
multi-threaded programming, providing OS abstraction,


 Name:   libLunchbox
 Group:  Development/Libraries

System Environment/Libraries is the group for the run-time library base
packages.


 License:LGPLv2

It's more than that.

Lunchbox-1.4.0/lunchbox/md5/md5.cc and md5.hh : This is a copied MD5
implementation with an own license by RSA Data Security Inc. And it's one not
mentioned at https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
already.

Lunchbox-1.4.0/lunchbox/atomic.h : Distributed under the Boost Software
License, Version 1.0.

Lunchbox-1.4.0/lunchbox/indexIterator.h : LGPLv3
Lunchbox-1.4.0/lunchbox/lfVector.h : LGPLv3
Lunchbox-1.4.0/lunchbox/lfVectorIterator.h : LGPLv3
Lunchbox-1.4.0/lunchbox/serializable.h : LGPLv3
Lunchbox-1.4.0/tests/lfVector.cpp : LGPLv3
Lunchbox-1.4.0/tests/servus.cpp : LGPLv3

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Clarification


 BuildRequires:  cmake, doxygen, graphviz

build.log contains a few could not find … messages. Are any of them
[optional] missing BuildRequires?


 %package devel
 Requires:   pkgconfig, cmake

Both should be dropped. There's an automatic dependency on /usr/bin/pkg-config
already. And this -devel package certainly does not strictly require cmake,
because e.g. it contains a pkgconfig file and can be used without cmake. Feel
free to include the cmake directories based on this in the guidelines:

https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function


 %package doc
 Requires:   %{name} = %{version}-%{release}

Separate documentation -doc packages typically don't require the base package.
It should be possible to install documentation without having to install a
program and all its dependencies.  

With a total size of just 76716 bytes, the files in this -doc package could
stay in the -devel package.


 %files
 %{_datadir}/%{name}

This tree belongs into the -devel package.

  drwxr-xr-x  /usr/share/libLunchbox
  drwxr-xr-x  /usr/share/libLunchbox/CMake
  -rw-r--r--  /usr/share/libLunchbox/CMake/options.cmake

The path is broken afaics after you move the file in the %install section.

$ cd Lunchbox-1.4.0
$ grep options.cmake * -R
CMake/FindLunchbox.cmake: 
include(${LUNCHBOX_LIBRARY_DIRS}/../share/Lunchbox/CMake/options.cmake)
CMakeLists.txt:install(FILES ${CMAKE_BINARY_DIR}/options.cmake
lunchbox/configure.cmake:set(OPTIONS_CMAKE ${CMAKE_BINARY_DIR}/options.cmake)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Jom3OOeZ1fa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review