[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 Marcus Asshauer changed: What|Removed |Added Flags|needinfo?(fedora@asshaueron | |line.de)| --- Comment #16 from Marcus Asshauer --- I am very sorry. Yes I am alive. I died the changes from above. http://mcas.fedorapeople.org/review/perl-DBD-Sybase.spec http://mcas.fedorapeople.org/review/perl-DBD-Sybase-1.15-1.fc20.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=6669551 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 David Dick changed: What|Removed |Added CC||dd...@cpan.org --- Comment #17 from David Dick --- Just a thought. Rather than throw the test suite away completely, you could replace "make test" with "perl -Iblib/lib -Iblib/arch t/base.t" which would prove that at least the build has succeeded and the Sybase shared object can be loaded. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 --- Comment #14 from Björn "besser82" Esser --- Marcus, are you alive? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9VefnGK9qH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 Björn "besser82" Esser changed: What|Removed |Added CC||fed...@asshaueronline.de Flags||needinfo?(fedora@asshaueron ||line.de) --- Comment #15 from Björn "besser82" Esser --- Ping No.2 ... -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 Björn Esser changed: What|Removed |Added Status|NEW |ASSIGNED CC||bjoern.es...@gmail.com Blocks||177841 (FE-NEEDSPONSOR) Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com Flags||fedora-review? --- Comment #1 from Björn Esser --- I'll take this one. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p6xQuYVaZJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 Marcus Asshauer changed: What|Removed |Added Blocks||988105 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OFy35tjVSp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 Björn Esser changed: What|Removed |Added Alias||perl-DBD-Sybase -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2IzdRJf9Ay&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 --- Comment #2 from Björn Esser --- spec inside srpm differs from the one provided by link. Rebuild your srpm, please, and re-upload. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vr2j4cJMDc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 --- Comment #3 from Marcus Asshauer --- rebuild and re-upload done -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cfDGYVgBDh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 --- Comment #4 from Marcus Asshauer --- http://mcas.fedorapeople.org/review/perl-DBD-Sybase-1.15-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8DDl7UIQwK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 --- Comment #5 from Marcus Asshauer --- Spec URL: http://mcas.fedorapeople.org/review/perl-DBD-Sybase.spec SRPM URL: http://mcas.fedorapeople.org/review/perl-DBD-Sybase-1.15-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZlOQ7leHBM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102
--- Comment #6 from Björn Esser ---
No issues found on this. :)
#
Package Review
==
Legend:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
---> This is intentional on c-compiled perl-extensions
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 9 files have unknown license. Detailed output of
licensecheck in /home/besser82/shared/fedora/review/988102-perl-DBD-
Sybase/licensecheck.txt
---> License is derived from perl. License-tag is fine
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 102400 bytes in 10 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %c
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102
--- Comment #7 from Björn Esser ---
There's just a small correction on the spec needed, because of
directory-ownership:
%files
%doc BUGS CHANGES README* *.pod eg
-%{perl_vendorarch}/*
+%{perl_vendorarch}/DBD/
+%{perl_vendorarch}/auto/DBD/
%{_mandir}/man*/*
"%{perl_vendorarch}/auto/" is owned by `perl-libs` so your pkg MUST NOT own
them.
Please change these small bits, enhace changelog (use rpmdev-bumpspec and add a
comment about your changes using editor-of-choice), rebuild srpm, upload new
stuff and update the links.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=SoZOOpCWWH&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102
Christopher Meng changed:
What|Removed |Added
CC||cicku...@gmail.com
--- Comment #8 from Christopher Meng ---
This package is in my repo ;) I've packaged it.
Issues besides Bjorn's:
1. Remove find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
This is a old mistake by extutils years ago, it's fixed now.
2. Why mark these as %doc:
*.pod eg ?
And I didn't push it to fedora review bwcause I can't test it with sybase
server, can you test it?
Thanks, and also please update your spec and srpm so we can review again.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=OhfghlFtMo&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 Christopher Meng changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TC9D4ICE1A&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 --- Comment #9 from Michael Schwendt --- > 2. Why mark these as %doc: > > *.pod eg ? That's a strange question. Could you be more verbose, please, and explain your thoughts? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AVHmE22wnc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102
--- Comment #10 from Björn Esser ---
(In reply to Christopher Meng from comment #8)
Thanks, for you remarks.
> This package is in my repo ;) I've packaged it.
>
> Issues besides Bjorn's:
>
> 1. Remove find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
>
> This is a old mistake by extutils years ago, it's fixed now.
Any clarifying link to this? For which dists this is fixed? Is el5 still
affected or are things fixed there, too?
As far as I see, this command will remove some unused and empty dirs, only.
Give me some helpful clues on this, please.
> 2. Why mark these as %doc:
>
> *.pod eg ?
Refering to mschwendt's comment #9: Why not? ;)
eg/ contains some brief examples, so it's really a should-be-in. *.pod is some
docs differing from man-page. It's kinda markdown; human-readable and
convertible to various formats with broad choice of different tools. So both
are %doc...
> And I didn't push it to fedora review because I can't test it with sybase
> server, can you test it?
Yes, temporary; if I need one, I can get one for a couple of hours ;)
> Thanks, and also please update your spec and srpm so we can review again.
The small two-line change, I mentioned, can be made by mcas on SCM-import, as
well. It's just important to have them made. ;)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=CN72SKAJhv&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 --- Comment #11 from Christopher Meng --- (In reply to Björn Esser from comment #10) > Any clarifying link to this? For which dists this is fixed? Is el5 still > affected or are things fixed there, too? > > As far as I see, this command will remove some unused and empty dirs, only. > Give me some helpful clues on this, please. Petr from Perl-devel has confirmed this in my package reviews, and remove this line won't cause any problem. But if you say el5, I think you may need to preserve it again. > > 2. Why mark these as %doc: > > > > *.pod eg ? > > Refering to mschwendt's comment #9: Why not? ;) > > eg/ contains some brief examples, so it's really a should-be-in. *.pod is > some docs differing from man-page. It's kinda markdown; human-readable and > convertible to various formats with broad choice of different tools. So > both are %doc... Understand now, thanks. > Yes, temporary; if I need one, I can get one for a couple of hours ;) Yes, I hope it can work. > The small two-line change, I mentioned, can be made by mcas on SCM-import, > as well. It's just important to have them made. ;) OK. ;) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KLNRvyXAyM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 --- Comment #12 from Michael Schwendt --- > But if you say el5, I think you may need to preserve it again. Nope. ;-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CgDC34Ya9i&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102
--- Comment #13 from Björn Esser ---
Thanks for the hint, Michael!
#
Marcus, let me get all needed spec-changes together here:
...snip...
find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
find %{buildroot} -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
find %{buildroot} -type f -name '*.pod' -exec rm -f {} ';'
-find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
%{_fixperms} %{buildroot}/*
...snip...
%files
%doc BUGS CHANGES README* *.pod eg
-%{perl_vendorarch}/*
+%{perl_vendorarch}/DBD/
+%{perl_vendorarch}/auto/DBD/
%{_mandir}/man*/*
...snip...
#
These two changes should bring spec, and therefor build rpms, in perfect shape
for production. You can do them during SCM-import. :)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=YA81Xh8YVx&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 --- Comment #19 from Markus Frosch --- Is there anything I can do to bring this do Fedora and EPEL? :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 Petr Šabata changed: What|Removed |Added CC||psab...@redhat.com --- Comment #20 from Petr Šabata --- I suppose you can take the review and finish it. Björn appears to be unavailable. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 Christopher Meng changed: What|Removed |Added CC||i...@cicku.me --- Comment #21 from Christopher Meng --- (In reply to Petr Šabata from comment #20) > I suppose you can take the review and finish it. Björn appears to be > unavailable. I can't remember, but I believe Marcus Asshauer is sponsored by Björn who is unavailable now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 --- Comment #22 from Markus Frosch --- Will review the package later, have packaged it myself for EL7 lately. Though I'm not a Fedora contributor, so we would need an official member to actually commit it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102 Bill Yodlowsky changed: What|Removed |Added Flags||needinfo?(bjoern.esser@gmai ||l.com) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 988102] Review Request: perl-DBD-Sybase - this package provides an interface for perl to connect with Sybase and MSSql databases
https://bugzilla.redhat.com/show_bug.cgi?id=988102
Bill Yodlowsky changed:
What|Removed |Added
CC||byodl...@redhat.com
--- Comment #18 from Bill Yodlowsky ---
Hi,
With this addition:
@@ -79,7 +79,7 @@
# Uncomment the following line if want to run the testsuite.
#
#make test
-
+%{__perl} -Iblib/lib -Iblib/arch t/base.t
Is there anything left holding this back?
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
