[Bug 990624] Review Request: json-parser - Very low footprint JSON parser written in portable ANSI C
https://bugzilla.redhat.com/show_bug.cgi?id=990624 Haïkel Guémar changed: What|Removed |Added CC||karlthe...@gmail.com --- Comment #1 from Haïkel Guémar --- quickies: * lacks a comment explaining how the tarball has been generated (either provide a script or a command-line) * python wrapper not included * tests (depending on the aforementioned python wrapper) missing too * you should request upstream maintainer to add a license file in his repository (and release tarballs when they'll be available) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HcTtT9qBLv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990624] Review Request: json-parser - Very low footprint JSON parser written in portable ANSI C
https://bugzilla.redhat.com/show_bug.cgi?id=990624
Christopher Meng changed:
What|Removed |Added
CC||cicku...@gmail.com
--- Comment #2 from Christopher Meng ---
I recommend you to move %post{un} scripts below install section and above
file's section.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=V5HFsEJx12&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990624] Review Request: json-parser - Very low footprint JSON parser written in portable ANSI C
https://bugzilla.redhat.com/show_bug.cgi?id=990624
--- Comment #3 from Igor Gnatenko ---
(In reply to Christopher Meng from comment #2)
> I recommend you to move %post{un} scripts below install section and above
> file's section.
fxd
(In reply to Haïkel Guémar from comment #1)
> quickies:
> * lacks a comment explaining how the tarball has been generated (either
> provide a script or a command-line)
Simple download
> * python wrapper not included
In future will deleted
> * tests (depending on the aforementioned python wrapper) missing too
In future will fixed
> * you should request upstream maintainer to add a license file in his
> repository (and release tarballs when they'll be available)
fxd
new spec: http://ignatenkobrain.fedorapeople.org/for-review/json-parser.spec
new srpm:
http://ignatenkobrain.fedorapeople.org/for-review/json-parser-1.0.0-1.df38ae7.fc19.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=LNL5hm3hx5&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990624] Review Request: json-parser - Very low footprint JSON parser written in portable ANSI C
https://bugzilla.redhat.com/show_bug.cgi?id=990624 Haïkel Guémar changed: What|Removed |Added Assignee|nob...@fedoraproject.org|karlthe...@gmail.com Flags||fedora-review? --- Comment #4 from Haïkel Guémar --- * current spec seems OK (i also reviewed the code, seems OK too) * i found out that the shared library generated was an empty stub, i submitted a Pull Request that fixes it https://github.com/udp/json-parser/pull/31 * i'll continue testing the library itself -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ds4nAQGjIe&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990624] Review Request: json-parser - Very low footprint JSON parser written in portable ANSI C
https://bugzilla.redhat.com/show_bug.cgi?id=990624 --- Comment #5 from Igor Gnatenko --- (In reply to Haïkel Guémar from comment #4) > * current spec seems OK (i also reviewed the code, seems OK too) > * i found out that the shared library generated was an empty stub, i > submitted a Pull Request that fixes it > https://github.com/udp/json-parser/pull/31 merged and updated > * i'll continue testing the library itself new spec: http://ignatenkobrain.fedorapeople.org/for-review/json-parser.spec new srpm: http://ignatenkobrain.fedorapeople.org/for-review/json-parser-1.0.0-3.13ef5a8.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HcPZ8fka4Z&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990624] Review Request: json-parser - Very low footprint JSON parser written in portable ANSI C
https://bugzilla.redhat.com/show_bug.cgi?id=990624
Haïkel Guémar changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #6 from Haïkel Guémar ---
* code review: OK
* shared library issue: OK (PR accepted and package updated)
* working package: OK (i wrote a sample C program that parses a JSON file for
testing purpose)
Since this package now complies with Fedora packaging guidelines, i hereby
approve it into Fedora Packages Collection.
I advise you to continue working with upstream on the test suite, it will
ensure that the library won't get any regression and keep working in the future
(and save time for upstream by noticing them faster).
Let me know if you experience issues in importing this package.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"BSD (2 clause)", "Unknown or generated". 4 files have unknown license.
Detailed output of licensecheck in /home/haikel/json-parser/990624-json-
parser/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 20480 bytes in 6 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: If the source package does not inclu
[Bug 990624] Review Request: json-parser - Very low footprint JSON parser written in portable ANSI C
https://bugzilla.redhat.com/show_bug.cgi?id=990624 Igor Gnatenko changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Igor Gnatenko --- New Package SCM Request === Package Name: json-parser Short Description: Very low footprint JSON parser written in portable ANSI C Owners: ignatenkobrain Branches: f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RKTGy3vegu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990624] Review Request: json-parser - Very low footprint JSON parser written in portable ANSI C
https://bugzilla.redhat.com/show_bug.cgi?id=990624 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vX5aazJVPM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990624] Review Request: json-parser - Very low footprint JSON parser written in portable ANSI C
https://bugzilla.redhat.com/show_bug.cgi?id=990624 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=o5tbLjQwtr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990624] Review Request: json-parser - Very low footprint JSON parser written in portable ANSI C
https://bugzilla.redhat.com/show_bug.cgi?id=990624 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JWaPVYKx3T&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990624] Review Request: json-parser - Very low footprint JSON parser written in portable ANSI C
https://bugzilla.redhat.com/show_bug.cgi?id=990624 --- Comment #9 from Fedora Update System --- json-parser-1.0.0-3.13ef5a8.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/json-parser-1.0.0-3.13ef5a8.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eMOYymBDc9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990624] Review Request: json-parser - Very low footprint JSON parser written in portable ANSI C
https://bugzilla.redhat.com/show_bug.cgi?id=990624 --- Comment #10 from Michael Schwendt --- Something for a future update: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VvWFh60sAe&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990624] Review Request: json-parser - Very low footprint JSON parser written in portable ANSI C
https://bugzilla.redhat.com/show_bug.cgi?id=990624 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- json-parser-1.0.0-3.13ef5a8.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LVsESRjfJJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990624] Review Request: json-parser - Very low footprint JSON parser written in portable ANSI C
https://bugzilla.redhat.com/show_bug.cgi?id=990624 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||json-parser-1.0.0-3.13ef5a8 ||.fc19 Resolution|--- |ERRATA Last Closed||2013-08-11 14:27:23 --- Comment #12 from Fedora Update System --- json-parser-1.0.0-3.13ef5a8.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MAt1w6MIOI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
