Re: [pacman-dev] [PATCH 1/1] always accept untranslated answers 'Y' and 'N'

2016-11-11 Thread Florian Weigelt
"Yes" in Swahili it is "Ndiyo", in Arabic it's "Na'am", Greek is "Nai", ...
apt on Ubuntu allows to answer with "J" for "Yes" on a German locale.
But I am not sure if apt unconditionally allows to answer with "Y/N". In
general I think it's a bad idea. Either allow localized input only, or
Y/N only.

On 11/11/16 21:34, Christian Hesse wrote:
> Lukas Fleischer  on Fri, 2016/11/11 21:23:
>> On Fri, 11 Nov 2016 at 21:15:48, Christian Hesse wrote:
>>> From: Christian Hesse 
>>>
>>> 'YES' translates to 'JA' in German, thus answer 'J' is expected for
>>> positive answer. This changes the behaviour to always accept 'Y'
>>> and 'N', in addition to the translated values.
>>
>> Not sure whether it is a problem in practice but what happens if "N" is
>> translated to "Y" in some language? Do we really want to accept if the
>> user enters "Y" in that case?
> 
> A valid point...
> Does such a language exist?
> 
> All my systems are configured with English locale, except my wife's and my
> mother's one. My blind typing for pacman commands breaks there. :-p
> 
> Well, possibly I should just set the root account to English locale... :D
> 



signature.asc
Description: OpenPGP digital signature


Re: [pacman-dev] [PATCH] Make sure all proper scripts are installed instead of the wrappers

2016-10-25 Thread Florian Weigelt
I can confirm Johannes' patch solves the described issue. Thanks.

On 10/25/16 21:02, Johannes Löthberg wrote:
> After 1f8f0bd9ac4c11cdc1b9506f9f64d8192ecad4ee all scripts that were
> changed to using the wrapper for in-tree use have the wrappers installed
> to the system instead of the actual script, so change the install
> command to support all wrapped scripts instead of just makepkg.
> 
> Signed-off-by: Johannes Löthberg 
> ---
>  scripts/Makefile.am | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile.am b/scripts/Makefile.am
> index 448057d..977aa90 100644
> --- a/scripts/Makefile.am
> +++ b/scripts/Makefile.am
> @@ -247,7 +247,9 @@ install-exec-hook:
>   cd $(DESTDIR)$(bindir) && \
>   $(RM) $$wrapper; \
>   done
> - $(INSTALL) .lib/makepkg $(DESTDIR)$(bindir)/makepkg
> + for wrapper in $(WRAPPER); do \
> + $(INSTALL) .lib/$${wrapper%-wrapper} 
> $(DESTDIR)$(bindir)/$${wrapper%-wrapper}; \
> + done
>   for dir in $(LIBMAKEPKGDIRS); do \
>   $(MKDIR_P) $(DESTDIR)$(libmakepkgdir)/$$dir; \
>   done
> 



signature.asc
Description: OpenPGP digital signature


[pacman-dev] building from git erroneous

2016-10-25 Thread Florian Weigelt
Building from commit fa06951d90fee028ece95fc7caab39fc7d35d55f generates
the scripts pacman-db-upgrade, pacman-key and pkgdelta in the form
DIR="/path/to/builddir/src/pacman/scripts"

LIBRARY="$DIR"/libmakepkg exec "$DIR"/.lib/pacman-key "$@"

so they hold a reference to the build directory. Building pacman with
makepkg triggers the "reference to $srcdir" warning. However, I haven't
bisected the latest commits yet.



signature.asc
Description: OpenPGP digital signature